December 2010 - openSUSE Build Service

[opensuse-buildservice] [PATCH] build: Fix signature verification
by Michal Marek 03 Jan '11

03 Jan '11

There is no 'en_EN' locale, so osc build fails with The following package could not be verified: /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_EN) Firthermore, it is not a good idea to treat any warning message as error, so do not fail of there is something different than the expected rpm -K output. Signed-off-by: Michal Marek <mmarek(a)suse.cz> --- osc/fetch.py | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/osc/fetch.py b/osc/fetch.py index 2e39833..c565bfb 100644 --- a/osc/fetch.py +++ b/osc/fetch.py @@ -268,7 +268,7 @@ def verify_pacs_old(pac_list): # save locale first (we rely on English rpm output here) saved_LC_ALL = os.environ.get('LC_ALL') - os.environ['LC_ALL'] = 'en_EN' + os.environ['LC_ALL'] = 'C' o = subprocess.Popen(['rpm', '-K'] + pac_list, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=True).stdout @@ -280,10 +280,7 @@ def verify_pacs_old(pac_list): for line in o.readlines(): if not 'OK' in line: - print - print >>sys.stderr, 'The following package could not be verified:' print >>sys.stderr, line - sys.exit(1) if 'NOT OK' in line: print -- 1.7.3.4 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 2

[opensuse-buildservice] [PATCH] build: Fix for su-wrapper = su -c
by Michal Marek 02 Jan '11

02 Jan '11

su-wrapper = su -c has been broken since commit 5376580. Handle this case so that people do not have to update their configs. Signed-off-by: Michal Marek <mmarek(a)suse.cz> --- osc/build.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/osc/build.py b/osc/build.py index a77865c..e1f1196 100644 --- a/osc/build.py +++ b/osc/build.py @@ -847,6 +847,8 @@ def main(apiurl, opts, argv): if need_root: sucmd = config['su-wrapper'].split() if sucmd[0] == 'su': + if sucmd[-1] == '-c': + sucmd.pop() cmd = sucmd + ['-s', cmd[0], 'root', '--' ] + cmd[1:] else: cmd = sucmd + cmd -- 1.7.3.4 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 1

[opensuse-buildservice] FATAL: kernel too old -- how to specify openSuse version to use for builds?
by Martin Grotzke 31 Dec '10

31 Dec '10

Hi, I just tried to build a package for Fedora_14 x86_64 and got the error FATAL: kernel too old In the mailing list archives I found advices like "You need to use openSUSE 11.3..." So I wonder how I can specify the build server version to use. I'm using the web frontend. I also tried to build for Fedora_14 i586, but that gives getbinaries: missing packages: WE_NEED_MORE_BUILD_HOSTS_SUPPORTING_FEDORA_14 (Is there more to say about this than what it says? ;-)) For Fedora_13 i586 the build is fine. Thanx for your help, cheers, Martin -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 2

[opensuse-buildservice] [PATCH] small fix for the acl+remoteproject handling
by Marcus Huewe 30 Dec '10

30 Dec '10

Hi, I just wrote a patch to fix some small issues with acl+remoteprojects: - app/controllers/build_controller.rb * def index: added support for remoteprojects (also added acl code for hidden remoteprojects) - app/controllers/source_controller.rb * def index_project: added acl code for hidden remoteprojects - app/models/db_project.rb * def is_remote_project?, def find_remote_project: added "skip_access=false" parameter to skip acl checks (by default they're enabled) - added new testcases Btw sometimes it's possible to "detect" hidden projects. For instance compare the output of GET /source/<hiddenproject> and GET /source/<non-existent> (I'm not quite sure if this is intended) Marcus --- src/api/app/controllers/build_controller.rb | 6 +++ src/api/app/controllers/source_controller.rb | 4 ++ src/api/app/models/db_project.rb | 16 +++++--- src/api/script/start_test_backend | 1 + src/api/test/fixtures/db_projects.yml | 9 +++++ src/api/test/fixtures/flags.yml | 6 +++ .../fixtures/project_user_role_relationships.yml | 5 +++ src/api/test/functional/interconnect_test.rb | 39 ++++++++++++++++++++ 8 files changed, 80 insertions(+), 6 deletions(-) diff --git a/src/api/app/controllers/build_controller.rb b/src/api/app/controllers/build_controller.rb index 7c4d3dd..67ff364 100644 --- a/src/api/app/controllers/build_controller.rb +++ b/src/api/app/controllers/build_controller.rb @@ -4,6 +4,12 @@ class BuildController < ApplicationController valid_http_methods :get, :post, :put prj = DbProject.find_by_name params[:project] + if prj.nil? and DbProject.is_remote_project?(params[:project], skip_access=true) + lpro, rpro = DbProject.find_remote_project(params[:project], skip_access=true) + prj = lpro if DbProject.check_access? lpro + # package is irrelevant for a remoteproject + params.delete :package + end pkg = DbPackage.find_by_project_and_name( params[:project], params[:package] ) if prj and params[:package] # todo: check if prj.nil?/pkg.nil? is sufficient diff --git a/src/api/app/controllers/source_controller.rb b/src/api/app/controllers/source_controller.rb index 06bf0ea..0b3e84c 100644 --- a/src/api/app/controllers/source_controller.rb +++ b/src/api/app/controllers/source_controller.rb @@ -79,6 +79,10 @@ class SourceController < ApplicationController deleted = params.has_key? :deleted pro = DbProject.find_by_name project_name hidden = DbProject.is_hidden?(project_name) + if pro.nil? and DbProject.is_remote_project?(project_name, skip_access=true) + lpro, rpro = DbProject.find_remote_project(project_name, skip_access=true) + hidden = DbProject.is_hidden?(lpro.name) && !DbProject.check_access?(lpro) + end # access checks #-------------- diff --git a/src/api/app/models/db_project.rb b/src/api/app/models/db_project.rb index ec72a62..b687869 100644 --- a/src/api/app/models/db_project.rb +++ b/src/api/app/models/db_project.rb @@ -36,10 +36,9 @@ class DbProject < ActiveRecord::Base class << self - def is_remote_project?(name) - lpro, rpro = find_remote_project(name) - return true unless lpro.nil? or lpro.remoteurl.nil? - return false + def is_remote_project?(name, skip_access=false) + lpro, rpro = find_remote_project(name, skip_access) + !lpro.nil? and !lpro.remoteurl.nil? end def is_hidden?(name) @@ -191,7 +190,7 @@ class DbProject < ActiveRecord::Base return dbp end - def find_remote_project(name) + def find_remote_project(name, skip_access=false) return nil unless name fragments = name.split(/:/) local_project = String.new @@ -201,7 +200,12 @@ class DbProject < ActiveRecord::Base remote_project = [fragments.pop, remote_project].compact.join ":" local_project = fragments.join ":" logger.debug "checking local project #{local_project}, remote_project #{remote_project}" - lpro = DbProject.find_by_name local_project + if skip_access + # hmm calling a private class method is not the best idea.. + lpro = find_initial :conditions => ["name = BINARY ?", local_project] + else + lpro = DbProject.find_by_name local_project + end return lpro, remote_project unless lpro.nil? or lpro.remoteurl.nil? end return nil diff --git a/src/api/script/start_test_backend b/src/api/script/start_test_backend index 9878c6c..349bbe9 100755 --- a/src/api/script/start_test_backend +++ b/src/api/script/start_test_backend @@ -154,6 +154,7 @@ Suse::Backend.put( '/source/LocalProject/_meta', DbProject.find_by_name('LocalPr Suse::Backend.put( '/source/LocalProject/remotepackage/_meta', DbPackage.find_by_project_and_name("LocalProject", "remotepackage").to_axml) Suse::Backend.put( '/source/LocalProject/remotepackage/_link', "<link project=\"RemoteInstance:BaseDistro\" package=\"pack1\" />") Suse::Backend.put( '/source/RemoteInstance/_meta', DbProject.find_by_name('RemoteInstance').to_axml) +Suse::Backend.put( '/source/HiddenRemoteInstance/_meta', DbProject.find_by_name('HiddenRemoteInstance').to_axml) Suse::Backend.put( '/source/UseRemoteInstance/_meta', DbProject.find_by_name('UseRemoteInstance').to_axml) Suse::Backend.put( '/source/home:adrian:BaseDistro/_meta', DbProject.find_by_name('home:adrian:BaseDistro').to_axml) Suse::Backend.put( '/source/home:adrian:ProtectionTest/_meta', DbProject.find_by_name('home:adrian:ProtectionTest').to_axml) diff --git a/src/api/test/fixtures/db_projects.yml b/src/api/test/fixtures/db_projects.yml index 45adf8b..cad7774 100644 --- a/src/api/test/fixtures/db_projects.yml +++ b/src/api/test/fixtures/db_projects.yml @@ -147,6 +147,15 @@ homeadrianProtectionTest: description: "" created_at: 2005-01-01 00:00:01 +HiddenRemoteInstance: + name: HiddenRemoteInstance + updated_at: 2005-01-01 00:00:01 + title: Remoteurl project which is hidden (access disabled) + id: 3006 + remoteurl: http://localhost:3200 + description: "for testing hidden remoteurl projects (access disabled)" + created_at: 2005-01-01 00:00:01 + # For testing remote project handling (we are our own remote instance) RemoteInstance: name: RemoteInstance diff --git a/src/api/test/fixtures/flags.yml b/src/api/test/fixtures/flags.yml index c8ecf2a..66059fc 100644 --- a/src/api/test/fixtures/flags.yml +++ b/src/api/test/fixtures/flags.yml @@ -77,6 +77,12 @@ hide_project: flag: access position: 1 +hide_remoteurlproject: + status: "disable" + db_project_id: 3006 + flag: access + position: 1 + source_protected_project: status: "disable" db_project_id: 3001 diff --git a/src/api/test/fixtures/project_user_role_relationships.yml b/src/api/test/fixtures/project_user_role_relationships.yml index 97c57ca..564f8dd 100644 --- a/src/api/test/fixtures/project_user_role_relationships.yml +++ b/src/api/test/fixtures/project_user_role_relationships.yml @@ -72,6 +72,11 @@ hiddenproject_maintainer_homer: bs_user_id: 46 role_id: 3 +hiddenremoteurlproject_maintainer_homer: + db_project_id: 3006 + bs_user_id: 46 + role_id: 3 + sourceaccess_project_maintainer_homer: db_project_id: 3001 bs_user_id: 49 diff --git a/src/api/test/functional/interconnect_test.rb b/src/api/test/functional/interconnect_test.rb index fe3c7d4..bffb122 100644 --- a/src/api/test/functional/interconnect_test.rb +++ b/src/api/test/functional/interconnect_test.rb @@ -240,4 +240,43 @@ end assert_response :success end + def test_get_packagelist_with_hidden_remoteurlproject + prepare_request_with_user "tom", "thunder" + get "/source/HiddenRemoteInstance" + assert_response 404 + get "/source/HiddenRemoteInstance:BaseDistro" + assert_response 404 + ActionController::IntegrationTest::reset_auth + prepare_request_with_user "hidden_homer", "homer" + get "/source/HiddenRemoteInstance" + assert_response :success + get "/source/HiddenRemoteInstance:BaseDistro" + assert_response :success + end + + def test_read_access_hidden_remoteurlproject_index + prepare_request_with_user "tom", "thunder" + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository" + assert_response 404 + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository?view=cache" + assert_response 404 + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository?view=binaryversions" + assert_response 404 + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository?view=cpio" + assert_response 404 + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/pack1" + assert_response 404 + ActionController::IntegrationTest::reset_auth + prepare_request_with_user "hidden_homer", "homer" + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository" + assert_response :success + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository?view=cache" + assert_response :success + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository?view=binaryversions" + assert_response :success + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/_repository?view=cpio" + assert_response :success + get "/build/HiddenRemoteInstance:BaseDistro/BaseDistro_repo/i586/pack1" + assert_response :success + end end -- 1.6.0.2 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

4 4

[opensuse-buildservice] where's the source root in obs?
by Lyre 29 Dec '10

29 Dec '10

Current rhel6 missing some devel packages. so I just download them from redhat and upload to my project (in the same directory with spec file). I will execute rpm -ivh in spec file. but what's the path of those file? -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 1

[opensuse-buildservice] Re: [PATCH] [api] Fix active_rbac/user/delete.rhtml to post to destroy method. Otherwise validation is broken in controllers/active_rbac/user_controller.rb and we can't delete users at all in the admin interface.
by Marcus Hüwe 27 Dec '10

27 Dec '10

Hi, On 2010-11-30 00:05:48 +0100, OBS build-service wrote: > From: Jan-Simon Möller <jsmoeller(a)linuxfoundation.org> > > Signed-off-by: Jan-Simon Möller <jsmoeller(a)linuxfoundation.org> > --- > src/api/app/views/active_rbac/user/delete.rhtml | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/api/app/views/active_rbac/user/delete.rhtml b/src/api/app/views/active_rbac/user/delete.rhtml > index 90025b2..df89d43 100644 > --- a/src/api/app/views/active_rbac/user/delete.rhtml > +++ b/src/api/app/views/active_rbac/user/delete.rhtml > @@ -7,7 +7,7 @@ depending on this user (articles, for example). > <strong>This action cannot be reverted!</strong> > </p> > > -<% form_for :group, :url => { :action => :delete, :id => @user } do |form| %> > +<% form_for :group, :url => { :action => :destroy, :id => @user } do |form| %> > <%= submit_tag 'Yes', :name => 'yes' %> > <%= submit_tag 'No', :name => 'no' %> > <% end %> > \ No newline at end of file Hmm I'm not sure if it's a good idea to "enable/fix" the user deletion. It was already discussed some time ago (see http://lists.opensuse.org/opensuse-buildservice/2010-08/msg00057.html). Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 2

[opensuse-buildservice] %buildroot not expanded in SLES11 and older
by Olaf Hering 26 Dec '10

26 Dec '10

Since there is appearently no example about how a single specfile could look like that builds across all supported distros I created home:olh:hello_world a few months ago. For some reason RPM_BUILD_ROOT does not exist in SLES* and 11.1. It turned out that %buildroot is not expanded for some reason. Any ideas whats missing in home:olh? Olaf -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 2

[opensuse-buildservice] is there a command like merge?
by Lyre 23 Dec '10

23 Dec '10

for example, i branch php package from opensuse11.3:update, just change the --disable-debug to --enable-debug in php.spec. is it possible to update my package with the original opensuse11.3:update ? -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 1

[opensuse-buildservice] osc under ubuntu 10.10
by Paul Elliott 22 Dec '10

22 Dec '10

I have just install the osc for ubuntu 10.10 osc --version 0.130.1 And when I do a commit I get this error: EDITOR=xemacs osc commit WARNING: source_validator_directory configured but it does not exist: /usr/lib/osc/source_validators Install osc-source_validator to fix. warning: your urllib2 version seems to be broken. Using a workaround for http://bugs.python.org/issue9639 Warning: Missing charsets in String to FontSet conversion Sending peless_1.223-1.diff.gz Sending peless_1.223-1.dsc Sending peless_1.223.orig.tar.gz Transmitting file data ... Committed revision 1. It seems to work anyway what is osc-source_validator and how do I install it? It does not seem to be available under opensuse package search? -- Paul Elliott 1(512)837-1096 pelliott(a)BlackPatchPanel.com PMB 181, 11900 Metric Blvd Suite J http://www.free.blackpatchpanel.com/pme/ Austin TX 78758-3117

2 1

[opensuse-buildservice] All packages on my local OBS server stucked at the status 'scheduled'
by Leaf John 22 Dec '10

22 Dec '10

Hello, I've setup an server locally(using OpenSuSE 11.3 and OBS 2.1, on Intel hardware),usually build arm arch binaries. It functioned well several days ago, but after an unexpected system fail, I restart the machine, but find all packages stuck at the status scheduled, while all workers are idle. My workers have qemu-arm-static installed, they've been build the arm binaries before. I've change the obs root from /srv/obs to /obs, and in this folder, I found an interesting folder: $ls /obs/run/worker 1 2 boot $cat 1/state 2/state <workerstate state="building" jobid=" a81436ad149448efb9a320c3499ecc3d" /> <workerstate state="building" jobid="397d0f1de6a2992cb4f8f78af6caf0be" /> I suspect that it was the workers didn't clean up it's previous jobs during restart, so I setup workers on other machine, and the server has found theses additional workers, however, the build doesn't start still. ---------------------------------------------------------------------------------------------------- $cat /obs/workers/idle/* <worker hostarch="i686" ip="127.0.0.1" port="37535" workerid="cnbjas56/1" /> <worker hostarch="i686" ip="127.0.0.1" port="49811" workerid="cnbjas56/2" /> <worker hostarch="i686" ip="127.0.0.1" port="36752" workerid="cnbjas56/3" /> <worker hostarch="i686" ip="172.20.0.61" port="33844" workerid="cnd000379ow/1" /> <worker hostarch="i686" ip="172.20.0.61" port="37058" workerid="cnd000379ow/2" /> $cat /obs/workers/building/* cat: /obs/workers/building/*: No such file or directory Is anyone have any idea about what's happening? I'm quit confused and don't konw what to do.. ----------------------------------------------- OBS versions: $rpm -qa | grep obs obs-signd-2.1.2-1.1.i586 obs-api-2.1.2-4.4.i586 obs-server-2.1.2-4.2.i586 obs-worker-2.1.2-4.2.noarch obs-utils-2.1.2-4.2.i586 obs-common-2.1.0-1.1.i586 -- Best Regards, Leaf Johnson<leafjohn(a)gmail.com> -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe(a)opensuse.org For additional commands, e-mail: opensuse-buildservice+help(a)opensuse.org

2 1