October 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] WebYaST: fixed translation packaging in WebYaST clients
by Ladislav Slezak 22 Oct '09

22 Oct '09

Hi all, I have fixed translation packaging in all WebYaST client plugins. Here I'll briefly describe the changes: These lines have been added to %build section: -------------------------------------------------------------------- # remove .po files (no longer needed) rm -rf $RPM_BUILD_ROOT/srv/www/%{pkg_user}/vendor/plugins/%{plugin_name}/po # search locale files %find_lang <GETTEXT_DOMAIN> -------------------------------------------------------------------- The first command removes all .po files from the build root, they are useless in built RPM package (they have been converted to .mo files by 'rake makemo'). The second command (%find_lang macro) searches for translation files in the buildroot and saves the file list to GETTEXT_DOMAIN.lang file which is used later. GETTEXT_DOMAIN defines which files will be added to the list. The generated file is then added to the RPM file list by -f option: -------------------------------------------------------------------- %files -f GETTEXT_DOMAIN.lang -------------------------------------------------------------------- Because .mo files are included in .lang file locale/ subtree can be removed from the file list (but the top level locale/ must be added using %dir macro). BTW simply adding /locale subdirectory to the file list is not the correct solution, in this case rpmlint prints lots of warnings about not used %lang macro (for each .mo file). -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 3

[yast-devel] Webyast - generated documentation
by Josef Reidinger 21 Oct '09

21 Oct '09

Hi, in short: look at http://w3.suse.de/~jreidinger/webservice http://w3.suse.de/~jreidinger/webclient and if you find that your plugin missing certainly amount of comments, you should improve it. It is now only on internal site (but anyone can generate it in git), but in future I hope we find some suitable place for this documentation. Also it is generated manually by me, as there is some problems with hudson. If documenation missing then your plugin cannot generate documentation by rake app:doc some details: I add to Rakefile task to generate documentation of framework and its plugins. rake doc (at top level directory). It uses rake app:doc in each plugin directory and copy it to one place where is dynamically generated index file. Webclient framework missing documentation, I plan to fix it. I welcome any suggestion on improvements. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 5

[yast-devel] WebYaST status call 21-Oct-2009
by Martin Vidner 21 Oct '09

21 Oct '09

Present: bbrunner, dmacvicar, jdsn, jsrain, jsuchome, kkaempf, mkudlvasr, mvidner, schubi Absent: jreidinger, lslezak, mschmidkunz, mzugec, rlihm jsuchome: - classic yast on RC2 - will help out with bugs jdsn+schubi: - rubyish registration, more rest test cases - will finish zypper calls mvidner: - comments in broken-authentication branch dmacvicar: - will have time for webyast again jsrain: - administration bbrunner: - testing fresh git, with selenium mkudlvasr: - eula tests, docs kkaempf: - will be in Prague tomorrow [jreidinger]: - http://www.suse.de/~jreidinger/ so make stubs for your modules [rlihm]: - getting the machine to a working state -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : treat absence of eulas.yml as blank eulas list (==all eulas are accepted)
by Josef Reidinger 20 Oct '09

20 Oct '09

Martin Kudlvasr write: > ref: refs/heads/master > commit 0e1503bd595f3058177385cb222914cfb6ac9466 > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Tue Oct 20 16:10:11 2009 +0200 > > treat absence of eulas.yml as blank eulas list (==all eulas are > accepted) and corruption of eulas.yml as error > --- > plugins/eulas/app/models/license.rb | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/plugins/eulas/app/models/license.rb > b/plugins/eulas/app/models/license.rb index 319a533..b6c393b 100644 > --- a/plugins/eulas/app/models/license.rb > +++ b/plugins/eulas/app/models/license.rb > @@ -71,11 +71,13 @@ class License > end > > def self.license_names > + config = YaST::ConfigFile.new(:eulas) > begin > - config = YaST::ConfigFile.new(:eulas) Yes, you can move it outside of begin as initialize doesn't throw exception. But how you know it? I think that it is not from documentation( http://w3.suse.de/~jreidinger/webservice/webservice/classes/YaST/ConfigFile… ) so I suggest that you can improve it (document which method throw exceptions). > config["licenses"] || [] > - rescue Exception => e > + rescue YaST::ConfigFile::NotFoundError > [] # treat absense or corruption of eulas.yml as "no eulas" > + rescue Exception > + raise CorruptedFileException.new config.path > end > end > -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] almost-fixing zero eulas
by Martin Vidner 20 Oct '09

20 Oct '09

Here is a patch that I am not sure is right, so it is not committed. If I use this, it is still broken, and every controller says: You must accept all EULAs before using this product! Accept End User Licence Agreement All licenses have already been accepted OK -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

4 7

[yast-devel] Re: [yast-commit] <rest-service> master : treat absence or corruption of eulas.yml as "no eulas"
by Klaus Kaempf 20 Oct '09

20 Oct '09

* Martin Kudlvasr <mkudlvasr(a)suse.cz> [Oct 20. 2009 14:47]: > > treat absence or corruption of eulas.yml as "no eulas" I'm fine with the absence case but corruption (wrong format) should be reported as an error. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status call 19-Oct-2009
by Martin Vidner 20 Oct '09

20 Oct '09

Present: jsrain, kkaempf, mvidner, jsuchome, jdsn, schubi, bbrunner, dmacvicar Absent: mschmidkunz, fnadge, jreidinger, lslezak, mzugec, mkudlvasr General ------- - Beta 2 released - we should be feature complete by the end of the week Reports ------- jsrain - no progress, doing team lead administration kkaempf - tested rest-service in a browser; bug work - will review code, work on bugs mvidner - released the beta - will work on Scr.execute jsuchome: - finished some stuff in mailsettings, documentation - will test the beta, may increase test coverage jdsn - registration: config reading+writing works, status reading works by guessing - will do parsing of NCC response, call zypper to modify repos, improve ruby style schubi - finished the registration client - will test on the service side - translations are checked in continuously bbrunner - new testing, updated the package listing dmacvicar - no progress, doing team lead administration - need to make the log viewer visible -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

2 1

[yast-devel] Re: [yast-commit] <web-client> master : validate list of e-mails in controller
by Josef Reidinger 19 Oct '09

19 Oct '09

Jiri Suchomel write: > ref: refs/heads/master > commit 23404e1c1c45f1ccb9a89e707c080a86bfeb7383 > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Wed Oct 14 11:33:02 2009 +0200 > > validate list of e-mails in controller > --- > .../app/controllers/administrator_controller.rb | 15 ++++++++++----- > 1 files changed, 10 insertions(+), 5 deletions(-) > > diff --git > a/plugins/administrator/app/controllers/administrator_controller.rb > b/plugins/administrator/app/controllers/administrator_controller.rb index > d1d493e..52332ef 100644 > --- a/plugins/administrator/app/controllers/administrator_controller.rb > +++ b/plugins/administrator/app/controllers/administrator_controller.rb > @@ -34,11 +34,16 @@ class AdministratorController < ApplicationController > @administrator.password = admin["password"] > @administrator.aliases = admin["aliases"] > > - # FIXME validate for set of mails, not just one > - if !admin["aliases"].empty? && admin["aliases"] !~ /(.+)(a)(.+)\.(.{2})/ > # yes, very weak - flash[:error] = _("Enter a valid e-mail address.") > - redirect_to :action => "index" > - return > + # validate data also here, if javascript in view is off > + if !admin["aliases"].empty? > + admin["aliases"].split(",").each do |mail| > + # only check emails, not local users > + if mail.include?("@") && mail !~ /(.+)(a)(.+)\.(.{2})/ ^^^ Hi, I think that this regex is not valid. It means that you expect .?? in mail. so I think you have problem if someone want root@localhost Also it is not easy to see that alse user(a)gmail.com works (it is because you forget to append $ after regex and ^ before regex. Also this is not controller job, but unfortunatelly we don't have easy accessible model in frontend to add validation, but it should change in future ( I believe in ActiveResource branch). > + flash[:error] = _("Enter a valid e-mail address.") > + redirect_to :action => "index" > + return > + end > + end > end > > if admin["password"] != admin["confirm_password"] > -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] Re: [yast-commit] <rest-service> master : add json support, small fixes in controllers, cleanup
by Martin Vidner 19 Oct '09

19 Oct '09

On Wed, Oct 14, 2009 at 07:19:38PM +0200, J.Daniel Schmidt wrote: > ref: refs/heads/master > commit 9e8e1a7d81cbdd2970a6264e456aed01331cb79d > Author: J. Daniel Schmidt <jdsn(a)suse.de> > Date: Wed Oct 14 19:19:38 2009 +0200 > > add json support, small fixes in controllers, cleanup You can use "git add -i" to easily split unrelated changes to separate commits: http://book.git-scm.com/4_interactive_adding.html > --- > .../app/controllers/configuration_controller.rb | 42 ++++++++++++++--- > .../app/controllers/registration_controller.rb | 15 +++--- > plugins/registration/app/models/registration.rb | 46 ++++++++++++++----- > .../app/views/configuration/show.json.erb | 2 +- > 4 files changed, 77 insertions(+), 28 deletions(-) > > diff --git a/plugins/registration/app/controllers/registration_controller.rb b/plugins/registration/app/controllers/registration_controller.rb > index bb80661..7ce1c05 100644 > --- a/plugins/registration/app/controllers/registration_controller.rb > +++ b/plugins/registration/app/controllers/registration_controller.rb > @@ -9,20 +9,21 @@ class RegistrationController < ApplicationController > # POST to registration => run registration > @registration = Registration.new({}) > > - # TODO: parse post data and set context data > + # TODO overwrite context data if defined > #(a)registration.set_context( { } ) > + > + # TODO: parse post data and set the arguments > + # @registration.set_arguments( { } ) > + > ret = @registration.register > + headers["Status"] = "400 Bad Request" if ret == 3 Is the intent to report to the upper layers (UI) that the lower layer (YaPI) encountered invalid data? Then you are supposed to raise InvalidParameters.new :some_item => "Missing" http://lists.opensuse.org/yast-devel/2009-09/msg00117.html > --- a/plugins/registration/app/models/registration.rb > +++ b/plugins/registration/app/models/registration.rb > @@ -27,8 +29,8 @@ class Registration > return if hash.nil? > > # merge custom context data > - if hash.class.to_s == 'Hash' > - @context.merge hash > + if hash.class == Hash > + hash.each {|k, v| @context.merge!( { k => ['s', "#{v.to_s}"] } ) } In '"#{v.to_s}"' you are doing the string conversion twice needlessly. Once is enough: $ irb irb(main):001:0> a = :A => :A irb(main):002:0> "#{a.to_s}" => "A" irb(main):003:0> "#{a}" => "A" irb(main):004:0> a.to_s => "A" Also, what is the point of merging a single keyed hash? @context[k] = ['s', v.to_s] seems enough. I see, it is influenced by the old deleted code. But then I'd recommend keeping '@context.merge! hash' (with "!") and doing the variant conversion in a separate step, because it will be unnecessary, eventually: https://bugzilla.novell.com/show_bug.cgi?id=538050 > else > raise "Invalid or missing registration initialization context data." > end > @@ -44,19 +46,26 @@ class Registration > self.initialize hash > end > > - def set_arguments(hash) > - @arguments = hash > + def add_argument(key, value) > + @arguments.merge!( { key => [ 'a{ss}',{ 'value' => "#{value.to_s}" } ] } ) > end > > def add_arguments(hash) > - @arguments.merge hash > + hash.each {|k, v| self.add_argument k, v } > + end > + > + def set_arguments(hash) > + @arguments = {} > + self.add_arguments hash > end -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST Beta 2 released
by Martin Vidner 19 Oct '09

19 Oct '09

DOWNLOAD: http://www.suse.de/~mvidner/webyast-beta2/WebYaST_on_SLES11.i686-0.0.17.vmx… http://www.suse.de/~mvidner/webyast-beta2/WebYaST_on_SLES11.i686-0.0.17.vmx… ( gpg --verify WebYaST_on_SLES11.i686-0.0.17.vmx.tar.gz.asc ) sha1sum: 3a6ac06f0abbb33ef315dcc28b9cb6cd8d984176 internal: ftp://cml.suse.cz/testing/webyast/WebYaST_on_SLES11.i686-0.0.17.vmx.tar.gz USAGE: 1. Run the appliance In the 1st run, accept the SLES EULA 2. Point the browser to port 54984 (**) Select the "localhost" item, Log in as root, with password linux 3. Go through the base setup (time and language) GENERAL NEWS: - Added the mail settings module - (the EULA module is not included yet due to packaging problems) - Re-enabled the firewall, with holes at 54984, 4984. - Added a tunneling helper (**) MODULE SPECIFIC NEWS: - Network: added in-form validation. - (Maintainers, please reply to this if you want to point out something. Come on!) KNOWN BUGS: - See this query for a complete bug list: https://bugzilla.novell.com/buglist.cgi?query_format=advanced&product=openS… FEEDBACK: - irc://irc.opensuse.org/yast - https://bugzilla.novell.com/enter_bug.cgi?component=WebYaST&product=openSUS… (please disregard the oS11.2 version and instead remember to mention the appliance version.) See http://en.opensuse.org/Bugs/WebYaST - mailto:yast-devel@opensuse.org **) options: - have the virtual machine set to network bridging - tunnel out from the inside: /root/bin/webyast-ssh 10.0.2.2 (where 10.0.2.2 is how the VM sees the host in a VirtualBox NAT setup. It forwards the ports 54984, 4984, and 10022->22) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0