October 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] WebYaST-service build fails on Hudson
by Klaus Kaempf 09 Oct '09

09 Oct '09

JFYI Looks like EULA test are not passing. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 3

[yast-devel] Re: [yast-commit] <rest-service> master : fixing packaging ...
by Josef Reidinger 09 Oct '09

09 Oct '09

Martin Kudlvasr write: > ref: refs/heads/master > commit 30333bdb0b24db7bfdc11fa7cecbf2341d8d880e > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Thu Oct 8 16:47:53 2009 +0200 > > fixing packaging ... > --- > plugins/eulas/app/controllers/eulas_controller.rb | 8 ++- > plugins/eulas/app/models/license.rb | 4 +- > plugins/eulas/package/eula.yml | 3 - > plugins/eulas/package/eulas.yml | 3 + > .../eulas/package/yast2-webservice-eula.changes | 5 - > plugins/eulas/package/yast2-webservice-eula.spec | 84 > -------------------- .../eulas/package/yast2-webservice-eulas.changes | > 5 + > plugins/eulas/package/yast2-webservice-eulas.spec | 84 > ++++++++++++++++++++ 8 files changed, 100 insertions(+), 96 deletions(-) > > diff --git a/plugins/eulas/app/models/license.rb > b/plugins/eulas/app/models/license.rb index 6024eb8..b5c2dea 100644 > --- a/plugins/eulas/app/models/license.rb > +++ b/plugins/eulas/app/models/license.rb > @@ -13,8 +13,8 @@ class License > > attr_accessor :name, :langs_hash, :langs_list, :accepted, :text, > :text_lang, :only_show > > - RESOURCES_DIR = > File.join(File.dirname(__FILE__),"..","..","config","resources") - > VAR_DIR = File.join(File.dirname(__FILE__),"..","..","var") + > VAR_DIR = > File.join(File.dirname(__FILE__),"/var","lib","yastws","eulas") + > RESOURCES_DIR = > File.join(File.dirname(__FILE__),"/usr","share","yastws","eulas") ^^^ Hi, I think you don't want this path. you join directory of current exucuted file with absolute path. so it should be (no __FILE__) File.join("/usr","share","yastws","eulas") > > def dig_lang(line) > r = Regexp.new('license(?:\.(\w+))?\.txt') -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] Re: [yast-commit] r58979 - in /trunk/registration/src/config: org.opensuse.yast.modules.yapi.ysr.register.policy org.opensuse.yast.modules.yapi.ysr.registerConfig.policy
by Josef Reidinger 09 Oct '09

09 Oct '09

jdsn(a)svn.opensuse.org write: > Author: jdsn > Date: Thu Oct 8 17:57:56 2009 > New Revision: 58979 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=58979&view=rev > Log: > split registration policy into two files > > Added: > > trunk/registration/src/config/org.opensuse.yast.modules.yapi.ysr.register. > policy > trunk/registration/src/config/org.opensuse.yast.modules.yapi.ysr.registerC > onfig.policy > > Added: > trunk/registration/src/config/org.opensuse.yast.modules.yapi.ysr.register. > policy URL: > http://svn.opensuse.org/viewcvs/yast/trunk/registration/src/config/org.ope > nsuse.yast.modules.yapi.ysr.register.policy?rev=58979&view=auto > ========================================================================== Hi, before you commit policy files I suggest you to test this file if it is valid. There is policyKit utility polkit-policy-file-validate which should say you, that this split is not valid and causes policy Kit problems. It is quite strictly defined file name and policy structure. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : test on empty list
by Josef Reidinger 08 Oct '09

08 Oct '09

Stefan Schubert write: > ref: refs/heads/master > commit dd33d008822d216d94a061fcfc2017385c7fb0f9 > Author: Stefan Schubert <schubi(a)suse.de> > Date: Thu Oct 8 13:50:13 2009 +0200 > > test on empty list > --- > .../app/controllers/patch_updates_controller.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git > a/plugins/patch_updates/app/controllers/patch_updates_controller.rb > b/plugins/patch_updates/app/controllers/patch_updates_controller.rb index > 507b97f..8f25528 100644 > --- a/plugins/patch_updates/app/controllers/patch_updates_controller.rb > +++ b/plugins/patch_updates/app/controllers/patch_updates_controller.rb > @@ -86,7 +86,7 @@ class PatchUpdatesController < ApplicationController > > flash.clear #no flash from load_proxy > last_patch = "" > - if patch_updates > + if patch_updates.size > 0 Hi, this is not correct change, because in case of error during loading patch_updates you can have it as nil and then this part of code throws Unknown method exception see: begin patch_updates = load_proxy 'org.opensuse.yast.system.patches', :all rescue Exception => e error = e patch_updates = nil # here you set nil end flash.clear #no flash from load_proxy last_patch = "" #here can be patch_update nil and nil Class doesn't have size method if patch_updates.size > 0 I suggest add to test case test what happen when load_proxy throw error and test if it end in expected result. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <rest-service> master : working eula backend, no access restrictions yet
by Josef Reidinger 08 Oct '09

08 Oct '09

Martin Kudlvasr write: > ref: refs/heads/master > commit f3713225650628c4b4ecaa247d9b7db1ea9f9f18 > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Thu Oct 8 13:52:39 2009 +0200 > > working eula backend, no access restrictions yet > --- > plugins/eulas/app/controllers/eulas_controller.rb | 5 +- > plugins/eulas/app/models/license.rb | 56 > +++++++++++++-------- plugins/eulas/app/views/eulas/index.html.erb | > 2 +- > plugins/eulas/app/views/eulas/show.html.erb | 5 ++- > plugins/eulas/test/unit/license_test.rb | 20 +++---- > 5 files changed, 51 insertions(+), 37 deletions(-) > > diff --git a/plugins/eulas/app/controllers/eulas_controller.rb > b/plugins/eulas/app/controllers/eulas_controller.rb index 83b0fd5..a449bee > 100644 > --- a/plugins/eulas/app/controllers/eulas_controller.rb > +++ b/plugins/eulas/app/controllers/eulas_controller.rb > @@ -1,6 +1,6 @@ > # = Eula controller > # Serves licences and handles notices about acceptations. > -class EulaController < ApplicationController > +class EulasController < ApplicationController > > before_filter :login_required > > @@ -14,7 +14,8 @@ class EulaController < ApplicationController > end > > def show > - @license = License.find params[:id] > + @id = params[:id].to_i I suggest check if params[:id] exist (for usage via curl e.g.) and if is not present throw exception. Now it cause unknown method without any user friendly message what goes wrong. > + @license = License.find @id > if not params[:lang].nil? then @license.load_text params[:lang] end ^^^ you use @license variable even if License.find can return nil, so another easy to crash part hint 'if not' == 'unless' hint2 use ruby one liner, no C oneliner so it should look like raise <some_exception> unless params[:id] @id = params[:id].to_i @license = License.find @id raise <some_exception> unless @license @license.load_text params[:lang] if params[:lang] > logger.debug @license.inspect > respond_to do |format| > diff --git a/plugins/eulas/app/models/license.rb > b/plugins/eulas/app/models/license.rb index cab752f..6024eb8 100644 > --- a/plugins/eulas/app/models/license.rb > +++ b/plugins/eulas/app/models/license.rb > @@ -10,9 +10,8 @@ class License > # :text_lang - language, of the current eula translation > # :only_show - some licenses only need to be show and user doesn't have > to change the radio button to "accept" # :accepted - whether this license > was already accepted > - # :last - true if this is the last unaccepted license. Set by > controller. > I suggest to you to try generate documentation for your code (rake doc:app). This doesn't work. Look e.g. on time module how to document attributes. > - attr_accessor :name, :langs_hash, :langs_list, :accepted, :text, > :text_lang, :only_show, :last + attr_accessor :name, :langs_hash, > :langs_list, :accepted, :text, :text_lang, :only_show > > RESOURCES_DIR = > File.join(File.dirname(__FILE__),"..","..","config","resources") VAR_DIR > = File.join(File.dirname(__FILE__),"..","..","var") @@ -55,32 +54,31 ^^^ see discussion about place for var directory on yast-devel. It should point to /var/lib/yastws/... also resources maybe should go to /usr/share/yastws > @@ class License > raise CorruptedFileException.new license_dir > end > @name = name > - # @last is true if this is the last license to be accepted. > - # this is to be set by class method > - @last = false > end > > - def self.find(name) > - license = new name > - # lets be sure, that @text and @text_lang is never nil > - license.load_text "en" > - license > + def self.find(id) > + name = license_names[id-1] # let ids in find start from 1 > + if name.nil? then > + nil > + else > + license = new name > + # lets be sure, that @text and @text_lang is never nil > + license.load_text "en" > + license > + end > end > > - def self.find_all > + def self.license_names > config = YaST::ConfigFile.new(:eula) > - license_names = config["licenses"] > - license_names.collect{|ln| new ln} > + begin > + config["licenses"] > + rescue Exception => e > + raise CorruptedFileException.new config.path > + end > end > > - def self.next > - all = find_all > - unaccepted_count = all.inject(0){|sum,license| sum + (license.accepted > ? 0 : 1)} - next_license = all.find{|license| not license.accepted} > - if not next_license.nil? then > - next_license.last = unaccepted_count == 1 > - end > - next_license > + def self.find_all > + Licenses.new license_names.collect{|ln| new ln} > end > > def save > @@ -133,12 +131,12 @@ class License > xml.name @name > xml.accepted (@accepted, {:type => "boolean"}) > xml.last (@last, {:type => "boolean"}) > - xml.textlang @text_lang > xml.availablelangs({:type => "array"}) do > @langs_list.each do |lang| > xml.availablelang lang > end > end > + xml.textlang @text_lang > xml.text @text > end > end > @@ -149,3 +147,17 @@ class License > end > > end > + > +class Licenses < Array > + def to_xml( options = {} ) > + xml = options[:builder] ||= Builder::XmlMarkup.new(options) > + xml.instruct! unless options[:skip_instruct] > + xml.eulas(:type => :array) do > + each {|eula| eula.to_xml(:builder => xml, :skip_instruct => true)} > + end > + end > + > + def to_json > + Hash.from_xml(to_xml).to_json > + end > +end > diff --git a/plugins/eulas/app/views/eulas/index.html.erb > b/plugins/eulas/app/views/eulas/index.html.erb index 646e8fb..5a82692 > 100644 > --- a/plugins/eulas/app/views/eulas/index.html.erb > +++ b/plugins/eulas/app/views/eulas/index.html.erb > @@ -4,7 +4,7 @@ > <% @licenses.each_with_index do |license,index| -%> > <tr> > <td> > - <%= link_to license.name, :only_path => :true, :controller => "eulas", > :action => :show, :id => index -%> + <%= link_to license.name, > :only_path => :true, :controller => "eulas", :action => :show, :id => > (index+1) -%> </td><td> > <%= license.accepted ? "v" : "x" -%> > </td> > diff --git a/plugins/eulas/app/views/eulas/show.html.erb > b/plugins/eulas/app/views/eulas/show.html.erb index 8a01c61..f0e2ffe > 100644 > --- a/plugins/eulas/app/views/eulas/show.html.erb > +++ b/plugins/eulas/app/views/eulas/show.html.erb > @@ -10,10 +10,13 @@ > </tr> > <tr> > <td>Available translations:</td> > - <td><%= @license.langs_list.join(", ") -%></td> > + <td><%= @license.langs_list.collect{ |lang| link_to lang, :only_path => > :true, :controller => "eulas", :action => :show, :id => @id, :params => > {:lang => lang} }.join(", ") -%></td> </tr> > <tr> > <td>Current translation:</td> > <td><%= @license.text_lang -%></td> > </tr> > </table> > +<pre> > +<%= @license.text -%> > +</pre> > diff --git a/plugins/eulas/test/unit/license_test.rb > b/plugins/eulas/test/unit/license_test.rb index 8f4b895..6b3f437 100644 > --- a/plugins/eulas/test/unit/license_test.rb > +++ b/plugins/eulas/test/unit/license_test.rb > @@ -2,20 +2,21 @@ require File.expand_path(File.dirname(__FILE__) + > "/../test_helper") > > class LicenseTest < ActiveSupport::TestCase > def test_create > - license = License.find 'openSUSE-11.1' > + license = License.find 1 > assert_not_nil license > assert_equal( license.accepted, false) > assert_equal( license.name, 'openSUSE-11.1' ) > end > > def test_accepted > - license = License.find 'SLED-10-SP3' > + license = License.find 2 > assert_not_nil license > assert_equal( license.accepted, true) > + assert_equal( license.name, 'SLED-10-SP3') > end > > def test_load_text > - license = License.find 'openSUSE-11.1' > + license = License.find 1 > license.load_text 'de' > assert_not_nil license.text > assert_equal( license.text_lang, 'de') > @@ -25,13 +26,13 @@ class LicenseTest < ActiveSupport::TestCase > end > > def test_to_xml > - license = License.find 'openSUSE-11.1' > + license = License.find 1 > license.load_text 'de' > assert_not_nil license.to_xml > end > > def test_to_json > - license = License.find 'openSUSE-11.1' > + license = License.find 1 > license.load_text 'de' > assert_not_nil license.to_json > end > @@ -40,12 +41,9 @@ class LicenseTest < ActiveSupport::TestCase > licenses = License.find_all > assert_equal( licenses.length, 2) > assert_equal(licenses[1].name, 'SLED-10-SP3') > - assert_nil licenses[1].text > + assert_nil licenses[1].text > + assert_not_nil licenses.to_xml > + assert_not_nil licenses.to_json > end > > - def test_next > - license = License.next > - assert_equal(license.name, 'openSUSE-11.1') > - assert_false license.accepted > - end > end > At general I suggest you to use more visible separating of public and private part of model as it makes your code more readability. At least you should mark methods as private or as public. (I suggest to put at top of code public methods and to bottom after private keyword private methods, because reader start from top of code.) Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] appliance status: 0.0.8
by Martin Vidner 08 Oct '09

08 Oct '09

DOWNLOAD: http://istudio.suse.de/download/2da4bb6b76af8face0523581c64e8e19/WebYaST_on… ftp://cml.suse.cz/testing/webyast/WebYaST_on_SLES11.i686-0.0.8.vmx.tar.gz (Sorry, still internal to Novell. We plan to have a public download this week) USAGE: 1. Run the appliance 2. Point the browser to port 80 (*) (**) Select the "localhost" item, Log in as root, with password linux 3. Go through the base setup (time and language) (***) GENERAL NEWS: - the rest server runs back on the usual port 8080 (*) MODULE SPECIFIC NEWS: - removed samba and user modules, as they are buggy and low priority - added custom service config (bnc#544332) but the icon is still missing (bnc#544355) - I don't know what changed in the individual modules. We need to fix this part FEEDBACK: this mailing list, Bugzilla, irc (TODO improve this section) *) in production it will run on a different port, see https://fate.novell.com/306714 https://fate.novell.com/306715 I plan to switch it to temporary ports this week to prepare for that **) options: - have the virtual machine set to network bridging - tunnel out from the inside: ssh -R 10080:127.0.0.1:80 \ -R 18080:127.0.0.1:8080 \ -R 10022:127.0.0.1:22 \ 10.0.2.2 (where 10.0.2.2 is how the VM sees the host in a VirtualBox NAT setup) ***) Still not fixed: 500 after basesystem setup (bnc#543766) touch /srv/www/yastws/vendor/plugins/basesystem/var/finish and reload the page -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 3

[yast-devel] mail server rest API proposal
by Jiří Suchomel 08 Oct '09

08 Oct '09

Mail server module proposal (fate #307142) --------------------------------------------- Tasks: - configure the SMTP server used for sending mails: - smtp server address - authentication fields Model singleton class MailServer attributes string smtp_server string login string password string tls access to the system: YaPI::MailServer YaPI::SERVICES Policies org.opensuse.yast.modules.yapi.mailserver.read org.opensuse.yast.modules.yapi.mailserver.write API URL: /mail REST service pseudo-code: # GET method def show read and return current settings # PUT method def update (params) save new settings: smtp server address and credentials if there was a change, reload of postfix service is needed -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 5

[yast-devel] WebYaST: new wiki page: Writing REST documentation
by Ladislav Slezak 08 Oct '09

08 Oct '09

Hi, I have finally finished the wiki page describing how to document a WebYaST REST API. It is available here: http://en.opensuse.org/YaST/Web/Development/REST_Service_Documentation (It's also linked from the main devel page http://en.opensuse.org/YaST/Web/Development .) Another change is that the documentation is now built during RPM package build, not in 'rake package'. The advantage is that the documentation will be automatically regenerated whenever the restility RPM is updated. (I have adapted all WebYaST packages, you don't need to change anything.) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : - Fixed static overlay when running in lighttpd server (bnc#544355)]
by Stefan Schubert 08 Oct '09

08 Oct '09

Ladislav Slezak schrieb: > On 7.10.2009 20:14, Ladislav Slezak wrote: > >> ref: refs/heads/master >> commit 23f769a1d9bd45762bf2eddbea731d1a64542dee >> Author: Ladislav Slezak <lslezak(a)novell.com> >> Date: Wed Oct 7 20:14:36 2009 +0200 >> > [...] > >> diff --git a/webclient/lib/yast/rack/static_overlay.rb b/webclient/lib/yast/rack/static_overlay.rb >> index 807470d..0548cf7 100644 >> --- a/webclient/lib/yast/rack/static_overlay.rb >> +++ b/webclient/lib/yast/rack/static_overlay.rb >> @@ -25,11 +25,21 @@ module YaST >> def call(env) >> req = ::Rack::Request.new(env) >> resource = URI.parse(req.url).path >> - puts resource >> + >> + # this is a workaround for lighttpd server >> + # where all requests go through FastCGI dispatcher >> + if resource == '/dispatch.fcgi' >> + # get the real request path >> + resource = env['REQUEST_URI'] >> + # Rack expects the path in PATH_INFO which is not set by lighttpd >> + env['PATH_INFO'] = env['REQUEST_URI'] >> + end >> + >> > > I'm not sure if this is the correct fix, I have found that the environment ('env' > variable in the code above) is quite different when running in lighttpd > server (in contrast to Mongrel or Webrick). > Thank you Ladislav for finding the reason for this bug. I can imaging that it has been quite "tricky" :-) I think that environment variable should be set in rails.include which is used by the lighttpd: # # usage: # $HTTP["host"] == "someapp.opensuse.org" { # rails_app = "someapp" # rails_root = "/srv/www/opensuse/someapp" # rails_procs = 4 # # production/development are typical values here # rails_mode = "production" # include "vhosts.d/rails.inc" # } # # quick fix for security bug in rails 1.1 # url.rewrite-once = ( "^/(app|components|config|db|doc|lib|log|public|script|test|tmp|vendor)/" => "/index.html" ) url.rewrite += ("^/apidocs(/|)$" => "/apidocs/html/index.html") magnet.attract-physical-path-to = ( conf_dir + "/cleanurl-v5.lua" ) accesslog.filename = log_root + "/obs-" + rails_app + "-access.log" rails_tmp = rails_root + "/tmp" server.document-root = rails_root + "/public" fastcgi.server = ( ".fcgi" => ( rails_app => ( "socket" => rails_tmp + "/sockets/fcgi.socket", "bin-path" => server.document-root + "/dispatch.fcgi", "bin-environment" => ( "RAILS_ENV" => rails_mode, "TMP" => rails_tmp ), "max-procs" => rails_procs, "idle-timeout" => 3600, ) ) ) > Maybe the lighttpd config should be changed instead of this patch, I don't know. > Can somebody check this possibility? Schubi? Duncan? > This is currently available for the service only. We will have to create this file for the client too. We need this file also for switching to production mode. The client still runs in development mode. So the fix is meanwhile absolutely OK. Thank you again for the fix ! Stefan > > > -- > > Best Regards > > Ladislav Slezák > Yast Developer > ------------------------------------------------------------------------ > SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz > Lihovarská 1060/12 tel: +420 284 028 960 > 190 00 Prague 9 fax: +420 284 028 951 > Czech Republic http://www.suse.cz/ > -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] system services vs custom service
by Martin Schmidkunz 08 Oct '09

08 Oct '09

Hi, while testing the latest webYaST appliance (0.0.10), which runs nice and smoothly so far, I was puzzled by two modules: System Services and Custom Service. What is the difference between those two modules? And what is the reason, why they are separated? Because to me, as a Newbie, both modules basically set up some services. Cu, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

4 3