October 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <rest-service> master : added requirements
by josef reidinger 26 Oct '09

26 Oct '09

Stefan Schubert napsal(a): > ref: refs/heads/master > commit 481a9c8138c759349c4ee63122c839ac46fa7b99 > Author: Stefan Schubert <schubi(a)suse.de> > Date: Mon Oct 26 10:09:26 2009 +0100 > > added requirements > --- > .../package/yast2-webservice-registration.spec | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/registration/package/yast2-webservice-registration.spec b/plugins/registration/package/yast2-webservice-registration.spec > index 2d25920..80d7d0a 100644 > --- a/plugins/registration/package/yast2-webservice-registration.spec > +++ b/plugins/registration/package/yast2-webservice-registration.spec > @@ -22,7 +22,7 @@ Source: www.tar.bz2 > BuildRoot: %{_tmppath}/%{name}-%{version}-build > BuildArch: noarch > BuildRequires: rubygem-mocha > -Requires: yast2-core > 2.18.14 > +Requires: yast2-core > 2.18.14 yast2-webservice-registration Hi, I don't understand this change. Why you add requirement to itself? It is some packaging trick? Josef > > # > %define pkg_user yastws -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] New rake task to submit package to OBS
by Josef Reidinger 23 Oct '09

23 Oct '09

Hi, today after I submit all packages (8 packages) hudson rewrites it with old version. Before I eat my hat, I create rake task to automatic submit package to obs repository - `rake submit` which check if package pass all tests and then submit it. (little hack if you are sure that it doesn't break anything is rake osc_submit ) enjoy it Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: package naming conventions
by Jiří Suchomel 23 Oct '09

23 Oct '09

Hi, I wanted to close bug 548676 ("mail_settings vs. mailsettings name inconsistency"), however, I found that we do not have any unique conventions of how to name a packages. We have packages: - with underscore in the name: yast2-webclient-patch_updates - with dash: yast2-webclient-custom-services - withoutwordseparators: yast2-webclient-systemtime ... so, shouldn't we unify it? Dash looks good in the name, because we have it already in the "yast2-web" part, but than we cannot find a consistency with controller/model names, which should have underscores or nothing. With underscore, we can could have it same at every place (yast2-webclient-patch_updates, patch_updates_controller.rb, PatchUpdatesController), however the package name is ugly. Without separators, package name and controller/model names could be the same ( yast2-webclient-systemtime, SystemtimeController), but object names look bad... Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST release process
by Martin Vidner 23 Oct '09

23 Oct '09

Hi, 1) YaST:Web:STABLE 2) weekly releases 1) there is a need for a stable repository, as a base for releases (both as repos and appliances) and for QA people. I will create another project in OBS, https://build.opensuse.org/project/show?project=YaST:Web:STABLE Few people(#) will be maintainers there and you will send submit requests. They will be rewieved, mainly to check that *the changes are documented in the changelog, with bug numbers* (I would like to hijack YaST:Web:Demo for this purpose but apparently a rename is not possible) That way the current repo, https://build.opensuse.org/project/show?project=YaST:Web can get checkins from Hudson even when we are making a release. So Y:W:S is like Factory and Y:W is its devel project. 2) There will be weekly releases on Fridays. By Thursday evening, you should - submit the packages and request the check in to YWS - send snippets for the weekly news: -- for the users (testers) -- for the developers, if you changed the framework or a library Overnight, the packages should build. On Friday I will make a test appliance, run it to catch obvious breakages (and play Coolo in such cases) upload it and compile the announcement. For this week, let's move the deadline to Friday noon. Before that, I will set up the project. (#) Who wants to play? -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 1

[yast-devel] Webyast and documentation
by Josef Reidinger 23 Oct '09

23 Oct '09

Hi, Here is my summary of my documentation tour experimenting. 1) I improve readme of rest-service. If you find that there is missing some essential information, please add it. 2) I test few tools to generate doc and here is result: a) classic rdoc - http://w3.suse.de/~jreidinger/webservice It is mature and working documentation tool without problems, but generated pages is not nice and user-friendly. b) yard - http://w3.suse.de/~jreidinger/webservice-yard/ Contain some advance features and is compatible with rdoc. I found problems if generated for whole git (as you can see it is not finded any README_FOR_APP). Also it doesn't generate links which is in rest-service README_FOR_APP. I try contact authors. c) new rdoc - http://w3.suse.de/~jreidinger/webservice-nrdoc/ New version contains better UI and also few good features like quick search, but it looks like some items is not showed (like just few files, few classes). Search functionality is nice. Clickable sources is also quite good. I welcome your opinions which one we should use for our generated documentation. new rdoc and yard is not in distribution, so it should be add if we use it. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WEbyast - documentation and yard
by Josef Reidinger 22 Oct '09

22 Oct '09

Hi, after yesterday duncan notice I play with yard extension of rdoc and I must say that it is really good. http://yard.soen.ca/getting_started It generate example webservice documentation and if you like it, I can switch generated doc to yard. http://w3.suse.de/~jreidinger/webservice-yard/ (internal only) Yard also can generate dependency graph. http://w3.suse.de/~jreidinger/webservice-yard/webservice-graph.png (internal only) I welcome suggestion and your opinions about yard. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : returning 400 and the missed arguments
by Josef Reidinger 22 Oct '09

22 Oct '09

Stefan Schubert write: > ref: refs/heads/master > commit df9763bc3ec86997021c9fd0f9b016b86cc6ab4f > Author: Stefan Schubert <schubi(a)suse.de> > Date: Thu Oct 22 14:47:07 2009 +0200 > > returning 400 and the missed arguments > --- > .../registration/registration_controller.rb | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git > a/plugins/registration/app/controllers/registration/registration_controlle > r.rb > b/plugins/registration/app/controllers/registration/registration_controlle > r.rb index bd915e1..9427aae 100644 > --- > a/plugins/registration/app/controllers/registration/registration_controlle > r.rb +++ > b/plugins/registration/app/controllers/registration/registration_controlle > r.rb @@ -22,9 +22,11 @@ class Registration::RegistrationController < > ApplicationController end > > ret = @register.register > - #if (ret != 0) > - # headers["Status"] = "400 Bad Request" > - #end > + if ret == "4" > + render :xml=>@register.to_xml( :root => "registration", :dasherize > => false ), :status =>400 and return + elseif ret != 0 > + render ErrorResult.error(404, 2, "Error while calling registration > server.") and return + end > end > > def show > Hi, If you use special code for communication it is OK, but when you want report error I suggest use BackendException. It is common way how we report errors on backend side and it has well defined structure which is easy to parse. see http://www.suse.de/~jreidinger/webservice/webservice/classes/BackendExcepti… (I should improve documentation of that class) and as example http://www.suse.de/~jreidinger/webservice/webservice/classes/NoPermissionEx… (especially source code of to_xml method) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] metric-fu for rest-service
by Josef Reidinger 22 Oct '09

22 Oct '09

Hi, I generate metric-fu statistic for rest-service (frontend still have some problems). It is located at http://w3.suse.de/~jreidinger/reststats/ (internal only) You can look how your code is good with comparison to another guys. There should be problem with paths, as I generate and copy file to another location. Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status call 22-Oct-2009
by Martin Vidner 22 Oct '09

22 Oct '09

Present: dmacvicar, jdsn, jfriedl, jsrain, jsuchome, lslezak, mschmidkunz, mvidner, schubi, stano Absent: bbrunner, kkaempf, jreidinger, mkudlvasr, mzugec, rlihm schubi: - registration in the background, talked to mc about not wanting to write a parser - will complete it jdsn: - zypper call done - will remove the parser dmacvicar: - reported some UI bugs - will work on permission bugs stano: - no update jsrain: - no update lslezak: - fixed input validation in admin module (was checking the whole form even though the action dealt with a part only) - fixed translation packaging, fixed the flags [but see https://bugzilla.novell.com/show_bug.cgi?id=541528 ] - will check an article about (not) using rubygems: http://weblog.rubyonrails.org/2009/9/1/gem-packaging-best-practices mvidner: - will discuss how to fix authentication ( https://bugzilla.novell.com/show_bug.cgi?id=542143 ) - will package and release jfriedl: - took over the documentation - will talk with kkaempf what to include mschmidkunz: - met with kkaempf and rlihm about status and work division - getting git working - questionnaire for testers - will grab some UI bugs jsuchome: - saw the long bug list, sorted some - worked on mail settings backend -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : enhanced test suite
by Josef Reidinger 22 Oct '09

22 Oct '09

Jiri Suchomel write: > ref: refs/heads/master > commit fbbae0661d2849bcf063c68aa242e65540689f12 > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Thu Oct 22 10:30:04 2009 +0200 > > enhanced test suite > required postfix > --- > plugins/mail_settings/app/models/mail_settings.rb | 18 +++-- > .../package/yast2-webservice-mailsettings.changes | 7 ++ > .../package/yast2-webservice-mailsettings.spec | 4 +- > .../functional/mail_settings_controller_test.rb | 70 > ++++++++++++++++++++ .../mail_settings/test/unit/mail_settings_test.rb | > 65 +++++++++++++----- 5 files changed, 137 insertions(+), 27 deletions(-) > > diff --git a/plugins/mail_settings/app/models/mail_settings.rb > b/plugins/mail_settings/app/models/mail_settings.rb index e0a1276..76203b7 > 100644 > --- a/plugins/mail_settings/app/models/mail_settings.rb > +++ b/plugins/mail_settings/app/models/mail_settings.rb > @@ -15,22 +15,23 @@ class MailSettings > include Singleton > > def initialize > - @password = "" > - @user = "" > - @smtp_server= "" > - @transport_layer_security = "NONE" > end > > # read the settings from system > def read > + # reset the settings before read > + @password = "" > + @user = "" > + @smtp_server= "" > + @transport_layer_security = "NONE" ^^^ If you must comment some code it is good point where is appropriate to separate it to own function with good name. I think you could create internal method clear or init, which is called from read. (Or you can revert old to old behavior and just call initialize in read such a def read initialize .... > yapi_ret = YastService.Call("YaPI::MailSettings::Read") > if yapi_ret.has_key? "SendingMail" > sending_mail = yapi_ret["SendingMail"] > if sending_mail.has_key? "RelayHost" > relay_host = sending_mail["RelayHost"] > @smtp_server = relay_host["Name"] > - @user = relay_host["Account"] > - @password = relay_host["Password"] > + @user = relay_host["Account"] if relay_host.has_key? "Account" > + @password = relay_host["Password"] if relay_host.has_key? > "Password" end > @transport_layer_security = sending_mail["TLS"] if > sending_mail.has_key? "TLS" end > @@ -40,8 +41,9 @@ class MailSettings > # Save new mail settings > def save(settings) > > - settings.each do |k, v| > - settings[k] = "" if v.nil? > + # fill settings hash if it misses some keys > + ["transport_layer_security", "smtp_server", "user", "password"].each > do |key| + settings[key] = "" if (!settings.has_key? key) || > settings[key].nil? end > > if settings["transport_layer_security"] == @transport_layer_security > && diff --git > a/plugins/mail_settings/package/yast2-webservice-mailsettings.changes > b/plugins/mail_settings/package/yast2-webservice-mailsettings.changes > index 6f0458c..d076d43 100644 > --- a/plugins/mail_settings/package/yast2-webservice-mailsettings.changes > +++ b/plugins/mail_settings/package/yast2-webservice-mailsettings.changes > @@ -1,4 +1,11 @@ > ------------------------------------------------------------------- > +Thu Oct 22 10:05:17 CEST 2009 - jsuchome(a)suse.cz > + > +- enhanced test suite > +- required postfix > +- 0.0.3 > + > +------------------------------------------------------------------- > Thu Oct 15 11:06:33 CEST 2009 - jsuchome(a)suse.cz > > - save MaximumMailSize, restart postfix > diff --git > a/plugins/mail_settings/package/yast2-webservice-mailsettings.spec > b/plugins/mail_settings/package/yast2-webservice-mailsettings.spec index > ef83baf..d06e58b 100644 > --- a/plugins/mail_settings/package/yast2-webservice-mailsettings.spec > +++ b/plugins/mail_settings/package/yast2-webservice-mailsettings.spec > @@ -15,7 +15,7 @@ Provides: > yast2-webservice:/srv/www/yastws/app/controllers/mail_settings_c License: > MIT > Group: Productivity/Networking/Web/Utilities > Autoreqprov: on > -Version: 0.0.2 > +Version: 0.0.3 > Release: 0 > Summary: YaST2 - Webservice - Mail Settings > Source: www.tar.bz2 > @@ -32,7 +32,7 @@ BuildRequires: yast2 yast2-mail > %endif > > # YaPI::MailServer (standard edition) > -Requires: yast2-mail > +Requires: yast2-mail postfix > > # YaPI::SERVICES (for postfix) > %if 0%{?suse_version} == 0 || %suse_version > 1110 > diff --git > a/plugins/mail_settings/test/functional/mail_settings_controller_test.rb > b/plugins/mail_settings/test/functional/mail_settings_controller_test.rb > new file mode 100644 > index 0000000..2f5f589 > --- /dev/null > +++ > b/plugins/mail_settings/test/functional/mail_settings_controller_test.rb > @@ -0,0 +1,70 @@ > +require File.expand_path(File.dirname(__FILE__) + "/../test_helper") > +require 'test/unit' > + > + > +class MailSettingsControllerTest < ActionController::TestCase > + fixtures :accounts > + > + def setup > + @controller = MailSettingsController.new > + @request = ActionController::TestRequest.new > + # http://railsforum.com/viewtopic.php?id=1719 > + @request.session[:account_id] = 1 # defined in fixtures > + > + @model = MailSettings.instance > + @model.stubs(:read).returns(true) > + end > + > + test "check 'show' result" do > + > + ret = get :show > + # success (200 OK) > + assert_response :success > + > + # is returned a valid XML? > + ret_hash = Hash.from_xml(ret.body) > + assert ret_hash > + assert ret_hash.has_key?("mail_settings") > + assert ret_hash["mail_settings"].has_key?("smtp_server") > + end > + > + test "put success" do > + @model.stubs(:save).with({'smtp_server' => "newserver"}).returns(true) > + > + ret = put :update, :mail_settings => {:smtp_server => "newserver"} > + ret_hash = Hash.from_xml(ret.body) > + > + assert_response :success > + assert ret_hash > + assert ret_hash.has_key?("mail_settings") > + end > + > + test "put failure" do > + YastService.stubs(:Call).with('YaPI::MailSettings::Write', { > + "Changed" => [ "i", 1], > + "MaximumMailSize" => [ "i", 10485760], > + "SendingMail" => ["a{sv}", { > + "Type" => [ "s", "relayhost"], > + "TLS" => [ "s", ""], > + "RelayHost" => [ "a{sv}", { > + "Name" => [ "s", "smtp.newdomain.com"], > + "Auth" => [ "i", 0], > + "Account" => [ "s", ""], > + "Password"=> [ "s", ""] > + }] > + }] > + > + }).returns("Unknown mail sending TLS type. Allowed values are: NONE | > MAY | MUST | MUST_NOPEERMATCH") + > + ret = put :update, :mail_settings => {:smtp_server => > "smtp.newdomain.com"} + > + ret_hash = Hash.from_xml(ret.body) > + > + assert_response 503 > + assert ret_hash > + assert ret_hash.has_key?("error") > + assert ret_hash["error"]["type"] == "MAIL_SETTINGS_ERROR" > + end > + > + > +end > diff --git a/plugins/mail_settings/test/unit/mail_settings_test.rb > b/plugins/mail_settings/test/unit/mail_settings_test.rb index > f33b9c4..df19b90 100644 > --- a/plugins/mail_settings/test/unit/mail_settings_test.rb > +++ b/plugins/mail_settings/test/unit/mail_settings_test.rb > @@ -11,6 +11,52 @@ class MailSettingsTest < ActiveSupport::TestCase > @model.read > end > > + def test_read_notls > + YastService.stubs(:Call).with('YaPI::MailSettings::Read').returns({ > + "SendingMail" => { > + "RelayHost" => { > + "Name" => "smtp.domain.com" > + } > + } > + }) > + ret = @model.read > + assert @model.transport_layer_security == "NONE" > + end > + > + def test_read > + YastService.stubs(:Call).with('YaPI::MailSettings::Read').returns({ > + "SendingMail" => { > + "TLS" => "MUST", > + "RelayHost" => { > + "Name" => "smtp.domain.com" > + } > + } > + }) > + ret = @model.read > + assert @model.smtp_server == "smtp.domain.com" > + assert @model.transport_layer_security == "MUST" > + end > + > + > + def test_save_no_change > + YastService.stubs(:Call).with('YaPI::MailSettings::Read').returns({ > + "SendingMail" => { > + "TLS" => "MUST", > + "RelayHost" => { > + "Name" => "smtp.domain.com" > + } > + } > + }) > + ret = @model.read > + ret = @model.save({ > + "smtp_server" => "smtp.domain.com", > + "user" => "", > + "password" => "", > + "transport_layer_security" => "MUST" > + }) > + assert ret > + end > + > def test_save > YastService.stubs(:Call).with('YaPI::MailSettings::Write', { > "Changed" => [ "i", 1], > @@ -36,21 +82,6 @@ class MailSettingsTest < ActiveSupport::TestCase > assert ret > end > > - def test_read > - YastService.stubs(:Call).with('YaPI::MailSettings::Read').returns({ > - "SendingMail" => { > - "TLS" => "MUST", > - "RelayHost" => { > - "Name" => "smtp.domain.com" > - } > - } > - }) > - ret = @model.read > - assert ret > - assert @model.smtp_server == "smtp.domain.com" > - assert @model.transport_layer_security == "MUST" > - end > - > > def test_save_failure > YastService.stubs(:Call).with('YaPI::MailSettings::Write', { > @@ -58,7 +89,7 @@ class MailSettingsTest < ActiveSupport::TestCase > "MaximumMailSize" => [ "i", 10485760], > "SendingMail" => ["a{sv}", { > "Type" => [ "s", "relayhost"], > - "TLS" => [ "s", nil], > + "TLS" => [ "s", ""], > "RelayHost" => [ "a{sv}", { > "Name" => [ "s", "smtp.newdomain.com"], > "Auth" => [ "i", 0], > @@ -67,7 +98,7 @@ class MailSettingsTest < ActiveSupport::TestCase > }] > }] > > - }).returns("TLS cannot be empty") > + }).returns("Unknown mail sending TLS type. Allowed values are: NONE | > MAY | MUST | MUST_NOPEERMATCH") assert_raise MailSettingsError do > @model.save({ > "smtp_server" => "smtp.newdomain.com", > I suggest move all DATA from test to Constants, then you can easily see what options is tested and add new specific data which should be tested. like WRITE_DBUS_DATA= { "Changed" => [ "i", 1], "MaximumMailSize" => [ "i", 10485760], "SendingMail" => ["a{sv}", { "Type" => [ "s", "relayhost"], "TLS" => [ "s", ""], "RelayHost" => [ "a{sv}", { "Name" => [ "s", "smtp.newdomain.com"], "Auth" => [ "i", 0], "Account" => [ "s", ""], "Password"=> [ "s", ""] }] }] } -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0