October 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Webyast: ActiveSource
by Josef Reidinger 13 Oct '09

13 Oct '09

Hi, I look on Friday on validations for our rest-service. I little play with code and it is not so easy to correctly define validation which is called in model context. I spend some time to google solution and there is ActiveSupport::Callbacks, whichhas required functionality. For correctly usage of Callbacks it is needed to call it on certain place in model code. I also find that ActiveResource and ActiveRecord contain interesting shortcuts and helpers, so I get idea that I should create general ActiveSource, for such models. This ActiveSource provide all things which is common for ActiveRecord and ActiveRecord such as save, find, create, load and filters like after_save, before_validation and others. What developer need to use this support is only provide method store (called from save, handle storing to source - in our case DBus), load (read from source - also DBUS) and optional initialize which should initialize by some defaults. It should also contain some automatic to_xml and to_json (at least to_json in our code is not DRY and to_xml should be also generated automatic). So if developer use ActiveSource code looks like this. class NtpSync < ActiveSource::Core validates_inclusion_of :sync, [true,false] before_filter :save { yapi_perm_check "ntp.synchronize" } def load @sync = false end def store if @sync raise NtpError.new(ret) unless YastService.Call ("YaPI::NTP::Synchronize") end return true #if false, then save also return false end end and usage in controller: NtpController < ApplicationController before_filter :login_required def show ntp = Ntp.find respond_to do |format| format.html { render :xml => ntp.actions.to_xml(:root => :actions)} #return xml only format.xml { render :xml => ntp.actions.to_xml(:root => :actions)} format.json { render :json => ntp.actions.to_json } end end def update root = params["ntp"] if root == nil || root == {} raise InvalidParameters.new :ntp => "Missing" end Ntp.create root show end def create update end end What do you think about the idea? Any comments, suggestions? Should I start with it? -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 1

[yast-devel] WebYaST status call 13-Oct-2009
by Martin Schmidkunz 13 Oct '09

13 Oct '09

participants: kkaempf, jsrain, mschmidkunz, dmacvicar, schubi, jdsn, visnov, lslezak, jreidinger ------------------------ General: * look through your tasks and bugs in bugzilla and update them in order to help estimate how much work is needed for feature freeze * reserve and take learning/training time ------------------------ Reports: kkaempf * meeting with mschmidkunz and rlihm about UI * plans to estimate how much work is needed for feature freeze jsrain * no updates mschmidkunz * meeting with kkaempf and rlihm about UI * plans to test appliance for inconsistencies and other UI/usability issues dmacvicar * no updates schubi * worked on registration module together with jdsn * plans to continue working on registration module jdsn * continued work with registration module * was able to run a registration successfully * plans to continue working on registration module (e.g. on missing informations) visnov * no update lslezak * reduced main package * improved creation of packages * input validation in admin settings module * plans to test mail settings modules jreidinger * fixes in webservice * plans to write proposal for validation on backend side --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

1 0

[yast-devel] WebYaST: Hash in Hash in YastService.Call
by J. Daniel Schmidt 13 Oct '09

13 Oct '09

Hi hackers, in rest-service/plugins/users/app/models/user.rb a hash is created: > parameters = { "index" => ["s", "uid"], > "user_attributes" => ["as", [ "cn" ]] } and then passed as parameter like this: > users_map = YastService.Call("YaPI::USERS::UsersGet", parameters) The hash requires a list of values, first one being a type identifier, the second being the real value. I found out that valid types are: s, i, b, a resp. as for string, integer, boolean and array resp. array of string. But I need to define a hash here. How can I pass a hash as hashvalue? Thanks for a hint. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg

3 2

[yast-devel] use-activeresource: continuation
by Martin Kudlvasr 12 Oct '09

12 Oct '09

Hi, I've been continuing with the work, which Martin Vidner and Karel started 2 weeks ago - trying to use ActiveResource without service_resource.rb . This is currently the "use-activeresource" branch. I've added support for discovering controller paths from interface name. So currently there are no hard coded controller paths. Previously resources were used like this: *** Example from network_controller.rb *** hn = load_proxy "org.opensuse.yast.modules.yapi.network.hostname" *** Now they can be used like this: *** plugins/network/app/model/hostname.rb *** class Hostname < YastResource uses_interface "org.opensuse.yast.modules.yapi.network.hostname" end *** Example from network_controller.rb *** Hostname.initialize_from_interface hn = Hostname.find :one *** I think, that: - this newer approach better follows the MVC philosophy (with service_resource.rb, no model class is possible) - the YastResource < ActiveResource class is much shorter and more readable - individual model classes can be enriched by resource-specific methods - YastResource and individual models are not created dynamically - and so are easier to test (in contrast with service_resource.rb) - test can be made for the model. Currently we depend on tests in controller. - it is Black Magic Free (TM) :-) Please note, that "use-activeresource" branch depends on "resource-restful" branch, because it needs to discover individual resources (which is not possible with current "/resources" on web-service). This work was done to show, that there are other (and many think better) approaches to the problem than dynamic creation of classes in service_resource.rb. So I especially ask Duncan and Klaas, what other problems service_resource solves and YastResource does not. Please let me know what you think. Martin Kudlvasr -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 6

[yast-devel] rgettext doesn't extract "#{name}" strings.
by Stefan Schubert 12 Oct '09

12 Oct '09

Hi, please have a look to: http://www.yotabanana.com/hiki/ruby-gettext-faq.html#rgettext+doesn't+extract+"%23{name}"+strings. Greetings Stefan -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> registration : add debug output and context default
by Josef Reidinger 12 Oct '09

12 Oct '09

J.Daniel Schmidt write: > ref: refs/heads/registration > commit c6c85811dd73c2f217a5a0ed12db733f9de2127c > Author: J. Daniel Schmidt <jdsn(a)suse.de> > Date: Thu Oct 8 20:19:28 2009 +0200 > > add debug output and context default > --- > .../app/controllers/configuration_controller.rb | 3 +- > .../app/controllers/registration_controller.rb | 13 +++++---- > plugins/registration/app/models/registration.rb | 27 > +++++++++++++++---- 3 files changed, 29 insertions(+), 14 deletions(-) > > diff --git > a/plugins/registration/app/controllers/configuration_controller.rb > b/plugins/registration/app/controllers/configuration_controller.rb index > 765c709..77315bb 100644 > --- a/plugins/registration/app/controllers/configuration_controller.rb > +++ b/plugins/registration/app/controllers/configuration_controller.rb > @@ -1,17 +1,16 @@ > # = RegistrationConfiguration controller > # Provides access to the configuration of the registration system > +#class Registration::ConfigurationController < ApplicationController > class ConfigurationController < ApplicationController > > before_filter :login_required > > - > def update > # PUT > # setRegistrationServerDetails > @registration = "PUT to /registration/configuration" > end > > - > def show > @registration = Registration.new( { } ) > # do not run registration > diff --git > a/plugins/registration/app/controllers/registration_controller.rb > b/plugins/registration/app/controllers/registration_controller.rb index > 56cb2f1..0362770 100644 > --- a/plugins/registration/app/controllers/registration_controller.rb > +++ b/plugins/registration/app/controllers/registration_controller.rb > @@ -5,20 +5,21 @@ class RegistrationController < ApplicationController > > before_filter :login_required > > - # @registration = Registration.new( { :doo => :daa } ) > - > - > def update > end > > def create > + puts "-> REGISTRATION CREATE" ^^^^ Hi, please don't add debugging output as puts. It is not rails way, you don't have filtering ability of logging and it is confusing. Please use rails logger. For usage look at other modules. If you have any questions just ask. > # POST to registration => run registration > @registration = Registration.new({}) > - > + puts "-> NEW registration" > + puts @registration.inspect > # TODO: parse post data and set context data > #(a)registration.set_context( { } ) > - @registration.register > - > + ret = @registration.register > + puts "-> RAN register" > + puts ret.inspect > + puts "-> PUT inpect ^" > end > > def show > diff --git a/plugins/registration/app/models/registration.rb > b/plugins/registration/app/models/registration.rb index 772e154..44e0133 > 100644 > --- a/plugins/registration/app/models/registration.rb > +++ b/plugins/registration/app/models/registration.rb > @@ -12,8 +12,18 @@ class Registration > @reg = '' > > def initialize(hash) > + # set context defaults > + @context = { 'yastcall' => 1, > + 'norefresh' => 1, > + 'restoreRepos' => 1, > + 'forcereg' => 0, > + 'nohwdata' => 1, > + 'nooptional' => 1, > + 'logfile' => '/root/.suse_register.log' } > + > + # merge custom context data > if hash.class.to_s == 'Hash' > - @context = hash > + @context.merge hash > else > raise "Invalid or missing registration initialization context data." > end > @@ -32,15 +42,20 @@ class Registration > end > > def register > - @reg = YastService.Call("YSR::stateless_register", @context ) > + puts "-> called registration.register" > + @reg = YastService.Call("YSR::stateless_register", { 'ctx' => > @context, 'arguments' => @arguments } ) + puts "-> > YSR::stateless_register was called" > + puts @reg.inspect > + return @reg.inspect Returning inspect, which should change in next rails version is not good idea. If you want formated description for user I think that user welcome more html way then pure string. > end > > - def get_registration_server_details > - @reg = "get-reg-srv-det" > + def get_registration_config > + return @reg.inspect > end > > - def set_registration_server_details(url, ca) > - @reg = "you want to set URL: #{ url }" > + def set_registration_config(url, ca) > + # TODO: write registration config > + return @reg.inspect > end > At overall I think that you overload controller layer. It should be thin layer which connect model with view. I think that many your methods should go to model. Controller should contain only model initialization and model changing. Rest model manipulation should go to model. Look e.g. at time module or language, how thin should be controller layer. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST status call 12-Oct-2009
by Martin Schmidkunz 12 Oct '09

12 Oct '09

participants: jsrain, jsuchome, visnov, kkaempf, schubi, jdsn, dmacvicar, mschmidkunz -------------------------- Goal for this week: have webYaST feature complete -------------------------- jsrain * updates from mvidner: he added java script value validation into network interface jsuchomel * commited module for mail settings * plans to work on enhancements for it (validation, basic UI stuff, testing, documentation,...) visnov * no updates kkaempf * likes to thank for great team effort to release beta 1 * was sick and plans to catch up with mails schubi * started to have a look on jdsn`s code jdsn * commited registration branch to git server, tries to fix errors asks for help, dmacvicar * likes to thank for great team effort to release beta 1 mschmidkunz * plans to meet with rlihm and kkaempf to polish UI --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : first version with writing: 0.0.2
by josef reidinger 12 Oct '09

12 Oct '09

Jiri Suchomel napsal(a): > ref: refs/heads/master > commit 6bb7f85ae3d25e33e674ab8a64d5bcd8035ba576 > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Fri Oct 9 16:12:51 2009 +0200 > > first version with writing: 0.0.2 > --- > .../app/controllers/mail_settings_controller.rb | 28 +++++++++++++++++++- > .../app/views/mail_settings/index.html.erb | 17 +++++++++++- > .../package/yast2-webclient-mailsettings.changes | 6 ++++ > .../package/yast2-webclient-mailsettings.spec | 2 +- > 4 files changed, 50 insertions(+), 3 deletions(-) > > diff --git a/plugins/mail_settings/app/controllers/mail_settings_controller.rb b/plugins/mail_settings/app/controllers/mail_settings_controller.rb > index 53d00e4..d434864 100644 > --- a/plugins/mail_settings/app/controllers/mail_settings_controller.rb > +++ b/plugins/mail_settings/app/controllers/mail_settings_controller.rb > @@ -21,7 +21,33 @@ class MailSettingsController < ApplicationController > def update > @mail_settings = load_proxy 'org.opensuse.yast.modules.yapi.mailsettings' > return unless @mail_settings > - redirect_to :action => "index" > + > + mail = params["mail_settings"] > + @mail_settings.smtp_server = mail["smtp_server"] > + @mail_settings.password = mail["password"] > + @mail_settings.user = mail["user"] > + @mail_settings.transport_layer_security = mail["transport_layer_security"] I think it is not neccesary code. Look at this method, it should automatic loads hash to ActiveResource - http://api.rubyonrails.org/classes/ActiveResource/Base.html#M000918 so you could use @mail_settings.load params["mail_settings"] And if we in future improve our code to use common ActiveResource model, then just 'Model.create params' creates new instance, fill it and then store, but it is more complicated to do it with current code > + > + begin > + response = @mail_settings.save > + rescue ActiveResource::ClientError => e > + flash[:error] = YaST::ServiceResource.error(e) > + logger.warn e.inspect > + rescue ActiveResource::ServerError => e > + error = Hash.from_xml e.response.body > + logger.warn error.inspect > + if error["error"] && error["error"]["type"] == "MAIL_SETTINGS_ERROR" > + flash[:error] = _("Error while saving mail settings: #{error["error"]["output"]}") > + else > + raise e > + end > + end > + > + if params.has_key? "commit" > + redirect_success # redirect to next step > + else > + redirect_to :action => "index" > + end > end > > end > diff --git a/plugins/mail_settings/app/views/mail_settings/index.html.erb b/plugins/mail_settings/app/views/mail_settings/index.html.erb > index 304b655..a38fec0 100644 > --- a/plugins/mail_settings/app/views/mail_settings/index.html.erb > +++ b/plugins/mail_settings/app/views/mail_settings/index.html.erb > @@ -1,5 +1,20 @@ > <div class='plugin-icon'><img src='/icons/yast-mail-server.png'/></div> > > +<% content_for :head do %> > + <%= javascript_include_tag :defaults %> ^^^^ you don't need this. this add support for AJAX, which you don't use. > + > + <style type="text/css"> > + label.error { float: none; color: red; padding-left: .5em; vertical-align: top; } > + </style> > + > + <script type="text/javascript"> > + $(document).ready(function(){ ^^^ Are you sure that it work? (I am not on work station). I think that it after load of page call validate on mailForm. Do you try change mail to invalid and it work? (if it doesn't work, look at time module, where I also validate time and date) > + $("#mailForm").validate() > + ); > + </script> > +<% end %> > + > + > <h2><%=_("Mail Settings")%></h2> > > <% disabled = ! @permissions[:write] %> > @@ -26,7 +41,7 @@ > </tr> > <tr class="bg"> > <td class="first"><strong><%=_("Confirm Password")%></strong></td> > - <td class="last"><%= f.password_field :confirm_password, :disabled => disabled, :equalTo => "#administrator_password" %></td> > + <td class="last"><%= f.password_field :confirm_password, :disabled => disabled, :equalTo => "#password" %></td> > </tr> > <tr> > <td><%= form_send_buttons :onclick=>"Element.show('progress')" %></td> > diff --git a/plugins/mail_settings/package/yast2-webclient-mailsettings.changes b/plugins/mail_settings/package/yast2-webclient-mailsettings.changes > index ffe663e..87eb10c 100644 > --- a/plugins/mail_settings/package/yast2-webclient-mailsettings.changes > +++ b/plugins/mail_settings/package/yast2-webclient-mailsettings.changes > @@ -1,4 +1,10 @@ > ------------------------------------------------------------------- > +Fri Oct 9 16:11:05 CEST 2009 - jsuchome(a)suse.cz > + > +- first version of writing > +- 0.0.2 > + > +------------------------------------------------------------------- > Fri Oct 9 13:44:11 CEST 2009 - jsuchome(a)suse.cz > > - initial version > diff --git a/plugins/mail_settings/package/yast2-webclient-mailsettings.spec b/plugins/mail_settings/package/yast2-webclient-mailsettings.spec > index 30dde35..a688c69 100644 > --- a/plugins/mail_settings/package/yast2-webclient-mailsettings.spec > +++ b/plugins/mail_settings/package/yast2-webclient-mailsettings.spec > @@ -14,7 +14,7 @@ PreReq: yast2-webclient >= 0.0.2 > License: GPL > Group: Productivity/Networking/Web/Utilities > Autoreqprov: on > -Version: 0.0.1 > +Version: 0.0.2 > Release: 0 > Summary: YaST2 - Webclient - Mail Settings > Source: www.tar.bz2 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <web-client> master : first version of mail_settings client
by josef reidinger 09 Oct '09

09 Oct '09

Jiri Suchomel napsal(a): > ref: refs/heads/master > commit 0272cd0212f5af21a6e1b92b05d98a7def26f40e > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Fri Oct 9 15:36:59 2009 +0200 > > first version of mail_settings client > --- > plugins/mail_settings/.gitignore | 3 + > plugins/mail_settings/README | 7 ++ > plugins/mail_settings/Rakefile | 10 +++ > .../app/controllers/mail_settings_controller.rb | 29 ++++++++ > .../app/views/mail_settings/index.html.erb | 36 +++++++++ > plugins/mail_settings/config/rails_parent.rb | 15 ++++ > plugins/mail_settings/doc/README_FOR_APP | 7 ++ > plugins/mail_settings/init.rb | 2 + > plugins/mail_settings/install.rb | 1 + > .../package/yast2-webclient-mailsettings.changes | 5 ++ > .../package/yast2-webclient-mailsettings.spec | 77 ++++++++++++++++++++ > plugins/mail_settings/shortcuts.yml | 8 ++ > plugins/mail_settings/tasks/systemtime_tasks.rake | 6 ++ ^^^^ Hi, I think you don't want have systemtime_tasks (I am not sure if it conflicts, but it is at least non-intuitive) Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] appliance status: 0.0.10
by Martin Vidner 09 Oct '09

09 Oct '09

DOWNLOAD: http://istudio.suse.de/download/2ddc7f80cffc0f0ceaadbd2997b4c5b3/WebYaST_on… ftp://cml.suse.cz/testing/webyast/WebYaST_on_SLES11.i686-0.0.10.vmx.tar.gz (Sorry, still internal to Novell. We plan to have a public download this week) (version 0.0.9 was skipped) USAGE: 1. Run the appliance 2. Point the browser to port 80 (*) (**) Select the "localhost" item, Log in as root, with password linux 3. Go through the base setup (time and language) GENERAL NEWS: - base setup is fixed... (note to self: remove the overlay once the build server is healthy again) ... but is not entered at all :( go to /controlpanel/basesystem to see it. MODULE SPECIFIC NEWS: - I don't know what changed in the individual modules. We need to fix this part KNOWN BUGS: - Custom Service has no icon (bnc#544355) - See this query for a complete bug list: https://bugzilla.novell.com/buglist.cgi?query_format=advanced&product=openS… FEEDBACK: - irc://irc.opensuse.org/yast - https://bugzilla.novell.com/enter_bug.cgi?component=WebYaST&product=openSUS… (please disregard the oS11.2 version and instead remember to mention the appliance version. TODO write http://en.opensuse.org/Bugs/WebYaST ) - mailto:yast-devel@opensuse.org *) in production it will run on a different port, stay tuned **) options: - have the virtual machine set to network bridging - tunnel out from the inside: ssh -R 10080:127.0.0.1:80 \ -R 18080:127.0.0.1:8080 \ -R 10022:127.0.0.1:22 \ 10.0.2.2 (where 10.0.2.2 is how the VM sees the host in a VirtualBox NAT setup) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 7