September 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Webyast - base system module and error reporting
by Josef Reidinger 10 Sep '09

10 Sep '09

Hi, I merge basesystem branch to master. So after you login to your machine ,if you don't install it from rpm,you find another new cool feature - backend error reporting. It says that some file missing for basesystem settings. So just install file from package to location which error hint you ;) Welcome any bug reports on base system settings or backend error reporting. ( I plan write to wiki what you must do in your module to allow it in basesystem settings) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-Sep-10
by Josef Reidinger 10 Sep '09

10 Sep '09

kkampf: - cleaning Patch module and continue with it - study rails constant for ENV versus env variable - continue with reviewing commited code dmacvicar: - vendor settings in log, will merge code to master mzugec: - network send data from frontend to backend to write and find problem with ruby dbus - will work on dbus write mvidner: - add tests yesterday fix - inspecting mzugec ruby dbus bug - start discussion on mailing list about change for ActiveResource in lslezak: - document debug rest service via curl - document restibility of plugin and generate output to public jsuchome: - commit rest api for administrator setting, simple webclient for it jsrain: no update jreidinger: - try merge basesystem branch to master - add reporting of backend problems to frontend jdns: - try solve registering repositories and services in backend -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] RFC logs API, settings
by Duncan Mac-Vicar Prett 10 Sep '09

10 Sep '09

Right now there is a resource /logs which support only index (in all formats) and show (only in txt format) <logs type="array"> <log> <id>system</id> <path>/var/log/messages</path> <description>System messages</description> </log> <log> <id>apache</id> <path>/var/log/apache2/access_log</path> <description>Apache</description> </log> </logs> The other supported API is /logs/id?lines=x which only answers in .txt format. I experimented with two ways to define those logs, you can't pass an arbitrary filename to the API because that would be a security hole, but you can define them in vendor config files. Here are the two approaches. 1) in /etc/YaST2/vendor.yml together with other vendor settings: bug_url: http://www.bugs.com packages: - mydb-server - mydb-console log_files: - /var/log/messages - /var/log/apache2/access_log And then you get them as /logs/0, logs/1 However, this has the drawback that you dont know anything else from the log to display it in the user interface. Then a second approach, cat /etc/YaST2/vendor/logs.yml system: path: /var/log/messages description: System messages apache: description: Apache path: /var/log/apache2/access_log Then the client can display more information about them. Which approach seems better? simplicity vs usefulness? -- Duncan Mac-Vicar P. - Engineering Manager, YaST SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Ruby-Perl binding
by J. Daniel Schmidt 09 Sep '09

09 Sep '09

Hi Hackers, In case somebody needs to evaluate Perl code from Ruby you can get the package "ruby-perl" from: https://build.opensuse.org/package/show?package=ruby- perl&project=home%3Ajdsn%3Atesting I only did some small tests with it (but now went for a different solution of my problem). Please report if there are any issues with the package. Don't know yet if I submit it to factory as it is not maintained. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Using curl for sending REST API requests
by Ladislav Slezak 09 Sep '09

09 Sep '09

Hi all, While documenting a REST API I realized that I'd like to test the XML examples which I have created. I have added a new section on the Tips wiki page [1] describing how to use curl for this task. The page describes how to authenticate to the REST API, how to send PUT/POST requests and how to send a XML input file. Enjoy! [1] http://en.opensuse.org/YaST/Web/Development/Tips#Using_curl_for_sending_RES… -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST: Registration RFC
by J. Daniel Schmidt 09 Sep '09

09 Sep '09

Hi, The last days I did some research about how to implement the registration in WebYaST. And the more I found out about the stuff the more complicated everthing got. I want to give a short summary and ask for your comments here. The registration itself is realised in a Perl module. There are currently two wrappers that do the workflow for this module. The first is a command line tool called "suse_register" and the second is the YaST module "inst_suse_register" which represents the GUI pendant. My first idea was to use the Perl module directly from Ruby. After a lot failures it finally works with the bindings from: http://www.yoshidam.net/Ruby.html#perl I will prepare a package of these in the BS in case somebody needs to evaluate Perl code from Ruby. When I realised that the rest-service does not run as root (it did on my workstation) but registration must run as root it made the bindings worthless. So we have to go through the needle eye of a DBus-SCR-call and run a commandline script (as root) and parse its output. Well, as I only need to call a script I don't see the need to go over DBus here. What about configuring sudo for the webservice user? Or using a tiny setuid wrapper script? Security-wise this would make no difference, as we can do everything via SCR-calls as root anyway. It would just make things less complicated (1). Fortunately I can rely on the fact that the NCC registration server (and soon SLMS as well) offer server side caching, that means, I don't need to implement a client side statemachine (which is hard in REST context where each next call is the first one). One tricky part is the zypp lock. If somebody locked the package manager on the system and then somebody else tries to register, the zypper calls will fail. The YaST module tells the user about it as it initialises the package manager on startup. But how to this in REST contect? Just return an error like "The service you are calling is temporarily not available. Please call again later"? :) This gets less funny when it happens during a registration, as we can/should not keep a package management lock in a REST service and thus the lock might be taken in the meanwhile. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg (1) For me all this has too many layers already: Ok, lets skip the users browser that does HTTP(S) requests to the web-client which in turn does HTTP(S) requests to the rest-service. The rail rest-service then needs to do an SCR-DBus call which starts a DBus- Service and so does an Execute as root and runs a new script (the current suse_register is not sufficient for this) which is a new wrapper for the registration Perl module that talks to the NCC-server via HTTPS requests and parses their XML. The dumped result needs to get parsed again in the rest- service. In case there is information missing the user needs to get asked again. In case the registration is done there are (most likely) changes to be done to the package system (which might fail because of a zypp lock of a different user) that need to go there the SCR-DBus-way. Can we reduce the number of layers somehow? Or did I forget about some, that need to be added to make it more interesting? :) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 5

[yast-devel] Lazy package requirements of YaST modules
by Martin Vidner 09 Sep '09

09 Sep '09

Hi, yast2-nfs-server requires nfs-kernel-server, but it does not say so in .spec. Instead, it checks at run time and offers to install it then. Other modules are similar. Should we not list these packages as Recommends in .spec? IIRC the current practice was esablished before Recommends was available. ( https://bugzilla.novell.com/show_bug.cgi?id=535544 ) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] Re: [Bug 537200] [task] [fate 307141] Admin password and e-mail rest service
by Jiří Suchomel 08 Sep '09

08 Sep '09

On Tuesday 08 of September 2009 13:44:03 Bugzilla_NoReply Bugzilla_NoReply wrote: > http://bugzilla.novell.com/show_bug.cgi?id=537200 > > User kkaempf(a)novell.com added comment > http://bugzilla.novell.com/show_bug.cgi?id=537200#c3 > > > > > > --- Comment #3 from Klaus Kämpf <kkaempf(a)novell.com> 2009-09-08 05:44:01 > MDT --- (In reply to comment #2) > > > Lets discuss such things on yast-devel ! > > Move the final documentation into git, link it from the wiki, and put the > wiki url here. > > > Admin password module proposal (fate #307141) > > --------------------------------------------- > > > > Tasks: > > - change administrator (root's) password > > - configure notification e-mail addresses > > (mail aliases for root) > > - possibly more in the future > > > Model > > > > singleton class Administrator > > > > attributes > > string password > > list aliases > > Why would aliases be a list ? I understand the request as "single email > address" to send mails to. And, is 'alias' the right name for this ? I'm thinking about the implementation as an entry in /etc/aliases (we have MailAliases.ycp for that). And here it is possible to assign multiple aliases for one e-mail. > > methods > > (access the system, probably using YaPI::USERS) > > > > set_password > > set_aliases > > get_aliases > > You don't need set/get prefixes in Ruby. Ah, well, get_aliases is actually part of find method. set_password and set_aliases are meant as a methods that actually access the system (call YaPI or whatever), not that they just fill the variables. Or there can be one save method, handling both, but I thought more granularity can help testing. > > > Policies > > > > org.opensuse.yast.modules.yapi.users.administrator.read > > org.opensuse.yast.modules.yapi.users.administrator.write > > > > API > > > > URL: /administrator > > > > REST service pseudo-code: > > > > # GET method > > def show > > > > read and return current mail aliases > > > > # PUT method > > def update (params) > > > > if password changed > > > > save the new password > > > > if aliases changed > > > > save new list of aliases -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] ** [webyast] Reminder: set your tasks to 'assigned'
by Klaus Kaempf 08 Sep '09

08 Sep '09

WebYaST developers, this is a friendly reminder to set the tasks you're working on to 'assigned' in Bugzilla. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: Transition of tasks to Bugzilla complete
by Klaus Kaempf 07 Sep '09

07 Sep '09

Hi, the initial round of moving tasks from the Wiki to Bugzilla is now done. All tasks are for 'WebYaST'/'openSUSE 11.2' and start with '[task]' in the summary. The tasks are sized to be reasonably small, typically two to three days. Every WebYaST developer should have one or more tasks assigned to him via bugzilla. ** Please check that the task assignment matches your current ** work. Set the bug to 'assigned' if this hasn't been done before. All tasks must have a 'target date' set. Please set this field according to your own estimate. Thanks ! Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : more readable
by Josef Reidinger 07 Sep '09

07 Sep '09

On 09/07/2009 01:05 PM, Stefan Schubert wrote: > ref: refs/heads/master > commit 32be3734b62d83a68169620cf8ebaa8b5f4908e8 > Author: Stefan Schubert <schubi(a)suse.de> > Date: Mon Sep 7 13:05:09 2009 +0200 > > more readable > --- > .../app/controllers/patch_updates_controller.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/patch_updates/app/controllers/patch_updates_controller.rb b/plugins/patch_updates/app/controllers/patch_updates_controller.rb > index 4747342..10daa3e 100644 > --- a/plugins/patch_updates/app/controllers/patch_updates_controller.rb > +++ b/plugins/patch_updates/app/controllers/patch_updates_controller.rb > @@ -29,7 +29,7 @@ class PatchUpdatesController < ApplicationController > patches_summary = { :security => 0, :important => 0, :optional => 0} > > [:security, :important, :optional].each do |patch_type| > - patches_summary[patch_type] = patch_updates.collect { |p| p.kind == patch_type.to_s ? p : nil }.nitems > + patches_summary[patch_type] = patch_updates.find_all { |p| p.kind == patch_type.to_s }.size Hi, little note to efficiency. This code iterate through patch_updates three times, creates three array for which then get size. I think that better is iterate only once and add size to. So you can instead [:security, :important, :optional].each do |patch_type| patches_summary[patch_type] = patch_updates.find_all { |p| p.kind == patch_type.to_s }.size use (you already init it to zero in hash initializer) patch_updates.each { |pu| patches_summary[pu.kind.to_sym] += 1 } you get some result, efficienty and I think that it is has same readability. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Starting Rails application in debugger
by Ladislav Slezak 04 Sep '09

04 Sep '09

Miso needed to start a Rails application in debugger some time ago, using 'debugger' keyword doesn't help if you want to debug application loading. Now I have found the correct way - call the debugger directly: cd web-client/webclient rdebug script/server -- --debugger (the application parameters are passed after -- options) Enjoy! :-) -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-Sep-04
by Klaus Kaempf 04 Sep '09

04 Sep '09

WebYaST 04-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mzugec, mvidner, jsrain, lslezak, bbrunner, jsuchome, visnov absent: fnadge, mschmidkunz Status: ----------- kkaempf: started to move todo list to bnc working on bnc#533178 (test environment set too late) dmacvicar: working system logs view, including 'live' ajax updates research on colorizing output eta 2009-sep-11 schubi: found easy way for vendor translations next: wiki documentation mzugec: network YaPI now reads real system data Next: improve test make 'index' function work mvidner: network module 'read only' done Next: improve test make 'index' function work jsrain: - lslezak: wrote test in services plugin next: document rest interface research on how others document such apis bbrunner: learning Next: set up KVM environment for testing virtual appliance jsuchome: created package next: service ui documentation visnov: - --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] TCP port for webyast?
by Martin Vidner 04 Sep '09

04 Sep '09

Hi, how long are we going to stay with 8080 and 3000? Wouldn't it be useful to decide before the next milestone? -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] first draft of webyast style guide
by Martin Schmidkunz 03 Sep '09

03 Sep '09

Hi, please find a first draft of a webYaST style guide at: http:// en.opensuse.org/YaST/Web/Docu/Style_Guide Is there anything missing? Or is there anything you would like to discuss? Looking forward to your comments! Thanks, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™

1 0

[yast-devel] TraditionalYaST: searching YaST modules by keywords
by Katarina Machalkova 03 Sep '09

03 Sep '09

YaST hackers, I've just finished implementing ground for feature #305845 [1], that is support for defining additional keywords for YaST module and querying those (in addition to module names) in (Qt4) control centre search. However, to put the feature really into practice, I need your help. It is very simple: all you have to do is to modify .desktop file(s) your YaST module ships by adding a new key-value pair to it. The key name is 'X-SuSE-YaST- Keywords' (to conform to xdg standards [2]) and its value is comma-separated list of words describing the function of the module. Example: [Desktop Entry] Type=Application //those you already have Name=Flinstones GenericName=Modern Stone Age Family //this you will need to add X-SuSE-YaST-Keywords=fred,wilma,barney,betty I'm sure you know best which keywords to put in in order to make it easier for the users to find the module :) Thanks for the cooperation. hB. [1] https://features.opensuse.org/305845 [2] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry- spec-1.0.html -- \\\\\ Katarina Machalkova \\\\\\\__o YaST developer __\\\\\\\'/_ & hedgehog painter

2 2

[yast-devel] Re: [yast-commit] <rest-service> network : dns model shows xml list
by Josef Reidinger 03 Sep '09

03 Sep '09

On 09/03/2009 12:14 PM, Michal Zugec wrote: > ref: refs/heads/network > commit b72baab724ea256472be56efe577c9231df97881 > Author: Michal Zugec <mzugec(a)suse.cz> > Date: Thu Sep 3 12:14:49 2009 +0200 > > dns model shows xml list > --- > plugins/network/app/models/dns.rb | 14 +++++++++++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/plugins/network/app/models/dns.rb b/plugins/network/app/models/dns.rb > index 6a03736..f153a75 100644 > --- a/plugins/network/app/models/dns.rb > +++ b/plugins/network/app/models/dns.rb > @@ -42,9 +42,17 @@ class DNS > xml = options[:builder] ||= Builder::XmlMarkup.new(options) > xml.instruct! unless options[:skip_instruct] > > - xml.hostname do > - xml.domains @domains > - xml.servers @servers > + xml.dns do > + xml.domains({:type => "array"}) do > + domains.each do |@domains, val| > + xml.tag!(:domain, domains) > + end > + end > + xml.servers({:type => "array"}) do > + servers.each do |@servers, val| > + xml.tag!(:nameserver, servers) > + end > + end > end > end > Hi, I see it quite often in code and Karel on session say, that instead xml.tag!(:domain, domains) we should use simple xml.domain domains -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST status 03-Sep-2009
by J. Daniel Schmidt 03 Sep '09

03 Sep '09

WebYaST 03-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mschmidkunz, jdsn, mzugec, mvidner, jsuchomel, lslezak absent: jsrain, visnov, fnadge Status: ----------- kkaempf: work in fate dmacvicar: work on error handling plan to handle errors from proxy as well in flash section and pick next high prio. feature schubi: vendor theming done, documentation is in the wiki plan to do it for translations in a similar way mschmidkunz: discussed UI elements for error display plan to release first version of the WebYaST style guide jdsn: research for registration module succeeded to evaluate single lines of perl from ruby plan to do it as well with an entire perl module mzugec: extended REST API for DNS plan to implement YaPI interfaces mvidner: work on bugzilla bugs plan to implement the read only part of the network module jsuchomel: work on bugzilla bugs discussed custom services plan to pick next TODO from the list lslezak: work on error handling in the services module plan to pick next TODO from the list General decisions: - We will handle concrete TODO actions in bugzilla. (not the generic fate request itself, but single tasks/steps to fulfill one) Please hand unassigned bugs to Klaus. - If you look for a new feature to implement please pick one from the _top_ of the TODO file Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: Vendor service - Summary + TODO
by Ladislav Slezak 03 Sep '09

03 Sep '09

(Resending to yast-devel for a broader discussion....) Dne 21.8.2009 10:08, Jiří Suchomel napsal(a): > On Thursday 20 of August 2009 13:30:12 Ladislav Slezak wrote: >> The REST service >> ================ >> >> - provides a REST API for both LSB and custom services >> - uses YaPI for LSB services >> - custom services are handled directly, config files are read/parsed >> directly, SCR service is used for execution >> - uses new YaST::ConfigFile library >> >> >> Web UI (webclient) >> ================== >> >> - provides a separate view on LSB services and custom services >> - allows custom branding (via modifications in /public directory) > > TODO > > The REST service > ================ > - enhance testsuite > - add function to query service status (Q: use new policy for query, or use > the one for "execute"?) I'd reuse the existing right, no need for extra one IMHO. > Web UI (webclient) > ================== > - testsuite > - design the UI (talk to mschmidkunz), may be different for System vs. Custom > services The question is if vendors would like to change "Custom Services" to a better name (with real service name). With current implementation they need to change the name directly in .yml config file. Is that OK? > - show the service status: > - for system services, probably first show list of services, that update the > status of each one service with AJAX calls Maybe one AJAX call for all services could be better (I'm not sure about the overhead, running 30 requests in parallel instead of big one might be too slow.) Any idea? I'm not an AJAX expert... > - custom service is expected to be only one currently, so the status could > be load on loading index page I'd keep the same functionality, this creates unnecessary complexity. More over reading the current status might take long time so the complete page would be displayed after a (possibly long) delay. > - think how the service execution result should be shown better -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 4

[yast-devel] Error handling - rest service side
by Josef Reidinger 03 Sep '09

03 Sep '09

Hi, as you can see from commits I merge my error handling branch to master. So what changes: in short: errors in backend is reported via exceptions, all webservice exceptions should have one ancestor BackendException, so if you want add own exception please create it as child of this class uncatched BackendExceptions is reported as 503 and content is xml description of problem. BackendException must have unique enum identificator, english description if anyone read directly xml and to_xml method, that creates content of respond. I create 3 exceptions for permission check as example, so now permission_check method throws exceptions instead returning false and if you don't want return something special, don't catch it. For yapi based modules I create shortcut yapi_perm_check where you only specify last part of permission (e.g. "time.read") more in yast_roles documentation. Duncan - can we generate documentation on some public place to easier link it and be easier accesible? Welcome any comments and I suggest create own exceptions. I plan in near future addapt client side error reporting for this 503 response. Documented also on wiki http://en.opensuse.org/YaST/Web/Development/Error_Handling Welcome any comments and suggestions -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> basesystem : when module failed in control panel, the result was endless redirect loop
by Josef Reidinger 03 Sep '09

03 Sep '09

On 08/26/2009 06:58 PM, Martin Kudlvasr wrote: > ref: refs/heads/basesystem > commit ea5740fcf91f51284a51cb1bf9345823ddd57cee > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Wed Aug 26 18:58:19 2009 +0200 > > when module failed in control panel, the result was endless redirect loop > added another view to separate controlpanel from basesystem. > now user actually see the error > --- > .../app/controllers/controlpanel_controller.rb | 25 +++++++++++++------ > webclient/app/views/controlpanel/basesystem.rhtml | 4 +++ > 2 files changed, 21 insertions(+), 8 deletions(-) > > diff --git a/webclient/app/controllers/controlpanel_controller.rb b/webclient/app/controllers/controlpanel_controller.rb > index b9ba795..09d7494 100644 > --- a/webclient/app/controllers/controlpanel_controller.rb > +++ b/webclient/app/controllers/controlpanel_controller.rb > @@ -38,8 +38,6 @@ class ControlpanelController < ApplicationController > > > # Constant that signalizes, that all steps from base system setup are done > - # This constant and constant in rest-service -> basesystem.rb are not connected > - # and do not have to be the same value > FINAL_STEP = "FINISH" > # nextstep and backstep expect, that wizard session variables are set > def ensure_wizard > @@ -62,8 +60,9 @@ class ControlpanelController < ApplicationController > # basesystem.save will set always current to FINAL_STEP > basesystem.save > session[:wizard_current] = FINAL_STEP > + redirect_to "/controlpanel" > end > - redirect_to "/controlpanel" > + redirect_to get_redirect_hash(session[:wizard_current]) > end Hi, you cannot do what this change (I already fix it, so this is just note). You redirect_to /controlpanel if basesystem steps is done and then you again redirect to last wizard step, which broke system. You can look at my commit for correct behavior ( only one redirect per action!) -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] automatic package submission should be working again
by Duncan Mac-Vicar P. 02 Sep '09

02 Sep '09

Lets see if YaST:Web builds by tomorrow ;-) Duncan -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] yast-commit mails delayed by almost a week ?!
by Klaus Kaempf 02 Sep '09

02 Sep '09

Hi, I'm wondering if others also get yast-commit mails delayed by almost a week. E.g. I received this morning a commit from last week Thursday. I just opened bnc#536189 to track this down. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 3

[yast-devel] Re: [yast-commit] <web-client> master : status module: code cleanup. TODO: implement limit format with maximum and minimum
by josef reidinger 02 Sep '09

02 Sep '09

Bjoern Geuken napsal(a): > ref: refs/heads/master > commit 995bc764b3e72bdb385961a80e3ee861fd9edec4 > Author: Bjoern Geuken <bgeuken(a)suse.de> > Date: Wed Sep 2 10:45:36 2009 +0200 > > status module: code cleanup. TODO: implement limit format with maximum and minimum > --- > .../status/app/controllers/status_controller.rb | 100 +++++--------------- > 1 files changed, 24 insertions(+), 76 deletions(-) > > diff --git a/plugins/status/app/controllers/status_controller.rb b/plugins/status/app/controllers/status_controller.rb > index bd5d22c..d791323 100644 > --- a/plugins/status/app/controllers/status_controller.rb > +++ b/plugins/status/app/controllers/status_controller.rb > @@ -14,63 +14,35 @@ class StatusController < ApplicationController > @permissions = @client.permissions > end > > - def create_data_map( tree, label = "") > + def write_data_group(label, group, metric_name, limits=nil) > + data_list = Array.new > + divisor = (group == "memory")? 1024*1024 : 1 # take MByte for the value > + count = 0 > + data_list = label.map{ |v| count+=1; [count,v.to_f/divisor]} Hi, just few notes, here I don't understand what is label. You have default value for label empty string "", is it really intended? then this map take from String each character and convert it to float (so you get ascii value). From my point of view maybe label is array? > + @data_group[group].merge!({metric_name => data_list}) As I previously say, merge is if you want merge two hash, but in this case you want set one value in hash (it is more effective and less confusing) so you can use @data_group[group][metric_name] = data_list > + divisor = (group == "memory")? 1024*1024 : 1 # take MByte for the value you redefine divisor with same value, is it intended? (second line of this method) Moving shared function to separete method and use it to reduce code (DRY) is good job ;) Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Don't use sudo git...
by Björn Geuken 01 Sep '09

01 Sep '09

Hi, I accidently send a patch with Author: root <root(a)linux-qwou.(none)> by using sudo. I appologize for any confusion and would be happy if anyone could help fixing this. thanks Björn -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1