September 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <rest-service> master : Switched to the InvalidParameters exception.
by Josef Reidinger 21 Sep '09

21 Sep '09

On Monday 21 September 2009 12:48:10 Martin Vidner wrote: > ref: refs/heads/master > commit 31a423025739c568c47ccd8a49faca381da583da > Author: Martin Vidner <mvidner(a)suse.cz> > Date: Mon Sep 21 12:18:07 2009 +0200 > > Switched to the InvalidParameters exception. > --- > .../app/controllers/network/dns_controller.rb | 2 +- > .../app/controllers/network/hostname_controller.rb | 2 +- > .../controllers/network/interfaces_controller.rb | 2 +- > .../app/controllers/network/routes_controller.rb | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/plugins/network/app/controllers/network/dns_controller.rb > b/plugins/network/app/controllers/network/dns_controller.rb index > 810b7df..bcfe961 100644 > --- a/plugins/network/app/controllers/network/dns_controller.rb > +++ b/plugins/network/app/controllers/network/dns_controller.rb > @@ -11,7 +11,7 @@ class Network::DnsController < ApplicationController > def update > root = params[:dns] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Dns", :error => > "Missing"}] end > > root["searches"]=root["searches"].split > diff --git a/plugins/network/app/controllers/network/hostname_controller.rb > b/plugins/network/app/controllers/network/hostname_controller.rb index > cd85d66..86c51d3 100644 > --- a/plugins/network/app/controllers/network/hostname_controller.rb > +++ b/plugins/network/app/controllers/network/hostname_controller.rb > @@ -12,7 +12,7 @@ class Network::HostnameController < ApplicationController > def update > root = params[:hostname] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Hostname", :error => > "Missing"}] end > > @hostname = Hostname.new(root) > diff --git > a/plugins/network/app/controllers/network/interfaces_controller.rb > b/plugins/network/app/controllers/network/interfaces_controller.rb index > 5571039..a377a09 100644 > --- a/plugins/network/app/controllers/network/interfaces_controller.rb > +++ b/plugins/network/app/controllers/network/interfaces_controller.rb > @@ -11,7 +11,7 @@ class Network::InterfacesController < > ApplicationController def update > root = params[:interfaces] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Interfaces", :error > => "Missing"}] end > > @iface = Interface.new(root) > diff --git a/plugins/network/app/controllers/network/routes_controller.rb > b/plugins/network/app/controllers/network/routes_controller.rb index > 571d132..011620a 100644 > --- a/plugins/network/app/controllers/network/routes_controller.rb > +++ b/plugins/network/app/controllers/network/routes_controller.rb > @@ -11,7 +11,7 @@ class Network::RoutesController < ApplicationController > def update > root = params[:routes] > if root == nil > - render ErrorResult.error(404, 2, "format or internal error") and > return + raise InvalidParameters.new [{:name => "Routes", :error => > "Missing"}] end > @route = Route.find(root[:id]) > @route.via = root[:via] > Hi, just note, that you don't need set name to humanized string, I already do it, so just name parameter like if routes is not set, then you can set name to "routes" -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] user feedback for webyast
by Martin Vidner 21 Sep '09

21 Sep '09

(randy-sk in irc://irc.freenode.net/susecz) He installed it from YaST:Web, I helped him with https://bugzilla.novell.com/show_bug.cgi?id=538039#c4 - collectd is not working [he needed to start collectd] - I need to install termcap... did not help [he tried Users, did not work] Cannot find termcap: TERM not set at /usr/lib/perl5/5.10.0/Term/ReadLine.pm line 351 false Cannot find termcap: TERM not set at /usr/lib/perl5/5.10.0/Term/ReadLine.pm line 351 0 false 0 pali false pali 0 randy false randy 0 - it is mostly working. it is funny. it is only missing icons in the control panel [he means to launch webyast locally. I told him we don't want that] - pity that you can't install packages - getting the health status is slow. (I would understand patches being slow, but not this) - a log viewer would be useful [ ;-) ] -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status, 2009-Sep-07
by Josef Reidinger 21 Sep '09

21 Sep '09

missing: duncan, daniel(public transport),mschidkunz (vacation) kkampf - moving things to bugzilla dmacvicar (reported by klaus) - log feature (highlight), vendor settings, review collectd (new version) schubi - working on package module mvidner - working on network ( provide available interfaces) mzugec - same as mvidner jsrain - no update jsuchome - no webyast related issues jreidinger - finishing basic system setup, start on setting time via ntp all - look at bugzilla and check if something is not clear -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

7 14

[yast-devel] Re: [yast-commit] <rest-service> master : more unit tests, exception handling
by josef reidinger 18 Sep '09

18 Sep '09

Jiri Suchomel napsal(a): > ref: refs/heads/master > commit 942d45274e1c9ca229bba8768436cced98d17e56 > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Fri Sep 18 09:41:46 2009 +0200 > > more unit tests, exception handling > --- > .../app/controllers/administrator_controller.rb | 2 +- > plugins/administrator/app/models/administrator.rb | 4 +- > .../administrator/test/unit/administrator_test.rb | 27 +++++++++++++++++++- > 3 files changed, 29 insertions(+), 4 deletions(-) > > diff --git a/plugins/administrator/app/controllers/administrator_controller.rb b/plugins/administrator/app/controllers/administrator_controller.rb > index 5a06f0a..3478c45 100644 > --- a/plugins/administrator/app/controllers/administrator_controller.rb > +++ b/plugins/administrator/app/controllers/administrator_controller.rb > @@ -37,7 +37,7 @@ class AdministratorController < ApplicationController > begin > @admin.save_aliases(data[:aliases]) > rescue Exception => e > - render ErrorResult.error(500, 2, e.message) and return > + render ErrorResult.error(404, 2, e.message) and return Please don't return 404 when error occure, this is quite confusing. I write separate mail about error handling when I mention it. If you use my second suggestion you don't need catch anything unless you want somehow rescue from it (which render is not). > end > end > show > diff --git a/plugins/administrator/app/models/administrator.rb b/plugins/administrator/app/models/administrator.rb > index 2327ebe..7580965 100644 > --- a/plugins/administrator/app/models/administrator.rb > +++ b/plugins/administrator/app/models/administrator.rb > @@ -35,7 +35,7 @@ class Administrator > new_aliases = "" if new_aliases.nil? || new_aliases == "NONE" > if @aliases.split(",").sort == new_aliases.split(",").sort > Rails.logger.debug "mail aliases have not been changed" > - return > + return true > end > parameters = { > "aliases" => ["as", new_aliases.split(",")] > @@ -43,7 +43,7 @@ class Administrator > yapi_ret = YastService.Call("YaPI::ADMINISTRATOR::Write", parameters) > Rails.logger.debug "YaPI returns: '#{yapi_ret}'" > > - raise yapi_ret unless yapi_ret.empty? > + raise Exception.new(yapi_ret) unless yapi_ret.empty? Don't raise anonymous exception, please use error handling feature and define own exception with proper handling. for example see how I handle response from NTP: http://git.opensuse.org/?p=projects/yast/rest-service.git;a=blob;f=plugins/… > @aliases = new_aliases > end > > diff --git a/plugins/administrator/test/unit/administrator_test.rb b/plugins/administrator/test/unit/administrator_test.rb > index 008977d..374b1d2 100644 > --- a/plugins/administrator/test/unit/administrator_test.rb > +++ b/plugins/administrator/test/unit/administrator_test.rb > @@ -6,6 +6,8 @@ class AdministratorTest < ActiveSupport::TestCase > > def setup > @model = Administrator.instance > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > + @model.read_aliases > end > > def test_save_password > @@ -15,7 +17,7 @@ class AdministratorTest < ActiveSupport::TestCase > end > > def test_read_aliases > - YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a@b" ] }) > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Read').returns({ "aliases" => [ "a(a)b.c" ] }) > ret = @model.read_aliases > assert ret > assert @model.aliases.split(",").size == 1 > @@ -29,4 +31,27 @@ class AdministratorTest < ActiveSupport::TestCase > assert @model.aliases.split(",").size == 2 > end > > + def test_save_empty_aliases > + new_aliases = "NONE" > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"aliases" => [ "as", [] ]}).returns("") > + ret = @model.save_aliases(new_aliases) > + assert ret > + assert @model.aliases.empty? > + end > + > + def test_save_failure > + new_aliases = [ "test(a)domain.com" ]; > + YastService.stubs(:Call).with('YaPI::ADMINISTRATOR::Write', {"aliases" => [ "as", new_aliases ]}).returns("YaPI error") > + assert_raise Exception do > + ret = @model.save_aliases(new_aliases.join(",")) > + end > + end > + > + def test_save_no_change > + new_aliases = [ "a@b" ]; > + ret = @model.save_aliases(new_aliases.join(",")) > + assert ret > + assert @model.aliases.split(",").size == 1 > + end > + > end -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] reverting the Yast icon in 11.2
by Jakub Steiner 18 Sep '09

18 Sep '09

Hi folks, I'd like to propose to revert the Yast launcher icon to the original wrench for usability reasons. This would be the first time we'd expose people to a cute little animal as an icon. Of course it's a chicken and egg problem setting up a brand. There are a few cases where building a brand for a product has preference over a clear metaphor giving insight on what the tool does. But I don't think it's the case with Yast. Yasti, the aardvark is a great mascot, perfect for conference swag. Exposing him everywhere it mentions Yast is a bad choice in my opinion. I don't think we aim for people on Fedora or Ubuntu to switch their configuration tools to YaST. We want people to switch to openSUSE. Our brand focus should be on openSUSE. I think it's best to revert back to the wrench for the icon. cheers -- Jakub Steiner <jimmac(a)gmail.com> http://jimmac.musichall.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] rest-service ResourcesController should be more RESTful
by Martin Kudlvasr 17 Sep '09

17 Sep '09

Hi, see http://bugzilla.novell.com/show_bug.cgi?id=539290 for introduction. Basically, we currently discover resources from interface using path like: /resources.xml?interface=org.opensuse.yast.modules.yapi.network this is not restful, so service_resource.rb circumvents this by always using "proxy.find :all" and then searching for the resource in the list (/resources.xml works well). Simply because "proxy.find 'org.opensuse.yast.modules.yapi.network'" does not work ("proxy" is a proxy for /resources). Goal: Make it work! Currently finding a single resource is not used, so we have a bit of freedom, when figuring that out. There are 2 problems: 1) /resources/org.opensuse.yast.modules.yapi.network is a problematic path, because "." is a format separator (for .xml, .json, ...). proposed solution: use dashes instead of dots in the URI. /resources/org-opensuse-yast-modules-yapi-network.xml We can say, that dashes cannot be part of interface name (thanks to mvidner for http://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol- names). The interface name has to be transliterated, but this happens only once on server and once on client. 2) there can be more resources found for a single interface name. In current implementation, ResourcesController returns this for /resources.xml: <resources> <resource> <interface> ... </resource> ... </resources> and the same format for /resources.xml?interface=org.opensuse.yast.modules.yapi.network . Returning a list of items, where (according to ActiveResource) a single item is expected. ActiveResource has a problem with that. **imho optimal solution:** remake the xml format, so that single resource can contain several implementations (the same way it is in internal structures of rest- service/webservice/lib/resource_registration.rb). The format for /resources.xml can then look like this: <resources> <resource> <implementations> <implementation> <interface> ... </implementation> </implementations> </resource> ... </resources> with the same (but only single <resource>) for /resources/$interface_name.xml . By remaking the xml, service_resource.rb would have to be changed. I tried that and did not succeed. **proposed solution:** Make server return only single implementation/resource, when asked for a single interface. This would preserve current format of /resources.xml and work with ActiveResource mechanisms at the same time. The only thing that changes is, that server decides which implementation of resource is used by the client. Until now, this was decided in web-client by the rule "take first" (service_resource.rb:315). Both proposed solutions are implemented in resource-restful branch and pushed to git.opensuse.org. Please comment, if this can be merged, and say why, if not. Martin Kudlvasr -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status 02-Sep-2009
by J. Daniel Schmidt 17 Sep '09

17 Sep '09

WebYaST 02-Sep-2009 =================== present: kkaempf, dmacvicar, schubi, mschmidkunz, jdsn, mzugec, mvidner, jsuchomel absent: jsrain, visnov, lslezak, fnadge Status: ----------- kkaempf: no progress due to a day off dmacvicar: error handling, see wiki page for details (and eMail on ML) http://en.opensuse.org/YaST/Web/Development/Error_Handling schubi: find a way for the customer to change setup (like theming paths) mschmidkunz: extended the styleguide (message boxes) jdsn: investigation for the registration module underlying perl module might be problematic to integrate in REST context mzugec: no progress due to L3 work plan to read system data via YaPI for network plugin mvidner: several fixes for tests (in own branch) not yet commited due to pending bugs jsuchomel: plan to do customizations for custom services plugin Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST build still failing
by Klaus Kaempf 17 Sep '09

17 Sep '09

Hi, building WebYaST on Hudson is failing since yesterday afternoon. Currently its a packaging bug in yast2-webclient-administrator. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Installation server, tftp and netinstall
by Birger Kollstrand 16 Sep '09

16 Sep '09

Hi, I'm wondering if there is a possibility to do some adaptations to the "Installation server" module in 11.2? I would very much like to see that when I start the Installation Server module the first time that it asks for installtion of the tftp module. For a netinstall system the two are linked together. I use this kind of setup now when I'm testing openSUSE and its realy nifty to be able to select between a number of releases and being able to have it running in a few minutes by netinstalling with the relevant release. The next step would be to enhance the Instalation server module to: - edit the pxelinux.cfg/default config file with the new version to make available. below is a copy of my current netinstall config. DEFAULT pxelinux.cfg/vesamenu.c32 #DEFAULT OS11.1_32 PROMPT 0 MENU TITLE Birger's boot palace MENU BACKGROUND pxelinux.cfg/background.jpg #TIMEOUT 300 # Install i386 Linux LABEL OS11.1_32 kernel OS11.1_32/linux append initrd=OS11.1_32/initrd splash=silent vga=0x317 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ # Sub menu for x86_64 linux with different VGA modes MENU BEGIN OS11.1_64_sub LABEL OS11.1_64_0x317 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x317 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x318 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x318 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x323_Elitebook 6930p kernel OS11.1_64/linux append initrd=OS11.1_64/initrd acpi=off pnpbios=off splash=silent vga=0x323 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x31B_1280x1024 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent splash=silent vga=0x31B showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ LABEL OS11.1_64_0x346 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.2/distros/openSUSE11.1/CD1/ MENU END # Sub menu for x86_64 linux with different autoyast files MENU BEGIN OS11.1_64_autoyast LABEL OS11.1_64_homeserv kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x346 autoyast=ftp://10.0.0.192/distros/autoyast/homeserv_22_12_08.xml showopts install=ftp://10.0.0.192/distros/OS11.1_64/CD1/ LABEL OS11.1_64_0x318 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent vga=0x318 showopts install=ftp://10.0.0.192/distros/OS11.1_64/CD1/ LABEL OS11.1_64_0x346 kernel OS11.1_64/linux append initrd=OS11.1_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.192/distros/OS11.1_64/CD1/ MENU END # Sub menu for 11.2 MENU BEGIN OS11.2 LABEL OS11.2MS5_32 kernel OS11.2MS5_32/linux append initrd=OS11.2MS5_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_32/CD1/ LABEL OS11.2MS5_64_0x346 kernel OS11.2MS5_64/linux append initrd=OS11.2MS5_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_64/CD1/ LABEL OS11.2MS5_32 kernel OS11.2MS5_32/linux append initrd=OS11.2MS5_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_32/CD1/ LABEL OS11.2MS5_64_0x346 kernel OS11.2MS5_64/linux append initrd=OS11.2MS5_64/initrd splash=silent splash=silent vga=0x346 showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS5_64/CD1/ LABEL OS11.2MS6_32 kernel OS11.2MS6_32/linux append initrd=OS11.2MS6_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS6_32/CD1/ LABEL OS11.2MS6_64 kernel OS11.2MS6_64/linux append initrd=OS11.2MS6_64/initrd splash=silent splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2MS6_64/CD1/ LABEL OS11.2MS7_32 kernel OS11.2MS7_32/linux append initrd=OS11.2MS7_32/initrd splash=silent showopts install=ftp://10.0.0.2/distros/openSUSE11.2Build0268_32/CD1/ MENU END - and copy the initrd and linux file from the new image to the tftpserver directory. this looks like this on one of my servers now: linserve2:/srv/tftpboot # ls OS11.1_32 OS11.2MS5_32 OS11.2MS6_32 OS11.2MS7_32 pxelinux.cfg OS11.1_64 OS11.2MS5_64 OS11.2MS6_64 pxelinux.0 vesamenu.c32 :-) Much to ask for, but it would be lovely! It is really neat when I do installs on 5 computers at a time and with different version. cu / birger.... -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST: how to pass empty string to rest-service?
by Jiří Suchomel 16 Sep '09

16 Sep '09

Hi, in administrator module I have a POST request from client that contains the information about root password and mail aliases. Sometimes I would like to pass an empty value (for mail aliases, to reset it to no alias) and to distinguish the empty value from nil (nil has a meaning do not try to save this, while empty means save empty). So, for example I have this object in webclient controller: @administrator.password = nil @administrator.aliases = "" and I'm calling POST with @administrator.save However, on the server part, I get this as parameters: {"format"=>"xml", "action"=>"create", "administrator"=>{"aliases"=>nil, "password"=>nil}, "controller"=>"administrator"} So both values are set to nil. When debugging, we saw that the RAW_POST_DATA has a value "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<administrator>\n <aliases></aliases>\n <password nil=\"true\"></password>\n</administrator>\n" which is converted by from_xml this way even if aliases tag looks differently from password tag: Hash.from_xml("<?xml?>\n<administrator>\n <aliases></aliases>\n <password nil=\"true\"></password>\n</administrator>\n") {"administrator"=>{"aliases"=>nil, "password"=>nil}} It would work if the request would contain <aliases type='string'></aliases> instead of <aliases></aliases>, however I don't know how to achieve this; using xml.aliases aliases, {:type => "string"} in models/administrator.rb's to_xml doesn't seem to help. Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 5