August 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <rest-service> master : Use format instead of content type, as it seems to set the
by Klaus Kaempf 26 Aug '09

26 Aug '09

* Duncan Mac-Vicar P <dmacvicar(a)suse.de> [Aug 25. 2009 00:04]: > ref: refs/heads/master > commit 72faf37c3f8dda4ab91a97f677f8833a775bded8 > Author: Duncan Mac-Vicar P <dmacvicar(a)suse.de> > Date: Tue Aug 25 00:01:33 2009 +0200 > > Use format instead of content type, as it seems to set the > content type too. Hmm, this looks 'fishy' to me. Actually, both ways (@request.accept and setting :format) should work. The (http-wise and restful) correct way is setting the http 'accept' header to the list of mime types (yes, there can be multiple) acceptable by the client. The server is then free to choose one of them. The :format is a Rails extension to support setting the mime type via the URL. Just look at the default routes.rb entry: map.connect ':controller/:action/:id.:format' This is basically a regexp saying that if the url contains two slashes and a dot its to be parsed as controller-slash-action-slash-id-dot-format Summary: Honoring the accept header is a 'must', honoring the :format extension a 'can'. Hth, Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] WebYaST 26-Aug-2009
by Duncan Mac-Vicar Prett 26 Aug '09

26 Aug '09

WebYaST 26-Aug-2009 =================== Status: ----------- present: visnov, jsrain, mvidner, mzugec, kkaempf, dmacvicar, begeuken, jdsn dmacvicar: hudson still in bad state, but now in the rpm packages area (like postin scripts failing) good example: polkit-auth an already granted policy returns non-zero. How to handle that in the packages? bgeuken: improving patch tests, having trouble mocking dbus callbacks. mvidner will help. discuss vendor adaptations with dmacvicar today kkaempf: no status jsrain: no status mvidner: doing release of ruby-dbus with Dbus::Main stop featre. mzugec: committed and reverted, test failed. Continue work on YaPI jsdn: bug browser detection making troubles to status page. -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : Revert "introduction to use dbus service"
by Klaus Kaempf 26 Aug '09

26 Aug '09

* Michal Zugec <mzugec(a)linux.intech-solutions.com> [Aug 25. 2009 17:09]: A couple of comments: > + ret = Scr.instance.execute(["/sbin/yast2", "lan", "list"]) > + lines = ret[:stderr].split "\n" > + devices = [] > + lines.each do |s| > + dev = Network.new Why is the class called 'Network' and the variable 'dev' ? The class should be either called NetworkDevice or embedded inside a module (aka namespace), resulting in Network::Device > + dev.id = s.split("\t")[0] > + dev.name = s.split("\t")[1] Its more readable (and more Ruby like) to have id and name as 'constructor' arguments: Network::Device.new id, name And these assignments are wasting cycles as you're splitting the string two times. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <rest-service> master : Do not fail if authorization is already granted
by josef reidinger 26 Aug '09

26 Aug '09

Duncan Mac-Vicar P napsal(a): > ref: refs/heads/master > commit 3e0888a99fc4e8eafdd54633acb92c17266eb853 > Author: Duncan Mac-Vicar P <dmacvicar(a)suse.de> > Date: Wed Aug 26 00:13:26 2009 +0200 > > Do not fail if authorization is already granted > --- > .../system/package/yast2-webservice-system.spec | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/plugins/system/package/yast2-webservice-system.spec b/plugins/system/package/yast2-webservice-system.spec > index 25bb247..c6872dd 100644 > --- a/plugins/system/package/yast2-webservice-system.spec > +++ b/plugins/system/package/yast2-webservice-system.spec > @@ -56,10 +56,10 @@ rm -rf $RPM_BUILD_ROOT > > %post > # granting all permissions for the web user > -polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.shutdown > -polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.shutdown-multiple-sessions > -polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.reboot > -polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.reboot-multiple-sessions > +polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.shutdown ||: > +polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.shutdown-multiple-sessions ||: > +polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.reboot ||: > +polkit-auth --user %{pkg_user} --grant org.freedesktop.hal.power-management.reboot-multiple-sessions ||: > > %postun > # discard all configured permissions for the web user Hi, I think that this is not good idea as silently fail could hide real problem. I think that we should prefer checking if permissions is set and if not then grant it. Now if somethink fail in setting permission noone know it. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Disabling and enabling modules
by Leonardo L. P. da Mata 25 Aug '09

25 Aug '09

Hello, i'm trying to add a new module into the installation so i can create a partition for recovering the system if the user causes a damage into the installed system. The module must create one autoyast.xml file that will be used to reinstall the system with the same configuration. To call this module i must add it into the control.xml file. If i add it into the "automatic configuration" step, it is called, but when i try to add it just before the congratulations step, it is not called. During my investigation i've found that this module is disabled by the function AdjustDisabledItems() called by the inst_worker_continue.ycp. This function call disable some modules and i don't know how to enable then only adding into the control.xml file. The only way i found how to enable this module was adding a call into the inst_worker_continue.ycp to the function ProductControl::EnableModule("name"); but to do this i need to change the content of the yast2-installation package. Is there any way to enable a module only adding it into the control.xml file? Thanks -- Leonardo Luiz Padovani da Mata barroca(a)gmail.com "May the force be with you, always" "Nerd Pride... eu tenho. Voce tem?" -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Webyast base system model proposal
by Josef Reidinger 25 Aug '09

25 Aug '09

Hi, base system model is something like first boot which ensure basic settings after first login to rest-service of target machine. First I describe how it should look from user perspective. User login to target machine and then he see first module from first boot sequency, after saving settings go to next step until last one is complete and then show standard control panel. Implementation proposal: Create new rest-service for first boot. This module store in database last successfully saved module. It also contains list of modules and its order. So frontend ask only what module is next one. If next one is control panel, then first boot is complete passed. Frontend is implemented mostly in control panel. It ask backend for next module in first boot order. If next module is not control panel, then control panel redirect to that module. The most complicated think is how recognize, that module settings is successfully set. My proposal is set to session in control panel, that modul must set status. If user successfully set settings that corresponding module set status to OK and control panel send this information to rest module and look what is next module to pass. pros: * Minimal changes to current code * Easily manageable order and modules in first boot neg: * Each modules must handle request to status * somehow must be solved returning from module to control panel (redirect after success save?), as browser back doesn't work as expected thanks for opinions and suggestions, Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 20

[yast-devel] Service plugins and client module 'acceptance criteria'
by Klaus Kaempf 25 Aug '09

25 Aug '09

Hi, looking at recent troubles with getting a clean build in Hudson, I have now started to define 'acceptance criteria' for checkins into the git 'master' branch. For the service plugins, look at http://en.opensuse.org/YaST/Web/Development/Service/ExitCriteria For the client modules, look at http://en.opensuse.org/YaST/Web/Development/Client/ExitCriteria I consider the current criteria as 'preliminary' and 'open for discussion', please comment. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : fixing packaging. Copy paste errors mostly
by Josef Reidinger 25 Aug '09

25 Aug '09

On 08/25/2009 11:15 AM, Duncan Mac-Vicar P wrote: > ref: refs/heads/master > commit 92e21ce73c1f73e8e0b2cadc7fc76fd08aebe50a > Author: Duncan Mac-Vicar P <dmacvicar(a)suse.de> > Date: Tue Aug 25 11:15:38 2009 +0200 > > fixing packaging. Copy paste errors mostly > --- > .../package/yast2-webservice-basesystem.spec | 8 ++++---- > .../patches/package/yast2-webservice-patches.spec | 2 +- > .../package/yast2-webservice-services.spec | 10 ++++++---- > .../system/package/yast2-webservice-system.spec | 4 ++-- > 4 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/plugins/basesystem/package/yast2-webservice-basesystem.spec b/plugins/basesystem/package/yast2-webservice-basesystem.spec > index 3058677..14cfb46 100644 > --- a/plugins/basesystem/package/yast2-webservice-basesystem.spec > +++ b/plugins/basesystem/package/yast2-webservice-basesystem.spec > @@ -27,7 +27,7 @@ Requires: yast2-country >= 2.18.9 > > # > %define pkg_user yastws > -%define plugin_name language > +%define plugin_name basesystem > # > > > @@ -63,7 +63,7 @@ rm -rf $RPM_BUILD_ROOT > %dir /srv/www/%{pkg_user}/vendor/plugins > %dir /srv/www/%{pkg_user}/vendor/plugins/%{plugin_name} > %dir /srv/www/%{pkg_user}/vendor/plugins/%{plugin_name}/doc > -%dir /srv/www/%{pkg_user}/vendor/plugins/%{plugin_name}/var > +#%dir /srv/www/%{pkg_user}/vendor/plugins/%{plugin_name}/var Hi, why you comment out this line? I need this directory for touching file that indicates base system completion. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Summary of code review
by Josef Reidinger 24 Aug '09

24 Aug '09

Hi, during today meeting with Karel (external rails consultant) we do some public code review of my code and we also find some general problems. I try summarize it in this mail. Please ask if you don't understand something. I start with rest-service: We should have some general method in ancestor (e.g. YastApplicationController) of all webyast plugins which do something (so no permissions or resources) some general method permission checker with same behavior (like response permission denied). We in general should eliminate things which is repeating in each plugin. Have one line view is useless and better is use respond_to. webclient: My class LogException is useles if we disable backtrace silencing so logger.info e is enought (btw it looks like our webclient is not generated by rails 2.3, as few files missing, it looks like we generated it by 2.2) http://afreshcup.com/2008/11/29/rails-23-backtrace-silencing/ load_proxy method is good idea how to reduce needed lines of code but should not redirect or set any infos. Instead use throwing exceptions and use rescue_from to display correct page. This also discover why sometime our universal exception handler doesn't work, because some exception is not child of Exception but Error. This also discover how looks our Resource service and it is really unreadable and unmaintainable code, as it is really big, should use e.g. mixins or something else to reduce its size and complexity. Test for this class looks good, so we should try refactor it to better result. We should better structure whole architecture like some part of controller do things in one area which is not close to controller contract, so we should move it to mixin (especially use it in application controller). Karel doesn't like checking for gettext in application controller. some positives from code review - time module is good documented and testing looks good even if designer could recognize it is written after code. Ideas to reduce code size and duplicated code is good, only implementation is not always good. some general knowledge: - testing model is the easiest so move the most of functionality there for easier testing - over-mocking is not good, as it abstract from reality (it is useful when you don't have implemented some functionality) - .railsrc and .irbrc for some general routines available during console session I hope I don't forget much thinks, maybe someone add another knowledge. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] Re: [yast-commit] <web-client> network : Prefer resource.policy to resource.interface for permissions.
by Klaus Kaempf 24 Aug '09

24 Aug '09

* Martin Vidner <mvidner(a)suse.cz> [Aug 24. 2009 15:52]: > > diff --git a/webclient/lib/yast/service_resource.rb b/webclient/lib/yast/service_resource.rb > index 670cb59..8a1fa31 100644 > --- a/webclient/lib/yast/service_resource.rb > +++ b/webclient/lib/yast/service_resource.rb > @@ -146,6 +146,10 @@ module YaST > raise "Can't retrieve permissions. No user specified and not logged in" if not login > > policy_name = nil > + if self.respond_to? :policy and self.policy This test shouldn't be needed as you're implementing 'policy' in the same controller. > + policy_name = self.policy > + end > + > if not policy_name > raise "object does not implement any interface" if not (self.respond_to?(:interface) and self.interface) > policy_name = self.interface > @@ -188,6 +192,14 @@ module YaST > defined?(@interface) ? @interface : nil > end > > + def policy=(policy_name) > + @policy = policy_name > + end > + > + def policy > + defined?(@policy) ? @policy : nil Just do an "attr_reader :policy". The policy attribute will default to 'nil'. > + end > + > def singular=(singular) > @singular = singular > end > @@ -283,6 +295,11 @@ module YaST > # set the interface name of the proxy > # that is used when retrieving permissions > rsrc.instance_variable_set(:@interface, resource.interface) > + begin > + rsrc.instance_variable_set(:@policy, resource.policy) This just doesn't look familiar and the Ruby documentation for instance_variable_set seems to discourage its use. What are you trying to achieve here ? Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0