August 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <rest-service> master : Patch controller - cache index result
by Klaus Kaempf 04 Aug '09

04 Aug '09

* Ladislav Slezak <lslezak(a)novell.com> [Aug 04. 2009 13:03]: > ref: refs/heads/master > commit 09b4fd6f9e0329370173ef2176d2dcded93a4564 > Author: Ladislav Slezak <lslezak(a)novell.com> > Date: Tue Aug 4 13:00:57 2009 +0200 > > Patch controller - cache index result > > Caching patch index result saves about 4 seconds for each call It would be interesting to add some performance tests to track the speed improvements as we do further changes. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST daily status, 4-Aug-2009
by Klaus Kaempf 04 Aug '09

04 Aug '09

WebYaST 4-Aug-2009 jsrain, kkaempf, dmacvicar, mzugec, lslezak, jreidinger, mkudlvasr, mschmidkunz Status update - dmacvicar: worked on improving testing - mzugec: - - lslezak: - split dbus from yast2-core - caching in rails - testing with patches, achieved speed improvements - jreidinger: minor fixes - mkudlvasr: - - mschmidkunz: - usability docs - kkaempf: - spend most of the day in FATE - synched with docu team - next steps: assign modules to developers --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST daily status, 3-Aug-2009
by Klaus Kaempf 04 Aug '09

04 Aug '09

WebYaST daily status call, 3-Aug-2009 Attendees: fnadge, jsrain, mzuceg, lslezak, kkaempf, dmacvicar - no status update, people did hackweek - next steps: - find out how to do vendor branding of the UI - check for proper use of css ids and classes (rlihm has started a wiki page with documentation) - brand a module (as an example) - clean up REST interface (look at every service and check if it has to be separate or can be combined with another one. document the semantics and the data model (resource names, attributes) of the service) --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Webyast - patch module backend
by Josef Reidinger 04 Aug '09

04 Aug '09

Hi, I look at this module and it looks like quite chaotic and not much readable. I think that I can improve it. What do you think about separate package kit handling to separate library, set model as usual at other modules (and use pkgkit library) and controller should contain only error handling? Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] Re: [yast-commit] <web-client> master : added appropriate icon to every plugin page
by Josef Reidinger 03 Aug '09

03 Aug '09

Please use always alternative text in image to have webyast as accessible as possible. For alt for logos see http://www.cs.tut.fi/~jkorpela/html/alt.html#logo . Thanks On 07/23/2009 05:13 PM, Martin Kudlvasr wrote: > ref: refs/heads/master > commit 9bbe6fc5d84ac819ba5d661afde926267e7d5339 > Author: Martin Kudlvasr <mkudlvasr(a)suse.cz> > Date: Thu Jul 23 17:13:28 2009 +0200 > > added appropriate icon to every plugin page > unified header level (=> h2) on all plugin pages > --- > plugins/language/app/views/language/index.rhtml | 6 ++++-- > plugins/network/app/views/network/index.html.erb | 5 ++++- > .../app/views/patch_updates/index.html.erb | 8 ++++++-- > .../permissions/app/views/permissions/index.rhtml | 7 ++++++- > .../app/views/samba_server/index.html.erb | 6 +++++- > plugins/securities/app/views/securities/create.erb | 5 ++++- > plugins/securities/app/views/securities/update.erb | 4 ++++ > plugins/services/app/views/services/index.rhtml | 7 ++++++- > plugins/status/app/views/status/index.html.erb | 6 ++++-- > .../systemtime/app/views/system_time/index.rhtml | 7 +++++-- > plugins/users/app/views/users/index.html.erb | 8 +++++++- > webclient/public/stylesheets/style.css | 10 ++++++++++ > 12 files changed, 65 insertions(+), 14 deletions(-) > > diff --git a/plugins/language/app/views/language/index.rhtml b/plugins/language/app/views/language/index.rhtml > index 61c0206..26f88e1 100644 > --- a/plugins/language/app/views/language/index.rhtml > +++ b/plugins/language/app/views/language/index.rhtml > @@ -1,4 +1,6 @@ > -<h1><%=_("Language")%></h1> > +<div class='plugin-icon'><img src='/icons/yast-language.png'/></div> > +<div class='plugin-content'> > +<h2><%=_("Language")%></h2> > <br/> > > <% form_tag '/language/commit_language' do -%> > @@ -30,7 +32,7 @@ > <%= submit_tag _("Save"), :disabled=>!@permissions[:write] %> > </div> > <% end -%> > - > +</div> > > > > diff --git a/plugins/network/app/views/network/index.html.erb b/plugins/network/app/views/network/index.html.erb > index 8531653..2934f1a 100644 > --- a/plugins/network/app/views/network/index.html.erb > +++ b/plugins/network/app/views/network/index.html.erb > @@ -1,4 +1,6 @@ > -<h1><%=_("Network Device")%></h1> > +<div class='plugin-icon'><img src='/icons/yast-network.png'/></div> > +<div class='plugin-content'> > +<h2><%=_("Network Device")%></h2> > > <table class="list"> > <tr> > @@ -14,4 +16,5 @@ > > > <a href="/" class="button"><%=_("Back")%></a> > +</div> > > diff --git a/plugins/patch_updates/app/views/patch_updates/index.html.erb b/plugins/patch_updates/app/views/patch_updates/index.html.erb > index d961632..7a6a9db 100644 > --- a/plugins/patch_updates/app/views/patch_updates/index.html.erb > +++ b/plugins/patch_updates/app/views/patch_updates/index.html.erb > @@ -15,7 +15,9 @@ > option[value=optional]:before { content:url('/icons/kupdateapplet_optional.png'); } > > </style> > - > + <div class='plugin-icon'><img src='/icons/yast-online_update.png'/></div> > + <div class='plugin-content'> > + <h2>Updates</h2> > <div class="loading"></div> > <% if @patch_updates.empty? %> > <p><%=_("Your system is up to date.") %></p> > @@ -39,6 +41,7 @@ > <%= submit_tag _("Update"), :onclick=>"Element.show('progress')", :action => 'install', :class => 'button' -%> > <a href="/" class="button"><%=_("Back")%></a> > <% end %> > + </div> > > <% end %> > > @@ -48,4 +51,5 @@ > :url => { :action => :load_filtered }, > :with => "'value=' + value" > ) > -%> > \ No newline at end of file > +%> > + > diff --git a/plugins/permissions/app/views/permissions/index.rhtml b/plugins/permissions/app/views/permissions/index.rhtml > index c3c7d39..1febec9 100644 > --- a/plugins/permissions/app/views/permissions/index.rhtml > +++ b/plugins/permissions/app/views/permissions/index.rhtml > @@ -44,7 +44,10 @@ > > <link rel="stylesheet" href="/inc/checktree/checktree.css" type="text/css" media="screen" title="default" charset="utf-8" /> > </head> > -<h1><%=_("User Permissions")%></h1> > +<div class='plugin-icon'><img src='/icons/yast-security.png'/></div> > +<div class='plugin-content'> > + > +<h2><%=_("User Permissions")%></h2> > <br> > <% form_tag '/permissions/search' do %> > <p><label for="user"><%=_("User")%></label> > @@ -157,4 +160,6 @@ > </table> > <% end %> > <% end %> > +</div> > </html> > + > diff --git a/plugins/samba_server/app/views/samba_server/index.html.erb b/plugins/samba_server/app/views/samba_server/index.html.erb > index 17692e5..fed4065 100644 > --- a/plugins/samba_server/app/views/samba_server/index.html.erb > +++ b/plugins/samba_server/app/views/samba_server/index.html.erb > @@ -1,3 +1,7 @@ > -<h1><%=_("Exported Samba Shares")%></h1> > +<div class='plugin-icon'><img src='/icons/yast-online_update.png'/></div> > +<div class='plugin-content'> > +<h2><%=_("Exported Samba Shares")%></h2> > > <%= html_simple_table([_("Samba Shares")], @shares, [:id], {:add => @permissions[:addshare], :edit => @permissions[:editshare], :delete => @permissions[:deleteshare], :id => :id})%> > +</div> > + > diff --git a/plugins/securities/app/views/securities/create.erb b/plugins/securities/app/views/securities/create.erb > index d1c99e0..57778f3 100644 > --- a/plugins/securities/app/views/securities/create.erb > +++ b/plugins/securities/app/views/securities/create.erb > @@ -1,3 +1,6 @@ > +<div class='plugin-icon'><img src='/icons/yast-security.png'/></div> > +<div class='plugin-content'> > + > <h2><%=_("Security")%></h2> > > <% form_tag '/security/update' do %> > @@ -29,4 +32,4 @@ > </span> > </span> > <% end %> > - > +</div> > diff --git a/plugins/securities/app/views/securities/update.erb b/plugins/securities/app/views/securities/update.erb > index 4b46f99..b408dd6 100644 > --- a/plugins/securities/app/views/securities/update.erb > +++ b/plugins/securities/app/views/securities/update.erb > @@ -1,3 +1,6 @@ > +<div class='plugin-icon'><img src='/icons/yast-security.png'/></div> > +<div class='plugin-content'> > + > <h2><%=_("Security")%></h2> > > <% form_tag '/security/update' do %> > @@ -29,3 +32,4 @@ > </span> > <% end %> > > +</div> > diff --git a/plugins/services/app/views/services/index.rhtml b/plugins/services/app/views/services/index.rhtml > index 06e3cb1..c3d63d8 100644 > --- a/plugins/services/app/views/services/index.rhtml > +++ b/plugins/services/app/views/services/index.rhtml > @@ -33,7 +33,10 @@ > </div> >  > > -<h1><%=_("Services")%></h1> > +<div class='plugin-icon'><img src='/icons/yast-online_update.png'/></div> > +<div class='plugin-content'> > + > +<h2><%=_("Services")%></h2> > <br> > > <% if ! @permissions[:execute] %> > @@ -65,3 +68,5 @@ > </li> > <% end %> > </ul> > + > +</div> > diff --git a/plugins/status/app/views/status/index.html.erb b/plugins/status/app/views/status/index.html.erb > index 12db9d1..586aca4 100644 > --- a/plugins/status/app/views/status/index.html.erb > +++ b/plugins/status/app/views/status/index.html.erb > @@ -1,5 +1,6 @@ > - > -<h1>Status</h1> > +<div class='plugin-icon'><img src='/images/monitoring.png'/></div> > +<div class='plugin-content'> > +<h2>Status</h2> > > <% column = 1 %> > <% @data_group.keys.sort.each do |key| %> > @@ -39,6 +40,7 @@ > <br> > <%= button_to _("Back"), :back %> > <br> > +</div> > <script type="text/javascript"> > > > diff --git a/plugins/systemtime/app/views/system_time/index.rhtml b/plugins/systemtime/app/views/system_time/index.rhtml > index d334b31..55909ad 100644 > --- a/plugins/systemtime/app/views/system_time/index.rhtml > +++ b/plugins/systemtime/app/views/system_time/index.rhtml > @@ -11,7 +11,8 @@ > <% disabled = ! @permissions[:write] %> > > > - > + <div class='plugin-icon'><img src='/icons/yast-ntp-client.png'/></div> > + <div class='plugin-content'> > <h2><%=_("Configure timezone")%></h2> > <% form_tag '/system_time/update_timezone', :class => 'container' do %> > <table summary="<%= _("Table for settings timezone for target machine.") %>"> > @@ -108,10 +109,12 @@ > </tr> > </table> > <% end %> > + </div> > > <%= observe_field(:region, > :frequency => 0.25, > :update => :timezones, > :url => { :action => :timezones_for_region }, > :with => "'disabled=' + "+ (disabled ? "true":"false")+" + '&value=' +value") %> > -<% end %> > \ No newline at end of file > +<% end %> > + > diff --git a/plugins/users/app/views/users/index.html.erb b/plugins/users/app/views/users/index.html.erb > index 8fbdb89..912ccad 100644 > --- a/plugins/users/app/views/users/index.html.erb > +++ b/plugins/users/app/views/users/index.html.erb > @@ -1,4 +1,7 @@ > -<h1><%=_("Local User")%></h1> > +<div class='plugin-icon'><img src='/icons/yast-users.png'/></div> > +<div class='plugin-content'> > + > +<h2><%=_("Local User")%></h2> > > <table class="list"> > <tr> > @@ -28,3 +31,6 @@ > <% end %> > > <a href="/" class="button"><%=_("Back")%></a> > + > +</div> > + > diff --git a/webclient/public/stylesheets/style.css b/webclient/public/stylesheets/style.css > index 174a7ce..e91bde2 100644 > --- a/webclient/public/stylesheets/style.css > +++ b/webclient/public/stylesheets/style.css > @@ -400,3 +400,13 @@ input.button { > .alt-bg { > background-color: #f9f9f9; > } > + > +.plugin-icon { > + float: left; > + margin: 1em; > +} > + > +.plugin-content { > + float: left; > + width: 90%; > +} -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : Time plugin - display date picker widget
by Josef Reidinger 03 Aug '09

03 Aug '09

Ladislav Slezak wrote: > ref: refs/heads/master > commit 4e3758db2f8ca694c59bc873fb3e9bc8fddaffb4 > Author: Ladislav Slezak <lslezak(a)novell.com> > Date: Fri Jul 24 12:56:53 2009 +0200 > > Time plugin - display date picker widget > --- > .../systemtime/app/views/system_time/index.rhtml | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/plugins/systemtime/app/views/system_time/index.rhtml b/plugins/systemtime/app/views/system_time/index.rhtml > index 00fc579..57cdf1d 100644 > --- a/plugins/systemtime/app/views/system_time/index.rhtml > +++ b/plugins/systemtime/app/views/system_time/index.rhtml > @@ -1,4 +1,6 @@ > <% if @permissions %> > + <link rel="stylesheet" href="/inc/smoothness/jquery.ui.custom.css" type="text/css" media="screen" title="default" charset="utf-8" /> > + > <% javascript_tag do -%> <snip> link is not possible to place inside div elements and as now is all content enclosed into div it cause fail of time tests (tidy validation). Is it possible to add this stylesheet to template? -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : Added new status icons (image map + css)
by Josef Reidinger 03 Aug '09

03 Aug '09

Robert Lihm wrote: > ref: refs/heads/master > commit 488a63e7d8f4b04b1d8e1d9ea243b3a03b7dd13b > Author: Robert Lihm <rlihm(a)lihmedia.org> > Date: Mon Jul 20 11:09:45 2009 +0200 > > Added new status icons (image map + css) > --- > .gitignore | 10 +------ > .../views/patch_updates/.__patch_summary.html.erb | Bin 4096 -> 0 bytes > .../views/patch_updates/_patch_summary.html.erb | 4 +++ > webclient/app/views/layouts/main.rhtml | 6 +--- > .../public/stylesheets/images/status-imagemap.png | Bin 0 -> 1963 bytes > webclient/public/stylesheets/style.css | 27 ++++++++++++++++++++ > 6 files changed, 34 insertions(+), 13 deletions(-) > > diff --git a/.gitignore b/.gitignore > index fbe5592..913ada8 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,9 +1,3 @@ > -# ignore package directory > -package/ > *~ > -\#*\# > -.\#* > -*.bak > -package > -locale > -coverage/ > \ No newline at end of file > +._* > +diff.diff > diff --git a/plugins/patch_updates/app/views/patch_updates/.__patch_summary.html.erb b/plugins/patch_updates/app/views/patch_updates/.__patch_summary.html.erb > deleted file mode 100644 > index bc723d2..0000000 > Binary files a/plugins/patch_updates/app/views/patch_updates/.__patch_summary.html.erb and /dev/null differ > diff --git a/plugins/patch_updates/app/views/patch_updates/_patch_summary.html.erb b/plugins/patch_updates/app/views/patch_updates/_patch_summary.html.erb > index 58c9aa1..0d67f4d 100644 > --- a/plugins/patch_updates/app/views/patch_updates/_patch_summary.html.erb > +++ b/plugins/patch_updates/app/views/patch_updates/_patch_summary.html.erb > @@ -6,12 +6,16 @@ > <% link_to "patch_updates" do %> > <% if patch[:security]+patch[:important] > 0 %> > <img src="/images/button_critical.png" alt="System need update"/> > + <div class="status-icon error"></div> > <% elsif patch[:optional] %> > <img src="/images/button_warning.png" alt="System contains any update" /> > + <div class="status-icon warning"></div> > <% else %> > <img src="/images/button_ok.png" alt="No updates available"/> > + <div class="status-icon ok"></div> > <% end %> > > + > <% any_update = false %> > <% if patch[:security] > 0 %> > <%= _("Security Updates: #{patch[:security]} ") %> > diff --git a/webclient/app/views/layouts/main.rhtml b/webclient/app/views/layouts/main.rhtml > index 0b5b68b..693dbb6 100644 > --- a/webclient/app/views/layouts/main.rhtml > +++ b/webclient/app/views/layouts/main.rhtml > @@ -69,11 +69,7 @@ > </div> > > <%= @content_for_layout %> > - > </div> > > <div id="footer" class=""> > - <div class="copy">© 2009 Novell, Inc.</div> > - </div> > - </body> > -</html> > \ No newline at end of file > + <div class="copy">© 2009 Novell, Inc.</di > \ No newline at end of file ^^^^^^^ Please take attention during editing files. I recommend run at least test for time as it contain tidy validation of page (duncan's hudson when it will be correctly setted also catch it). To all - try also use tidy validator, it catch problematic things in html code and prevent accident commits. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] RFC: splitting yast2-core package
by Ladislav Slezak 03 Aug '09

03 Aug '09

Hi all, Currently yast2-core package requires also DBus and PolicyKit packages (because of the DBus service and the DBus agent). This makes updating or compiling the interpreter more complicated and the DBus service is always installed (even when not needed) which is bad from security point of view. So my proposal is to split the package into three parts: - yast2-core - the core interpreter + agents (no DBus or PolicyKit dependency) - yast2-dbus-client - the DBus agent (requires DBus), currently needed by yast2-storage only - yast2-dbus-server - YaST DBus services (require DBus + PolicyKit), needed by WebYast (so it should not be installed by default) I have already prepared the new packages in tmp/lslezak SVN branch, RPMs are in my OBS project (home:lslezak:Factory). Please review the proposal. If there are no objections I'll submit the packages to Factory soon... Thank you. -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 6