August 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <rest-service> network : added config file for routes
by Klaus Kaempf 31 Aug '09

31 Aug '09

* Michal Zugec <mzugec(a)suse.cz> [Aug 31. 2009 08:59]: > ref: refs/heads/network > commit 0dfc80d23eaec24c737fd30f9e2b09b14d77a487 > Author: Michal Zugec <mzugec(a)suse.cz> > Date: Mon Aug 31 08:58:53 2009 +0200 > > added config file for routes This comment doesn't match the change. > --- > plugins/network/config/resources/routes.yml | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/plugins/network/config/resources/routes.yml b/plugins/network/config/resources/routes.yml > index 09c08d5..3f765a5 100644 > --- a/plugins/network/config/resources/routes.yml > +++ b/plugins/network/config/resources/routes.yml > @@ -1,3 +1,4 @@ > interface: org.opensuse.yast.modules.yapi.network.routes > policy: org.opensuse.yast.modules.yapi.network > controller: network/routes > +singular: true Why would 'routes' be singular ? This means that only one route ever exists. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <rest-service> master : packages module: compare installed packages with vendor list (on rest-service)
by josef reidinger 28 Aug '09

28 Aug '09

Bjoern Geuken napsal(a): > ref: refs/heads/master > commit cddddcc11c0d9e7f04d9f2fca0ded04e50a71a45 > Author: Bjoern Geuken <bgeuken(a)suse.de> > Date: Fri Aug 28 16:45:34 2009 +0200 > > packages module: compare installed packages with vendor list (on rest-service) > --- > .../patches/app/controllers/packages_controller.rb | 25 ++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/plugins/patches/app/controllers/packages_controller.rb b/plugins/patches/app/controllers/packages_controller.rb > index e3e9718..e2b46ca 100644 > --- a/plugins/patches/app/controllers/packages_controller.rb > +++ b/plugins/patches/app/controllers/packages_controller.rb > @@ -40,11 +40,36 @@ class PackagesController < ApplicationController > > public > > + def compare_lists(packages) > + vendor_packages = Hash.new > + # yml datei auslesen: ["packages"] => ["yast-core", "ruby-dbus", ...] Hi, Please write comments in english > + package_list = Array.new > + package_list << ["yast2-users", "3ddiag", "foo"] > + > + package_list.each {|pk_name| > + packages.each {|p| > + # package installed? > + if p.name == pk_name > + # store version and name > + vendor_packages["package"] = {:name => "#{p.name}", :version => "#{p.version}"} > + end > + } > + unless vendor_packages.has_key? pk_name > + vendor_packages["package"] = {"#{pk_name}" => "not installed"} > + end I don't understand what it should do, especially condition at unless as you notime insert key that is pk_name. You always insert key "package" which you overwrite. I think you want do this: package_list.each {|pk_name| package = packages.find { |pkg| pkg.name == pk_name } vendor_packages[pk_name] = package ? {:name => "#{package.name}", :version => "#{package.version}"} : {"#{pk_name}" => "not installed"} } But I am not sure what is your goal, so maybe it can be done better (especially marking uninstalled packages look little strange) > + } > + # puts vendor_packages.inspect > + vendor_packages > + end > + > # GET /patch_updates > # GET /patch_updates.xml > def index > # note: permission check was performed in :before_filter > @packages = Package.find(:installed) > + if params[:filter] == "custom" > + @packages = compare_lists(@packages) This is really confusing as you change type of field. It was array of packages and result is another hash. > + end > respond_to do |format| > format.html { render :xml => @packages.to_xml( :root => "packages", :dasherize => false ) } > format.xml { render :xml => @packages.to_xml( :root => "packages", :dasherize => false ) } -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] text style guide
by Martin Schmidkunz 28 Aug '09

28 Aug '09

Hi, I am currently thinking about the webYaST text style guide and particularly about capitalization issues. There are two ways how to capitalize text: title style and sentence style. Whereas sentence style is quite easy to use (only capitalize first letter in a sentence) title style is quite difficult to handle: the first letter of each word is capitalized, the rest are lower case. In some cases short articles, prepositions, and conjunctions are not capitalized. (see http://msdn.microsoft.com/en-us/library/ aa511441.aspx#T and http://en.wikipedia.org/wiki/Sentence_case ) Currently (http://en.opensuse.org/YaST/Style_Guide) YaST uses sentence style in: * messages (warning, error, question,...) * progress stages * status bars * help text title style is used in: * headings, titles, and group labels * input and command widgets * module names * progress bar labels * status information, summaries and proposals * trees * tables For webYaST we could simply adopt the YaST text style guide or change it to this: "Use title style for titles and sentence style for all other UI elements." Titles would be: * headings, titles * module names This rule is used in many web applications (e.g. google) and in the UI of our target group (MS Windows style guide). Would the second suggestion (Use title style for titles and sentence style for all other UI elements.) be easier for you as developers or would you prefer to stick to the old YaST rules? As the only important thing with text style guide is consistency I would be fine with both solutions (although I have a slight personal preference towards the second solution :-)), I would like to pick the solution which is easier for you, the developers! If you think, that the old YaST text style is easier for you, please let me know until next Tuesday (1st September) otherwise we will go for the second suggestion. Have a nice weekend, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status 28-Aug-2009
by Klaus Kaempf 28 Aug '09

28 Aug '09

WebYaST 28-Aug-2009 =================== Status: ----------- present: kkaempf, mschmidkunz, bgeuken, mzugec, lslezak absent: mvidner, jsrain, jsrain, visnov, dmacvicar, jsdn mschmidkunz: - worked on UI documentation in Wiki sent around on yast-devel - Next: more docs bgeuken: - more Ruby training - learned ruby-dbus - Next: Vendor setting for vendor packages (version display) mzugec: - hostname/domainname works in network stack (yapi->server->client) - Next: more YaPI work and tests lslezak: - service modules display current status now - still too slow - Next: benchmarking, improve test suite kkaempf: - code reviews - Next: more code reviews --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] UI documentation
by Martin Schmidkunz 28 Aug '09

28 Aug '09

Hi, please find some UI documentation on: http://en.opensuse.org/YaST/Web/Docu/Style_Guide The documentation includes: * generic webYaST layout * generic module layout * overview dialog * add wizard * edit * delete Looking forward to your comments, Martin --- Martin Schmidkunz User Experience Specialist mschmidkunz(a)novell.com +49 (0) 911 740 53-346 --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) --- Novell® Making IT Work As One™ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] Webyast: REST error response
by Josef Reidinger 27 Aug '09

27 Aug '09

Hi, I look what is possible to use to report errors on our rest-service. I find summary there http://www.oreillynet.com/onlamp/blog/2003/12/restful_error_handling.html and improvement here http://www.dalouche.com/wordpress/2009/04/25/error-handling-in-rest-applica…. For our purpose I think that the best sollution is to use our own error code which is not used, ( i that one which begin 4** is good) and in body specify type of error, needed data for generate report (like which permission mission and for which user) and english error description. This error description should not use frontend, as it must match type and print localized error description. So what I plan to do: - Defined exceptions in backend which modules should throw in case of errors - Add exceptions to webservice method where it is appropriate (like check_permission should not return anything, just throw exception because user already should check its permission) - Add rescue_from to application controller to automatic generate proper response code and body - Add error handler to webclient - ideal is throw exception which is catch by rescue_from and this exception contain response from which generate localized error page) For this I suggest little refactoring of resource loader, at least I try make it less dynamic to easier enhance it. Welcome any comments and suggestion. Now I create branch for it and try start which some ideas, so it doesn't break any code until it is ready. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 4

[yast-devel] JavaScript.code_quality <> Ruby.code_quality
by J. Daniel Schmidt 27 Aug '09

27 Aug '09

Hi WebYaST hackers, Yesterday I fixed this JavaScript browser detection bug: https://bugzilla.novell.com/show_bug.cgi?id=529931 and just wanted to tell you my observations. We spend a lot of time writing good, clean, DRY, easily readable ruby code and even have tools like Flog, Flay and Heckle(1) to check its quality. All this is great, sure. But on the other hand we just dump JavaScript code into the users browser to do some magic but don't care for quality there. The bug above was just 4 tests if a variable had a value. Here's a diff snippet: - window.G_vmlCanvasManager.init_(document); + if (window.G_vmlCanvasManager) { + window.G_vmlCanvasManager.init_(document); + } My JavaScript debugger(2) still gets flooded with warnings about the code that we run in the users browser. So there might arise other stuff in the future. Somehow this feels strange. Focussing on good code on the one side but forgettig about it on the other. (1) http://ruby.sadi.st/Ruby_Sadist.html (2) Web Developer plugin for Firefox: https://addons.mozilla.org/en-US/firefox/addon/60 I also recommend Firebug: https://addons.mozilla.org/en-US/firefox/addon/1843 Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] WebYaST 27-Aug-2009
by Duncan Mac-Vicar Prett 27 Aug '09

27 Aug '09

WebYaST 27-Aug-2009 =================== Status: ----------- present: kkaempf, dmacvicar, jdsn, jreidinger, mzugec, jsrain, lslezak, visnov, bgeuken, mvidner, mschmidkunz dmacvicar: - vendor settings discussion with Björn - hudson: client builds, service: network call depends - rack middleware for engine's static assets, submitted discussion to upstream: http://groups.google.com/group/rubyonrails-core/t/fbc79b21b0ddc3ed - hudson git plugin bug: https://hudson.dev.java.net/issues/show_bug.cgi?id=2827 kkaempf: - no status jdsn: - javascript browser detection - will continue to work in bugzilla jreidinger: - basesystem, controller action - send mail to designers. Will work in a branch some error handling - AI: write mail with proposal, look at ErrorResult facility mzugec: - network tests - discussion about YaPI testing models. Language plugin an example. jsrain: - no update lslezak: - monday: services testsuite, no more updates - plan today: status custom services visnov: - no updates bgeuken: - packages controller - dbus problems: discussing with mvidner - integrate the vendor settings mvidner: - released dbus library, loop.quit support - will work with Björn to fix packages controller - submitted to YaST:Web devel:languages:ruby:extensions - http://github.com/mvidner/ruby-dbus/tree/master mschmidkunz: - document basic UI behavior, continue to work on that. - will notify others when these updates happen -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] RFC: plugin static assets
by Duncan Mac-Vicar Prett 26 Aug '09

26 Aug '09

Hi By default, rails engines do not support static assets in their own public/ directory. It is a so obvious feature that I had the prejudge in mind that it would not be trivial. I implemented a Rack middleware that looks in all the loaded plugins for a resource, if it can be served from there, it does it, if not, it forwards to the application (a simple overlay, just like the other parts of the engines work). Attached is the patch for review. This allows engines to have their own public/ directory with files, images, css files, etc. Just like with engines controllers and views, you need to have name conventions, as the names may clash. -- Duncan Mac-Vicar P. - Engineering Manager, YaST SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)

1 0

[yast-devel] Webyast session with consultant
by Josef Reidinger 26 Aug '09

26 Aug '09

Hi, I bring notes from today's session with consultant. We look at test-driven development. Usual presentation which can be also find on net, so nothing especially interesting. We try shoulda gem, which is quite good for reporting problems (test reports looks better). I ask also how to move our 2.2 generated rails to 2.3. Karel says that rails from 2.2 have templates which can generate code better (really good for business convence, so we should create some template for webyast plugins) and maybe exist some template to convert generated application. I google it and write result. Second think which we learn is how to work routes. especially interesting methods for rest is method resources and resource (and parameters only and except). Also we look how REST work. What Karel find strange is that we have default route, which often lead to unintended routes and behavior. Second what he think is that we should use route for each plugin as each plugin should define its routes which it provides. For REST we should look how is designed cloudkit ( http://getcloudkit.com/ and http://www.bestechvideos.com/2009/06/04/pivotal-labs-talks-cloudkit-hacking… ). Rest tutorial is at http://www.infoq.com/articles/rest-anti-patterns and http://www.infoq.com/articles/rest-introduction We also talk about our webclient and what we should improve. We should have webclient also rest. Especially we should operate easy on hosts. Karel propose have sub-resources. So url should look like /hosts/1/systemtime for setting systemtime on first host. Also we give another hints how to change our dynamic creating ActiveResource to normal classes and have in each plugin usual model, which should contain a lot of functionality and can be easily tested. (So we should have something like YaSTController as ancestor and YaSTResource as model ancestor). Welcome any another ideas which I forget mention. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

6 10