August 2013 - YaST Development - openSUSE Mailing Lists

[yast-devel] Fixing yast2-slide-show for SLE11 SP3
by Karl Eichwalder 16 Sep '15

16 Sep '15

I want to fix yast2-slide-show for SLE11 SP3. Which git commands do I have to use, please? Thus far, I have checked out trunk only. -- Karl Eichwalder SUSE LINUX Products GmbH R&D / Documentation Maxfeldstraße 5 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 7

[yast-devel] Requirements for Yast testing framework
by Ladislav Slezak 13 Sep '13

13 Sep '13

Hi, in a different thread we are discussing the possible frameworks for writing tests. Although it's nice to have some preferred framework and style, we should actually collect our requirements first to see what we need or expect from it. I'd like to start a broader discussion because once we choose the framework and start writing tests then it will hard to go back and use something else... Look at the current existing Yast tests. What do you like? What you don't like? Which features you miss or need? Here are my ideas, please comment, add your expectations, requirements... Testing Framework Requirements ------------------------------ - For programmers: The tests will be written by programmers and used by programmers. Therefore we do not need any human readable language in tests (like in Cucumber [1]). That only adds one level of complexity for developers without much gain. The tests should be easy readable without strange syntax or rules. You should quickly see what is being tested and how from the test code. - Mocking Ruby calls: During tests we need to stub and mock some method calls to avoid touching the real system. We need to provide testing data as a part of tests. We need to mock any Ruby call, the current Yast is able to mock only SCR calls and that's limiting and makes troubles when using other modules. - Unit tests: We do only unit testing [2] in Yast (we test modules/methods separately without any context), so unit test support is mandatory. The question is if we could do more and also use integration testing [3] in the future. Like the installer could setup partitioning and then check bootloader and software proposal. That would probably need some UI support, but in some cases it could be nice. - Development tools integration: Currently we run "make check", the framework should be easily used from make (or rake) from Yast code. - OBS integration: We also run the tests during package build in OBS so we need to package the testing framework as a RPM package. It also needs to work in OBS environment properly (e.g. there is no internet access, no outside connection is possible). - Code coverage: To have good tests we need to know the code coverage to easily find the missing parts. - Sharing framework configuration, testing code, asserts...: It should be easy to share common parts, asserts... to avoid code duplication and make maintenance easier. - Last but not least: it should be well maintained (SLE support!), stable, well documented... (as usual with a good software...) Thanks for your comments! [1] http://cukes.info/ [2] http://en.wikipedia.org/wiki/Unit_testing [3] http://en.wikipedia.org/wiki/Integration_testing -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

7 12

[yast-devel] RFC: Drop yast2 sw_single CLI interface
by Josef Reidinger 03 Sep '13

03 Sep '13

Hi, I would like to drop yast2 sw_single CLI interface because zypper already do such job much better and if we drop it, then it simplify code and we have only one recommended solution which we need to maintain. Any comments, suggestion or complain. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

8 15

[yast-devel] unit tests for yast modules written in ruby
by Roman Neuhauser 02 Sep '13

02 Sep '13

hola! vlado brought up an interesting topic, namely the choice of a unit-testing framework. there's a bunch of them written for ruby code, some of the most popular ones (presented in no particular order) are: * minitest http://rubydoc.info/gems/minitest/frames * rspec http://rspec.info/ * shoulda http://rubydoc.info/gems/shoulda/frames * Test::Unit http://www.ruby-doc.org/stdlib-1.9.3/libdoc/test/unit/rdoc/Test/Unit.html see https://en.wikipedia.org/wiki/Unit_testing_frameworks_for_Ruby for a pretty good overview. i have no strong preference or dislike for any of them, with the exception of rspec, which creates methods on the CUT (to be clear: i don't like that). but before we dive into a massive flamewar re: which one is the best, there's another topic to chew on: do we need to standardize this at all? as far as i understand the situation, yast modules are mostly silos with one or two people ever hacking on any given module. this arrangement would lend weight to the argument that no, we don't need to standardize on a single unit-testing framework, each maintainer is free to choose whatever they like most. OTOH, strong code-ownership has its downsides, so maybe, unless we want to make the segregation of interests stronger, we should not move the code further apart. a standard test framework would make it easier to move code between modules, eg. utility functions initially written for a specific yast module getting promoted to ruby-bindings or something. opinions? -- roman -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

7 12

[yast-devel] Questions about some YCP Equivalents in ruby
by Thomas Fehr 02 Sep '13

02 Sep '13

Hi, While I was just fixing a bug in current head and had to test the fix anyway I assumed I could easily modify the ruby code needing to be adapted anyway to a more ruby-like style. I replaced the common usage of hash access with default parameter by YCP Code --> Ruby like replacement part["fsid"]:0 --> (part["fsid"]||0) part["type"]:`none --> (part["type"]||:none) substring(part["device"]:"",0,9) --> part["device"][0,9] Could someone with more ruby experience tell me if these replacements are reasonable? My testing showed they work, but I am not sure if there are pitfalls I am not aware of. Tschuess, Thomas Fehr -- Thomas Fehr, SuSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Tel: +49-911-74053-0, Fax: +49-911-74053-482, Email: fehr(a)suse.de GPG public key available. -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

6 13

[yast-devel] YaST crashes selecting a few modules
by Freek de Kruijf 28 Aug '13

28 Aug '13

I did a new installation with the M4 iso and added http://download.opensuse.org/repositories/YaST:/Head/openSUSE_12.3/ as a repository. After that I forced an update of all modules in that repository. I needed to leave some "obsolete" packages in the system, but most were updated from that repository. After that I could start the YaST window, but the bootloader module and the software module did not start. Did not try other modules. -- fr.gr. Freek de Kruijf -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] installer's memory requirements
by Michal Filka 28 Aug '13

28 Aug '13

Hi, i'm currently testing latest build (openSUSE-Factory-DVD-x86_64-Build06) and I'm running out of memory. Currently I use VirtualBox' VM with up to 2GB (for M3 512MB was enough). I also got: "YaST got signal 11 at YCP file /mounts/mp_0001/usr/share/YaST2/modules/Storage.rb:2343" Anyone experienced same issue? Side note: the message should be updated as YCP is not in game any longer ;-) Michal Filka -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 3

[yast-devel] Rules for yast development after feature freeze
by Josef Reidinger 27 Aug '13

27 Aug '13

Hi, opensuse is already in base system feature freeze, so all features that affect installation should be postponed. I create simple wiki page[1], that describe how we can store future changes, because usually bugfixes have bigger traffic then features to it. But if we want start with some ideas how to improve installation we can do it now respecting given rules. The most important part is that also changes going to separate branch for next opensuse should be reviewed, so we prevent big branch that cannot be reviewed. Josef [1] https://github.com/yast/yast-yast2/wiki/How-to-make-changes-affecting-base-… -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Unify yast-yast2 directory structure
by Josef Reidinger 27 Aug '13

27 Aug '13

Hi, now yast-yast2 contain library directory that is separated to sub-directories [1]. I would like to have there only one src directory that respect Y2DIR structure. Main benefit from this move is that it is much easier to test code, because now there interdependencies between directories, so you need to know what subdirs you must use and it means you must create a lot of effort to detect it or test only on installed system ( both is bad from my POV ). The biggest drawback is that we lost logical separation between these modules, but we can improve documentation, so it is not so big ( like links in documentation of related modules ). Do you have any objections, opinions or comments? If not I do it on Tuesday 27th ( so lslezak and mvidner can make comments after his return from vacation ). Josef [1] https://github.com/yast/yast-yast2/tree/master/library -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 3

[yast-devel] ldap Viewer cn=Administrator
by Günther J. Niederwimmer 27 Aug '13

27 Aug '13

Hello, Can any tell me on witch place the ldap-Viewer store the cn=.... I have installed my ldap with a other "cn=admin" but the ldap-Viewer don't read the /etc/sysconfig/ldap and I have always the "cn=Administrator" This is a SLES 11 SP3 system. -- mit freundlichen Grüßen / best Regards, Günther J. Niederwimmer -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 2

[yast-devel] removing obsolete YaST SVN repo
by J. Daniel Schmidt 26 Aug '13

26 Aug '13

Hi YaST-Hackers, About 15 months ago YaST migrated from SVN to GIT. Since then the old SVN repo was in read-only mode. If nobody objects, I'd like to remove the old svn repo now. So, does anybody still use it or relies on the repo being available? Please tell me by next week. Otherwise I will remove it next Friday. Happy YaST-Ruby-hacking. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE LINUX Products GmbH Research & Development Maxfeldstr. 5 HRB 16746 (AG Nürnberg) D-90409 Nürnberg GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 2

[yast-devel] ruby library for manipulation with /etc/passwd and /etc/shadow
by Josef Reidinger 26 Aug '13

26 Aug '13

Hi, I just found quite interesting library[1][2] for manipulation with /etc/passwd and /etc/shadow in quite nice way. Maybe we can use it in yast code if it works good ( so we can reduce our code and benefit from third party code ). Josef [1] http://www.reddit.com/r/ruby/comments/1l2xpe/etcutils_rw_access_to_linux_us… [2] https://github.com/dacamp/etcutils -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Bigger example of tests and possible code reduction with ruby
by Josef Reidinger 23 Aug '13

23 Aug '13

Hi, I just created another pull request[1] that demonstrate how easy can be written test with new framework and what is more important how easy is to modify it ( like add another value to test ). It also demonstrate how can be with ruby simplified code. If you have any question please just ask, so we can see better code on more places. Also you can review if I do not break anything ( you can proof it with test case ). Josef P.S. not recognizing embedded IPv4 in IPv6 is intention as I do refactoring, but after accept of it, I will fix it as it is valid syntax. [1] https://github.com/yast/yast-yast2/pull/106 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Skeleton or refactored yast module
by Josef Reidinger 21 Aug '13

21 Aug '13

Hi, I am now considering if for documentation purpose is better if we have skeleton or have one really nice plugin that can be used as example. I think about pros and cons and summarize it below. What is your opinion on this topic as it would be nice to have something where we can point new developer who is interested in Yast like when you start you can play generate skeleton and start playing or start with this module and play with it. Skeleton: Pros: - simply - have marks where user should change something Cons: - simply to become outdated or broken as it is not used except new developers ( it actually happen to old one ) Nice module: Pros: - real code, so bigger chance that it contain code that developer need - code is regularly used and tested - real automated tests Cons: - contain module specific code, that is not need to understand Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Simple example of refactoring
by Josef Reidinger 21 Aug '13

21 Aug '13

Hi, because we have now ruby I want to show really simple way how we can refactor existing code. I choose just simple example to be easy to understand and on other hand full working. [1] There is two interesting points in it. 1) using minitest for testing, its structure ( so you can imagine how it looks ) and how it can be easy integrated with automake ( nice part is that if you run `make check` then both testsuite is run, old and new one 2) Using ruby builtin regex, so we no longer need our own. If you have any question I welcome it or if you are interested how do different thing in ruby. Josef [1] https://github.com/yast/yast-yast2/compare/0e08c9b...43fd34e6?expand=1 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 3

[yast-devel] Help: Lost in Ruby
by Arvin Schnell 20 Aug '13

20 Aug '13

Hi, I would like to use some classes in the converted ruby code but I have problems with function lookup. I have figured out how to call functions (e.g. ArrangeButtons from include/partitioning/ep-lib.rb in my class method by using "module_function :ArrangeButtons" in ep-lib.rb. The problem now is that the method deep_copy cannot be found inside ArrangeButtons. It works if I use "include PartitioningEpLibInclude" inside my class but I don't like to extend the classes with lots of general utility functions. So what's the correct way here? Attached is a patch. The error message is: Client call failed with undefined method `deep_copy' for Yast::PartitioningEpLibInclude:Module and backtrace ["/usr/share/YaST2/include/partitioning/ep-lib.rb:503:in `ArrangeButtons'", "/usr/share/YaST2/include/partitioning/ep-all.rb:183:in `create'", ... ciao Arvin

4 7

[yast-devel] Question Problem with new Hardware
by Günther J. Niederwimmer 19 Aug '13

19 Aug '13

Hello, A fiend have a new Hardware ASUS P9D WS with the new CPU 1150 Socket and the new C226 Chipset. On this Motherboard it is not possible to install oS 12.3 or 13.1 I have no mouse or / keyboard (logitech wireless), is this a YaST2 Problem or a kernel Problem. With older P8CWS, Chipset C216 it is working. Grub2 can handle this Problem? -- mit freundlichen Grüßen / best Regards, Günther J. Niederwimmer -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Converting YCP data files into YAML, continue removing YCP
by Ladislav Slezak 16 Aug '13

16 Aug '13

Hi all, The ruby conversion did not touch the YCP data files (the files which are installed into /usr/share/YaST2/data and are read using SCR::Read(.target.yast2/.ycp, "foo.ycp") call.) These data files usually contain additional data like hardware databases, additional data mapping... There are several reasons why we did not convert them: - "foo.ycp" in the SCR call would not exist after the conversion, there would be "foo.rb" - .target.yast2 agent parses YCP files, it would fail with Ruby content - Ruby format is not the best format for storing data But to get rid of the YCP interpreter completely (our long term goal) we need to convert these YCP data files anyway. For this reason I have created a simple "ycp2yml" client which reads a specified YCP file and writes it's value into a YAML file. It is included in the latest devtools. It's very easy, it just evaluates the YCP file via SCR.Read, coverts to YAML by calling to_yaml method and saves the result to a file. That means it's not a 1:1 copy, e.g. comments are not transferred, translation marks are lost,... But in many cases it is enough. Of course, you can patch the YAML file manually after the conversion. Example usage: /sbin/yast2 ycp2yml consolefonts.ycp consolefonts.yml Then replace the original YCP file in Git (don't forget to fix Makefile.am and *.spec.in) and use it this way: require 'yaml' # add this if not already there Yast.import "Directory" ... # original code: data = ... SCR.Read(path(".target.yast2"), "foo.ycp") data = YAML.load_file(Directory.datadir + "/foo.yml") rescue nil # nil is the default value if an exception is raised (missing file, # broken/inconsistent, read error...) and is backward compatible. # You can use different default if needed. Note: if you use translations in the original YCP file then you need to use different solution, e.g. convert it into a Ruby file and make it Yast include. You can look at these pull requests: https://github.com/yast/yast-sound/pull/2 https://github.com/yast/yast-ntp-client/pull/10 Enjoy! -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 4

[yast-devel] Yast Modules: Summer Sale
by Lukas Ocilka 15 Aug '13

15 Aug '13

Hi, I've just announced the *Yast Summer Sale* at this blog: http://kobliha-suse.blogspot.cz/2013/08/yast-modules-summer-sale.html We are offering some great Yast modules for half the price now! If you are interested in having these modules in openSUSE and/or maintaining them, get in touch with us (here or at opensuse-factory). Thanks Lukas -- Lukas Ocilka, Cloud & Systems Management Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Introduce Y2DIR "dir" directory
by Josef Reidinger 15 Aug '13

15 Aug '13

Hi, in short, I add in ruby bindings automatic inclusion of "dir" repositories in Y2 paths to ruby load path. Reason is to have common place to have pure ruby private ( in sense of not share it with rest of ruby world ) files. Its intended usage is for various modules, classes and other stuff that makes your plugins nicer. Include directory is not good as it contain now translated code and contain some special magic to make it work in ycp-way. Namespace is shared between plugins so it make sense to use own namespace there same way as in "include" directory. Thanks locilka for initial idea. Long story: For code now there is modules, clients and includes. Modules is intended for modules that share its functionality over component system. You can import it. Clients is scripts, that can be executed by Yast2 environment. Include is tricky as it is code snippets that is internally shared, but it has few limitations - It must be included in code, it must be ensured that it is included only once, so it is very limited compared to ruby ( or perl, python ) ability to share code parts. That leads to idea, that we need directory where you can have proprietary parts of code that is intended only for given module and its usage depends on language. Current status is that it is supported only in ruby-bindings, but plan is also to add it to perl and python bindings, if there is someone who is interested in it (e.g. now in perl it must be all in one file or use some tricky loading or write upstream perl library, that can be called). Example demonstration ( not working, just to demonstrate, real example comes after Milestone 4 ): client C: require "services/main_dialog" data = Services.load dialog = MainDialog.new data result = dialog.run if result == :ok Services.save dialog.data end return result dir/services/main_dialog.rb: require "yast" class Services attr_reader :data def initialize ... end def run ... end end Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

4 5

[yast-devel] Bug in Ruby code with arg_ref
by Arvin Schnell 14 Aug '13

14 Aug '13

Hi, we had a strange bug in yast-storage with the Ruby code for adding new LVM logical volumes (also see bng #834330). In ep-lvm-lib.rb the function "EpCreateLogicalVolume" has a local variable "data". That variable is passed by reference to "DlgCreateLogicalVolume" in ep-lvm-dialogs.rb along with a reference to the function "Commit". Commit use "data". So the code looks roughly like this: def EpCreateLogicalVolume(device) data = { ... } _Commit = lambda do do something with data end data_ref = arg_ref(data); DlgCreateLogicalVolume(data_ref, fun_ref(_Commit, "symbol ()")) data = data_ref.value; end def DlgCreateLogicalVolume(data, _Commit) modify data _Commit.call end The problem is that "data" when used in "Commit" has wrong values; it's neither the original value set in "EpCreateLogicalVolume" nor the value set in "DlgCreateLogicalVolume" but some mixture. It's caused by the fact that "data = data_ref.value" happens after calling "Commit". We fixed this by passing "data" to "Commit" explicitely. ciao Arvin -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 2

[yast-devel] Rake for Yast
by Vladimir Moravec 12 Aug '13

12 Aug '13

Hi, recently I have submitted initial pull request with proposal for integrating and extending of ruby build tool Rake for Yast [1] . The code is going to be packaged as ruby gem(and additionally as rpm). All important initial information is available in the README file includedwithinthe repo. Any commentsand recommendations are welcome. Thanks. Vlado [1] https://github.com/yast/yast-rake/pull/1

1 0

[yast-devel] new y2tool does not provide generateYCPWrappers any more
by Thomas Fehr 12 Aug '13

12 Aug '13

Hi, While trying to build yast2-storage, I stumbled over the fact that y2tools does not support command "generateYCPWrappers" any more. We still use these calls for cenerating the wrappers for callback functions between libstorage and yast2-storage. In spite of the misleading name generateYCPWrappers, these have noting to do with YCP code but with functionality in yast2-core which ist still valid and used. When building yast2-storage it now fails with: y2tool: Can't find "generateYCPWrappers" in /usr/share/YaST2/data/devtools/bin Tschuess, Thomas Fehr -- Thomas Fehr, SuSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Tel: +49-911-74053-0, Fax: +49-911-74053-482, Email: fehr(a)suse.de GPG public key available. -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 1

[yast-devel] modules wich need a maintainer
by Joerg Stephan 10 Aug '13

10 Aug '13

Hey folks, i've seen the current effords and the discussion on modules, is there any list of modules which currently does not have an maintainer and where a maintainer would be needed, i would like to help if i can. Regards -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 3

[yast-devel] optimization opportunities in the ycp -> ruby conversion
by Roman Neuhauser 09 Aug '13

09 Aug '13

hello, two topics re y2r (i know i'm horribly late to the party). 1. procedural vs. object-oriented ruby the generated ruby code consists, to a large degree, of function calls emulating semantics of basic ycp operations: Builtins.foreach, Ops.add, etc. these functions are @deprecated, meaning we should go and replace them with native ruby equivalents after checking that the conversion is safe. the point of these emulations is that ycp's nil is a NullObject, you can iterate it like an empty hash or list, you can add it to a number (you'll get nil back), you can concat it with a string or list (same), whereas in ruby you need to if/else around it as stuff like nil.each generates NoMethodError exceptions. but, after perusing ops.rb, builtins.rb, and a few .rb files in yast-installation/, it seems to me that we could have a much more natural-looking ruby code if, instead of having Ops.add all over the place we went for Yast::String#+, Yast::Array#+, etc. it seems there's not so many places where we "return nil", and we could "return Yast::String.new", "return Yast::Array.new" etc in such places. 2. optimization/simplification opportunities in y2r this might not be a representative example, i haven't seen it all. i looked through yast-installation/src/clients/desktop_finish.rb for opportunities to remove some Builtin.foreach calls. it took me about 30 minutes (first encounter with builtins.rb, ops.rb etc) to realize that there's *no reason* for @desktop_order to be pulled through Builtins.foreach: it's always an array. the next thing on my mind was: if *i* can see this, why not the transpiler? the questions here are: is it too late now? if yes, is ther a tool that would let us transform the ruby code? (pls no sed(1) jokes ;) i can see how adding such optimization phases to y2r could require slight changes (hints) to the ycp code, and i don't expect it to do inter-module analysis (though that would enable most gains). i'm afraid that we're going to get stuck with most of the generated code for the next 10 years. there's ~9k lines with Ops.add alone across the generated code, total number of uses of these @deprecated methods will be quite a bit higher, and if we're going to do the analysis (as opposed to a computer), it'll take a very long time, and we're bound to introduce more bugs than the computer would. https://github.com/roman-neuhauser/yast-installation/compare/master...built… - @desktop_order is initialized with the array literal, so we know the type - it has no getter/setter, so no problems from those - it is reassigned by Builtins operations called on itself; they are guaranteed to return Array if they received one -- roman -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 2