October 2011 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] r66458 - in /branches/SuSE-Code-11-SP2-Branch/add-on-creator: VERSION package/yast2-add-on-creator.changes
by Ladislav Slezak 19 Oct '11

19 Oct '11

Dne 14.10.2011 16:09, jsuchome(a)svn2.opensuse.org napsal(a): > ============================================================================== > --- branches/SuSE-Code-11-SP2-Branch/add-on-creator/package/yast2-add-on-creator.changes (original) > +++ branches/SuSE-Code-11-SP2-Branch/add-on-creator/package/yast2-add-on-creator.changes Fri Oct 14 16:09:52 2011 > @@ -1,4 +1,13 @@ > ------------------------------------------------------------------- > +Fri Oct 14 15:58:44 CEST 2011 - jsuchome(a)suse.cz > + > +- cleanup the preparation directory for building iso image > + (bnc#623036) > +- correct file name of exported keys (bnc#622569) > +- handle spaces in path to rpm packages (bnc#604730) > +- 2.17.15 > + > +------------------------------------------------------------------- > Tue Dec 22 14:16:06 CET 2009 - jsuchome(a)suse.cz IMHO it's better to commit single changelog line together with each commit than several lines in a separate commit - you know which changelog belogs to which code change and it makes merging/cherry-picking easier. -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] r66469 - in /trunk/packager: ./ package/ src/modules/ testsuite/tests/
by Ladislav Slezak 19 Oct '11

19 Oct '11

Dne 17.10.2011 16:04, locilka(a)svn2.opensuse.org napsal(a): > Author: locilka > Date: Mon Oct 17 16:04:47 2011 > New Revision: 66469 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=66469&view=rev > Log: > - Readding missing feature supported in control file: Packages > required by a selected desktop in DefaultDesktop (bnc#724491). > - 2.21.20 > > ... with testcase ^^^^^^^^^^^^^^ Great! Thanks! -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] r66461 - in /trunk/pam: VERSION package/yast2-pam.changes src/Autologin.ycp
by Ladislav Slezak 19 Oct '11

19 Oct '11

Dne 17.10.2011 10:00, jsuchome(a)svn2.opensuse.org napsal(a): > + available = true; > + user = (string) SCR::Read (.sysconfig.displaymanager.DISPLAYMANAGER_AUTOLOGIN); > + pw_less = (string) SCR::Read (.sysconfig.displaymanager.DISPLAYMANAGER_PASSWORD_LESS_LOGIN) == "yes"; > + > + if (user == nil || user == "") > + user = ""; Test for nil is sufficient, replacing empty string by empty string is useless. -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] r66475 - in /trunk/storage: package/yast2-storage.changes storage/src/modules/FileSystems.ycp
by Lukas Ocilka 18 Oct '11

18 Oct '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 18.10.2011 11:27, fehr(a)svn2.opensuse.org napsal(a): > Author: fehr > Date: Tue Oct 18 11:27:53 2011 > New Revision: 66475 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=66475&view=rev > > ... > > - `error_text_percent : _("Value must be 1% and 200%. Try again."), > + `error_text_percent : _("Value must be between 1% and 200%. Try again."), Sometimes (if we expect some changes later) it makes sense to write: - --- cut --- sformat(_("Value must be between %1 and %2. Try again."), "1%", "200%") - --- cut --- or maybe - --- cut --- sformat(_("Value must be between %1% and %2%. Try again."), 1, 200) - --- cut --- but then you'd definitely need to make a comment for translators to keep %1% and %2% unchanged (because the second % means really per cent) Bye Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iD8DBQFOnWkyVSqMdRCqTiwRAu5xAJ4wufmwqJgfZ3LCH6pcwhZs+nma7ACgkbsF wG9DLIYXBhE7/A9PzYIDxcA= =6d0k -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Re: Supported Desktops: Possible Issue in Control File
by Lukas Ocilka 17 Oct '11

17 Oct '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 17.10.2011 16:47, Stephan Kulow napsal(a): > Montag, 17. Oktober 2011 sent Lukas Ocilka: >> Hi, >> >> I've just found out, that we have two supported desktops with the same >> name *twm* in *openSUSE 12.1*. I haven't tested what it actually does yet. >> > > Why is the name not in <name> then? Hmm, false alarm ... probably ... "desktop" : "desktop to start", // DEFAULT_WM So it's a desktop which should be started by default (if, e.g., startx called). Sorry for the noise. Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iD8DBQFOnEfGVSqMdRCqTiwRAqx1AJ9eF9XKUUYEK3TqI1QMFy9iHXwZ6QCfRtGg rqzNpKlIFM3kHLDBSoV+4Mw= =imNd -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Supported Desktops: Possible Issue in Control File
by Lukas Ocilka 17 Oct '11

17 Oct '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I've just found out, that we have two supported desktops with the same name *twm* in *openSUSE 12.1*. I haven't tested what it actually does yet. - --- cut --- <supported_desktops> ... shortened ... <one_supported_desktop> <name>min_x</name> <desktop>twm</desktop>  <label_id>desktop_min_x</label_id> <logon>xdm</logon> <cursor>DMZ</cursor> <packages>xorg-x11 branding-openSUSE</packages> <order config:type="integer">6</order> <patterns>x11 base</patterns> <icon>yast-x11</icon> </one_supported_desktop> <one_supported_desktop> <name>textmode</name> <desktop>twm</desktop>  <label_id>desktop_textmode</label_id> <logon>xdm</logon> <cursor>DMZ</cursor> <packages>branding-openSUSE</packages> <order config:type="integer">8</order> <patterns>minimal_base minimal_base-conflicts</patterns> <icon>yast-sshd</icon> </one_supported_desktop> </supported_desktops> - --- cut --- Bye Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iD8DBQFOnDk1VSqMdRCqTiwRAhWBAKCBh0oTGkcgVdD7i7UfxlcK04KlTwCcC2jz oXt1Jgl8AJRXwSzGnF26ADw= =dkIR -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] r66442 - /trunk/add-on-creator/src/AddOnCreator.ycp
by Ladislav Slezak 14 Oct '11

14 Oct '11

Dne 14.10.2011 11:25, jsuchome(a)svn2.opensuse.org napsal(a): > - SCR::Execute (.target.bash, sformat ("cp %1 %2/", file_path, tmpdir)); > + SCR::Execute (.target.bash, sformat ("cp -- %1 %2/", file_path, tmpdir)); You could also change %1 to '%1' + add String::Quote() when changing all these commands... -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 3

[yast-devel] Re: [yast-commit] r66364 - in /trunk/s390: ./ package/ src/clients/ src/dump/ src/iucvterminal-server/ src/iucvterminal/ src/modules/ src/onpanic/
by Ladislav Slezak 14 Oct '11

14 Oct '11

Dne 10.10.2011 15:37, thardeck(a)svn2.opensuse.org napsal(a): [...] If you write a long multipart help text it is a good idea to identify the parts and give them a sequence number in comments. The comments are part of .pot files and are visible to translators who can figure out that all the texts belong together and they know the sequence (gettext might change the order in the generated pot file) E.g.: > + /* TS-Shell */ // Help text: Dialog for setting 'foobar' (1/6) > + "ts" : _("<big>TS-Shell</big>") // Help text: Dialog for setting 'foobar' (2/6) > ++ _("TS-Shell allows the Authorization to be specified for every TS-Shell user and group. The rights of a group are inherited by their members.") > + // Help text: Dialog for setting 'foobar' (3/6) > ++ _("Each allowed z/VM IDs are either selected manually under Selection, defined by a Regex or loaded from a File which consist all allowed z/VM IDs separated by breaks.") > + // Help text: Dialog for setting 'foobar' (4/6) > ++ _("By clicking on the button New User addtional TS-Shell users could be created and also deleted by using Delete User.") > + // Help text: Dialog for setting 'foobar' (5/6) > ++ _("To add or remove groups from the TS-Shell authorization table or to change the membership of them Manage Groups has to be called.") > + // Help text: Dialog for setting 'foobar' (6/6) > ++ _("With Audited IDs the z/VM IDs could be specified from which transcripts should be gathered."), > + foreach (string zvmid, zvmid_list,{ > + line = line + 1; > + if (regexpmatch(zvmid, "[^a-zA-Z0-9]")) Use rather [[:alnum:]] or [[:alpha:]] instead of [a-zA-Z] in regular expressions. The problem is that these sequences are locale dependent and e.g. in Estonian language there is 't' _after_ 'z' so [a-z] doesn't mach any string containg 't'! (Actually there are more letters after 'z', see http://en.wikipedia.org/wiki/Estonian_alphabet) This can lead to severe problems like these: https://bugzilla.novell.com/show_bug.cgi?id=177560 (Reading empty sysconfig values) https://bugzilla.novell.com/show_bug.cgi?id=227256 ('ftp' schema not valid in URL) BTW maybe we should grep all yast sources for [a-z] sequences... -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 2

[yast-devel] Re: [yast-commit] r66433 - in /trunk/runlevel: VERSION package/yast2-runlevel.changes src/ui.ycp
by Ladislav Slezak 14 Oct '11

14 Oct '11

> - StartStopServiceDep (current_service, ret == `start); > + if (ret == `restart) { > + list ret = startStopService (current_service, "restart"); > + y2internal ("Ret: %1", ret); Remove the y2internal call or replace it by y2debug/y2milestone. -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Seen: Re: [yast-commit] r66430 - in /trunk/theme: VERSION package/yast2-theme.changes yast2-theme.spec.in
by Ladislav Slezak 14 Oct '11

14 Oct '11

-- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 1