[yast-devel] Re: [yast-commit] r66442 - /trunk/add-on-creator/src/AddOnCreator.ycp
Dne 14.10.2011 11:25, jsuchome@svn2.opensuse.org napsal(a):
- SCR::Execute (.target.bash, sformat ("cp %1 %2/", file_path, tmpdir)); + SCR::Execute (.target.bash, sformat ("cp -- %1 %2/", file_path, tmpdir));
You could also change %1 to '%1' + add String::Quote() when changing all these commands... -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne Pá 14. října 2011 12:08:13 Ladislav Slezak napsal(a):
Dne 14.10.2011 11:25, jsuchome@svn2.opensuse.org napsal(a):
- SCR::Execute (.target.bash, sformat ("cp %1 %2/", file_path, tmpdir)); + SCR::Execute (.target.bash, sformat ("cp -- %1 %2/", file_path, tmpdir));
You could also change %1 to '%1' + add String::Quote() when changing all these commands...
Yes, I thought about it for first, but then I realized that some other commands to which I pass the file path containing quote cannot handle it anyway, so it would be futile. j -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Fri, Oct 14, 2011 at 03:35:17PM +0200, Jiri Suchomel wrote:
Dne Pá 14. října 2011 12:08:13 Ladislav Slezak napsal(a):
Dne 14.10.2011 11:25, jsuchome@svn2.opensuse.org napsal(a):
- SCR::Execute (.target.bash, sformat ("cp %1 %2/", file_path, tmpdir)); + SCR::Execute (.target.bash, sformat ("cp -- %1 %2/", file_path, tmpdir));
You could also change %1 to '%1' + add String::Quote() when changing all these commands...
Yes, I thought about it for first, but then I realized that some other commands to which I pass the file path containing quote cannot handle it anyway, so it would be futile.
What programms cannot handle the quotes? The shell parses the
string so this should not confuse any program.
Or wasn't .target.bash used in thoses cases?
ciao Arvin
--
Arvin Schnell,
Dne Pá 14. října 2011 15:41:14 Arvin Schnell napsal(a):
On Fri, Oct 14, 2011 at 03:35:17PM +0200, Jiri Suchomel wrote:
Dne Pá 14. října 2011 12:08:13 Ladislav Slezak napsal(a):
You could also change %1 to '%1' + add String::Quote() when changing all these commands...
Yes, I thought about it for first, but then I realized that some other commands to which I pass the file path containing quote cannot handle it anyway, so it would be futile.
What programms cannot handle the quotes? The shell parses the string so this should not confuse any program.
rpm wasn't able to take a string created with String::Quote. And also create_package_descr script. Maybe more, I haven't tried with all ones I'm using in add-on-creator. j -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (3)
-
Arvin Schnell -
Jiri Suchomel -
Ladislav Slezak