July 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] How to submit patch
by Dave Plater 20 Jul '09

20 Jul '09

Hi, I wish to submit a patch which fixes the size column in yast2-qt-pkg-YQPkgList.cc re: https://bugzilla.novell.com/show_bug.cgi?id=513242 what version of qt-pkg should I make the patch against? Regards Dave P -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 5

[yast-devel] Minutes of Prague YaST Team Meeting: 2009-07-16
by Michal Zugec 20 Jul '09

20 Jul '09

Minutes of Prague YaST Team Meeting: 2009-07-16 =============================================== http://en.opensuse.org/YaST/Team Present: jreidinger, jsrain, jsuchome, juhliarik, kmachalkova, locilka, lslezak, mkudlvars, mvidner, mzugec Absent: jkupec Minutes: mzugec Next Minutes: jkupec - Qt4 Control Center has some features from Qt3CC (CLI support, ...) - collective maintenance update for several yast packages (for SLE10SP2) - UI tests for webyast with Selenium framwork, Watir doesn't work -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : Clear flash message after display
by josef reidinger 19 Jul '09

19 Jul '09

Klaus KXXmpf napsal(a): > ref: refs/heads/master > commit a1d4d55f265606b6a35ab9dd4feea2fc65d2c749 > Author: Klaus KĂ¤mpf <kkaempf(a)suse.de> > Date: Fri Jul 17 18:09:38 2009 +0200 > > Clear flash message after display > > Huh, this should be handled by Rails somehow. For now, I consider it a > workaround. > --- > webclient/app/views/layouts/main.rhtml | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/webclient/app/views/layouts/main.rhtml b/webclient/app/views/layouts/main.rhtml > index 829e3fa..4b97532 100644 > --- a/webclient/app/views/layouts/main.rhtml > +++ b/webclient/app/views/layouts/main.rhtml > @@ -60,6 +60,7 @@ > <% [:error, :warning, :notice, :message].each do |name| %> > <% if flash[name] %> > <%= "<div class=\"notifications\" id=\"#{name}\">#{flash[name]}</div>" %> > + <% flash.delete name -%> > <% end %> > <% end %> > I think you ran into problem with flash and flash now ( http://yawningman.blogspot.com/2007/03/flash-message-not-clearing.html and http://api.rubyonrails.org/classes/ActionController/Flash.html) especially using method now ( and related discard). Maybe you can try don't use error parameter and set flash object in target controller. JR -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <web-client> master : hacks to not lose camelCased variables
by Klaus Kaempf 17 Jul '09

17 Jul '09

* Jiri Suchomel <jsuchome(a)suse.cz> [Jul 17. 2009 15:53]: > + > + # FIXME hack, this must be done properly > + # (my keys in camelCase were transformed to under_scored) Actually, under_scored is Ruby convention and should be used. I already raised the question about our data model rules and attribute naming last week. Martin replied and I want to discuss it further after his return next week. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST daily sync - 2009-07-13
by Jiri Srain 17 Jul '09

17 Jul '09

Schubi: - monitoring stuff, working on layout, looks nice - AI: post some screenshots on yast-devel Klaus: - testcases, looking into webclient side - working on project plan - Robert Lihm is fulli assigned, hopefully starts today Duncan: - no big changes, service passing the test - TODO add web-client, integrate code checker into checks Jiri: - AI improve system check while making it work Michal: - no big update, just submitted tests for web-client - currently L3 issues Ladislav: - testing of UI-testing frameworks - problems with Watir, Selenium testing currently WIP - S. more complex, but more feature-complete - S. seems to be the way to go, report update expected later today Josef: - bugfixing of time-out error - looking at HTML page validation Martin S.: - working on UI workflow documentation -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 5

[yast-devel] Re: [yast-commit] <web-client> master : Removed tables
by Josef Reidinger 16 Jul '09

16 Jul '09

Robert Lihm wrote: > ref: refs/heads/master > commit 141ebbc22a7387658dbc38660ac2546c52a91759 > Author: Robert Lihm <rlihm(a)lihmedia.org> > Date: Thu Jul 16 14:50:22 2009 +0200 > > Removed tables > * added div structure > * added javascript for row highlighting > --- > webclient/.gitignore | 1 + > webclient/app/views/controlpanel/index.rhtml | 71 ++++++++++------------- > webclient/app/views/controlpanel/show_all.rhtml | 53 ++++++++++++++--- > webclient/app/views/layouts/main.rhtml | 8 ++- > webclient/public/images/geckohead-green.png | Bin 0 -> 3798 bytes > webclient/public/stylesheets/style.css | 46 +++++++++++++-- > 6 files changed, 121 insertions(+), 58 deletions(-) > > diff --git a/webclient/.gitignore b/webclient/.gitignore > index 9992c2a..34e40d8 100644 > --- a/webclient/.gitignore > +++ b/webclient/.gitignore > @@ -2,3 +2,4 @@ > db/*.sqlite3 > db/schema.rb > ._* > +diff.diff > diff --git a/webclient/app/views/controlpanel/index.rhtml b/webclient/app/views/controlpanel/index.rhtml > index 9a13c68..4570a64 100644 > --- a/webclient/app/views/controlpanel/index.rhtml > +++ b/webclient/app/views/controlpanel/index.rhtml > @@ -1,20 +1,11 @@ > -<%= javascript_include_tag :defaults %> > -<% if ActionController::Routing.possible_controllers.include?("patch_updates") %> > -<% javascript_tag do -%> > - $(document).ready( function() { > - <%= remote_function(:update => "status_patches", > - :url => { :controller => :patch_updates, :action => :show_summary }) %> > - }); > -<% end -%> > -<% end %> > + > <h3><img src="/images/monitoring.png" height="23" width="23" border="0" /> <%= _("Status") %></h3> > > -<div id="status_patches"> > - <% if ActionController::Routing.possible_controllers.include?("patch_updates") %> > - <img src="/images/working.gif" height="32" width="32" border="0" /> Loading informations about patches > - <% else %> > - Patch plugin is not installed. > - <% end %> > +<div id="status_patches_icon"> > + <img src= <%=@update_image%> height="32" width="32" border="0" /> > +</div> > +<div id="status_patches_msg"> > + <a href="patch_updates"><%=@update_label%></a> > </div> Please don't change functional code in pages. I think that problem appear that you work on not updated system and somehow it doesn't merge. Please take attention on this as e.g. this completely break patch line on control panel. I fix it. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : These helpers are unused
by Ladislav Slezak 16 Jul '09

16 Jul '09

Klaus KXXmpf wrote: > ref: refs/heads/master > commit 8e6cb38ef8d49e4307700f048884d55a294c9f47 > Author: Klaus Kämpf <kkaempf(a)suse.de> > Date: Wed Jul 15 15:54:53 2009 +0200 > > These helpers are unused > --- > webclient/app/helpers/view_helpers/html_helper.rb | 96 -------------------- > webclient/app/helpers/view_helpers/label_helper.rb | 16 ---- > 2 files changed, 0 insertions(+), 112 deletions(-) Ooops! They are used by the samba-server plugin. The intention was to put all generic helpers to the main webclient package so all plugins can share them (DRY). -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : Add FIXMEs
by Josef Reidinger 16 Jul '09

16 Jul '09

Klaus KXXmpf wrote: > ref: refs/heads/master > commit 93073b2d3f55a9ee3a87a3e8b95bf6937a0902f8 > Author: Klaus KÃ¤mpf <kkaempf(a)suse.de> > Date: Wed Jul 15 16:43:09 2009 +0200 > > Add FIXMEs > --- > .../app/controllers/system_time_controller.rb | 15 +++++++++++++-- > 1 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/plugins/systemtime/app/controllers/system_time_controller.rb b/plugins/systemtime/app/controllers/system_time_controller.rb > index a2fe83e..2155aa1 100644 > --- a/plugins/systemtime/app/controllers/system_time_controller.rb > +++ b/plugins/systemtime/app/controllers/system_time_controller.rb > @@ -1,6 +1,8 @@ > require 'yast/service_resource' > require 'systemtime' > > +# FIXME: add comments to explain functions > + Hi, I try solve all fixmes before I go on vacation. documentation is done > class SystemTimeController < ApplicationController > before_filter :login_required > layout 'main' > @@ -15,6 +17,7 @@ class SystemTimeController < ApplicationController > end > > def fill_current_region > + # FIXME: @region can remain unset I solve that after discussion with jsuchome where this case can happen and check if rest-service is setted to unknown timezone (only unknown timezone couldn't have region). So if that one is setted I show error. > @@timezones.each do |region| > region.entries.each do |entry| > if entry.id == @systemtime.timezone > @@ -25,17 +28,19 @@ class SystemTimeController < ApplicationController > end > > def fill_date_and_time (timedate) > + # FIXME: such conversions should be in a model Done > @time = timedate[timedate.index(" - ")+3,8] > @date = timedate[0..timedate.index(" - ")-1] > #convert date to format for datepicker > @date.sub!(/^(\d+)-(\d+)-(\d+)/,'\3/\2/\1') > end > > - > - > public > + > + # FIXME: should go to initialize() done > @@timezones = {} > > + # FIXME: should go to initialize() Doesn't work in initialize, and after googling noone have it in initialize and even in tutorial it is directly in class > # Initialize GetText and Content-Type. > init_gettext "yast_webclient_systemtime" # textdomain, options(:charset, :content_type) > > @@ -53,9 +58,11 @@ class SystemTimeController < ApplicationController > fill_date_and_time((a)systemtime.time) > end > > + # FIXME: rename to 'update' to match rails conventions done > def commit_time > t = load_proxy 'org.opensuse.yast.modules.yapi.time' > > + # FIXME: add a 'redirect_to' all these redirect to stuff is problematic as in load_proxy is some redirect_to if occur situation where we can redirect to adress with howto solve problem. I try change load_proxy to redirect in each case where it make sense and document how to cancel redirection if anyone need it (like AJAX stuff). > unless t > return false > end > @@ -71,14 +78,17 @@ class SystemTimeController < ApplicationController > rescue ActiveResource::ClientError => e > flash[:error] = YaST::ServiceResource.error(e) > log_exception e > + #FIXME: what about other exceptions ? done > end > > redirect_to :action => :index > end > > + # FIXME: rename to 'update' to match rails conventions done > def commit_timezone > t = load_proxy 'org.opensuse.yast.modules.yapi.time' > > + # FIXME: add a 'redirect_to' ^^^ > unless t > return false > end > @@ -91,6 +101,7 @@ class SystemTimeController < ApplicationController > rescue ActiveResource::ClientError => e > flash[:error] = YaST::ServiceResource.error(e) > log_exception e > + #FIXME: what about other exceptions ? done > end > > redirect_to :action => :index -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <web-client> master : Improve robustness --> Funny behavior or Ruby
by Stefan Schubert 16 Jul '09

16 Jul '09

Klaus KXXmpf schrieb: > > - def create_data() > - @data = {} > - @limits = {} > - @limits_list = {} > + def create_data > + @data = @limits = @limits_list = @data_group = Hash.new > status = [] > It seems that all variables have now the same reference to ONE Hash. Has anyone an explanation for that ? Greetings Stefan -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] webyast, some issues
by Duncan Mac-Vicar P. 16 Jul '09

16 Jul '09

So, another round of tests :-) - Permissions setup In theory, there are 2 groups of permissions: - the ones for the service, which allows it to read policykit permisions, execute scr/YaST calls, and do some packagekit stuff. - the per service ACLs, which represent resources, and that ones are used by the service to check if the logged user has permission (when it is a pam user), which are executed by the service if the user is authorized by using his powers coming from the permissions above. To quicly setup the permissions, policyKit-rights.rb uses polkit-auth $user -- explicit to see what permissions are on. This option excludes permissions set by adding a match tag on PolicyKit.conf, is that intented? The same things does then the system_check tag, which complains that some actions are not authorized for current user, even if they are using PolicyKit.conf (which is not explicit). CCing Marcus and Ludwig here :-) - Login slow It seems the health status (or something else) takes some time, and makes the impression login would take forever. - tests How are tests in all plugins supposed to be run? I am confused with some tasks being at the top-level, others shared in webservice-tasks, others specific to the webclient or service, and other stuff is implemented in script/something (why not a task?) - How is, in a similar fashion packaging done? (in order to integrate it to hudson). Duncan -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

5 4