July 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] WebYaST status call 10-Jun-2009
by Klaus Kaempf 13 Jul '09

13 Jul '09

[Apologies for the late status. I'll do the minutes again on Wednesday ;-)] WebYaST status call 2009-07-10 Attendees: schubi, mzugec, mvidner, jsrain, kkaempf, dmacvicar, lslezak schubi - Working on Status/Monitoring mzugec - tests for systemtime (backend) mvidner - tests for D-Bus backend error reporting jsrain - just getting started kkaempf - talked to web designer moved testing focus to web-client now dmacvicar - Still working on Hudson build server lslezak - looking into web ui test tools (Watir, Selenium) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : systemtime: test for commit
by Josef Reidinger 13 Jul '09

13 Jul '09

mzugec wrote: > ref: refs/heads/master > commit d84d7b800e722ce8409bbd534c3065aa0ec30c05 > Author: mzugec <mzugec(a)novell.com> > Date: Fri Jul 10 16:57:02 2009 +0200 > > systemtime: test for commit > --- > .../app/controllers/system_time_controller.rb | 2 +- > .../test/functional/systemtime_controller_test.rb | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 1 deletions(-) > > diff --git a/plugins/systemtime/app/controllers/system_time_controller.rb b/plugins/systemtime/app/controllers/system_time_controller.rb > index 563dfbc..8320bc8 100644 > --- a/plugins/systemtime/app/controllers/system_time_controller.rb > +++ b/plugins/systemtime/app/controllers/system_time_controller.rb > @@ -52,13 +52,13 @@ class SystemTimeController < ApplicationController > def commit_time > proxy = YaST::ServiceResource.proxy_for('org.opensuse.yast.modules.yapi.time') > @permissions = proxy.permissions > - > begin > t = proxy.find > rescue ActiveResource::ClientError => e > flash[:error] = YaST::ServiceResource.error(e) > redirect_to :action => :index > end > +debugger > > arr = params[:date][:date].split("/") > t.time = "#{arr[2]}-#{arr[0]}-#{arr[1]} - "+params[:currenttime] > <snip /> Please don't add debugger to code and don't submit it. At first it cause problem it is not nice and second it can cause serious problem if we set test server as debugger need interact. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Minutes of Prague YaST Team Meeting: 2009-07-09
by Martin Vidner 10 Jul '09

10 Jul '09

Minutes of Prague YaST Team Meeting: 2009-07-09 =============================================== http://en.opensuse.org/YaST/Team Present: jkupec, jreidinger, jsrain, juhliarik, locilka, lslezak, mvidner, mzugec Absent: jsuchome, kmachalkova (vacation) Minutes: mvidner Next Minutes: mzugec WebYaST ======= See minutes of the daily status calls on yast-devel jreidinger: packagekitd bombs out if it cannot get the zypp lock Miscellaneous ============= jkupec: SMT; looking at 11.2 features for zypper lslezak: maintenance updates locilka: SMT; maintenance updates mzugec: bugs juhliarik: bugs, features WIP, got a good patch for yast2-python-bindings from Jeff Shantz (GSoC) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : made check for packages work in non-english locale
by josef reidinger 10 Jul '09

10 Jul '09

JiXXXX XXrain napsal(a): > ref: refs/heads/master > commit 1666acacf0784ddec98cdb7fc0b35e9882ee5d33 > Author: JiĹ�Ă Ĺ rain <jsrain(a)suse.cz> > Date: Fri Jul 10 11:03:28 2009 +0200 > > made check for packages work in non-english locale > --- > webservice/lib/tasks/checks.rake | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/webservice/lib/tasks/checks.rake b/webservice/lib/tasks/checks.rake > index 6f3ac9d..06fb74c 100644 > --- a/webservice/lib/tasks/checks.rake > +++ b/webservice/lib/tasks/checks.rake > @@ -24,7 +24,10 @@ def test_module name, package > end > > def test_version package, version > + old_lang = ENV['LANG'] > + ENV['LANG'] = 'C' > v = `rpm -q #{package}` > + ENV['LANG'] = old_lang > escape v, "install #{package} >= #{version}" if v =~ /is not installed/ > nvr = v.split "-" > rel = nvr.pop Isn't easier just use v = `LANG=C rpm -q #{package}` instead of this patch? less code is better code :) JR -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] messing with /etc/PolicyKit/PolicyKit.conf
by Martin Vidner 10 Jul '09

10 Jul '09

Hi, jsrain is trying to get WebYaST running from git. In http://en.opensuse.org/YaST/Web/Development#Setup_permissions it says to edit PolicyKit.conf. Will this not confuse the permission handler? AFAIK it checks for explicit permissions only. I think there is a helper script that sets up the explicit permissions, right? How to call it? Also, at some time our scripts used to mess with PolicyKit.conf. RPMs must not do that. Is that removed by now? -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 3

[yast-devel] Implemented - rest-service and basic tests
by Josef Reidinger 09 Jul '09

09 Jul '09

Hi, short version: I implemented basic test in rest-service lib/plugin_basic_tests.rb and all it is fully documented by rdoc. long version: At first motivation why use this tests. At first this tests ensure that all modules react same on some general situation like no permission for action or send same mime type for xml and jason. At second it force better design for some modules which allow in future easier maintenance of that modules. Last but not least is that tests alone for my modules give 70% coverage (and I add only two lines of code to test). This tests require some prerequisites which is written in documentation. This prerequisites especially force usage controller as thin layer, that ensure only correct translation of parameters to model, behavior during exception and access restriction. Rest of functionality should be in model. As example of how controller and model should look is my modules time and language (both use this tests). As example how it should not look like (no offense, it is common problem, that controller contain almost every functionality) is patch module. I follow rails convention that for model filling is used find method and for storing is used save method. and getters/setters for attributes. I attach here text of documentation as rdoc task not working good for rest-service (you can generate it manually by rdoc lib/basic_plugin_tests.rb) [1]. I welcome any comments, questions and suggestions for another tests. Also some architect (Klaus, duncan) should look if expected behavior in test is what we really expect from module. [1]: PluginBasicTests module The module is designed to perform few basic tests of webservice plugin controller behavior. Its goal is provide same unify behavior to each webservice plugin like unified response if user doesn‘t have permissions or same content type. Prerequisites The module expect some hints from controller test file for correct work. It needs model class specified at @model_class field, controller instance at @controller and request specification at @request field. Controller is expected to be thin layer and all dbus or system call is done at model code. Controller use during reading only read motode of model and during writing only save method. Example usage This example show basic testing of controller of plugin require File.expand_path(File.dirname(__FILE__) + "/../test_helper") require 'test/unit' require 'rubygems' require 'mocha' require File.expand_path( File.join("lib","plugin_basic_tests"), RailsParent.parent ) class LanguageControllerTest < ActionController::TestCase fixtures :accounts def setup @model = Language @controller = LanguageController.new @request = ActionController::TestRequest.new # http://railsforum.com/viewtopic.php?id=1719 @request.session[:account_id] = 1 # defined in fixtures end include PluginBasicTests #another specific controller test like correct parsing arguments #or specific exceptions end -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 1

[yast-devel] WebYaST daily sync - 07/09/09
by Bjoern Geuken 09 Jul '09

09 Jul '09

WebYaST daily sync - 07/09/09 Status: ---------- Björn: - working on tests for status module Schubi: - gets access to rest service (status) - managed to get jquery working - will now collect data for web-client Klaus: - discussed ui with Micha yesterday. Tries to get design fo WebYast - looked at permission model Duncan: - finished upgrade of Hudson. Hudson is running - moved server to new serverroom - test suite doesn't pass yet Jiri: - no update Martin V.: - fixed on Bugs - sent mail to yast-devel(a)opensuse.org concerning dbus Martin Schmidkunz: - ui meeting with Klaus and Micha - sent mail and likes to have some feedback Joseph: - created basic test (mail) - try examples Michal: - test for systemtime - L3 incident -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] rest-plugin skeleton in yast2-devtools ?
by Klaus Kaempf 09 Jul '09

09 Jul '09

Hi, doing a 'svn up' in devtools pulled in a rest-plugin skeleton. While I applaud having a plugin skeleton for WebYaST rest-service, I wonder if yast2-devtools is the right place. Installing yast2-devtools requires a bunch of packages one never needs for Ruby on Rails development, e.g. libxslt, GNU autotools, or cmake. I'd rather place the skeleton at git.opensuse.org with a script to create a new plugin. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] TraditionalYaST: Check unsupported in/out paramter to Pkg::PkgUpdateAll (pkg-bindings,update_proposal.ycp,Wagon.ycp,???)
by Michael Andres 08 Jul '09

08 Jul '09

Hi! (in svn/yast/trunk) Pkg::PkgUpdateAll internally calls zypp::Resolver::doUpgrade to perform the distribution upgrade. Since 11.1 we're using libsatsolver for this and any provided input arguments are obsolete, and returned statistic values are fake (allways 0). Removing this outdated UpgradeStatistics stuff from libzypp, I found that some YCP code (update_proposal.ycp,Wagon.ycp) still passes options to Pkg::PkgUpdateAll (e.g. 'silent_downgrades') or evaluates values in the returned map (e.g. 'ProblemListSze'). I fixed Pkg::PkgUpdateAll to no longer refer to the UpgradeStatistics class, and so it now returns an empty map. (pkg-bindings-2.18.8) But the YCP code calling Pkg::PkgUpdateAll should be reviewed. Either those in/output values can be cleaned up, or we need to invent some substitute for the desired functionality (although no one seems to have missed something in code11). -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma(a)novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] D-Bus and Ruby
by Martin Vidner 08 Jul '09

08 Jul '09

I have posted a summary of my findings so far: http://mvidner.blogspot.com/2009/07/d-bus-and-ruby.html -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0