June 2016 - YaST Development - openSUSE Mailing Lists

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 24 Jun '16

24 Jun '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-add-on: - Handling in URLs (55 days) https://github.com/yast/yast-add-on/pull/28 Pending requests in repository yast-autoinstallation: - unify bnc flags (14 days) https://github.com/yast/yast-autoinstallation/pull/219 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160531_kexec_reboot' (23 days) https://github.com/yast/yast-autoinstallation/pull/215 Pending requests in repository yast-bootloader: - [Review] Request from 'schubi2' @ 'yast/yast-bootloader/review_160617_autoyast_conifuration_bnc_985007' (6 days) https://github.com/yast/yast-bootloader/pull/346 Pending requests in repository yast-country: - Ensure ntp is installed (when Install Recommended Packages is off) (261 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - SSH Importer: Width fix to avoid cut of CheckBoxFrame Label (15 days) https://github.com/yast/yast-installation/pull/391 Pending requests in repository yast-network: - [WIP] Udev methods consolidation (8 days) https://github.com/yast/yast-network/pull/410 - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (14 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-schema: - Add ssh_import section (17 days) https://github.com/yast/yast-schema/pull/17 Pending requests in repository yast-snapper: - [WIP] Added snapshot Class with strategy pattern. (22 days) https://github.com/yast/yast-snapper/pull/40 Pending requests in repository yast-sound: - [WIP] (L3) SP4 soundcard DB update (15 days) https://github.com/yast/yast-sound/pull/19 Pending requests in repository yast-storage: - Add option to disable swap creation (148 days) https://github.com/yast/yast-storage/pull/182 - Propose /boot for encrypted root on PowerPC (184 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-crowbar: - Cloud5 (66 days) https://github.com/yast/yast-crowbar/pull/47 Pending requests in repository yast-rake: - Added version:wbump task (8 days) https://github.com/yast/yast-rake/pull/31 Pending requests in repository yast-auth-server: - bnc#965311 - yast ldap-server-ssl-check does not handle ldaps only ldap+starttls works (22 days) https://github.com/yast/yast-auth-server/pull/25 - Drop ca mgm (155 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast-migration: - [WIP] Rubocop update (10 days) https://github.com/yast/yast-migration/pull/34 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 23 Jun '16

23 Jun '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-add-on: - Handling in URLs (54 days) https://github.com/yast/yast-add-on/pull/28 Pending requests in repository yast-autoinstallation: - unify bnc flags (13 days) https://github.com/yast/yast-autoinstallation/pull/219 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160531_kexec_reboot' (22 days) https://github.com/yast/yast-autoinstallation/pull/215 Pending requests in repository yast-bootloader: - [Review] Request from 'schubi2' @ 'yast/yast-bootloader/review_160617_autoyast_conifuration_bnc_985007' (5 days) https://github.com/yast/yast-bootloader/pull/346 Pending requests in repository yast-country: - Ensure ntp is installed (when Install Recommended Packages is off) (260 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - SSH Importer: Width fix to avoid cut of CheckBoxFrame Label (14 days) https://github.com/yast/yast-installation/pull/391 Pending requests in repository yast-network: - [WIP] Udev methods consolidation (7 days) https://github.com/yast/yast-network/pull/410 - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (13 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-schema: - Add ssh_import section (16 days) https://github.com/yast/yast-schema/pull/17 Pending requests in repository yast-snapper: - [WIP] Added snapshot Class with strategy pattern. (21 days) https://github.com/yast/yast-snapper/pull/40 Pending requests in repository yast-sound: - [WIP] (L3) SP4 soundcard DB update (14 days) https://github.com/yast/yast-sound/pull/19 Pending requests in repository yast-storage: - Add option to disable swap creation (147 days) https://github.com/yast/yast-storage/pull/182 - Propose /boot for encrypted root on PowerPC (183 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-crowbar: - Cloud5 (65 days) https://github.com/yast/yast-crowbar/pull/47 Pending requests in repository yast-rake: - Added version:wbump task (7 days) https://github.com/yast/yast-rake/pull/31 Pending requests in repository yast-auth-server: - bnc#965311 - yast ldap-server-ssl-check does not handle ldaps only ldap+starttls works (21 days) https://github.com/yast/yast-auth-server/pull/25 - Drop ca mgm (154 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast-migration: - [WIP] Rubocop update (9 days) https://github.com/yast/yast-migration/pull/34 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 22 Jun '16

22 Jun '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-add-on: - Handling in URLs (53 days) https://github.com/yast/yast-add-on/pull/28 Pending requests in repository yast-autoinstallation: - unify bnc flags (12 days) https://github.com/yast/yast-autoinstallation/pull/219 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160531_kexec_reboot' (21 days) https://github.com/yast/yast-autoinstallation/pull/215 Pending requests in repository yast-bootloader: - [Review] Request from 'schubi2' @ 'yast/yast-bootloader/review_160617_autoyast_conifuration_bnc_985007' (4 days) https://github.com/yast/yast-bootloader/pull/346 Pending requests in repository yast-country: - Ensure ntp is installed (when Install Recommended Packages is off) (259 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - SSH Importer: Width fix to avoid cut of CheckBoxFrame Label (13 days) https://github.com/yast/yast-installation/pull/391 Pending requests in repository yast-network: - [WIP] Udev methods consolidation (6 days) https://github.com/yast/yast-network/pull/410 - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (12 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-schema: - Add ssh_import section (15 days) https://github.com/yast/yast-schema/pull/17 Pending requests in repository yast-snapper: - [WIP] Added snapshot Class with strategy pattern. (20 days) https://github.com/yast/yast-snapper/pull/40 Pending requests in repository yast-sound: - [WIP] (L3) SP4 soundcard DB update (13 days) https://github.com/yast/yast-sound/pull/19 Pending requests in repository yast-storage: - Add option to disable swap creation (146 days) https://github.com/yast/yast-storage/pull/182 - Propose /boot for encrypted root on PowerPC (182 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-crowbar: - Cloud5 (64 days) https://github.com/yast/yast-crowbar/pull/47 Pending requests in repository yast-rake: - Added version:wbump task (6 days) https://github.com/yast/yast-rake/pull/31 Pending requests in repository yast-auth-server: - bnc#965311 - yast ldap-server-ssl-check does not handle ldaps only ldap+starttls works (20 days) https://github.com/yast/yast-auth-server/pull/25 - Drop ca mgm (153 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast-migration: - [WIP] Rubocop update (8 days) https://github.com/yast/yast-migration/pull/34 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Heads-up: ruby-2.4.0-preview1 unifies Fixnum and Bignum
by Martin Vidner 21 Jun '16

21 Jun '16

Hi, ruby-2.4 includes a feature named "Unify Fixnum and Bignum into Integer" https://www.ruby-lang.org/en/news/2016/06/20/ruby-2-4-0-preview1-released/ https://bugs.ruby-lang.org/issues/12005 I have installed it with rbenv and found that the constants Fixnum and Bignum still exist, but resolve to the Integer class. So our code referencing Fixnum should still work. https://github.com/search?utf8=%E2%9C%93&q=is_a%3F+Fixnum+org%3Ayast&type=C… OTOH, we also have Yast::Integer, so considering the "fun" we are having with ::String and Yast::String we may be better off removing Yast::Integer before we uprade to ruby-2.4 http://www.rubydoc.info/github/yast/yast-yast2/Yast/IntegerClass -- Martin Vidner, YaST Team http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

3 2

[yast-devel] Rubocop update?
by Ladislav Slezak 21 Jun '16

21 Jun '16

Hi all, Some YaST projects already use Rubocop for checking the code style, but we froze the Rubocop version to 0.29.1 which is quite old these days (almost 1.5 year) and it produces some warnings with the latest common SUSE style [1] as it is written for newer versions. I have tried using the latest Rubocop (0.40.0) in some YaST projects to see how much work the upgrade would require and how much the code would change. ## Change it now? My first question is do we actually want to upgrade Rubocop *now*? IMHO it makes sense to upgrade it now. If we do it now it will save us some work later with SP2 maintenance when backporting the fixes from master. For the older branches (SP1 and older) we would stick with the old Rubocop. I.e. keep the version in the .travis.yml, for Jenkins we would build two versions of the Rubocop RPM in YaST:Head. And I expect that SP1 will need less and less fixes after SP2 is released. ## What would be actually changed? Here is a proposal for the upgrade. We need to update the default Rubocop config a bit [2] and then we need to adapt the code in all YaST projects which use Rubocop. I have started with the migration module which is small and written from scratch (i.e. no nasty YCP-Ruby code). The change was easy, everything was auto-corrected by Rubocop [3]. Then I tried yast2 which a big beast with a lot of YCP-Ruby code. You can see the change in [4]. It took me quite some time as not everything could be autocorrected... Note: I run each cop (check) in a separate commit so you can see what has been changed. On the other hand some changes require running more cops to be finished completely, e.g. a cop changes indentation of the code, but the comments are unchanged and are indented by a different cop later in a different commit. So I you see some strange or incomplete changes in a commit then check the final result (complete diff), it might be fixed in the end. Please check the pull requests and comment either there or here on the mailing list. ## Next Steps After we agree with the change and the updated style we can adapt the rest [5]. I guess it should rather easier as the most complex package (yast2) has been already adapted, the rest should be hopefully easier ;-) Thank you! Ladislav [1] https://github.com/SUSE/style-guides [2] https://github.com/yast/yast-devtools/pull/107 [3] https://github.com/yast/yast-migration/pull/34 [4] https://github.com/yast/yast-yast2/pull/478 [5] > find . -maxdepth 2 -name .rubocop.yml | sort ./bootloader/.rubocop.yml ./installation/.rubocop.yml ./journal/.rubocop.yml ./migration/.rubocop.yml ./network/.rubocop.yml ./nfs-client/.rubocop.yml ./rake-ci/.rubocop.yml ./rake/.rubocop.yml ./registration/.rubocop.yml ./rubocop-yast/.rubocop.yml ./ruby-bindings/.rubocop.yml ./storage-ng/.rubocop.yml ./yast2/.rubocop.yml -- Ladislav Slezák YaST Developer lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 1

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 21 Jun '16

21 Jun '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-add-on: - Handling in URLs (52 days) https://github.com/yast/yast-add-on/pull/28 Pending requests in repository yast-autoinstallation: - unify bnc flags (11 days) https://github.com/yast/yast-autoinstallation/pull/219 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160531_kexec_reboot' (20 days) https://github.com/yast/yast-autoinstallation/pull/215 Pending requests in repository yast-country: - Ensure ntp is installed (when Install Recommended Packages is off) (258 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - SSH Importer: Width fix to avoid cut of CheckBoxFrame Label (12 days) https://github.com/yast/yast-installation/pull/391 Pending requests in repository yast-network: - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (11 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-schema: - Add ssh_import section (14 days) https://github.com/yast/yast-schema/pull/17 Pending requests in repository yast-snapper: - [WIP] Added snapshot Class with strategy pattern. (19 days) https://github.com/yast/yast-snapper/pull/40 Pending requests in repository yast-sound: - [WIP] (L3) SP4 soundcard DB update (12 days) https://github.com/yast/yast-sound/pull/19 Pending requests in repository yast-storage: - Add option to disable swap creation (145 days) https://github.com/yast/yast-storage/pull/182 - Propose /boot for encrypted root on PowerPC (181 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-crowbar: - Cloud5 (63 days) https://github.com/yast/yast-crowbar/pull/47 Pending requests in repository yast-auth-server: - bnc#965311 - yast ldap-server-ssl-check does not handle ldaps only ldap+starttls works (19 days) https://github.com/yast/yast-auth-server/pull/25 - Drop ca mgm (152 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast-migration: - [WIP] Rubocop update (7 days) https://github.com/yast/yast-migration/pull/34 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 20 Jun '16

20 Jun '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-add-on: - Handling in URLs (51 days) https://github.com/yast/yast-add-on/pull/28 Pending requests in repository yast-autoinstallation: - unify bnc flags (10 days) https://github.com/yast/yast-autoinstallation/pull/219 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160531_kexec_reboot' (19 days) https://github.com/yast/yast-autoinstallation/pull/215 Pending requests in repository yast-country: - Ensure ntp is installed (when Install Recommended Packages is off) (257 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - SSH Importer: Width fix to avoid cut of CheckBoxFrame Label (11 days) https://github.com/yast/yast-installation/pull/391 Pending requests in repository yast-network: - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (10 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-schema: - Add ssh_import section (13 days) https://github.com/yast/yast-schema/pull/17 Pending requests in repository yast-snapper: - [WIP] Added snapshot Class with strategy pattern. (18 days) https://github.com/yast/yast-snapper/pull/40 Pending requests in repository yast-sound: - [WIP] (L3) SP4 soundcard DB update (11 days) https://github.com/yast/yast-sound/pull/19 Pending requests in repository yast-storage: - Add option to disable swap creation (144 days) https://github.com/yast/yast-storage/pull/182 - Propose /boot for encrypted root on PowerPC (180 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-crowbar: - Cloud5 (62 days) https://github.com/yast/yast-crowbar/pull/47 Pending requests in repository yast-auth-server: - bnc#965311 - yast ldap-server-ssl-check does not handle ldaps only ldap+starttls works (18 days) https://github.com/yast/yast-auth-server/pull/25 - Drop ca mgm (151 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast-migration: - [WIP] Rubocop update (6 days) https://github.com/yast/yast-migration/pull/34 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] YaST2 code reorganization
by Imobach González Sosa 17 Jun '16

17 Jun '16

Hi all, We all know that YaST2 is a huge project and it contains a lot of code: modules, libraries, clients, agents, dialogs... When it comes the organization of the Ruby code, there some things that we could improve. After discussing in our Gran Canaria office :) we decided to write a short document to summarize problems and possible solutions. It's available in a Gist[1] and we would like to hear your opinions. Obviously, it's not something to be done right now, but we wanted to start the discussion about these topics and try to come up with a final proposal for the future. Thanks! [1] https://gist.github.com/imobach/d90940315bd0471ee00b2a68ba22fbe5 Regards, Imo -- Imobach González Sosa YaST team at SUSE LINUX GmbH

2 1

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 17 Jun '16

17 Jun '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-add-on: - Handling in URLs (48 days) https://github.com/yast/yast-add-on/pull/28 Pending requests in repository yast-autoinstallation: - unify bnc flags (7 days) https://github.com/yast/yast-autoinstallation/pull/219 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160531_kexec_reboot' (16 days) https://github.com/yast/yast-autoinstallation/pull/215 Pending requests in repository yast-country: - Ensure ntp is installed (when Install Recommended Packages is off) (254 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - SSH Importer: Width fix to avoid cut of CheckBoxFrame Label (8 days) https://github.com/yast/yast-installation/pull/391 Pending requests in repository yast-network: - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (7 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-schema: - Add ssh_import section (10 days) https://github.com/yast/yast-schema/pull/17 Pending requests in repository yast-snapper: - [WIP] Added snapshot Class with strategy pattern. (15 days) https://github.com/yast/yast-snapper/pull/40 Pending requests in repository yast-sound: - [WIP] (L3) SP4 soundcard DB update (8 days) https://github.com/yast/yast-sound/pull/19 Pending requests in repository yast-storage: - Add option to disable swap creation (141 days) https://github.com/yast/yast-storage/pull/182 - Propose /boot for encrypted root on PowerPC (177 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-crowbar: - Cloud5 (59 days) https://github.com/yast/yast-crowbar/pull/47 Pending requests in repository yast-auth-server: - bnc#965311 - yast ldap-server-ssl-check does not handle ldaps only ldap+starttls works (15 days) https://github.com/yast/yast-auth-server/pull/25 - Drop ca mgm (148 days) https://github.com/yast/yast-auth-server/pull/21 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Report: Applying ruby-lint to SUSE Ruby code (CSM Workshop 2016)
by Martin Vidner 16 Jun '16

16 Jun '16

[ruby-lint](https://github.com/YorickPeterse/ruby-lint) is a static code analysis tool for Ruby. After I saw some stupid bugs caused by misremembering method or attribute names I tried it. It found those bugs but buried them in tons of false positives. During the Cloud and Systems Management Department workshop in June 2016 I set out to find if there is a way to configure ruby-lint so that it is usable. ## Result Found some (1) bugs in YaST. Found some (10) bugs in ruby-lint. It is not usable yet but I want to fix it. ## Lint statistics I ran ruby-lint on some of our projects: YaST (and some of its dependencies) and Crowbar. This spreadsheet summarizes the number of reports ruby-lint produced. Nearly all of them are false positives, caused by bugs in ruby-lint listed below. <https://docs.google.com/spreadsheets/d/1Pk2vjVtsVBJMdEEAXhpESaRc0jDavh4Q-R9…> ## Bugs in YaST found by ruby-lint - [`y2milestone` was used instead of `Builtins.y2milestone`][yastbug]. ## Bugs in ruby-lint ### Important bugs, fixed - If there was a warning reported by the ruby parser itself (such as ambiguous syntax), ruby-lint would silently stop processing and produce a partial report. [Do not stop parsing all files on a syntax warning][stopwarn177]. ### Important bugs, not fixed yet - To find information for a new class FooBar, ruby-lint ignores the `require` statements in analyzed code, instead autoloading files using the Rails convention: foo_bar.rb. This fails to find nearly all YaST classes. Submitted a PR: [Explicit mapping of constants to files][const179]. - [Top level constant lookup does not work: `::File`][file180]. - ruby-lint checks whether performed calls correspond to defined APIs. To learn about the APIs it can either parse their code, or, especially for APIs implemented in C, it can load so called [definitions][definitions]. The gem ships many definitions for the standard library and some gems such as nokogiri. But it only works if the namespaces described by the definition files are disjoint. That is a problem since we need `Yast` for yast2-ruby-bindings and `Yast::UI` for yast2-ycp-ui-bindings. [Definitions for overlapping namespaces are not merged][mergedefs181]. - [Methods defined within `class << self` do not see each other][classself145]. ### Other bugs, fixed - [Make argument_amount report the method name][argamount172] - [Sort reports consistently][sort176] ### Other bugs, not fixed yet - Crash when a method argument has a slightly unusual value: an empty Regex `//`, an empty heredoc, or `yield`. This can be worked around by changing the code so I consider it less important. [Not enough argument definitions][crashyield173]. - [Crash when referencing the 10th regex captured value `$10`][dollarten175]. - It reports "break can only be used inside a loop/block" when it sees a `break` in an outer loop after an inner loop has ended. [loop_keywords is fooled by nested loops][nestedloop178]. [definitions]: http://code.yorickpeterse.com/ruby-lint/latest/file.definitions.html [classself145]: https://github.com/YorickPeterse/ruby-lint/issues/145 [argamount172]: https://github.com/YorickPeterse/ruby-lint/pull/172 [crashyield173]: https://github.com/YorickPeterse/ruby-lint/issues/173 [dollarten175]: https://github.com/YorickPeterse/ruby-lint/issues/175 [sort176]: https://github.com/YorickPeterse/ruby-lint/pull/176 [stopwarn177]: https://github.com/YorickPeterse/ruby-lint/pull/177 [nestedloop178]: https://github.com/YorickPeterse/ruby-lint/issues/178 [const179]: https://github.com/YorickPeterse/ruby-lint/pull/179 [file180]: https://github.com/YorickPeterse/ruby-lint/issues/180 [mergedefs181]: https://github.com/YorickPeterse/ruby-lint/issues/181 [yastbug]: https://github.com/yast/yast-yast2/pull/475 -- Martin Vidner, YaST Team http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0