March 2016 - YaST Development - openSUSE Mailing Lists

[yast-devel] old libstorage design decision
by Josef Reidinger 03 Mar '16

03 Mar '16

Hi, when I thinking about current design discussion and design of new libstorage, I think it helps if we know what is problem with old libstorage that prevents its evolution and require revolution like rewrite. So is there any link where is documented which design decision leads to problem in old libstorage? I try design-decissions.md but it is just result of new decision, but no retrospective on old one. I see something in [1] but I miss there what prevents evolution of code that remove limitations of data structures, why all data cannot be exported/imported, why cannot be introduced exceptions, why API cannot be consolidated to new interface. Why monolitic code with very long functions cannot be refactored to small ones. Only one design decision which I see there is that problem is that heavily relies on "target map" which contain all storage-related data. So I see there is a problem that all code is tightly coupled with target map data structure ( known as common coupling [2] ) which leads to solution that now there is still high coupling on device graph, but its data structure is more hidden, so it depends on smaller API then before (so now it is External coupling or Stamp coupling depending on given code which is one or three steps better ). So I believe that new code wants to prevent to get to such state where evolution is not possible and it can bring some light to some design decision rationale and can helps others understand it. Thanks Josef [1] https://github.com/openSUSE/libstorage/blob/master/doc/status-current-code.… [2] https://en.wikipedia.org/wiki/Coupling_%28computer_programming%29#Procedura… -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 03 Mar '16

03 Mar '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - Use /proc/uptime instead of system time while waiting for services restart (5 days) https://github.com/yast/yast-autoinstallation/pull/197 - Fix install rules SLE 12 GA (34 days) https://github.com/yast/yast-autoinstallation/pull/190 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160113_bug_955878_merged_with_sp1' (48 days) https://github.com/yast/yast-autoinstallation/pull/179 Pending requests in repository yast-core: - Optionally build with Clang instead of GCC (via bcond_with clang). (6 days) https://github.com/yast/yast-core/pull/106 Pending requests in repository yast-country: - Some changes in the tumbleweed mappings (bsc#942899 and bsc#942896) (36 days) https://github.com/yast/yast-country/pull/61 - Ensure ntp is installed (when Install Recommended Packages is off) (148 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - Poc recover values (128 days) https://github.com/yast/yast-installation/pull/319 Pending requests in repository yast-network: - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (6 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-snapper: - [DO NOT MERGE] Added snapshot Class with strategy pattern. (89 days) https://github.com/yast/yast-snapper/pull/40 - Cleanup and delete multiple snapshots at once (#bsc#956143). (91 days) https://github.com/yast/yast-snapper/pull/39 Pending requests in repository yast-storage: - Add option to disable swap creation (35 days) https://github.com/yast/yast-storage/pull/182 - Ported support for LVM proposal setting from SP1 to Master (6 days) https://github.com/yast/yast-storage/pull/177 - Propose /boot for encrypted root on PowerPC (71 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-testsuite: - skel: runtest.sh: Set Y2DIR to a sensible default value (6 days) https://github.com/yast/yast-testsuite/pull/13 Pending requests in repository yast-yast2: - Cleanup NetworkInterfaces.Read (27 days) https://github.com/yast/yast-yast2/pull/433 - Count test coverage more accurately (6 days) https://github.com/yast/yast-yast2/pull/426 Pending requests in repository yast-auth-server: - Drop ca mgm (42 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast.github.io: - Add some documentation about submit requests (96 days) https://github.com/yast/yast.github.io/pull/55 Pending requests in repository aytests-tests: - [do not merge] Installation rules (19 days) https://github.com/yast/aytests-tests/pull/12 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 02 Mar '16

02 Mar '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - Use /proc/uptime instead of system time while waiting for services restart (4 days) https://github.com/yast/yast-autoinstallation/pull/197 - Fix install rules SLE 12 GA (33 days) https://github.com/yast/yast-autoinstallation/pull/190 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160113_bug_955878_merged_with_sp1' (47 days) https://github.com/yast/yast-autoinstallation/pull/179 Pending requests in repository yast-core: - Optionally build with Clang instead of GCC (via bcond_with clang). (5 days) https://github.com/yast/yast-core/pull/106 Pending requests in repository yast-country: - Some changes in the tumbleweed mappings (bsc#942899 and bsc#942896) (35 days) https://github.com/yast/yast-country/pull/61 - Ensure ntp is installed (when Install Recommended Packages is off) (147 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - Poc recover values (127 days) https://github.com/yast/yast-installation/pull/319 Pending requests in repository yast-network: - [WIP] Added subclass for recognize InfiniBand cards (bsc#903190) (5 days) https://github.com/yast/yast-network/pull/383 Pending requests in repository yast-snapper: - [DO NOT MERGE] Added snapshot Class with strategy pattern. (88 days) https://github.com/yast/yast-snapper/pull/40 - Cleanup and delete multiple snapshots at once (#bsc#956143). (90 days) https://github.com/yast/yast-snapper/pull/39 Pending requests in repository yast-storage: - Add option to disable swap creation (34 days) https://github.com/yast/yast-storage/pull/182 - Ported support for LVM proposal setting from SP1 to Master (5 days) https://github.com/yast/yast-storage/pull/177 - Propose /boot for encrypted root on PowerPC (70 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-testsuite: - skel: runtest.sh: Set Y2DIR to a sensible default value (5 days) https://github.com/yast/yast-testsuite/pull/13 Pending requests in repository yast-yast2: - Cleanup NetworkInterfaces.Read (26 days) https://github.com/yast/yast-yast2/pull/433 - Count test coverage more accurately (5 days) https://github.com/yast/yast-yast2/pull/426 Pending requests in repository yast-auth-server: - Drop ca mgm (41 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast.github.io: - Add some documentation about submit requests (95 days) https://github.com/yast/yast.github.io/pull/55 Pending requests in repository aytests-tests: - [do not merge] Installation rules (18 days) https://github.com/yast/aytests-tests/pull/12 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Refactoring madness: chapter three
by Ancor Gonzalez Sosa 01 Mar '16

01 Mar '16

This is the (hopefully) last part of my list of thing I considered as the obvious way to go while refactoring/reviewing code at some point but turned out to be more controversial than I expected. This week we'll probably agree in a more shared and less personal view about these topics. 1) RSpec as a design validator I like the RSpec approach to unit testing and I consider the RSpec tests of a class like the detailed documentation about its behavior. I try to write the RSpec tests relatively early in the process (without reaching the extreme of TDD) because it allows me to validate my design decisions. If I struggle to write meaningful readable RSpec test or I need a lot of non-obvious mocking during the process, then I conclude that my classes are not properly designed. In that case, I sometimes switch to TDD mode, writing the desired RSpec and then fixing my class. 2) Another note about OOP design In our new code there are some things that I consider kind of "design smells". I can be, as always, wrong but I feel like some of our code is misusing OOP as a mere way of encapsulate functionality. Going back to concrete real examples, we had this: fake_probing = Yast::Storage::FakeProbing.new devicegraph = fake_probing.devicegraph factory = Yast::Storage::FakeDeviceFactory.new(devicegraph) factory.load_yaml_file(input_file) yaml_writer = Yast::Storage::YamlWriter.new yaml_writer.write(devicegraph, output_file) The fact that we had a "new" every couple of lines is a design smell to me. The adopted solution was creating class methods, so we can do things like this. fake_probing = Yast::Storage::FakeProbing.new devicegraph = fake_probing.devicegraph Yast::Storage::FakeDeviceFactory.load_yaml_file(devicegraph, input_file) Yast::Storage::YamlWriter.write(devicegraph, output_file) Just a cosmetic fix for an issue that I consider deeper: we are writing good old procedural code dressed up as OO code. Every class has the only responsibility of implementing one step in a process and only one public method to execute that step (manipulating a set of I/O arguments). Is just one example of solutions that are perfectly correct but look quite unfamiliar to a Ruby developer's eyes and are quite hard to express as a set of RSpec behavior-oriented specs. Not saying they are wrong, just that they don't look like "the ruby way". Like this alternative which (although not perfect) is a much more "rubyist" way of writing the same: factory = Yast::Storage::DevicegraphFactory.new devicegraph = factory.create_from_file(input_file) File.open(output_file, 'w') {|f| f.write devicegraph.to_yaml } 3) Write every piece of code as something to maintain This is more related to Scrum than to Ruby or OOP. Since we are using Scrum to create YaST, I expect most PBIs to result in a YaST client that can be invoked using /sbin/yast2 or in a set of RSpecs that will be executed in every "rake test:unit" and used as a reference documentation in the future. I consider tests in the "examples" directory to be dead code. I consider that moving code from /test or /src/clients into /src/examples is the first step to have it broken with nobody ever noticing. A have a similar feeling about code used for debugging. It should be "in the right place" design-wise. Don't think in the debugging code as something temporary. If you are needing it today, you will probably need it (or something very similar) also in the future. Make it part of your design... and use mechanisms that would be useful when that code is executed as an RSpec test or yast client. That's all. Sorry again for the long text. I suck at summarizing. Cheers. -- Ancor González Sosa YaST Team at SUSE Linux GmbH -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

4 4

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 01 Mar '16

01 Mar '16

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - Fix install rules SLE 12 GA (32 days) https://github.com/yast/yast-autoinstallation/pull/190 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160113_bug_955878_merged_with_sp1' (46 days) https://github.com/yast/yast-autoinstallation/pull/179 Pending requests in repository yast-country: - Some changes in the tumbleweed mappings (bsc#942899 and bsc#942896) (34 days) https://github.com/yast/yast-country/pull/61 - Ensure ntp is installed (when Install Recommended Packages is off) (146 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-installation: - Poc recover values (126 days) https://github.com/yast/yast-installation/pull/319 Pending requests in repository yast-snapper: - [DO NOT MERGE] Added snapshot Class with strategy pattern. (87 days) https://github.com/yast/yast-snapper/pull/40 - Cleanup and delete multiple snapshots at once (#bsc#956143). (89 days) https://github.com/yast/yast-snapper/pull/39 Pending requests in repository yast-storage: - Add option to disable swap creation (33 days) https://github.com/yast/yast-storage/pull/182 - Propose /boot for encrypted root on PowerPC (69 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-yast2: - Cleanup NetworkInterfaces.Read (25 days) https://github.com/yast/yast-yast2/pull/433 Pending requests in repository yast-firewall: - Merge into Sle 12 sp1 (6 days) https://github.com/yast/yast-firewall/pull/23 Pending requests in repository yast-auth-server: - Drop ca mgm (40 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast.github.io: - Add some documentation about submit requests (94 days) https://github.com/yast/yast.github.io/pull/55 Pending requests in repository aytests-tests: - Check packages notifications (6 days) https://github.com/yast/aytests-tests/pull/16 - [do not merge] Installation rules (17 days) https://github.com/yast/aytests-tests/pull/12 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0