December 2014 - YaST Development - openSUSE Mailing Lists

[yast-devel] RFC - New Storage API
by Arvin Schnell 22 Dec '14

22 Dec '14

Hi, after the announcement of my ideas for a Storage Redesign in YaST I present now the first draft of the API that libstorage will provide. Remember that this API should be used by all YaST modules using functions from yast2-storage so far since the infamous target map will vanish. Device Graph ------------ The basic data structure is a directed graph of device objects as already explained (https://github.com/aschnell/libstorage-bgl-eval/wiki). Compared to the target map there are a few new objects, e.g. PartitionTable, Encryption and Filesystem. How to get a Device Graph ------------------------- Libstorage works with several device graphs, mainly the "probed" and the "current". Somehow you will have access to the main storage objects and can use that to get a device graph: DeviceGraph* device_graph = storage->getCurrent(); Manipulating the Device Graph ----------------------------- There are "constructors" for all concrete objects (e.g. Ext4 and Swap are concrete while Filesystem is abstract). Disk* sda = Disk::create(device_graph, "/dev/sda"); The device_graph is the owner of the objects. Creating disks will of course only be allowed in the image/KIWI mode. Most objects will be created by calling member functions of the parent: PartitionTable* gpt = sda->createPartitionTable(GPT); Partition* sda1 = gpt->createPartition("/dev/sda1"); // parameter will change Manipulating is done with member functions, e.g.: filesystem->addMountPoint("/boot"); There is also a low level interface where the vertices and edges of the graph are manipulated directly, e.g.: PartitionTable* gpt = Gpt::create(device_graph); // creates vertex Using::create(device_graph, sda, gpt); // creates edge Partition* sda1 = Partition::create("/dev/sda1"); // creates vertex Subdevice::create(device_graph, gpt, sda1); // creates edge But this low level interface should be reserved for the expert partitioner if needed at all. Querying the Device Graph ------------------------- Generic functions to query relatives of a device: vector<Device*> children = device->getChildren(); Here getChildren, getParents, getSiblings, getDescendants, getAncestors, getLeafs and getRoots is available. Special functions to query relatives of a device, e.g. the partitions of a partition table: vector<Partition*> partitions = gpt->getPartitions(); Functions to find specific devices, e.g. filesystems by mount point: Filesystem::findByMountPoint(device_graph, "/boot"); Combining query functions in a complex example: Suppose the bootloader has to know whether the device mounted at "/" uses a LVM logical volume: for (const Filesystem* filesystem : Filesystem::findByMountPoint(device_graph, "/")) { for (const Device* device : filesystem->getAncestors(false)) { if (dynamic_cast<const LvmLv*>(device)) cout << "mount point \"/\" somehow uses a logical volume" << endl; } } https://github.com/aschnell/libstorage-bgl-eval/blob/master/examples/find1.… Bindings -------- I have swig generated bindings for Ruby, Python and Perl5. The repository contains a few examples for each of them: https://github.com/aschnell/libstorage-bgl-eval/tree/master/bindings Help ---- The Makefile.am for Perl bindings needs improvement and the bindings should get a tiny testsuite. RFC --- If you see problems with this API for your module, generally miss something or have ideas for improvement please comment now. ciao Arvin -- Arvin Schnell, <aschnell(a)suse.de> Senior Software Engineer, Research & Development SUSE LINUX GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 4

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 22 Dec '14

22 Dec '14

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - Fix bashisms in fetch_image.sh script (7 days) https://github.com/yast/yast-autoinstallation/pull/93 Pending requests in repository yast-bootloader: - New inst clients (17 days) https://github.com/yast/yast-bootloader/pull/204 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (19 days) https://github.com/yast/yast-bootloader/pull/201 Pending requests in repository yast-installation: - SLE12-SP1: allow keyboard layout testing in language dialog (bnc#889549) (17 days) https://github.com/yast/yast-installation/pull/248 - Proposal cleaning (16 days) https://github.com/yast/yast-installation/pull/247 Pending requests in repository yast-kdump: - get rid of autotools (11 days) https://github.com/yast/yast-kdump/pull/23 Pending requests in repository yast-network: - AY: added IPv6 option (bnc#633310) (12 days) https://github.com/yast/yast-network/pull/270 Pending requests in repository yast-packager: - Fill options value if /proc/cmdline is empty (6 days) https://github.com/yast/yast-packager/pull/98 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (18 days) https://github.com/yast/yast-packager/pull/96 Pending requests in repository yast-theme: - Install scalable icons & fix name of yast-yast-language.* to yast-language.* (115 days) https://github.com/yast/yast-theme/pull/45 Pending requests in repository yast-docker: - Start making this a gem (76 days) https://github.com/yast/yast-docker/pull/2 Pending requests in repository yast.github.io: - Suggested text changes (11 days) https://github.com/yast/yast.github.io/pull/35 - Suggested Text Changes (11 days) https://github.com/yast/yast.github.io/pull/30 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 19 Dec '14

19 Dec '14

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - Fix bashisms in fetch_image.sh script (4 days) https://github.com/yast/yast-autoinstallation/pull/93 Pending requests in repository yast-bootloader: - New inst clients (14 days) https://github.com/yast/yast-bootloader/pull/204 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (16 days) https://github.com/yast/yast-bootloader/pull/201 Pending requests in repository yast-installation: - SLE12-SP1: allow keyboard layout testing in language dialog (bnc#889549) (14 days) https://github.com/yast/yast-installation/pull/248 - Proposal cleaning (13 days) https://github.com/yast/yast-installation/pull/247 Pending requests in repository yast-kdump: - get rid of autotools (8 days) https://github.com/yast/yast-kdump/pull/23 Pending requests in repository yast-network: - AY: added IPv6 option (bnc#633310) (9 days) https://github.com/yast/yast-network/pull/270 Pending requests in repository yast-packager: - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (15 days) https://github.com/yast/yast-packager/pull/96 Pending requests in repository yast-theme: - Install scalable icons & fix name of yast-yast-language.* to yast-language.* (112 days) https://github.com/yast/yast-theme/pull/45 Pending requests in repository yast-docker: - Start making this a gem (73 days) https://github.com/yast/yast-docker/pull/2 Pending requests in repository yast.github.io: - Suggested text changes (8 days) https://github.com/yast/yast.github.io/pull/35 - Suggested Text Changes (8 days) https://github.com/yast/yast.github.io/pull/30 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 18 Dec '14

18 Dec '14

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - For SLE12-SP1: load release notes of extensions also during AutoYaST (bnc#893586) (15 days) https://github.com/yast/yast-autoinstallation/pull/92 Pending requests in repository yast-bootloader: - New inst clients (13 days) https://github.com/yast/yast-bootloader/pull/204 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (15 days) https://github.com/yast/yast-bootloader/pull/201 Pending requests in repository yast-installation: - SLE12-SP1: allow keyboard layout testing in language dialog (bnc#889549) (13 days) https://github.com/yast/yast-installation/pull/248 - Proposal cleaning (12 days) https://github.com/yast/yast-installation/pull/247 Pending requests in repository yast-kdump: - get rid of autotools (7 days) https://github.com/yast/yast-kdump/pull/23 Pending requests in repository yast-network: - Autoyast: do not overwrite firewall settings (6 days) https://github.com/yast/yast-network/pull/275 - AY: added IPv6 option (bnc#633310) (8 days) https://github.com/yast/yast-network/pull/270 Pending requests in repository yast-packager: - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (14 days) https://github.com/yast/yast-packager/pull/96 Pending requests in repository yast-theme: - Install scalable icons & fix name of yast-yast-language.* to yast-language.* (111 days) https://github.com/yast/yast-theme/pull/45 Pending requests in repository yast-fonts: - travis build, bug fixes (6 days) https://github.com/yast/yast-fonts/pull/10 Pending requests in repository yast-docker: - Start making this a gem (72 days) https://github.com/yast/yast-docker/pull/2 Pending requests in repository yast.github.io: - Suggested text changes (7 days) https://github.com/yast/yast.github.io/pull/35 - Suggested Text Changes (7 days) https://github.com/yast/yast.github.io/pull/30 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] My Cucumber experience
by Ladislav Slezak 17 Dec '14

17 Dec '14

Hi all, JFYI: I just published a short blog post [1] about my experience with Cucumber testing framework [2] in rubocop-yast [3]. [1] http://lslezak.blogspot.com/2014/12/cucumber-testing-framework.html [2] http://cukes.info/ [3] https://github.com/yast/rubocop-yast -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak(a)suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] rspec 3.0
by Josef Reidinger 17 Dec '14

17 Dec '14

Hi, in this blog post http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3 is summary of changes in new rspec 3.0. I do not think that we will use it for SLE-12 tests, but maybe it will be used for 13.2. In general I think we should not use new syntax now, but what we can do is to not use deprecated syntax as there is already alternatives to prevent future problems. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

5 5

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 17 Dec '14

17 Dec '14

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - For SLE12-SP1: load release notes of extensions also during AutoYaST (bnc#893586) (14 days) https://github.com/yast/yast-autoinstallation/pull/92 Pending requests in repository yast-bootloader: - New inst clients (12 days) https://github.com/yast/yast-bootloader/pull/204 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (14 days) https://github.com/yast/yast-bootloader/pull/201 Pending requests in repository yast-installation: - SLE12-SP1: allow keyboard layout testing in language dialog (bnc#889549) (12 days) https://github.com/yast/yast-installation/pull/248 - Proposal cleaning (11 days) https://github.com/yast/yast-installation/pull/247 Pending requests in repository yast-kdump: - get rid of autotools (6 days) https://github.com/yast/yast-kdump/pull/23 Pending requests in repository yast-network: - Autoyast: do not overwrite firewall settings (5 days) https://github.com/yast/yast-network/pull/275 - AY: added IPv6 option (bnc#633310) (7 days) https://github.com/yast/yast-network/pull/270 Pending requests in repository yast-packager: - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (13 days) https://github.com/yast/yast-packager/pull/96 Pending requests in repository yast-theme: - Install scalable icons & fix name of yast-yast-language.* to yast-language.* (110 days) https://github.com/yast/yast-theme/pull/45 Pending requests in repository yast-fonts: - travis build, bug fixes (5 days) https://github.com/yast/yast-fonts/pull/10 Pending requests in repository yast-docker: - Start making this a gem (71 days) https://github.com/yast/yast-docker/pull/2 Pending requests in repository yast.github.io: - Suggested text changes (6 days) https://github.com/yast/yast.github.io/pull/35 - Suggested Text Changes (6 days) https://github.com/yast/yast.github.io/pull/30 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 16 Dec '14

16 Dec '14

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - For SLE12-SP1: load release notes of extensions also during AutoYaST (bnc#893586) (13 days) https://github.com/yast/yast-autoinstallation/pull/92 Pending requests in repository yast-bootloader: - New inst clients (11 days) https://github.com/yast/yast-bootloader/pull/204 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (13 days) https://github.com/yast/yast-bootloader/pull/201 Pending requests in repository yast-installation: - SLE12-SP1: allow keyboard layout testing in language dialog (bnc#889549) (11 days) https://github.com/yast/yast-installation/pull/248 - Proposal cleaning (10 days) https://github.com/yast/yast-installation/pull/247 Pending requests in repository yast-network: - AY: added IPv6 option (bnc#633310) (6 days) https://github.com/yast/yast-network/pull/270 Pending requests in repository yast-packager: - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (12 days) https://github.com/yast/yast-packager/pull/96 Pending requests in repository yast-theme: - Install scalable icons & fix name of yast-yast-language.* to yast-language.* (109 days) https://github.com/yast/yast-theme/pull/45 Pending requests in repository yast-yast2: - Use native Ruby implementations in Yast::URL and Yast::IP (27 days) https://github.com/yast/yast-yast2/pull/305 Pending requests in repository yast-docker: - Start making this a gem (70 days) https://github.com/yast/yast-docker/pull/2 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Pending Pull Requests
by yast-ci＠opensuse.org 15 Dec '14

15 Dec '14

This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - For SLE12-SP1: load release notes of extensions also during AutoYaST (bnc#893586) (12 days) https://github.com/yast/yast-autoinstallation/pull/92 Pending requests in repository yast-bootloader: - New inst clients (10 days) https://github.com/yast/yast-bootloader/pull/204 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (12 days) https://github.com/yast/yast-bootloader/pull/201 Pending requests in repository yast-installation: - SLE12-SP1: allow keyboard layout testing in language dialog (bnc#889549) (10 days) https://github.com/yast/yast-installation/pull/248 - Proposal cleaning (9 days) https://github.com/yast/yast-installation/pull/247 Pending requests in repository yast-packager: - Fill options value if /proc/cmdline is empty (11 days) https://github.com/yast/yast-packager/pull/98 - SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) (11 days) https://github.com/yast/yast-packager/pull/96 Pending requests in repository yast-theme: - Install scalable icons & fix name of yast-yast-language.* to yast-language.* (108 days) https://github.com/yast/yast-theme/pull/45 Pending requests in repository yast-yast2: - Use native Ruby implementations in Yast::URL and Yast::IP (26 days) https://github.com/yast/yast-yast2/pull/305 Pending requests in repository yast-docker: - Start making this a gem (69 days) https://github.com/yast/yast-docker/pull/2 -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] Rubocop vs Zombies
by Martin Vidner 12 Dec '14

12 Dec '14

No, it's not a movie (yet). What ---- As you know, Zombie Killer aims to replace Ops and Builtins in the code converted from YCP, automatically and safely: https://github.com/yast/zombie-killer Lada recently introduced Rubocop, which can detect a lot of style issues or even bugs, and autocorrect some of them. We have enabled it in Travis for some repositores already: http://lists.opensuse.org/yast-devel/2014-11/msg00066.html Obviously there are similarities between these projects, and luckily, both are based on the same parser library. So Lada has made a prototype of a YaST specific Rubocop plugin, which incorporates big parts of Zombie Killer: https://github.com/yast/rubocop-yast How --- Today we have discussed how to go forward with these. 1. Port Zombie Killer to Rubocop. Rubocop is a well working platform matching closely the aims and even the implementation of ZK. 2. Apply it continuously. Unlike with the switch from YCP, there is no reason to wait for the Zombie Cop to be "complete". We want to implement small features and apply them piece by piece. 3. Distinguish Strict and Tolerant modes. For newly written libraries we want to treat all zombies as offenses but for code converted from YCP we want to convert the ones which are safe to do so and shut up about the rest. 4. Package as a gem only. So far we do not see a need to build a RPM. The package will run in Travis, not in OBS. 5. Measure and present the effects. To make sure that we spend effort effectively, we will produce statistics of zombie counts and their evolution across time, for individual repos and all of YaST. (A simple extension will enable us to get the code quality graphs we currently have on CodeClimate, but for a longer span than one month.) https://codeclimate.com/github/yast/yast-bootloader/trends https://github.com/mvidner/metrics 6. Apply to individual repositores, not across all of YaST?? We are not so confident about (6) and want your opinion about this. Applying a new Zombie Cop across all of YaST has the benefit of generally having more of clean code. The usual maintainer (if any) of that repo does not have to care. On the other hand, some cops,like the logging one, may be a bit aggressive and require fixups to the old tests. There may even be bugs, and those could go unnoticed for a long time for little used and tested modules. So we think it is more appropriate to apply the Zombie Cops (or any cops, actually) only when touching a module for another reason. You will object that it may result of many code changes, which is hard to review. But that is solved by having separate cops for each kind of change, and applying them one per each commit. Next ---- Port all of the current Zombie Killer to a Rubocop plugin, including the tests. -- Martin Vidner, Cloud & Systems Management Team http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

2 1