August 2013 - YaST Development - openSUSE Mailing Lists

[yast-devel] Bug in Ruby code with arg_ref
by Arvin Schnell 14 Aug '13

14 Aug '13

Hi, we had a strange bug in yast-storage with the Ruby code for adding new LVM logical volumes (also see bng #834330). In ep-lvm-lib.rb the function "EpCreateLogicalVolume" has a local variable "data". That variable is passed by reference to "DlgCreateLogicalVolume" in ep-lvm-dialogs.rb along with a reference to the function "Commit". Commit use "data". So the code looks roughly like this: def EpCreateLogicalVolume(device) data = { ... } _Commit = lambda do do something with data end data_ref = arg_ref(data); DlgCreateLogicalVolume(data_ref, fun_ref(_Commit, "symbol ()")) data = data_ref.value; end def DlgCreateLogicalVolume(data, _Commit) modify data _Commit.call end The problem is that "data" when used in "Commit" has wrong values; it's neither the original value set in "EpCreateLogicalVolume" nor the value set in "DlgCreateLogicalVolume" but some mixture. It's caused by the fact that "data = data_ref.value" happens after calling "Commit". We fixed this by passing "data" to "Commit" explicitely. ciao Arvin -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 2

[yast-devel] Rake for Yast
by Vladimir Moravec 12 Aug '13

12 Aug '13

Hi, recently I have submitted initial pull request with proposal for integrating and extending of ruby build tool Rake for Yast [1] . The code is going to be packaged as ruby gem(and additionally as rpm). All important initial information is available in the README file includedwithinthe repo. Any commentsand recommendations are welcome. Thanks. Vlado [1] https://github.com/yast/yast-rake/pull/1

1 0

[yast-devel] new y2tool does not provide generateYCPWrappers any more
by Thomas Fehr 12 Aug '13

12 Aug '13

Hi, While trying to build yast2-storage, I stumbled over the fact that y2tools does not support command "generateYCPWrappers" any more. We still use these calls for cenerating the wrappers for callback functions between libstorage and yast2-storage. In spite of the misleading name generateYCPWrappers, these have noting to do with YCP code but with functionality in yast2-core which ist still valid and used. When building yast2-storage it now fails with: y2tool: Can't find "generateYCPWrappers" in /usr/share/YaST2/data/devtools/bin Tschuess, Thomas Fehr -- Thomas Fehr, SuSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Tel: +49-911-74053-0, Fax: +49-911-74053-482, Email: fehr(a)suse.de GPG public key available. -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 1

[yast-devel] modules wich need a maintainer
by Joerg Stephan 10 Aug '13

10 Aug '13

Hey folks, i've seen the current effords and the discussion on modules, is there any list of modules which currently does not have an maintainer and where a maintainer would be needed, i would like to help if i can. Regards -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

3 3

[yast-devel] optimization opportunities in the ycp -> ruby conversion
by Roman Neuhauser 09 Aug '13

09 Aug '13

hello, two topics re y2r (i know i'm horribly late to the party). 1. procedural vs. object-oriented ruby the generated ruby code consists, to a large degree, of function calls emulating semantics of basic ycp operations: Builtins.foreach, Ops.add, etc. these functions are @deprecated, meaning we should go and replace them with native ruby equivalents after checking that the conversion is safe. the point of these emulations is that ycp's nil is a NullObject, you can iterate it like an empty hash or list, you can add it to a number (you'll get nil back), you can concat it with a string or list (same), whereas in ruby you need to if/else around it as stuff like nil.each generates NoMethodError exceptions. but, after perusing ops.rb, builtins.rb, and a few .rb files in yast-installation/, it seems to me that we could have a much more natural-looking ruby code if, instead of having Ops.add all over the place we went for Yast::String#+, Yast::Array#+, etc. it seems there's not so many places where we "return nil", and we could "return Yast::String.new", "return Yast::Array.new" etc in such places. 2. optimization/simplification opportunities in y2r this might not be a representative example, i haven't seen it all. i looked through yast-installation/src/clients/desktop_finish.rb for opportunities to remove some Builtin.foreach calls. it took me about 30 minutes (first encounter with builtins.rb, ops.rb etc) to realize that there's *no reason* for @desktop_order to be pulled through Builtins.foreach: it's always an array. the next thing on my mind was: if *i* can see this, why not the transpiler? the questions here are: is it too late now? if yes, is ther a tool that would let us transform the ruby code? (pls no sed(1) jokes ;) i can see how adding such optimization phases to y2r could require slight changes (hints) to the ycp code, and i don't expect it to do inter-module analysis (though that would enable most gains). i'm afraid that we're going to get stuck with most of the generated code for the next 10 years. there's ~9k lines with Ops.add alone across the generated code, total number of uses of these @deprecated methods will be quite a bit higher, and if we're going to do the analysis (as opposed to a computer), it'll take a very long time, and we're bound to introduce more bugs than the computer would. https://github.com/roman-neuhauser/yast-installation/compare/master...built… - @desktop_order is initialized with the array literal, so we know the type - it has no getter/setter, so no problems from those - it is reassigned by Builtins operations called on itself; they are guaranteed to return Array if they received one -- roman -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

2 2

[yast-devel] Some YaST Packages Will Be Out of Maintenance Soon
by Lukas Ocilka 08 Aug '13

08 Aug '13

Hi, We'd like to stop maintaining some of the old YaST packages in both openSUSE and SLE in the near future because there are more important tasks we should focus on. This means that the current YaST Team will not take care of them anymore: add features, fix bugs, submit to Factory, etc. We have a few options what we could do depending on the fact whether the openSUSE community wants to keep them: - Remove from GitHub completely (not a good option) - Delete all files from master branch and add README that would state that $this package is free for taking over - Move to openSUSE project and add some README without removing files from the master branch, and also removing from openSUSE - Offer these YaST modules to community at opensuse-factory In all cases, we should replace the current MAINTAINER with some generic (opensuse-factory?) mailing-list. Packages in question (examples) - yast2-phone-services - yast2-modem - yast2-x11 - yast2-mouse - yast2-irda - yast2-fingerprint-reader Let's discuss the possibilities and then let's decide which one is the best. Thanks Lukas -- Lukas Ocilka, Cloud & Systems Management Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

4 4

[yast-devel] YaST Ruby final conversion & integration - DONE
by David Majda 08 Aug '13

08 Aug '13

Hi, we are pleased to announce that the final Ruby conversion of YaST YCP code to Ruby is over. The converted source was committed to Git [1], passed through Jenkins and builds successfully in YaST:Head [2]. YaST version was increased to 3.0.0. We also sent submit requests to Factory (not accepted yet). ** YaST Git repositories are open for development again. ** Thanks everybody for patience and welcome to the new Ruby era :-) Technical Details ----------------- In all affected Git repositories, we used the following Git tags to mark the conversion: * good-bye-ycp -- last commit before the conversion * hello-ruby -- last commit of the conversion You can use them to see the changes the conversion did, e.g.: https://github.com/yast/yast-yast2/compare/good-bye-ycp...hello-ruby The amount of converted code is quite impressive: * 4204 files * 594680 lines of YCP deleted * 724687 lines of Ruby added Issues ------ There are few small issues that remain to be solved: * There were problems running tests on Jenkins for several packages. We solved them temporarily by fiddling with the test scripts, but we need to fix them more properly. Josef & Martin will look into that. Note the tests still pass correctly in when building in the OBS. * Module "iplb" is currently broken -- it wasn't converted, but its tests don't work after converting "testsuite" into Ruby. We need to clarify status of this module and fix it or drop it. Next Steps ---------- In the coming days and weeks, we would like to do the following: 1. Publish a document describing what the conversion changed (and how) and what remained the same. This will make starting with Ruby YaST easier for everybody who was not involved in the conversion. 2. Publish a document describing how to best handle YaST maintenance fixes in the old YCP code base which will need to be applied back to Ruby. 3. Decide on how exactly to do documentation and testing. 4. Update the skeleton that shows how to create a new YaST module to Ruby and describe the best practices. 5. Initiate a discussion about further changes and improvements in YaST architecture, which would allow us simplify it even more and make YaST even more attractive to contributors. [1] https://github.com/yast/ [2] https://build.opensuse.org/project/show/YaST:Head -- David Majda SUSE Studio developer http://susestudio.com/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

8 12

[yast-devel] Results after upgrading yast to ruby-yast in 12.3
by Manu Gupta 08 Aug '13

08 Aug '13

Hey All I am using ruby-yast now, when I run yast from the terminal I get the following output linux-6gy3:~ # yast terminate called after throwing an instance of 'YUIPluginException' what(): Couldn't load plug-in ncurses YaST got signal 6 at YCP file /usr/share/YaST2/clients/menu.rb:193 /sbin/yast: line 431: 28057 Aborted $ybindir/y2base $module "$@" "$SELECTED_GUI" $Y2_GEOMETRY $Y2UI_ARGS seems like ncurses is not loaded, is this is a known bug or what can i do enable more logs -- Regards Manu Gupta -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

4 3

[yast-devel] BuildRequires cleanup, check your *.spec files
by Ladislav Slezak 07 Aug '13

07 Aug '13

Hi all, after converting YaST to Ruby we do not compile YCP modules to YBC binary files anymore. The compilation required all imported modules to be present in the system during build. With Ruby it's not needed. The result is that some packages can be possibly removed from BuildRequires. Of course, if an external module is needed for running the tests then it still must be present [1]. In extreme cases all Yast packages (besides yast2-devtools) can be removed from BuildRequires. Even yast2 and yast2-core, see this [2]. The list of packages which can be removed depends on what's tested. Or you might need some file from other package during build, therefore the cleanup cannot be done automatically. So please, check your *.spec files and think about possible obsolete BuildRequires and remove them. If you are unsure just try removing it and build the package locally using "osc". If it succeeds then it's not needed :-) Sometimes you need to modify the configure.in.in file, there might be a check which tests some package/library/file/... presence but it's actually not used later. If you need some help just ask here.... Removing an unnecessary BuildRequire means that less package rebuilds will be needed in OBS and the rebuilds will be faster after updating a package. Also local builds will be faster (less packages to download and install). Thanks! Ladislav [1] This could be potentially avoided by mocking the imports and module calls via 'mocha' gem. Later I'd like to create some example... [2] https://github.com/yast/yast-bootloader/pull/22 -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0

[yast-devel] YCP -> Ruby translation - known issues
by David Majda 07 Aug '13

07 Aug '13

Hi, FYI I created a page in YCP Killer wiki that collects known issues with the YCP -> Ruby translation: https://github.com/yast/ycp-killer/wiki/Known-Issues The intent is to have one canonical place when one can look in case of suspicion that something doesn't work right after the conversion. Right now, there is just one known issue, but it is possible that the list will expand in the future. -- David Majda SUSE Studio developer http://susestudio.com/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org To contact the owner, e-mail: yast-devel+owner(a)opensuse.org

1 0