July 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <web-client> master : Removed tables
by Josef Reidinger 16 Jul '09

16 Jul '09

Robert Lihm wrote: > ref: refs/heads/master > commit 141ebbc22a7387658dbc38660ac2546c52a91759 > Author: Robert Lihm <rlihm(a)lihmedia.org> > Date: Thu Jul 16 14:50:22 2009 +0200 > > Removed tables > * added div structure > * added javascript for row highlighting > --- > webclient/.gitignore | 1 + > webclient/app/views/controlpanel/index.rhtml | 71 ++++++++++------------- > webclient/app/views/controlpanel/show_all.rhtml | 53 ++++++++++++++--- > webclient/app/views/layouts/main.rhtml | 8 ++- > webclient/public/images/geckohead-green.png | Bin 0 -> 3798 bytes > webclient/public/stylesheets/style.css | 46 +++++++++++++-- > 6 files changed, 121 insertions(+), 58 deletions(-) > > diff --git a/webclient/.gitignore b/webclient/.gitignore > index 9992c2a..34e40d8 100644 > --- a/webclient/.gitignore > +++ b/webclient/.gitignore > @@ -2,3 +2,4 @@ > db/*.sqlite3 > db/schema.rb > ._* > +diff.diff > diff --git a/webclient/app/views/controlpanel/index.rhtml b/webclient/app/views/controlpanel/index.rhtml > index 9a13c68..4570a64 100644 > --- a/webclient/app/views/controlpanel/index.rhtml > +++ b/webclient/app/views/controlpanel/index.rhtml > @@ -1,20 +1,11 @@ > -<%= javascript_include_tag :defaults %> > -<% if ActionController::Routing.possible_controllers.include?("patch_updates") %> > -<% javascript_tag do -%> > - $(document).ready( function() { > - <%= remote_function(:update => "status_patches", > - :url => { :controller => :patch_updates, :action => :show_summary }) %> > - }); > -<% end -%> > -<% end %> > + > <h3><img src="/images/monitoring.png" height="23" width="23" border="0" /> <%= _("Status") %></h3> > > -<div id="status_patches"> > - <% if ActionController::Routing.possible_controllers.include?("patch_updates") %> > - <img src="/images/working.gif" height="32" width="32" border="0" /> Loading informations about patches > - <% else %> > - Patch plugin is not installed. > - <% end %> > +<div id="status_patches_icon"> > + <img src= <%=@update_image%> height="32" width="32" border="0" /> > +</div> > +<div id="status_patches_msg"> > + <a href="patch_updates"><%=@update_label%></a> > </div> Please don't change functional code in pages. I think that problem appear that you work on not updated system and somehow it doesn't merge. Please take attention on this as e.g. this completely break patch line on control panel. I fix it. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : These helpers are unused
by Ladislav Slezak 16 Jul '09

16 Jul '09

Klaus KXXmpf wrote: > ref: refs/heads/master > commit 8e6cb38ef8d49e4307700f048884d55a294c9f47 > Author: Klaus Kämpf <kkaempf(a)suse.de> > Date: Wed Jul 15 15:54:53 2009 +0200 > > These helpers are unused > --- > webclient/app/helpers/view_helpers/html_helper.rb | 96 -------------------- > webclient/app/helpers/view_helpers/label_helper.rb | 16 ---- > 2 files changed, 0 insertions(+), 112 deletions(-) Ooops! They are used by the samba-server plugin. The intention was to put all generic helpers to the main webclient package so all plugins can share them (DRY). -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : Add FIXMEs
by Josef Reidinger 16 Jul '09

16 Jul '09

Klaus KXXmpf wrote: > ref: refs/heads/master > commit 93073b2d3f55a9ee3a87a3e8b95bf6937a0902f8 > Author: Klaus KÃ¤mpf <kkaempf(a)suse.de> > Date: Wed Jul 15 16:43:09 2009 +0200 > > Add FIXMEs > --- > .../app/controllers/system_time_controller.rb | 15 +++++++++++++-- > 1 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/plugins/systemtime/app/controllers/system_time_controller.rb b/plugins/systemtime/app/controllers/system_time_controller.rb > index a2fe83e..2155aa1 100644 > --- a/plugins/systemtime/app/controllers/system_time_controller.rb > +++ b/plugins/systemtime/app/controllers/system_time_controller.rb > @@ -1,6 +1,8 @@ > require 'yast/service_resource' > require 'systemtime' > > +# FIXME: add comments to explain functions > + Hi, I try solve all fixmes before I go on vacation. documentation is done > class SystemTimeController < ApplicationController > before_filter :login_required > layout 'main' > @@ -15,6 +17,7 @@ class SystemTimeController < ApplicationController > end > > def fill_current_region > + # FIXME: @region can remain unset I solve that after discussion with jsuchome where this case can happen and check if rest-service is setted to unknown timezone (only unknown timezone couldn't have region). So if that one is setted I show error. > @@timezones.each do |region| > region.entries.each do |entry| > if entry.id == @systemtime.timezone > @@ -25,17 +28,19 @@ class SystemTimeController < ApplicationController > end > > def fill_date_and_time (timedate) > + # FIXME: such conversions should be in a model Done > @time = timedate[timedate.index(" - ")+3,8] > @date = timedate[0..timedate.index(" - ")-1] > #convert date to format for datepicker > @date.sub!(/^(\d+)-(\d+)-(\d+)/,'\3/\2/\1') > end > > - > - > public > + > + # FIXME: should go to initialize() done > @@timezones = {} > > + # FIXME: should go to initialize() Doesn't work in initialize, and after googling noone have it in initialize and even in tutorial it is directly in class > # Initialize GetText and Content-Type. > init_gettext "yast_webclient_systemtime" # textdomain, options(:charset, :content_type) > > @@ -53,9 +58,11 @@ class SystemTimeController < ApplicationController > fill_date_and_time((a)systemtime.time) > end > > + # FIXME: rename to 'update' to match rails conventions done > def commit_time > t = load_proxy 'org.opensuse.yast.modules.yapi.time' > > + # FIXME: add a 'redirect_to' all these redirect to stuff is problematic as in load_proxy is some redirect_to if occur situation where we can redirect to adress with howto solve problem. I try change load_proxy to redirect in each case where it make sense and document how to cancel redirection if anyone need it (like AJAX stuff). > unless t > return false > end > @@ -71,14 +78,17 @@ class SystemTimeController < ApplicationController > rescue ActiveResource::ClientError => e > flash[:error] = YaST::ServiceResource.error(e) > log_exception e > + #FIXME: what about other exceptions ? done > end > > redirect_to :action => :index > end > > + # FIXME: rename to 'update' to match rails conventions done > def commit_timezone > t = load_proxy 'org.opensuse.yast.modules.yapi.time' > > + # FIXME: add a 'redirect_to' ^^^ > unless t > return false > end > @@ -91,6 +101,7 @@ class SystemTimeController < ApplicationController > rescue ActiveResource::ClientError => e > flash[:error] = YaST::ServiceResource.error(e) > log_exception e > + #FIXME: what about other exceptions ? done > end > > redirect_to :action => :index -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <web-client> master : Improve robustness --> Funny behavior or Ruby
by Stefan Schubert 16 Jul '09

16 Jul '09

Klaus KXXmpf schrieb: > > - def create_data() > - @data = {} > - @limits = {} > - @limits_list = {} > + def create_data > + @data = @limits = @limits_list = @data_group = Hash.new > status = [] > It seems that all variables have now the same reference to ONE Hash. Has anyone an explanation for that ? Greetings Stefan -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] webyast, some issues
by Duncan Mac-Vicar P. 16 Jul '09

16 Jul '09

So, another round of tests :-) - Permissions setup In theory, there are 2 groups of permissions: - the ones for the service, which allows it to read policykit permisions, execute scr/YaST calls, and do some packagekit stuff. - the per service ACLs, which represent resources, and that ones are used by the service to check if the logged user has permission (when it is a pam user), which are executed by the service if the user is authorized by using his powers coming from the permissions above. To quicly setup the permissions, policyKit-rights.rb uses polkit-auth $user -- explicit to see what permissions are on. This option excludes permissions set by adding a match tag on PolicyKit.conf, is that intented? The same things does then the system_check tag, which complains that some actions are not authorized for current user, even if they are using PolicyKit.conf (which is not explicit). CCing Marcus and Ludwig here :-) - Login slow It seems the health status (or something else) takes some time, and makes the impression login would take forever. - tests How are tests in all plugins supposed to be run? I am confused with some tasks being at the top-level, others shared in webservice-tasks, others specific to the webclient or service, and other stuff is implemented in script/something (why not a task?) - How is, in a similar fashion packaging done? (in order to integrate it to hudson). Duncan -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

5 4

[yast-devel] Re: [yast-commit] <web-client> master : Prevent crash on missing permission
by Josef Reidinger 16 Jul '09

16 Jul '09

Klaus KXXmpf wrote: > ref: refs/heads/master > commit befe6e2ab25ac2a8b6117f3d99eb8f859cbb3204 > Author: Klaus KÃ¤mpf <kkaempf(a)suse.de> > Date: Wed Jul 15 16:49:51 2009 +0200 > > Prevent crash on missing permission > --- > .../app/controllers/system_time_controller.rb | 2 ++ > .../systemtime/app/views/system_time/index.rhtml | 4 +++- > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/plugins/systemtime/app/controllers/system_time_controller.rb b/plugins/systemtime/app/controllers/system_time_controller.rb > index 2155aa1..8b6da35 100644 > --- a/plugins/systemtime/app/controllers/system_time_controller.rb > +++ b/plugins/systemtime/app/controllers/system_time_controller.rb > @@ -48,6 +48,8 @@ class SystemTimeController < ApplicationController > @systemtime = load_proxy 'org.opensuse.yast.modules.yapi.time' > > unless @systemtime > + flash[:warning] = "No permissions for time module" > + redirect_to root_path > return false > end > > diff --git a/plugins/systemtime/app/views/system_time/index.rhtml b/plugins/systemtime/app/views/system_time/index.rhtml > index 46fbb96..81fc88c 100644 > --- a/plugins/systemtime/app/views/system_time/index.rhtml > +++ b/plugins/systemtime/app/views/system_time/index.rhtml > @@ -23,7 +23,9 @@ > <%=_("Region:")%> > </label> > </td> > - <td><%= select_tag "region", options_for_select(@valid, @region.name), :disabled=> disabled %></td> > + <% name = @region.name rescue "" > + @valid = Array.new unless @valid -%> > + <td><%= select_tag "region", options_for_select(@valid, name), :disabled => disabled %></td> > > </tr> > <tr> Hi, this is not correct fix as @systemtime is nil is more case and it is solved (even with correct flash message) in load_proxy. What is needed to add is check if is set permissions[:read]...I change this patch to working version. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] /repositories/YaST:/Web/ is way outdated
by Lukas Ocilka 15 Jul '09

15 Jul '09

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I'm currently building a testing appliance with WebYaST and I've found that RPMs in th YaST:/Web repository are quite old. See http://download.opensuse.org/repositories/YaST:/Web/openSUSE_11.1/ For instance: yast2-webservice-patches-0.0.1-1.1.noarch.rpm -- 19-May-2009 13:00 Could you, please, update it? Thx && Bye Lukas -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpdx+wACgkQVSqMdRCqTiwRFwCfSlOKtqxoqYJ0WWEqXpvmVBb+ Y1wAn2lxHSuf9+LYygKJ3RMyR9etXE1R =vSDl -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Re: [yast-commit] <web-client> master : Remove all empty 'alt=' tags
by josef reidinger 15 Jul '09

15 Jul '09

Klaus KXXmpf napsal(a): > ref: refs/heads/master > commit a8b23a8cb484a9735881979a22df51be165720cf > Author: Klaus KĂ¤mpf <kkaempf(a)suse.de> > Date: Wed Jul 15 10:37:35 2009 +0200 > > Remove all empty 'alt=' tags > --- > webclient/app/views/controlpanel/index.rhtml | 8 ++++---- > webclient/app/views/controlpanel/show_all.rhtml | 2 +- > webclient/app/views/hosts/edit.html.erb | 4 ++-- > webclient/app/views/hosts/index.html.erb | 2 +- > webclient/app/views/hosts/new.html.erb | 4 ++-- > 5 files changed, 10 insertions(+), 10 deletions(-) > > <snip> > diff --git a/webclient/app/views/hosts/index.html.erb b/webclient/app/views/hosts/index.html.erb > index bc7ab27..feb6e34 100644 > --- a/webclient/app/views/hosts/index.html.erb > +++ b/webclient/app/views/hosts/index.html.erb > @@ -36,7 +36,7 @@ > </tbody> > > </table> > - <input class="button jqModal" type="submit" value="Add" id="add-host" /> > + <%= link_to _('Add'), new_host_path, :class => "button" %> > <!-- > FIXME may be add remove and edit buttons and get rid of the icons above > <input class="button disabled" disabled="true" type="submit" value="Remove" id="remove-printer"/> Hi, I don't understand this change. If it is part of form, that direct link doesn't work, does? And if it is separated button that do action (think this is that case) why not use button_to? Is there some magic in rails that I don't see? -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] DVD - insert/change request procedure
by Robert Schweikert 15 Jul '09

15 Jul '09

Hi, Is there a canned way to request the user to insert the next DVD? When SUSE was distributed on multiple CD-ROMs this existed, is this stuff still around and easy to use from a shell script? I am working on a project that requires more than 1 DVD. Once the stuff from the 1st DVD is installed the system will boot from the hard drive. Once the system is up and running I need the user to insert the 2nd DVD to get the data. Thus I am looking for an easy way to get a dialog posted, the DVD mounted etc, such that I can just copy the data to where I need it to be. Thanks, Robert -- Robert Schweikert MAY THE SOURCE BE WITH YOU Software Engineer Consultant LINUX rschweikert(a)novell.com 781-464-8147 Novell Making IT Work As One -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] Larger change on webclient side, run "rake db:migrate"
by Klaus Kaempf 15 Jul '09

15 Jul '09

Hi, if you 'git pull' on webservice, you'll most probably have to run a "rake db:migrate" afterwards. Sorry for the inconvenience. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 4

[yast-devel] Unsetting autologin from a script
by Robert Schweikert 14 Jul '09

14 Jul '09

I am working on a project creating an appliance using kiwi. The appliance has a software config step that is automatically kicked of when it is first installed on the hardware. Thus I am setting up autologin mechanism. Once the configuration is done I would like to remove the autologin mechanism. Is there a convenient way to do this or do I need to write a script to change /etc/sysconfig/displaymanager? Thanks, Robert -- Robert Schweikert MAY THE SOURCE BE WITH YOU Software Engineer Consultant LINUX rschweikert(a)novell.com 781-464-8147 Novell Making IT Work As One -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] WebYaST developers: check return values of YaST::ServiceResource.proxy_for
by Klaus Kaempf 14 Jul '09

14 Jul '09

Hi, as we have a distributed application with WebYaST, the frontend part actually has to check if the backend part is complete and behaves correctly. So whenever you request a backend resource, check if it actually exists ! Klaus -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 7

[yast-devel] WebYaST system monitoring
by Stefan Schubert 14 Jul '09

14 Jul '09

Hi, here is a short description how this plugin works and how it can be installed/configured. I have also attached a screen shot which shows the current state of development. http://en.opensuse.org/YaST/Web/Development#System_Monitoring_module Greetings Stefan -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 6

[yast-devel] ActionController::Session::CookieStore::CookieOverflow
by Jiri Srain 13 Jul '09

13 Jul '09

Hi! Trying to run the web-client from git, in some cases even at the very first page, I get: Status: 500 Internal Server Error ActionController::Session::CookieStore::CookieOverflow in the output, followed by the call trace. What causes it? How do I work it around or (even better) fix it? Thanks, Jiri -- Regards, Jiri Srain YaST Team Leader --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: jsrain(a)suse.cz Lihovarska 1060/12 tel: +420 284 028 959 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

5 11

[yast-devel] Webyast - html validation testing
by Josef Reidinger 13 Jul '09

13 Jul '09

Hi, I look at html validation. After searching through google I found that is used 2 validators, often together w3c and tidy by bindings. w3c ----- Often used as remote server validation. It is not possible for our test server and also build service doesn't allow that communication to internet. W3c validator is open source and it is packed also in suse. But its local settings is hard to do automatic and need also some webserver that runs it. And I think this is not acceptable as it could take non-trivial time to run it and as it should run also during building each plugin it could take serious amoung of time. tidy ----- Tidy is binary library and executable. All modules that I find on internet use ruby bindings and each complain about its implementation, stability and bugs. Also it is not packaged in suse repository. I try another way and use cli tool to validate it and parse its output. You can find result of my work in git and now it is used language module Welcome any comments language output: > 2) Failure: > test_access_without_write_permissions(LanguageControllerTest) > [test/validation_assert.rb:18:in `assert_valid_markup' > /test/functional/language_controller_test.rb:120:in `test_access_without_write_permissions']: > Find validation problems: line 28 column 7 - Warning: <img> element not empty or not closed > line 53 column 1 - Warning: <br> element not empty or not closed > line 88 column 4 - Warning: <br> element not empty or not closed > line 89 column 4 - Warning: <br> element not empty or not closed > line 55 column 196 - Warning: <table> lacks "summary" attribute > Info: Doctype given is "-//W3C//DTD XHTML 1.0 Strict//EN" > Info: Document content looks like HTML Proprietary > 5 warnings, 0 errors were found! > > > The table summary attribute should be used to describe > the table structure. It is very helpful for people using > non-visual browsers. The scope and headers attributes for > table cells are useful for specifying which headers apply > to each table cell, enabling non-visual browsers to provide > a meaningful context for each cell. > > For further advice on how to make your pages accessible > see http://www.w3.org/WAI/GL. You may also want to try > "http://www.cast.org/bobby/" which is a free Web-based > service for checking URLs for accessibility. > > To learn more about HTML Tidy see http://tidy.sourceforge.net > Please send bug reports to html-tidy(a)w3.org > HTML and CSS specifications are available from http://www.w3.org/ > Lobby your company to join W3C, see http://www.w3.org/Consortium > . > <false> is not true. what is changed in controller test: require File.expand_path( File.join("test","validation_assert"), RailsParent.parent ) #that inject new method to ancestor of test and to test where you want test response: assert_valid_markup -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] WebYaST status call 10-Jun-2009
by Klaus Kaempf 13 Jul '09

13 Jul '09

[Apologies for the late status. I'll do the minutes again on Wednesday ;-)] WebYaST status call 2009-07-10 Attendees: schubi, mzugec, mvidner, jsrain, kkaempf, dmacvicar, lslezak schubi - Working on Status/Monitoring mzugec - tests for systemtime (backend) mvidner - tests for D-Bus backend error reporting jsrain - just getting started kkaempf - talked to web designer moved testing focus to web-client now dmacvicar - Still working on Hudson build server lslezak - looking into web ui test tools (Watir, Selenium) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : systemtime: test for commit
by Josef Reidinger 13 Jul '09

13 Jul '09

mzugec wrote: > ref: refs/heads/master > commit d84d7b800e722ce8409bbd534c3065aa0ec30c05 > Author: mzugec <mzugec(a)novell.com> > Date: Fri Jul 10 16:57:02 2009 +0200 > > systemtime: test for commit > --- > .../app/controllers/system_time_controller.rb | 2 +- > .../test/functional/systemtime_controller_test.rb | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 1 deletions(-) > > diff --git a/plugins/systemtime/app/controllers/system_time_controller.rb b/plugins/systemtime/app/controllers/system_time_controller.rb > index 563dfbc..8320bc8 100644 > --- a/plugins/systemtime/app/controllers/system_time_controller.rb > +++ b/plugins/systemtime/app/controllers/system_time_controller.rb > @@ -52,13 +52,13 @@ class SystemTimeController < ApplicationController > def commit_time > proxy = YaST::ServiceResource.proxy_for('org.opensuse.yast.modules.yapi.time') > @permissions = proxy.permissions > - > begin > t = proxy.find > rescue ActiveResource::ClientError => e > flash[:error] = YaST::ServiceResource.error(e) > redirect_to :action => :index > end > +debugger > > arr = params[:date][:date].split("/") > t.time = "#{arr[2]}-#{arr[0]}-#{arr[1]} - "+params[:currenttime] > <snip /> Please don't add debugger to code and don't submit it. At first it cause problem it is not nice and second it can cause serious problem if we set test server as debugger need interact. -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Minutes of Prague YaST Team Meeting: 2009-07-09
by Martin Vidner 10 Jul '09

10 Jul '09

Minutes of Prague YaST Team Meeting: 2009-07-09 =============================================== http://en.opensuse.org/YaST/Team Present: jkupec, jreidinger, jsrain, juhliarik, locilka, lslezak, mvidner, mzugec Absent: jsuchome, kmachalkova (vacation) Minutes: mvidner Next Minutes: mzugec WebYaST ======= See minutes of the daily status calls on yast-devel jreidinger: packagekitd bombs out if it cannot get the zypp lock Miscellaneous ============= jkupec: SMT; looking at 11.2 features for zypper lslezak: maintenance updates locilka: SMT; maintenance updates mzugec: bugs juhliarik: bugs, features WIP, got a good patch for yast2-python-bindings from Jeff Shantz (GSoC) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <rest-service> master : made check for packages work in non-english locale
by josef reidinger 10 Jul '09

10 Jul '09

JiXXXX XXrain napsal(a): > ref: refs/heads/master > commit 1666acacf0784ddec98cdb7fc0b35e9882ee5d33 > Author: JiĹ�Ă Ĺ rain <jsrain(a)suse.cz> > Date: Fri Jul 10 11:03:28 2009 +0200 > > made check for packages work in non-english locale > --- > webservice/lib/tasks/checks.rake | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/webservice/lib/tasks/checks.rake b/webservice/lib/tasks/checks.rake > index 6f3ac9d..06fb74c 100644 > --- a/webservice/lib/tasks/checks.rake > +++ b/webservice/lib/tasks/checks.rake > @@ -24,7 +24,10 @@ def test_module name, package > end > > def test_version package, version > + old_lang = ENV['LANG'] > + ENV['LANG'] = 'C' > v = `rpm -q #{package}` > + ENV['LANG'] = old_lang > escape v, "install #{package} >= #{version}" if v =~ /is not installed/ > nvr = v.split "-" > rel = nvr.pop Isn't easier just use v = `LANG=C rpm -q #{package}` instead of this patch? less code is better code :) JR -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 2

[yast-devel] messing with /etc/PolicyKit/PolicyKit.conf
by Martin Vidner 10 Jul '09

10 Jul '09

Hi, jsrain is trying to get WebYaST running from git. In http://en.opensuse.org/YaST/Web/Development#Setup_permissions it says to edit PolicyKit.conf. Will this not confuse the permission handler? AFAIK it checks for explicit permissions only. I think there is a helper script that sets up the explicit permissions, right? How to call it? Also, at some time our scripts used to mess with PolicyKit.conf. RPMs must not do that. Is that removed by now? -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 3

[yast-devel] Implemented - rest-service and basic tests
by Josef Reidinger 09 Jul '09

09 Jul '09

Hi, short version: I implemented basic test in rest-service lib/plugin_basic_tests.rb and all it is fully documented by rdoc. long version: At first motivation why use this tests. At first this tests ensure that all modules react same on some general situation like no permission for action or send same mime type for xml and jason. At second it force better design for some modules which allow in future easier maintenance of that modules. Last but not least is that tests alone for my modules give 70% coverage (and I add only two lines of code to test). This tests require some prerequisites which is written in documentation. This prerequisites especially force usage controller as thin layer, that ensure only correct translation of parameters to model, behavior during exception and access restriction. Rest of functionality should be in model. As example of how controller and model should look is my modules time and language (both use this tests). As example how it should not look like (no offense, it is common problem, that controller contain almost every functionality) is patch module. I follow rails convention that for model filling is used find method and for storing is used save method. and getters/setters for attributes. I attach here text of documentation as rdoc task not working good for rest-service (you can generate it manually by rdoc lib/basic_plugin_tests.rb) [1]. I welcome any comments, questions and suggestions for another tests. Also some architect (Klaus, duncan) should look if expected behavior in test is what we really expect from module. [1]: PluginBasicTests module The module is designed to perform few basic tests of webservice plugin controller behavior. Its goal is provide same unify behavior to each webservice plugin like unified response if user doesn‘t have permissions or same content type. Prerequisites The module expect some hints from controller test file for correct work. It needs model class specified at @model_class field, controller instance at @controller and request specification at @request field. Controller is expected to be thin layer and all dbus or system call is done at model code. Controller use during reading only read motode of model and during writing only save method. Example usage This example show basic testing of controller of plugin require File.expand_path(File.dirname(__FILE__) + "/../test_helper") require 'test/unit' require 'rubygems' require 'mocha' require File.expand_path( File.join("lib","plugin_basic_tests"), RailsParent.parent ) class LanguageControllerTest < ActionController::TestCase fixtures :accounts def setup @model = Language @controller = LanguageController.new @request = ActionController::TestRequest.new # http://railsforum.com/viewtopic.php?id=1719 @request.session[:account_id] = 1 # defined in fixtures end include PluginBasicTests #another specific controller test like correct parsing arguments #or specific exceptions end -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 1

[yast-devel] WebYaST daily sync - 07/09/09
by Bjoern Geuken 09 Jul '09

09 Jul '09

WebYaST daily sync - 07/09/09 Status: ---------- Björn: - working on tests for status module Schubi: - gets access to rest service (status) - managed to get jquery working - will now collect data for web-client Klaus: - discussed ui with Micha yesterday. Tries to get design fo WebYast - looked at permission model Duncan: - finished upgrade of Hudson. Hudson is running - moved server to new serverroom - test suite doesn't pass yet Jiri: - no update Martin V.: - fixed on Bugs - sent mail to yast-devel(a)opensuse.org concerning dbus Martin Schmidkunz: - ui meeting with Klaus and Micha - sent mail and likes to have some feedback Joseph: - created basic test (mail) - try examples Michal: - test for systemtime - L3 incident -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] rest-plugin skeleton in yast2-devtools ?
by Klaus Kaempf 09 Jul '09

09 Jul '09

Hi, doing a 'svn up' in devtools pulled in a rest-plugin skeleton. While I applaud having a plugin skeleton for WebYaST rest-service, I wonder if yast2-devtools is the right place. Installing yast2-devtools requires a bunch of packages one never needs for Ruby on Rails development, e.g. libxslt, GNU autotools, or cmake. I'd rather place the skeleton at git.opensuse.org with a script to create a new plugin. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] TraditionalYaST: Check unsupported in/out paramter to Pkg::PkgUpdateAll (pkg-bindings,update_proposal.ycp,Wagon.ycp,???)
by Michael Andres 08 Jul '09

08 Jul '09

Hi! (in svn/yast/trunk) Pkg::PkgUpdateAll internally calls zypp::Resolver::doUpgrade to perform the distribution upgrade. Since 11.1 we're using libsatsolver for this and any provided input arguments are obsolete, and returned statistic values are fake (allways 0). Removing this outdated UpgradeStatistics stuff from libzypp, I found that some YCP code (update_proposal.ycp,Wagon.ycp) still passes options to Pkg::PkgUpdateAll (e.g. 'silent_downgrades') or evaluates values in the returned map (e.g. 'ProblemListSze'). I fixed Pkg::PkgUpdateAll to no longer refer to the UpgradeStatistics class, and so it now returns an empty map. (pkg-bindings-2.18.8) But the YCP code calling Pkg::PkgUpdateAll should be reviewed. Either those in/output values can be cleaned up, or we need to invent some substitute for the desired functionality (although no one seems to have missed something in code11). -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma(a)novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] D-Bus and Ruby
by Martin Vidner 08 Jul '09

08 Jul '09

I have posted a summary of my findings so far: http://mvidner.blogspot.com/2009/07/d-bus-and-ruby.html -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0