November 2009 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] <web-client> master : evaluate the state of each translation and suggest to delete it if it is unsufficent
by Martin Vidner 23 Nov '09

23 Nov '09

On Fri, Nov 20, 2009 at 07:15:02PM +0100, Stefan Schubert wrote: > ref: refs/heads/master > commit fec94faa8960f68547a1980ff6d4df634e31dd57 > Author: Stefan Schubert <schubi(a)suse.de> > Date: Fri Nov 20 19:15:02 2009 +0100 > > evaluate the state of each translation and suggest to delete it if it is unsufficent > --- > Rakefile | 24 ++++++++++++++++++++++++ > webclient/lib/tasks/gettext.rake | 27 +++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 0 deletions(-) > > diff --git a/Rakefile b/Rakefile > index 184c6cf..a1b8f72 100644 > --- a/Rakefile > +++ b/Rakefile NOOOOO!! You have hijacked the top level Rakefile to suit your particular specialized task. Please revert it and create the fetch_po task separately. > @@ -8,12 +8,36 @@ task :default => :test > > %w(fetch_po makemo updatepot test test:ui rdoc pgem package release install install_policies check_syntax package-local buildrpm buildrpm-local test:test:rcov).each do |task_name| > desc "Run #{task_name} task for all projects" > + > task task_name do > + if task_name == "fetch_po" > + #remove translation statistik > + File.delete(File.join("pot", "translation_status.yaml")) if File.exist?("pot/translation_status.yaml") > + end > + > PROJECTS.each do |project| > system %(cd #{project} && #{env} #{$0} #{task_name}) > raise "Error on execute task #{task_name} on #{project}" if $?.exitstatus != 0 > end > + > + if task_name == "fetch_po" > + #remove translations which have not at least 80 percent translated text > + limit = Float(80) Bonus points for a well hidden constant. It should be TRANSLATION_LIMIT = 80 near the top of the file. > + result = Hash.new > + result = YAML.load(File.open(File.join("pot", "translation_status.yaml"))) if File.exists?(File.join("pot", "translation_status.yaml")) > + result.each {|key,value| > + translated = un_translated = Float(0) > + translated = value["translated"].to_f if value.has_key? "translated" > + un_translated += value["untranslated"].to_f if value.has_key? "untranslated" > + un_translated += value["fuzzy"].to_f if value.has_key? "fuzzy" > + limit_eval = translated/(un_translated+translated) > + if limit_eval < limit/100 > + puts "Language #{key} should be deleted cause it has only #{(limit_eval*100).to_i} percent translation reached." > + end > + } > + end > end > + > end > > desc "Run doc to generate whole documentation" > diff --git a/webclient/lib/tasks/gettext.rake b/webclient/lib/tasks/gettext.rake > index 972de14..d0a00dc 100644 > --- a/webclient/lib/tasks/gettext.rake > +++ b/webclient/lib/tasks/gettext.rake -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] WebYaST status call 20-Nov-2009
by J. Daniel Schmidt 20 Nov '09

20 Nov '09

present: visnov, jsrain, schubi, kkaempf, bbrunner, dmacvicar, jreidinger, mvidner, lslezak, jdsn, jsuchomel stano: offers help for release process jreidinger: fixing bugs, esp. time and ntp mvidner: RC3 release will work on appliance docs jsrain: testing RC3 ladislav: work on bugs jsuchomel: work on bugs, RC3 testing kkaempf: RC3 testing, will enter his bugs dmacvicar: no updates bbrunner: RC3 testing, looking after status module issues schubi: fixed status module, search for solution for collectd bug jdsn: wrote script to create ssl certificate on service start will hook it to rc-script To everyone: - Please close your bugs as soon they are fixed. - Strict RC4 check-in deadline: Monday noon. Ciao, Daniel -- J. Daniel Schmidt <jdsn(a)suse.de> SUSE Linux Products GmbH Research & Development Maxfeldstr. 5 GF: Markus Rex, HRB 16746 (AG Nürnberg) D-90409 Nürnberg -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] Re: [yast-commit] <web-client> master : - control panel: skip the plugins without data (bnc#557131) - 0.0.16
by Martin Vidner 20 Nov '09

20 Nov '09

On Fri, Nov 20, 2009 at 09:46:13AM +0100, Jiri Suchomel wrote: > ref: refs/heads/master > commit d27da79f667358dd476c72324775d5ad0222f8ad > Author: Jiri Suchomel <jsuchome(a)suse.cz> > Date: Fri Nov 20 09:46:13 2009 +0100 > > - control panel: skip the plugins without data (bnc#557131) > - 0.0.16 > --- > webclient/app/views/controlpanel/index.rhtml | 1 + > webclient/package/yast2-webclient.changes | 6 ++++++ > webclient/package/yast2-webclient.spec | 2 +- > 3 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/webclient/app/views/controlpanel/index.rhtml b/webclient/app/views/controlpanel/index.rhtml > index d07fb56..a91590e 100644 > --- a/webclient/app/views/controlpanel/index.rhtml > +++ b/webclient/app/views/controlpanel/index.rhtml > @@ -66,6 +66,7 @@ > <div class="list-row overview"> > > <% @shortcuts.each do |name, data| %> > + <% next if data.nil? || data.empty? %> "next if data.blank?", see http://api.rubyonrails.org/classes/Object.html#M000279 But there is no test case. Because there is no model for the shortcuts. It is all in the controlpanel controller. Why should we deal with an empty shortcut? I don't like adding more (questionable) logic to code that is too complex already. Please simply remove the shortcut file instead (or rename to disabled-shortcut.yml). -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

2 1

[yast-devel] RC 4 upcoming
by Martin Vidner 20 Nov '09

20 Nov '09

Hi! the deadline is Monday noon. But be prepared for rejections, so submit sooner :) As we are getting close, stricter rules apply * include test cases * refer to bug numbers (and mark the bugs fixed) To make reviewing easier, mention the bug numbers everywhere: in code comments, in git commits (1st line), in osc commits, in osc sr's. * use this to check the real changes: git log --stat -- plugins/$MINE * submit to YaST:Web:STABLE osc sr YaST:Web $PKG YaST:Web:STABLE -- Martin Vidner, YaST developer http://www.flickr.com/photos/mikeb-photos/3177190505/sizes/m/ Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Just note about PATH in YaPI modules
by Josef Reidinger 19 Nov '09

19 Nov '09

I now find where is problem in NTP synchronization in RC3. It is problem that PATH in YaPI modules is not same as PATH for user root. So if you run any script or program from /usr/sbin or /sbin use full path to that script otherwise it is not found. Also I found that many YaPI modules doesn't log anything. Maybe it should be useful to add some logging to easier debugging customer issues. Thanks for attention Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast (language,time,basesystem,ntp) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 4

[yast-devel] Re: [yast-commit] <web-client> master : cleanup exception handling espl. not running collectd (bnc#555205)
by Josef Reidinger 19 Nov '09

19 Nov '09

Stefan Schubert write: > ref: refs/heads/master > commit 4ab44123fb323d1dd41e6616a80c1baeeae3d4ca > Author: Stefan Schubert <schubi(a)suse.de> > Date: Thu Nov 19 11:08:47 2009 +0100 > > cleanup exception handling espl. not running collectd (bnc#555205) > --- > .../status/app/controllers/status_controller.rb | 40 > ++++++++++++++----- 1 files changed, 29 insertions(+), 11 deletions(-) > > diff --git a/plugins/status/app/controllers/status_controller.rb > b/plugins/status/app/controllers/status_controller.rb index > 4936a53..ca521b8 100644 > --- a/plugins/status/app/controllers/status_controller.rb > +++ b/plugins/status/app/controllers/status_controller.rb > @@ -154,15 +154,24 @@ class StatusController < ApplicationController > > def index > return unless client_permissions > - > - log = YaST::ServiceResource.proxy_for('org.opensuse.yast.system.logs') > - @logs = log.find(:all) > - flash[:notice] = _("No data found for showing system status.") unless > create_data - limits_reached > - logger.debug "limits reached for #{@limits_list[:reached].inspect}" > + begin > + log = > YaST::ServiceResource.proxy_for('org.opensuse.yast.system.logs') + > @logs = log.find(:all) > + flash[:notice] = _("No data found for showing system status.") > unless create_data + limits_reached > + logger.debug "limits reached for #{@limits_list[:reached].inspect}" > + rescue ActiveResource::ServerError => error > + error_hash = Hash.from_xml error.response.body > + logger.warn error_hash.inspect > + if error_hash["error"] && > + (error_hash["error"]["type"] == "SERVICE_NOT_RUNNING" || > error_hash["error"]["type"] == "NO_PERM") + flash[:error] = > error_hash["error"]["description"] Hi, few notes. You can benefit here from clientException class, so you can use exception = ClinetException.new(error) if ["SERVICE_NOT_RUNNING","NO_PERM"].include? exception.backend_exception_type flash[:error] = exception.message #bonus you have localized message from ErrorConstructor class (just add localization string here) else ... end > + else > + raise error > + end > + end > end > > - > def show_summary > return unless client_permissions > begin > @@ -173,10 +182,19 @@ class StatusController < ApplicationController > status = _("No data found for showing system status.") > end > render :partial => "status_summary", :locals => { :status => status, > :error => nil } - rescue Exception => error > - erase_redirect_results #reset all redirects > - erase_render_results > - render :partial => "status_summary", :locals => { :status => nil, > :error => ClientException.new(error) } and return + rescue > ActiveResource::ClientError => error > + logger.warn error.inspect > + render :partial => "status_summary", :locals => { :status => nil, > :error => ClientException.new(error) } and return + rescue > ActiveResource::ServerError => error > + error_hash = Hash.from_xml error.response.body > + logger.warn error_hash.inspect > + if error_hash["error"] && > + (error_hash["error"]["type"] == "SERVICE_NOT_RUNNING" || > error_hash["error"]["type"] == "NO_PERM") + status = > error_hash["error"]["description"] same as above. Josef > + render :partial => "status_summary", :locals => { :status => > status, :error => nil } + else > + render :partial => "status_summary", :locals => { :status => > nil, :error => ClientException.new(error) } + end > end > end > -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast (language,time,basesystem,ntp) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1

[yast-devel] WebYaST (next) Possible user experience improvements
by Duncan Mac-Vicar Prett 19 Nov '09

19 Nov '09

Here is the list of improvements I would like to see in a future (after release) iteration. Some of them may have bugs already, others may not. I would like to get some feedback before making bugs reports. I hope also that we get more priority to make the core product great to use instead of the old- classic "add a module to configure foobar" (which is something ISVs should better do) *) System services: * collectd working... (running) start stop status * cron working... (running) start stop status * dbus working... (running) start stop status ... ... Isn't that too much to read? - I suggest to use a small icon to show if running or not), may be a slightly animated heartbeat (soft to the eyes). - Start and stop do not need to be separated, you can't have stop if it is not started, they can use the same state (toggle) so the text switches to stop after you start. - I did not understand the "status" link, for me it looks more than a "refresh" of the "running" text. This can be done by either having just one refresh link for all, or just poll the server for changes using ajax. *) Registration The text "regcode-sles". IIRC this is a limitation of the current stack because this text comes from suseRegister. So it can be fixed in the future and now is a known limitation and not a usability bug. *) Time The two comboboxes could be replaced with an interactive worldmap + a textbox to freewrite with autocompletion so you can either use mouse or keyboard. The textbox can also not be present at all. Also, I think for entering the date we should have a calendar input. We had one, but I see it is not longer there. *) Network A common problem of system managements applications is to accidentally expose the configuration file format :-) an example: Name servers : [_____________________] What I am suppose to enter there? It asks with plural, there is a single field. What is "prefixlen"? Also, I think this is reported, if you click next, settings are saved, if you are using DHCP your ip changes and^^^NO CARRIER Another issue that may apply to other modules too is to make the difference between the value that is retrieved from a textfield, to the value that is displayed when it is empty. The user may not know the meaning of an empty field. For example if using DHCP one could fill the nameservers field with "Will be auto discovered". This is also valid for fields that are not disabled, where a text for the empty state helps the user to make a meaning of the text being empty *) Mail settings If security is disabled, then username/password should be disabled. If the server is not configured, then even the security checkbox can be disabled too. *) Administrator password The 3 save buttons is confusing. IIRC kkaempf already reported this. It is confusing because this module has the ability of doing instant apply before clicking next, while network saves at "next" clicking time. "Forward mail to", what goes there? an email address? How the user guess that? he needs to think, which is what we want to avoid. Here it may useful to enter an example greyed text that dissapears when focus is on the field (the field value still could evaluate to empty) *) General - Maintainer easter-egg I have asked 150 times in irc "who is doing the X module?", therefore I suggest a easter egg keyboard shortcut that once pressed a hidden <div> at the bottom emerges, with a gravatar and name/login of the maintainer/s :-) plus a report bug link -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

4 3

[yast-devel] WebYaST status call 26-Oct-2009
by Stefan Schubert 19 Nov '09

19 Nov '09

participants: mvidner, schubi, jsuchome, mschmidkunz, jdsn, jsrain, kkaempf, dmacvicar, bbrunner mschmidkunz: - UI-Bug fixed - will fix time module bugs bbrunner: -reviewed and closed bugzilla entries dmacvicar: - checked bugzilla entries jsrain: will test appliance mvidner: - will releasing beta3 today - have sent an email "how to test an appliance" schubi: testing and bug fixing of rest-service module. First run has been successfully. Greetings Stefan -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

3 5

[yast-devel] Re: [yast-commit] <rest-service> master : fix default registration context, cleanup show templates
by Martin Vidner 18 Nov '09

18 Nov '09

On Sat, Nov 14, 2009 at 02:52:32AM +0100, J.Daniel Schmidt wrote: > ref: refs/heads/master > commit ab0b5faedefc16ca3523c2d4ed496b41741d17f3 > Author: J. Daniel Schmidt <jdsn(a)suse.de> > Date: Sat Nov 14 02:52:32 2009 +0100 > > fix default registration context, cleanup show templates > --- > > diff --git a/plugins/registration/app/views/registration/registration/show.html.erb b/plugins/registration/app/views/registration/registration/show.html.erb > index 50e8aac..bbba3c0 100644 > --- a/plugins/registration/app/views/registration/registration/show.html.erb > +++ b/plugins/registration/app/views/registration/registration/show.html.erb > @@ -1,11 +1 @@ > -<%= # @register == nil ? "@register is nil - FIXME" : @register.to_xml > - -%> > -<%= case @register.class.to_s > - when 'NilClass' > - "@register is nil" > - when 'String' > - @register.to_s > - when 'Register' > - @register.to_xml > - end > - -%> > +<%= @register.to_xml if @register -%> You should not claim HTML and send XML. Simply don't support HTML, the browsers show XML just fine. http://lists.opensuse.org/yast-devel/2009-10/msg00136.html -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Re: [yast-commit] <web-client> master : adjusted layout of edit users
by Josef Reidinger 18 Nov '09

18 Nov '09

Martin Schmidkunz write: > ref: refs/heads/master > commit 8eff8b208f34e489c539b3eb948856f7895702be > Author: Martin Schmidkunz <mschmidkunz(a)suse.de> > Date: Wed Nov 18 16:17:59 2009 +0100 > > adjusted layout of edit users > --- > .../permissions/app/views/permissions/index.rhtml | 2 +- > plugins/security/shortcuts.yml | 2 +- > plugins/users/app/views/users/edit.html.erb | 74 > +++++++++---------- 3 files changed, 37 insertions(+), 41 deletions(-) > > diff --git a/plugins/permissions/app/views/permissions/index.rhtml > b/plugins/permissions/app/views/permissions/index.rhtml index > 5869f3f..f459c4f 100644 > --- a/plugins/permissions/app/views/permissions/index.rhtml > +++ b/plugins/permissions/app/views/permissions/index.rhtml > @@ -155,8 +155,8 @@ > <br> > <% #not ready to set permissions submit_tag _("Set"), :disabled=> > !@right_set_permissions, :class => 'button' %> > - <a href="/" class="button"><%=_("Back")%></a> > <% end %> > + <%= form_send_buttons :disabled => disabled, :class => "button" %> Please don't use send buttons. In comment above code was said that permission module cannot set permission so save do nothing. Permission module is now only for viewing permissions for certain user. > <% end %> > </div> > </html> > diff --git a/plugins/security/shortcuts.yml > b/plugins/security/shortcuts.yml index d84e21e..a5a6db8 100644 > --- a/plugins/security/shortcuts.yml > +++ b/plugins/security/shortcuts.yml > @@ -2,7 +2,7 @@ main: > icon: '/icons/yast-firewall.png' > url: /security > groups: [ Network ] > - tags: [ security, access] > + tags: [ access, security ] > title: Firewall/SSH > description: Setting firewall and Secure Shell > > diff --git a/plugins/users/app/views/users/edit.html.erb > b/plugins/users/app/views/users/edit.html.erb index 6cbd33c..d7a178d > 100644 > --- a/plugins/users/app/views/users/edit.html.erb > +++ b/plugins/users/app/views/users/edit.html.erb > @@ -1,4 +1,4 @@ > -<h1><%=_("Edit User %s") %(a)user.uid%></h1> > +<h1><%=_("Edit user %s") %(a)user.uid%></h1> > <br> > > <% disabled = ! @permissions[:usermodify] %> > @@ -6,44 +6,40 @@ > <% form_for(:user, @user, :url => { :action => "update" }, :html => { > :method => :put } ) do |f| %> <%= f.error_messages %> > > - <div class="table"> > - <table class="list" cellpadding="0" cellspacing="0"> > - <tr> > - <th class="full" colspan="2"><%=_("User")%></th> > - </tr> > - <tr> > - <td class="first" width="120"><strong><%=_("Full Name")%></strong></td> > - <td class="last"><%= f.text_field :cn , :disabled => disabled %></td> > - </tr> > - <tr class="bg"> > - <td class="first"><strong><%=_("Groups")%></strong></td> > - <td class="last"><%= f.text_field :grp_string, :disabled => disabled > %></td> - </tr> > - <tr> > - <td class="first"><strong><%=_("Default Group")%></strong></td> > - <td class="last"><%= f.text_field :groupname, :disabled => disabled > %></td> - </tr> > - <tr class="bg"> > - <td class="first"><strong><%=_("Home Directory")%></strong></td> > - <td class="last"><%= f.text_field :home_directory, :disabled => disabled > %></td> - </tr> > - <tr> > - <td class="first"><strong><%=_("Login Shell")%></strong></td> > - <td class="last"><%= f.text_field :login_shell, :disabled => disabled > %></td> - </tr> > - <tr class="bg"> > - <td class="first"><strong><%=_("Login Name")%></strong></td> > - <td class="last"><%= f.text_field :uid, :disabled => disabled %></td> > - </tr> > - <tr> > - <td class="first"><strong><%=_("UID Number")%></strong></td> > - <td class="last"><%= f.text_field :uid_number , :disabled => disabled > %></td> - </tr> > - <tr class="bg"> > - <td class="first"><strong><%=_("Password")%></strong></td> > - <td class="last"><%= f.password_field :user_password, :disabled => > disabled %></td> - </tr> > - </table> > + <fieldset> > + <p> > + <label><%=_("Full Name")%></label> > + <%= f.text_field :cn , :disabled => disabled %> > + </p> > + <p> > + <label><%=_("Groups")%></label> > + <%= f.text_field :grp_string, :disabled => disabled %> > + </p> > + <p> > + <label><%=_("Default Group")%></label> > + <%= f.text_field :groupname, :disabled => disabled %> > + </p> > + <p> > + <label><%=_("Home Directory")%></label> > + <%= f.text_field :home_directory, :disabled => disabled %> > + </p> > + <p> > + <label><%=_("Login Shell")%></label> > + <%= f.text_field :login_shell, :disabled => disabled %> > + </p> > + <p> > + <label><%=_("Login Name")%></label> > + <%= f.text_field :uid, :disabled => disabled %> > + </p> > + <p> > + <label><%=_("UID Number")%></label> > + <%= f.text_field :uid_number , :disabled => disabled %> > + </p> > + <p> > + <label><%=_("Password")%></label> > + <%= f.password_field :user_password, :disabled => disabled %> > + </p> > + </fieldset> > <p><%= f.submit _("Update"), :disabled => disabled %><%= link_to > _('Back'), {:action => :index}, :onclick=>"$('#progress').show()", :class > => "button"%></p> </div> > <% end %> > -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast (language,time,basesystem,ntp) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 1