September 2012 - openSUSE Kernel - openSUSE Mailing Lists

Re: [opensuse-kernel][PATCH] hwmon: (applesmc) Shorten minimum wait time
by Al Cho 17 Sep '12

17 Sep '12

Hi Frankie, On Mon, Sep 17, 2012 at 4:36 AM, Frankie Onuonga <onuonga(a)live.com> wrote: > Hi guys, > I have a macbook pro and would like to help the community to solve this > problem you having here. > please let me know what you would like me to do and how I can be off > assistance. > Thanks for your help! May I know what version your Macbook Pro is ? and would you please help me to test the patch : hwmon-applesmc-Decode-and-act-on-read-write-status-c.patch ? and if you want try those patches: hwmon-applesmc-Decode-and-act-on-read-write-status-c.patch hwmon-applesmc-Shorten-minimum-wait-time.patch irq_remap-disable-IRQ-remapping-if-any-IOAPIC-lacks-.patch tg3-add-device-id-of-Apple-Thunderbolt-Ethernet-devi.patch I have a test version kernel here: https://build.opensuse.org/project/show?project=home%3Aacho-novell%3Abranch… Cheers, AL > > On Thu, Sep 13, 2012 at 8:46 AM, Al Cho <acho(a)suse.com> wrote: >> >> On Thu, Sep 13, 2012 at 3:16 PM, Jean Delvare <jdelvare(a)suse.de> wrote: >> > Le jeudi 13 septembre 2012 à 11:42 +0800, Al Cho a écrit : >> >> I will pick it to test on my machine, then push to opensuse-kernel, >> >> and I guess we may need more patches for hwmon(applesmc) or others. >> > >> > FWIW I checked all the applesmc patches since kernel v3.4 yesterday, and >> > the other patches do not seem to be needed. That being said, I don't >> > have any Mac machine to test the code, so I might be wrong. >> > >> >> Thanks a lot, >> so am I, that is my first time to get a Mac machine so I didn't know many >> thing >> about that ( even it's Intel Mac), and I would like to test each >> kernel patches for >> our kernel, so please let me know if any testing I can help. >> >> Cheer, >> AL >> -- >> To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org >> To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org >> > -- Al Yu-Chen Cho Software Engineer Room B, 26/F, No. 216 Tun-Hwa S. Road, Sec. 2 Taipei, 106 +8862-2376-0010 X20031 acho(a)suse.com SUSE -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org

1 0

[opensuse-kernel] [PATCH] hwmon: (applesmc) Decode and act on read/write status codes
by acho＠suse.com 17 Sep '12

17 Sep '12

From: Henrik Rydberg <rydberg(a)euromail.se> Subject: [PATCH] hwmon: (applesmc) Decode and act on read/write status codes Git-commit: 829917cd7246204d6c5f066c40b66d2b62d0930d Patch-mainline: v3.6-rc1~61^2 Reference: bnc#779487 Date: Fri, 27 Jul 2012 20:12:46 +0200 The behavior of the SMC has changed several times over the years, causing read failures in the driver. It seems the problem can be explained by a shift in SMC speed combined with improper action on status codes. We should first wait for the SMC to settle, which was the most frequent response on the old slow machines. Then, if the SMC is busy, we need to try again later by resending the command. This was the most likely response until 2012. Now, with a shorter wait time, we are again most likely to poll while the SMC is settling, and as a result we see high failure rates on many old and new models. With the distinction between busy and failure, we can also wait longer before retrying, without sacrificing speed. This seems to bring failures down to virtually zero on all models. Tested on: MBA1,1 MBA3,1 MBA5,1 MBA5,2 MBP9,2 Tested-by: Adam Somerville <adamsomerville(a)gmail.com> Tested-by: Hubert Eichner <hubert.georg.eichner(a)gmail.com> Signed-off-by: Henrik Rydberg <rydberg(a)euromail.se> Signed-off-by: Guenter Roeck <linux(a)roeck-us.net> Acked-by: Cho, Yu-Chen <acho(a)suse.com> --- drivers/hwmon/applesmc.c | 70 ++++++++++++++++++++++++++++++---------------- 1 files changed, 46 insertions(+), 24 deletions(-) diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 4d937a1..2827088 100644 --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -55,9 +55,9 @@ /* wait up to 32 ms for a status change. */ #define APPLESMC_MIN_WAIT 0x0010 +#define APPLESMC_RETRY_WAIT 0x0100 #define APPLESMC_MAX_WAIT 0x8000 -#define APPLESMC_STATUS_MASK 0x0f #define APPLESMC_READ_CMD 0x10 #define APPLESMC_WRITE_CMD 0x11 #define APPLESMC_GET_KEY_BY_INDEX_CMD 0x12 @@ -162,51 +162,68 @@ static unsigned int key_at_index; static struct workqueue_struct *applesmc_led_wq; /* - * __wait_status - Wait up to 32ms for the status port to get a certain value - * (masked with 0x0f), returning zero if the value is obtained. Callers must + * wait_read - Wait for a byte to appear on SMC port. Callers must * hold applesmc_lock. */ -static int __wait_status(u8 val) +static int wait_read(void) { + u8 status; int us; - - val = val & APPLESMC_STATUS_MASK; - for (us = APPLESMC_MIN_WAIT; us < APPLESMC_MAX_WAIT; us <<= 1) { udelay(us); - if ((inb(APPLESMC_CMD_PORT) & APPLESMC_STATUS_MASK) == val) + status = inb(APPLESMC_CMD_PORT); + /* read: wait for smc to settle */ + if (status & 0x01) return 0; } + pr_warn("wait_read() fail: 0x%02x\n", status); return -EIO; } /* - * special treatment of command port - on newer macbooks, it seems necessary - * to resend the command byte before polling the status again. Callers must - * hold applesmc_lock. + * send_byte - Write to SMC port, retrying when necessary. Callers + * must hold applesmc_lock. */ -static int send_command(u8 cmd) +static int send_byte(u8 cmd, u16 port) { + u8 status; int us; + + outb(cmd, port); for (us = APPLESMC_MIN_WAIT; us < APPLESMC_MAX_WAIT; us <<= 1) { - outb(cmd, APPLESMC_CMD_PORT); udelay(us); - if ((inb(APPLESMC_CMD_PORT) & APPLESMC_STATUS_MASK) == 0x0c) + status = inb(APPLESMC_CMD_PORT); + /* write: wait for smc to settle */ + if (status & 0x02) + continue; + /* ready: cmd accepted, return */ + if (status & 0x04) return 0; + /* timeout: give up */ + if (us << 1 == APPLESMC_MAX_WAIT) + break; + /* busy: long wait and resend */ + udelay(APPLESMC_RETRY_WAIT); + outb(cmd, port); } + + pr_warn("send_byte(0x%02x, 0x%04x) fail: 0x%02x\n", cmd, port, status); return -EIO; } +static int send_command(u8 cmd) +{ + return send_byte(cmd, APPLESMC_CMD_PORT); +} + static int send_argument(const char *key) { int i; - for (i = 0; i < 4; i++) { - outb(key[i], APPLESMC_DATA_PORT); - if (__wait_status(0x04)) + for (i = 0; i < 4; i++) + if (send_byte(key[i], APPLESMC_DATA_PORT)) return -EIO; - } return 0; } @@ -219,11 +236,14 @@ static int read_smc(u8 cmd, const char *key, u8 *buffer, u8 len) return -EIO; } - outb(len, APPLESMC_DATA_PORT); + if (send_byte(len, APPLESMC_DATA_PORT)) { + pr_warn("%.4s: read len fail\n", key); + return -EIO; + } for (i = 0; i < len; i++) { - if (__wait_status(0x05)) { - pr_warn("%.4s: read data fail\n", key); + if (wait_read()) { + pr_warn("%.4s: read data[%d] fail\n", key, i); return -EIO; } buffer[i] = inb(APPLESMC_DATA_PORT); @@ -241,14 +261,16 @@ static int write_smc(u8 cmd, const char *key, const u8 *buffer, u8 len) return -EIO; } - outb(len, APPLESMC_DATA_PORT); + if (send_byte(len, APPLESMC_DATA_PORT)) { + pr_warn("%.4s: write len fail\n", key); + return -EIO; + } for (i = 0; i < len; i++) { - if (__wait_status(0x04)) { + if (send_byte(buffer[i], APPLESMC_DATA_PORT)) { pr_warn("%s: write data fail\n", key); return -EIO; } - outb(buffer[i], APPLESMC_DATA_PORT); } return 0; -- 1.7.7 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org

1 0

[opensuse-kernel] Re: [opensuse-factory] segfault on zypper dup completion
by Cristian Rodríguez 16 Sep '12

16 Sep '12

El 29/08/12 12:43, Felix Miata escribió: >> [ 475.004020] ------------[ cut here ]------------ >> [ 475.004041] WARNING: at >> /home/abuild/rpmbuild/BUILD/kernel-desktop-3.4.2/linux-3.4/net/sched/sch_generic.c:256 >> >> dev_watchdog+0x1e8/0x200() >> [ 475.004046] Hardware name: >> [ 475.004049] NETDEV WATCHDOG: eth0 (e100): transmit queue 0 timed out >> [ 475.004052] Modules linked in: snd_pcm_oss snd_mixer_oss snd_seq >> snd_seq_device nfsd nfs lockd fscache auth_rpcgss nfs_acl sunrpc dm_mod >> sr_mod snd_intel8x0 cdrom snd_ac97_codec ac97_bus snd_pcm snd_timer snd >> soundcore snd_page_alloc iTCO_wdt iTCO_vendor_support microcode pcspkr >> e100 >> i2c_i801 shpchp pci_hotplug floppy i915 drm_kms_helper drm >> i2c_algo_bit video >> button scsi_dh_rdac scsi_dh_alua scsi_dh_hp_sw scsi_dh_emc scsi_dh fan >> processor thermal thermal_sys ata_generic ata_piix sata_sil >> [ 475.004113] Pid: 0, comm: swapper/0 Not tainted 3.4.2-1-desktop #1 >> [ 475.004117] Call Trace: >> [ 475.004138] [<c02054b9>] try_stack_unwind+0x199/0x1b0 >> [ 475.004149] [<c02041d7>] dump_trace+0x47/0xf0 >> [ 475.004155] [<c020551b>] show_trace_log_lvl+0x4b/0x60 >> [ 475.004161] [<c0205548>] show_trace+0x18/0x20 >> [ 475.004169] [<c06f02fe>] dump_stack+0x6d/0x72 >> [ 475.004178] [<c0233188>] warn_slowpath_common+0x78/0xb0 >> [ 475.004185] [<c0233253>] warn_slowpath_fmt+0x33/0x40 >> [ 475.004194] [<c0636ef8>] dev_watchdog+0x1e8/0x200 >> [ 475.004204] [<c0240808>] run_timer_softirq+0xf8/0x300 >> [ 475.004211] [<c02398a1>] __do_softirq+0x81/0x1b0 >> [ 475.004217] [<c02040b6>] do_softirq+0x76/0xb0 >> [ 475.004224] ---[ end trace e91e2e809858261d ]--- >> [ 475.021328] e100 0000:01:02.0: eth0: NIC Link is Up 100 Mbps Full >> Duplex >> [ 2774.999044] end_request: I/O error, dev fd0, sector 0 >> [ 3268.406459] udevd[12045]: starting version 182 >> [ 4264.313985] nfsd: last server has exited, flushing export cache >> [ 4269.974101] NFSD: Using /var/lib/nfs/v4recovery as the NFSv4 state >> recovery directory >> [ 4269.974153] NFSD: starting 90-second grace period >> [ 4875.923898] zypper[2291]: segfault at 0 ip 08140fd8 sp bfcdcd80 >> error 4 in >> zypper[8048000+151000] Well.. that's a kernel bug, zypper not at fault. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org

2 1

[opensuse-kernel][PATCH] hwmon: (applesmc) Shorten minimum wait time
by Cho, Yu-Chen 13 Sep '12

13 Sep '12

From: Henrik Rydberg <rydberg(a)euromail.se> Subject: [PATCH] hwmon: (applesmc) Shorten minimum wait time Git-commit: a332bf9a65ab34b01226ed177f6937af843c8465 Patch-mainline: v3.6-rc1~120^2~4 Reference: bnc#779487 Date: Mon, 9 Jul 2012 12:10:26 +0200 The 2012 series of MacBooks have a faster SMC, and the current driver timings do not work at all. Tests show that decreasing the minimum wait time, from 64 us to 16 us, works well. Since this is still larger than the original minimum of 10 us used before 2008, there is nothing inherently problematic with changing it. The fail frequency on older machines seems to increase slightly, but not enough to be noticeable. Tested on MBA11, MBA31, MBA5,2, MBP9,2. The patch was originally written by adamski99 (ubuntuforums.org) and later tested by janhouse (bbs.archlinux.org). Signed-off-by: Henrik Rydberg <rydberg(a)euromail.se> Signed-off-by: Guenter Roeck <linux(a)roeck-us.net> Acked-by: Cho, Yu-Chen <acho(a)suse.com> --- drivers/hwmon/applesmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 0162f55..f41585e 100644 --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -54,7 +54,7 @@ #define APPLESMC_MAX_DATA_LENGTH 32 /* wait up to 32 ms for a status change. */ -#define APPLESMC_MIN_WAIT 0x0040 +#define APPLESMC_MIN_WAIT 0x0010 #define APPLESMC_MAX_WAIT 0x8000 #define APPLESMC_STATUS_MASK 0x0f -- 1.7.7 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org

3 4

[opensuse-kernel] Request
by Andres Silva 13 Sep '12

13 Sep '12

I recently purchased a new laptop. It brings a multitouch trackpad made by Sentelic. It is called the Sentelic Sensin Pad. It supports some nice multitouch gestures, for example, pinch to zoom. It seems though that the sensing pad is not recognized properly. It does two finger scrolling very roughly. Sometimes, it maps two fingers instead of one, and it does not scroll but move the pointer through the screen to where the other finger is. Can you take a look into the driver that controls this touchpad to make the recognition better? Could this also do pinch to zoom? Thank you Andy (anditosan) PS: Attached is a screenshot of how KDE recognizes this device.

1 0

[opensuse-kernel] zcache=deflate needs CONFIG_CRYPTO_DEFLATE=y
by Cristian Rodríguez 12 Sep '12

12 Sep '12

Hi: In current openSUSE kernels one cannot use zcache=deflate, only the default LZO unless CONFIG_CRYPTO_DEFLATE is set to Y. Will be cool if this can be changed in the future. Thanks. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org

2 4

[opensuse-kernel] [PATCH] ARM fixup build of tegra flavor
by Dirk Müller 11 Sep '12

11 Sep '12

Hi, tegra needs a bit more tweaking to build with 3.6rc5. Please apply. TIA, Dirk

1 1

[opensuse-kernel] [ARM] enable zcache
by Dirk Müller 11 Sep '12

11 Sep '12

Hi, this enables zcache in the config for ARM, as it could be useful there (memory pressure is often high). Thanks, Dirk

2 2

[opensuse-kernel] [PATCH] fix kernel-tegra build
by Dirk Müller 11 Sep '12

11 Sep '12

Hi, the patch below fixes build for kernel-tegra. Please apply TIA, Dirk

2 1

[opensuse-kernel] [PATCH] fix build of kernel-omap2plus
by Dirk Müller 11 Sep '12

11 Sep '12

Hi, the patch below removes some optional parts from kernel-omap2plus to fix the build of 3.6rc5. Please apply. TIA, Dirk

2 1