December 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 3d4ddf: Create resourceful routes for sub controllers of p...
by Björn Geuken 18 Dec '18

18 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3d4ddf78d0123ed64ed6dde7c4362aca148f2b82 https://github.com/openSUSE/open-build-service/commit/3d4ddf78d0123ed64ed6d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-16 (Sun, 16 Dec 2018) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/projects/meta/show.html.erb M src/api/app/views/webui/projects/rebuild_times/show.html.erb M src/api/app/views/webui/repositories/state.html.haml M src/api/app/views/webui2/webui/projects/meta/show.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.html.haml M src/api/app/views/webui2/webui/projects/rebuild_times/show.html.haml M src/api/app/views/webui2/webui/repositories/state.html.haml M src/api/config/routes.rb M src/api/spec/bootstrap/features/webui/repositories_spec.rb M src/api/spec/controllers/webui/projects/meta_controller_spec.rb M src/api/spec/controllers/webui/projects/rebuild_times_controller_spec.rb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Create resourceful routes for sub controllers of project controller We keep the old routes for compatibility reasons. Commit: ab8dc0fbad32495d40755c96857ba6b6654a8d71 https://github.com/openSUSE/open-build-service/commit/ab8dc0fbad32495d40755… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-16 (Sun, 16 Dec 2018) Changed paths: M src/api/app/views/webui/project/_tabs.html.erb Log Message: ----------- Convert hash rockets to symbolized form Commit: 172acac7c9556eae326217b5d64c5f77a739f322 https://github.com/openSUSE/open-build-service/commit/172acac7c9556eae32621… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui/project/_tabs.html.erb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/projects/meta/show.html.erb M src/api/app/views/webui/projects/rebuild_times/show.html.erb M src/api/app/views/webui/repositories/state.html.haml M src/api/app/views/webui2/webui/projects/meta/show.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.html.haml M src/api/app/views/webui2/webui/projects/rebuild_times/show.html.haml M src/api/app/views/webui2/webui/repositories/state.html.haml M src/api/config/routes.rb M src/api/spec/bootstrap/features/webui/repositories_spec.rb M src/api/spec/controllers/webui/projects/meta_controller_spec.rb M src/api/spec/controllers/webui/projects/rebuild_times_controller_spec.rb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Merge pull request #6517 from bgeuken/resourceful_routing_for_pulse Use resourceful routing Compare: https://github.com/openSUSE/open-build-service/compare/40219b038be7...172ac… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] be95e0: Move the flag calculation into a model
by Ana María Martínez Gómez 18 Dec '18

18 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: be95e084321842be715ffbfb8d637e7ce7369abd https://github.com/openSUSE/open-build-service/commit/be95e084321842be715ff… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-16 (Sun, 16 Dec 2018) Changed paths: M src/api/app/controllers/webui2/repositories_controller.rb M src/api/app/helpers/webui/repository_helper.rb M src/api/app/mixins/get_flags.rb M src/api/app/models/flag.rb A src/api/app/models/flag/specified_flags.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/project.rb M src/api/app/views/webui2/shared/_flag_popover.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml Log Message: ----------- Move the flag calculation into a model To make the webui code we did for repositories controller also useful for the API to avoid having 2 ways for the same Commit: 2a27c17c9d2285ad7b18358ee364e4a584e09166 https://github.com/openSUSE/open-build-service/commit/2a27c17c9d2285ad7b183… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-16 (Sun, 16 Dec 2018) Changed paths: M src/api/app/helpers/flag_helper.rb M src/api/app/models/flag.rb Log Message: ----------- Use Flag::SpecifiedFlags to replace 2 more functions Commit: 40219b038be747f07bb81129a37b647d0b19fc69 https://github.com/openSUSE/open-build-service/commit/40219b038be747f07bb81… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/controllers/webui2/repositories_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/webui/repository_helper.rb M src/api/app/mixins/get_flags.rb M src/api/app/models/flag.rb A src/api/app/models/flag/specified_flags.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/project.rb M src/api/app/views/webui2/shared/_flag_popover.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml Log Message: ----------- Merge pull request #6626 from coolo/remove_expand_flags2 Harmonize flag calculation code between api and bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/8df3b55686da...40219… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] c7a98b: Report the right status report
by Björn Geuken 18 Dec '18

18 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c7a98b6b924bb5fbd79949d86f66d24d47dd5580 https://github.com/openSUSE/open-build-service/commit/c7a98b6b924bb5fbd7994… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Report the right status report :report_uuid is mandatory but wasn't used in the controller. Instead it always returned .first - for unknown reason Fixes https://github.com/openSUSE/open-build-service/issues/6124 Commit: 8df3b55686da3805df4367b3ed79a2dcab5a84cf https://github.com/openSUSE/open-build-service/commit/8df3b55686da3805df436… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Merge pull request #6636 from coolo/fix_6124 Report the right status report Compare: https://github.com/openSUSE/open-build-service/compare/dfa42b359acc...8df3b… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] fecef2: Cleanup breadcrumb CSS
by Stephan Kulow 18 Dec '18

18 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: fecef2ec2a47b73c0eae8e080468c3a6316d055d https://github.com/openSUSE/open-build-service/commit/fecef2ec2a47b73c0eae8… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/breadcrumbs-component.scss M src/api/app/views/webui2/webui/main/_breadcrumb_items.html.haml Log Message: ----------- Cleanup breadcrumb CSS Style any link within the breadcrumbs the same, regardless of having the 'breadcrumb-item' class or not. This is just a follow up of #6592 which was already merged when I realized that the CSS could be written in a simpler way. Commit: dfa42b359accac9bb35c5504f2e7bb8bf25c9d8f https://github.com/openSUSE/open-build-service/commit/dfa42b359accac9bb35c5… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/breadcrumbs-component.scss M src/api/app/views/webui2/webui/main/_breadcrumb_items.html.haml Log Message: ----------- Merge pull request #6635 from bgeuken/cleanup_breadcrumb_css Cleanup breadcrumb CSS Compare: https://github.com/openSUSE/open-build-service/compare/47ab53fd2b89...dfa42… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by coolo 18 Dec '18

18 Dec '18

Branch: refs/heads/depfu/update/srcapi/autoprefixer-rails-9.4.3 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 550001: Update autoprefixer-rails to version 9.4.3
by Stephan Kulow 18 Dec '18

18 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 550001fba6251d41502d10b25d0480821a4af0ad https://github.com/openSUSE/open-build-service/commit/550001fba6251d41502d1… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update autoprefixer-rails to version 9.4.3 Commit: 47ab53fd2b89144f859c60c0b5f6508052131f09 https://github.com/openSUSE/open-build-service/commit/47ab53fd2b89144f859c6… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6652 from openSUSE/depfu/update/srcapi/autoprefixer-rails-9.4.3 [src/api] Update autoprefixer-rails: 9.4.2 → 9.4.3 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/b9f073f86c1e...47ab5… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 693852: Move rendering flags into flag helper
by Victor Pereira 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 693852490e4f6f743d6afb44d28c6a680085801d https://github.com/openSUSE/open-build-service/commit/693852490e4f6f743d6af… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/helpers/flag_helper.rb M src/api/app/views/models/_package.xml.builder M src/api/app/views/models/_project.xml.builder Log Message: ----------- Move rendering flags into flag helper Fetch the loops in one go and group_by in ruby (not to be confused by group, which translates to 'GROUP BY'), so that we can prefetch all architectures for all flags in one go, which translates into 2 queries - where we had up N+1 queries for architectures and up to 2 queries per flag type Also share this improvement directly between package and project Co-authored-by: Ana María Martínez Gómez <ammartinez(a)suse.de> Commit: b9f073f86c1e9cc50631aaf3055f6609b291af9e https://github.com/openSUSE/open-build-service/commit/b9f073f86c1e9cc50631a… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/helpers/flag_helper.rb M src/api/app/views/models/_package.xml.builder M src/api/app/views/models/_project.xml.builder Log Message: ----------- Merge pull request #6634 from coolo/optimtize_flags_rendering Just fetch the flags and check if they are empty afterwards Compare: https://github.com/openSUSE/open-build-service/compare/1e9d3d37784c...b9f07… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8c89c9: Avoid .required? function in loops
by Victor Pereira 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8c89c9a080ba4ef803548a3f61eabbfdf7612006 https://github.com/openSUSE/open-build-service/commit/8c89c9a080ba4ef803548… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/views/status/checks/_check.xml.builder M src/api/app/views/status/checks/show.xml.builder M src/api/app/views/status/reports/show.xml.builder Log Message: ----------- Avoid .required? function in loops The check's required function actually checks the checkable of the status_report, which is rather expensive SELECT `status_reports`.* FROM `status_reports` WHERE `status_reports`.`id` = 32 LIMIT 1 [["id", 32], ["LIMIT", 1]] SELECT `repositories`.* FROM `repositories` WHERE `repositories`.`id` = 342446 LIMIT 1 [["id", 342446], ["LIMIT", 1]] And this is done for every check in the report. While we already know the checkable (the repository), so just pass it to the partial. Commit: 1e9d3d37784c13ee1f17334951cf3644fcae3eed https://github.com/openSUSE/open-build-service/commit/1e9d3d37784c13ee1f173… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/views/status/checks/_check.xml.builder M src/api/app/views/status/checks/show.xml.builder M src/api/app/views/status/reports/show.xml.builder Log Message: ----------- Merge pull request #6637 from coolo/enhance_render_status_check Avoid .required? function in loops Compare: https://github.com/openSUSE/open-build-service/compare/f9c2ab1a829a...1e9d3… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 1456a3: Add gpg key and ssl certificate modal
by Victor Pereira 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1456a3fe2671d4fdceaf8c71669ca37f5c646319 https://github.com/openSUSE/open-build-service/commit/1456a3fe2671d4fdceaf8… Author: David Kang <dkang(a)suse.com> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/bottom_actions/_gpg_key_ssl_certificate.html.haml M src/api/app/views/webui2/webui/project/bottom_actions/_modify_project.html.haml Log Message: ----------- Add gpg key and ssl certificate modal Commit: ef2a1d55d242d972577d756039928a40030a2fa3 https://github.com/openSUSE/open-build-service/commit/ef2a1d55d242d972577d7… Author: David Kang <dkang(a)suse.com> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: R src/api/spec/cassettes/Bootstrap_Projects/DoD_Repositories/adding_DoD_repositories_via_meta_editor.yml M src/api/spec/cassettes/Bootstrap_Projects/branching/a_non-existing_package.yml R src/api/spec/cassettes/Bootstrap_Projects/branching/a_package_with_disabled_access_flag.yml R src/api/spec/cassettes/Bootstrap_Projects/branching/a_package_with_disabled_sourceaccess_flag.yml R src/api/spec/cassettes/Bootstrap_Projects/branching/an_existing_package_to_an_invalid_target_package_or_project.yml M src/api/spec/cassettes/Bootstrap_Projects/changing_project_title_and_description.yml M src/api/spec/cassettes/Bootstrap_Projects/creating_packages_in_projects_owned_by_user_eg_home_projects/with_valid_data.yml M src/api/spec/cassettes/Bootstrap_Watchlists/add_projects_to_watchlist.yml M src/api/spec/cassettes/Bootstrap_Watchlists/remove_projects_from_watchlist.yml Log Message: ----------- Update cassettes because KeyInfo make a call to the backend Commit: f9c2ab1a829a4547e19d81b7ca4f262b4d800729 https://github.com/openSUSE/open-build-service/commit/f9c2ab1a829a4547e19d8… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/bottom_actions/_gpg_key_ssl_certificate.html.haml M src/api/app/views/webui2/webui/project/bottom_actions/_modify_project.html.haml R src/api/spec/cassettes/Bootstrap_Projects/DoD_Repositories/adding_DoD_repositories_via_meta_editor.yml M src/api/spec/cassettes/Bootstrap_Projects/branching/a_non-existing_package.yml R src/api/spec/cassettes/Bootstrap_Projects/branching/a_package_with_disabled_access_flag.yml R src/api/spec/cassettes/Bootstrap_Projects/branching/a_package_with_disabled_sourceaccess_flag.yml R src/api/spec/cassettes/Bootstrap_Projects/branching/an_existing_package_to_an_invalid_target_package_or_project.yml M src/api/spec/cassettes/Bootstrap_Projects/changing_project_title_and_description.yml M src/api/spec/cassettes/Bootstrap_Projects/creating_packages_in_projects_owned_by_user_eg_home_projects/with_valid_data.yml M src/api/spec/cassettes/Bootstrap_Watchlists/add_projects_to_watchlist.yml M src/api/spec/cassettes/Bootstrap_Watchlists/remove_projects_from_watchlist.yml Log Message: ----------- Merge pull request #6638 from DavidKang/fix-gpg Add gpg key and ssl certificate modal Compare: https://github.com/openSUSE/open-build-service/compare/4758eee2be32...f9c2a… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8eb8b4: Remove Refresh button from requests page in bootst...
by Björn Geuken 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8eb8b4941b202bb333f3360f4136bdf128f3effa https://github.com/openSUSE/open-build-service/commit/8eb8b4941b202bb333f33… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/views/webui2/shared/_requests_table.html.haml Log Message: ----------- Remove Refresh button from requests page in bootstrap When we set some filters in requests' page and then click on Refresh, all the filters get reset (back to default values). We also realized that the Refresh functionality is not really needed. Therefore, we decide to remove the button. Commit: 4758eee2be328dfa59a884c8df02171c93897b72 https://github.com/openSUSE/open-build-service/commit/4758eee2be328dfa59a88… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/views/webui2/shared/_requests_table.html.haml Log Message: ----------- Merge pull request #6651 from saraycp/remove_refresh Remove Refresh button from requests page in bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/6f3575c3500f...4758e… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0