Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8c89c9a080ba4ef803548a3f61eabbfdf7612006 https://github.com/openSUSE/open-build-service/commit/8c89c9a080ba4ef803548a... Author: Stephan Kulow Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/views/status/checks/_check.xml.builder M src/api/app/views/status/checks/show.xml.builder M src/api/app/views/status/reports/show.xml.builder Log Message: ----------- Avoid .required? function in loops The check's required function actually checks the checkable of the status_report, which is rather expensive SELECT `status_reports`.* FROM `status_reports` WHERE `status_reports`.`id` = 32 LIMIT 1 [["id", 32], ["LIMIT", 1]] SELECT `repositories`.* FROM `repositories` WHERE `repositories`.`id` = 342446 LIMIT 1 [["id", 342446], ["LIMIT", 1]] And this is done for every check in the report. While we already know the checkable (the repository), so just pass it to the partial. Commit: 1e9d3d37784c13ee1f17334951cf3644fcae3eed https://github.com/openSUSE/open-build-service/commit/1e9d3d37784c13ee1f1733... Author: Victor Pereira Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/views/status/checks/_check.xml.builder M src/api/app/views/status/checks/show.xml.builder M src/api/app/views/status/reports/show.xml.builder Log Message: ----------- Merge pull request #6637 from coolo/enhance_render_status_check Avoid .required? function in loops Compare: https://github.com/openSUSE/open-build-service/compare/f9c2ab1a829a...1e9d3d... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.