Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 18511b770e575cd4a4335d03ba5ff9e69dca6dd0
https://github.com/openSUSE/open-build-service/commit/18511b770e575cd4a4335…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/app/models/comment.rb
R src/api/app/models/comment_package.rb
R src/api/app/models/comment_project.rb
R src/api/app/models/comment_request.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
A src/api/db/migrate/20161115094035_add_commentable_to_comments.rb
M src/api/db/structure.sql
Log Message:
-----------
[api] Make comment class polymorphic
I introduced the migration and the relations needed to make the Comment
model polymorphic. I eliminated the CommentPackage, CommentProject and
CommentRequest models as they are not longer needed and I moved their
methods to the Comment model. I also removed the check_is_child
validation in Comment as it doesn't make sense now.
Commit: 72c105cc08a7362335537891b548648dbc48f0d4
https://github.com/openSUSE/open-build-service/commit/72c105cc08a7362335537…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
A src/api/db/migrate/20161122121211_move_comments_data.rb
M src/api/db/structure.sql
Log Message:
-----------
[api] Migration to use the old comments
Add a migration which moves all the comment's data to use the relatation
instroduced in e34e4156b628c6f1c0307b961da9fa290bdf99c6 That allows to
use the old comments.
Note that comments are only save if all the data can me moved. If not
the migration will fail.
Commit: 5c1acdb2f5c943e605c2eece309adfcbfa68e181
https://github.com/openSUSE/open-build-service/commit/5c1acdb2f5c943e605c2e…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
A src/api/db/migrate/20161122123708_remove_old_relations_from_comments.rb
M src/api/db/structure.sql
Log Message:
-----------
[api] Remove unused columns in comments table
Remove the old relations and columns from the comments table, as after
moving the data in 984b89c1303155c0eb663332861094e20f83494b they are not
needed any more.
Commit: 712437586c1fea06e2689314fab9c74d93b4593a
https://github.com/openSUSE/open-build-service/commit/712437586c1fea06e2689…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
M src/api/app/models/comment.rb
Log Message:
-----------
[api] Refactor Comment#involved_users
Commit: 86d76618e808b84e3d0811ee8c4c39a71bee77b6
https://github.com/openSUSE/open-build-service/commit/86d76618e808b84e3d081…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
M src/api/test/fixtures/comments.yml
M src/api/test/functional/webui/request_controller_test.rb
M src/api/test/unit/comment_test.rb
Log Message:
-----------
[api] Fix old tests for new comments relations
Fix old tests to use the new relations for comments.
Commit: 0b6eee979965413b0241724241d50fe0ab68e4f8
https://github.com/openSUSE/open-build-service/commit/0b6eee979965413b02417…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
R src/api/spec/factories/comment_packages.rb
R src/api/spec/factories/comment_projects.rb
R src/api/spec/factories/comment_requests.rb
A src/api/spec/factories/comments.rb
M src/api/spec/features/webui/comments_spec.rb
M src/api/spec/mailers/event_mailer_spec.rb
M src/api/spec/models/comment_spec.rb
Log Message:
-----------
[api] Fix Rspec for new comments relations
Fix Rspec to use the new relations for comments.
Commit: f31abc1726ca0142268cf94383faf377ae4ce550
https://github.com/openSUSE/open-build-service/commit/f31abc1726ca0142268cf…
Author: Henne Vogelsang <hvogel(a)opensuse.org>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/app/models/comment.rb
R src/api/app/models/comment_package.rb
R src/api/app/models/comment_project.rb
R src/api/app/models/comment_request.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
A src/api/db/migrate/20161115094035_add_commentable_to_comments.rb
A src/api/db/migrate/20161122121211_move_comments_data.rb
A src/api/db/migrate/20161122123708_remove_old_relations_from_comments.rb
M src/api/db/structure.sql
R src/api/spec/factories/comment_packages.rb
R src/api/spec/factories/comment_projects.rb
R src/api/spec/factories/comment_requests.rb
A src/api/spec/factories/comments.rb
M src/api/spec/features/webui/comments_spec.rb
M src/api/spec/mailers/event_mailer_spec.rb
M src/api/spec/models/comment_spec.rb
M src/api/test/fixtures/comments.yml
M src/api/test/functional/webui/request_controller_test.rb
M src/api/test/unit/comment_test.rb
Log Message:
-----------
Merge pull request #2348 from Ana06/comment_polymorphic
[api] Make comment class polymorphic
Compare: https://github.com/openSUSE/open-build-service/compare/264b026bf9e7...f31ab…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: df357bdad280c265ab9a5136285278caa4c461c1
https://github.com/openSUSE/open-build-service/commit/df357bdad280c265ab9a5…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/controllers/application_controller.rb
M src/api/app/controllers/build_controller.rb
M src/api/app/controllers/person_controller.rb
M src/api/app/controllers/webui/monitor_controller.rb
M src/api/app/controllers/webui/patchinfo_controller.rb
M src/api/app/controllers/webui/search_controller.rb
M src/api/app/jobs/project_status_calculator.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/bs_request_action_maintenance_incident.rb
M src/api/app/models/event_find_subscribers.rb
M src/api/app/models/package.rb
M src/api/app/models/package_build_status.rb
M src/api/app/models/project.rb
M src/api/app/models/unregistered_user.rb
M src/api/config/deploy.rb
M src/api/lib/wizard.rb
M src/api/test/functional/source_controller_test.rb
M src/api/test/functional/webui/attributes_test.rb
M src/api/test/functional/webui/spider_test.rb
Log Message:
-----------
[ci] Enable Style/NegatedIf Rubocop cop
Enable Style/NegatedIf Robocop cop and solve the offenses.
This cop checks for uses of if with a negated condition. Only ifs
without else are considered.
Commit: 2aec968a1f9e418ad467a2fad87454b2aef156a0
https://github.com/openSUSE/open-build-service/commit/2aec968a1f9e418ad467a…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/controllers/application_controller.rb
M src/api/app/controllers/build_controller.rb
M src/api/app/controllers/person_controller.rb
M src/api/app/controllers/webui/monitor_controller.rb
M src/api/app/controllers/webui/patchinfo_controller.rb
M src/api/app/controllers/webui/search_controller.rb
M src/api/app/jobs/project_status_calculator.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/bs_request_action_maintenance_incident.rb
M src/api/app/models/event_find_subscribers.rb
M src/api/app/models/package.rb
M src/api/app/models/package_build_status.rb
M src/api/app/models/project.rb
M src/api/app/models/unregistered_user.rb
M src/api/config/deploy.rb
M src/api/lib/wizard.rb
M src/api/test/functional/source_controller_test.rb
M src/api/test/functional/webui/attributes_test.rb
M src/api/test/functional/webui/spider_test.rb
Log Message:
-----------
Merge pull request #2395 from Ana06/negated_if
[ci] Enable Style/NegatedIf Rubocop cop
Compare: https://github.com/openSUSE/open-build-service/compare/17f51a782af7...2aec9…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 929c57049665fa059817ae2b00df3248b2d3cdec
https://github.com/openSUSE/open-build-service/commit/929c57049665fa059817a…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
M src/api/lib/tasks/sprites.rake
Log Message:
-----------
Change the resprite task to not add .css
Change the resprite task to not add `.css` to the generated `.scss`
style file as it deprecated and unnecessary.
Commit: 216895cdac10269ffa917723667efcd55c2b9474
https://github.com/openSUSE/open-build-service/commit/216895cdac10269ffa917…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
A src/api/app/assets/icons/drive-optical-32.png
A src/api/app/assets/icons/drive-optical-48.png
M src/api/app/assets/images/icons_sprite.png
M src/api/app/assets/stylesheets/webui/application/icons.scss
M src/api/app/views/webui/image_templates/index.html.haml
M src/api/app/views/webui/main/index.html.erb
Log Message:
-----------
[api] Better icon for image templates
Find better icon for image templates and then fix styling of the icon on
main page.
Commit: 3851590f0a043b9e64ae557e6353fbb6feb991f6
https://github.com/openSUSE/open-build-service/commit/3851590f0a043b9e64ae5…
Author: Moisés Déniz Alemán <mdeniz(a)suse.com>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
A src/api/app/assets/icons/drive-optical-32.png
A src/api/app/assets/icons/drive-optical-48.png
M src/api/app/assets/images/icons_sprite.png
M src/api/app/assets/stylesheets/webui/application/icons.scss
M src/api/app/views/webui/image_templates/index.html.haml
M src/api/app/views/webui/main/index.html.erb
M src/api/lib/tasks/sprites.rake
Log Message:
-----------
Merge pull request #2393 from Ana06/kiwi-icon
Image templates icon
Compare: https://github.com/openSUSE/open-build-service/compare/4f74812e0b7c...38515…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 64ac6ffe3415740ae35bb25dfbc6b5f1776f0c36
https://github.com/openSUSE/open-build-service/commit/64ac6ffe3415740ae35bb…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/test/functional/webui/package_controller_test.rb
Log Message:
-----------
[ci] Enable Style/AsciiComments rubocop
Commit: 46cd274d4c6ca02b941eb127bd90e065d9108392
https://github.com/openSUSE/open-build-service/commit/46cd274d4c6ca02b941eb…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/lib/activexml/node.rb
Log Message:
-----------
[ci] Enable Performance/RedundantBlockCall rubocop
This cop identifies the use of a &block parameter and block.call where yield would do just as well.
Commit: 6b005ed61b40d6851317c2e47fb8dcb7b7fb36b1
https://github.com/openSUSE/open-build-service/commit/6b005ed61b40d6851317c…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/models/project.rb
Log Message:
-----------
[ci] Enable Style/EachWithObject rubocop
Commit: 4f74812e0b7c1040cded7375050c883d8b871884
https://github.com/openSUSE/open-build-service/commit/4f74812e0b7c1040cded7…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-30 (Wed, 30 Nov 2016)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/models/project.rb
M src/api/lib/activexml/node.rb
M src/api/test/functional/webui/package_controller_test.rb
Log Message:
-----------
Merge pull request #2390 from bgeuken/ascii_cop
Enable some more rubocops
Compare: https://github.com/openSUSE/open-build-service/compare/4657c592e58e...4f748…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 85c6d74cf816ee4c11d3f97cb3e1a2e2d97ee49d
https://github.com/openSUSE/open-build-service/commit/85c6d74cf816ee4c11d3f…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
R src/api/app/assets/stylesheets/webui/application/attribute.css.scss
A src/api/app/assets/stylesheets/webui/application/attribute.scss
R src/api/app/assets/stylesheets/webui/application/bento.css.scss
A src/api/app/assets/stylesheets/webui/application/bento.scss
R src/api/app/assets/stylesheets/webui/application/cm2.css.scss
A src/api/app/assets/stylesheets/webui/application/cm2.scss
R src/api/app/assets/stylesheets/webui/application/cm2/suse.css.scss
A src/api/app/assets/stylesheets/webui/application/cm2/suse.scss
R src/api/app/assets/stylesheets/webui/application/comments.css.scss
A src/api/app/assets/stylesheets/webui/application/comments.scss
R src/api/app/assets/stylesheets/webui/application/dialog.css.scss
A src/api/app/assets/stylesheets/webui/application/dialog.scss
R src/api/app/assets/stylesheets/webui/application/home.css.scss
A src/api/app/assets/stylesheets/webui/application/home.scss
R src/api/app/assets/stylesheets/webui/application/icons.css.scss
A src/api/app/assets/stylesheets/webui/application/icons.scss
R src/api/app/assets/stylesheets/webui/application/ie.css.scss
A src/api/app/assets/stylesheets/webui/application/ie.scss
R src/api/app/assets/stylesheets/webui/application/image_templates.css.sass
A src/api/app/assets/stylesheets/webui/application/image_templates.sass
R src/api/app/assets/stylesheets/webui/application/monitor.css.scss
A src/api/app/assets/stylesheets/webui/application/monitor.scss
R src/api/app/assets/stylesheets/webui/application/notifications.css.scss
A src/api/app/assets/stylesheets/webui/application/notifications.scss
R src/api/app/assets/stylesheets/webui/application/our-own-jquery-ui.css.scss
A src/api/app/assets/stylesheets/webui/application/our-own-jquery-ui.scss
R src/api/app/assets/stylesheets/webui/application/package.css.scss
A src/api/app/assets/stylesheets/webui/application/package.scss
R src/api/app/assets/stylesheets/webui/application/print.css.scss
A src/api/app/assets/stylesheets/webui/application/print.scss
R src/api/app/assets/stylesheets/webui/application/project.css.scss
A src/api/app/assets/stylesheets/webui/application/project.scss
R src/api/app/assets/stylesheets/webui/application/request.css.scss
A src/api/app/assets/stylesheets/webui/application/request.scss
R src/api/app/assets/stylesheets/webui/application/screen.css.scss
A src/api/app/assets/stylesheets/webui/application/screen.scss
R src/api/app/assets/stylesheets/webui/application/search.css.scss
A src/api/app/assets/stylesheets/webui/application/search.scss
R src/api/app/assets/stylesheets/webui/application/style.css.scss
A src/api/app/assets/stylesheets/webui/application/style.scss
Log Message:
-----------
[api] Deprecation warning: extra .css
Deprecation warning: extra `.css` in `SASS` and `SCSS` files is
unnecessary.
Commit: 4657c592e58e66e3228daf75634f6613ea898e0e
https://github.com/openSUSE/open-build-service/commit/4657c592e58e66e3228da…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
R src/api/app/assets/stylesheets/webui/application/attribute.css.scss
A src/api/app/assets/stylesheets/webui/application/attribute.scss
R src/api/app/assets/stylesheets/webui/application/bento.css.scss
A src/api/app/assets/stylesheets/webui/application/bento.scss
R src/api/app/assets/stylesheets/webui/application/cm2.css.scss
A src/api/app/assets/stylesheets/webui/application/cm2.scss
R src/api/app/assets/stylesheets/webui/application/cm2/suse.css.scss
A src/api/app/assets/stylesheets/webui/application/cm2/suse.scss
R src/api/app/assets/stylesheets/webui/application/comments.css.scss
A src/api/app/assets/stylesheets/webui/application/comments.scss
R src/api/app/assets/stylesheets/webui/application/dialog.css.scss
A src/api/app/assets/stylesheets/webui/application/dialog.scss
R src/api/app/assets/stylesheets/webui/application/home.css.scss
A src/api/app/assets/stylesheets/webui/application/home.scss
R src/api/app/assets/stylesheets/webui/application/icons.css.scss
A src/api/app/assets/stylesheets/webui/application/icons.scss
R src/api/app/assets/stylesheets/webui/application/ie.css.scss
A src/api/app/assets/stylesheets/webui/application/ie.scss
R src/api/app/assets/stylesheets/webui/application/image_templates.css.sass
A src/api/app/assets/stylesheets/webui/application/image_templates.sass
R src/api/app/assets/stylesheets/webui/application/monitor.css.scss
A src/api/app/assets/stylesheets/webui/application/monitor.scss
R src/api/app/assets/stylesheets/webui/application/notifications.css.scss
A src/api/app/assets/stylesheets/webui/application/notifications.scss
R src/api/app/assets/stylesheets/webui/application/our-own-jquery-ui.css.scss
A src/api/app/assets/stylesheets/webui/application/our-own-jquery-ui.scss
R src/api/app/assets/stylesheets/webui/application/package.css.scss
A src/api/app/assets/stylesheets/webui/application/package.scss
R src/api/app/assets/stylesheets/webui/application/print.css.scss
A src/api/app/assets/stylesheets/webui/application/print.scss
R src/api/app/assets/stylesheets/webui/application/project.css.scss
A src/api/app/assets/stylesheets/webui/application/project.scss
R src/api/app/assets/stylesheets/webui/application/request.css.scss
A src/api/app/assets/stylesheets/webui/application/request.scss
R src/api/app/assets/stylesheets/webui/application/screen.css.scss
A src/api/app/assets/stylesheets/webui/application/screen.scss
R src/api/app/assets/stylesheets/webui/application/search.css.scss
A src/api/app/assets/stylesheets/webui/application/search.scss
R src/api/app/assets/stylesheets/webui/application/style.css.scss
A src/api/app/assets/stylesheets/webui/application/style.scss
Log Message:
-----------
Merge pull request #2391 from Ana06/css-unnecessary
[api] Deprecation warning: extra .css
Compare: https://github.com/openSUSE/open-build-service/compare/8823b5803e7f...4657c…