September 2023 - Open Build Service Commits

[openSUSE/open-build-service] e53f65: Update octokit to version 7.2.0
by depfu[bot] 30 Sep '23

30 Sep '23

Branch: refs/heads/depfu/update/srcapi/octokit-7.2.0 Home: https://github.com/openSUSE/open-build-service Commit: e53f650ecbea809ab1dee2d6097958f94ff15427 https://github.com/openSUSE/open-build-service/commit/e53f650ecbea809ab1dee… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-09-30 (Sat, 30 Sep 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/octokit-7.1.0.gem A src/api/vendor/cache/octokit-7.2.0.gem Log Message: ----------- Update octokit to version 7.2.0

1 0

[openSUSE/open-build-service]
by Bernhard M. Wiedemann 29 Sep '23

29 Sep '23

Branch: refs/heads/depfu/update/srcapi/rubocop-1.56.4 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 12f3e7: Update rubocop to version 1.56.4
by Bernhard M. Wiedemann 29 Sep '23

29 Sep '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 12f3e735d0345bb9ef11e8d94b6070916c7c2070 https://github.com/openSUSE/open-build-service/commit/12f3e735d0345bb9ef11e… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.56.3.gem A src/api/vendor/cache/rubocop-1.56.4.gem Log Message: ----------- Update rubocop to version 1.56.4 Commit: 221811444256005c46b48af45f7f6313496c8499 https://github.com/openSUSE/open-build-service/commit/221811444256005c46b48… Author: Bernhard M. Wiedemann <bwiedemann(a)suse.de> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.56.3.gem A src/api/vendor/cache/rubocop-1.56.4.gem Log Message: ----------- Merge pull request #14989 from openSUSE/depfu/update/srcapi/rubocop-1.56.4 [src/api] Update rubocop 1.56.3 → 1.56.4 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/45fff87d1a07...22181…

1 0

[openSUSE/open-build-service] 12f3e7: Update rubocop to version 1.56.4
by depfu[bot] 29 Sep '23

29 Sep '23

Branch: refs/heads/depfu/update/srcapi/rubocop-1.56.4 Home: https://github.com/openSUSE/open-build-service Commit: 12f3e735d0345bb9ef11e8d94b6070916c7c2070 https://github.com/openSUSE/open-build-service/commit/12f3e735d0345bb9ef11e… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.56.3.gem A src/api/vendor/cache/rubocop-1.56.4.gem Log Message: ----------- Update rubocop to version 1.56.4

1 0

[openSUSE/open-build-service] 44093d: Implement filtering decision events together with ...
by Dani Donisa 29 Sep '23

29 Sep '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 44093d7616b21f5f3bad0ef263529fc52e22574a https://github.com/openSUSE/open-build-service/commit/44093d7616b21f5f3bad0… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M src/api/app/queries/notifications_finder.rb Log Message: ----------- Implement filtering decision events together with reports For now the report filter will show also the clear and favor decision events. Commit: 45fff87d1a07bcd4e79917368d64967b9c224c4a https://github.com/openSUSE/open-build-service/commit/45fff87d1a07bcd4e7991… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M src/api/app/queries/notifications_finder.rb Log Message: ----------- Merge pull request #14975 from danidoni/implement-filters-for-decision-events Implement filters for decision events Compare: https://github.com/openSUSE/open-build-service/compare/21ba858d147c...45fff…

1 0

[openSUSE/open-build-service] 4870bb: Remove unused `modal_title` attribute
by Jacob Michalskie 29 Sep '23

29 Sep '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4870bb530276458e775f39deb9f75915a94af7ba https://github.com/openSUSE/open-build-service/commit/4870bb530276458e775f3… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M src/api/app/components/report_component.html.haml M src/api/app/components/report_component.rb Log Message: ----------- Remove unused `modal_title` attribute The title of the modal is already set by javascript. Commit: 9ee4a5354fc6a7c00207b483c578475153ec3ced https://github.com/openSUSE/open-build-service/commit/9ee4a5354fc6a7c00207b… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M src/api/app/components/bs_request_comment_component.html.haml M src/api/app/components/report_component.html.haml M src/api/app/components/report_component.rb M src/api/app/controllers/webui/reports_controller.rb M src/api/app/views/webui/comment/_reply.html.haml M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/package/show_actions/_report_package.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/project/show_actions/_report_project.html.haml M src/api/app/views/webui/reports/create.js.erb M src/api/app/views/webui/request/beta_show.html.haml M src/api/app/views/webui/user/_basic_info.html.haml Log Message: ----------- Remove `modal_id` in Report Component It is enough to have one report modal in each rendered page. Commit: bd68a6f27b2eb893b2ffee5f677bd50dba5dc745 https://github.com/openSUSE/open-build-service/commit/bd68a6f27b2eb893b2ffe… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M src/api/app/assets/javascripts/webui/report.js M src/api/app/components/report_component.html.haml M src/api/app/components/report_component.rb M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/request/beta_show.html.haml M src/api/app/views/webui/user/_basic_info.html.haml Log Message: ----------- Set the confirmation text from the link In the same web page there could be several links which could open the report modal for different type of objects. Setting the confirmation text from the component isn't the solution. Commit: a028e42c8f918bd9af20817b184a0627024d54af https://github.com/openSUSE/open-build-service/commit/a028e42c8f918bd9af208… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M src/api/app/components/report_component.rb M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/request/beta_show.html.haml M src/api/app/views/webui/user/_basic_info.html.haml Log Message: ----------- Move policy checks inside ReportComponent Pass `reportable` parameter to ReportComponent. This way we can check the policies inside the Report component. Also, get rid of the `user` parameter. This was used only to check for the content_moderation feature flag. But this is already done in the policy check for the Report model. Commit: ff30e4ebca83034b94bff05d714c65b74955a99c https://github.com/openSUSE/open-build-service/commit/ff30e4ebca83034b94bff… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/request/_request_comments.html.haml Log Message: ----------- Move Report component call outside the comment list Project, package and request pages use the comment list. The project and package pages already call the Report component. The request view didn't. Call the Report component from the `request/_request_comments partial`, so we can get rid of the call of the Report component in the `comment/_show` partial, wich is redundant for projects and packages. Commit: bac53b8d52ba8e5b0a897dd9eb04e7eb06f92c45 https://github.com/openSUSE/open-build-service/commit/bac53b8d52ba8e5b0a897… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M src/api/app/assets/javascripts/webui/report.js M src/api/app/components/report_component.rb Log Message: ----------- Fix javascript and remove render condition from report modal We cannot authorize inside the render condition in this case. We render the modal on the package, project and request views, then set the attributes on the form inside the model via javascript. When for example we cannot report on the package itself but on the comment that is on the package view, the component is not rendered. We already have authorization on the controller code and the report links. There is no need to do this on the modal. Commit: 2547088f9876dfade89590920cf767ad0674ae65 https://github.com/openSUSE/open-build-service/commit/2547088f9876dfade8959… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: R src/api/app/components/report_component.html.haml R src/api/app/components/report_component.rb M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/request/_request_comments.html.haml M src/api/app/views/webui/request/beta_show.html.haml A src/api/app/views/webui/shared/_report_modal.html.haml M src/api/app/views/webui/user/_basic_info.html.haml Log Message: ----------- Move report component to a partial After removing the render? condition from the component, there is nothing left where a view component would be beneficial. All attributes are set via javascript. Lets move it to a partial. Commit: 21ba858d147c802027e28ebef4deb704578ed1ca https://github.com/openSUSE/open-build-service/commit/21ba858d147c802027e28… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M src/api/app/assets/javascripts/webui/report.js M src/api/app/components/bs_request_comment_component.html.haml R src/api/app/components/report_component.html.haml R src/api/app/components/report_component.rb M src/api/app/controllers/webui/reports_controller.rb M src/api/app/views/webui/comment/_reply.html.haml M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/package/show_actions/_report_package.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/project/show_actions/_report_project.html.haml M src/api/app/views/webui/reports/create.js.erb M src/api/app/views/webui/request/_request_comments.html.haml M src/api/app/views/webui/request/beta_show.html.haml A src/api/app/views/webui/shared/_report_modal.html.haml M src/api/app/views/webui/user/_basic_info.html.haml Log Message: ----------- Merge pull request #14935 from eduardoj/refactoring/report_component Refactor report component Compare: https://github.com/openSUSE/open-build-service/compare/dbbf111efbc1...21ba8…

1 0

[openSUSE/open-build-service] eba09c: Improve the creation of subscriptions for Decision
by Dani Donisa 29 Sep '23

29 Sep '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: eba09cd34e3c2e9cd42e971c737243a71622dd99 https://github.com/openSUSE/open-build-service/commit/eba09cd34e3c2e9cd42e9… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/lib/tasks/dev/reports.rake Log Message: ----------- Improve the creation of subscriptions for Decision Commit: e2c9188247ff8cc9a4d3e78485aa577197a4bc2e https://github.com/openSUSE/open-build-service/commit/e2c9188247ff8cc9a4d3e… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb M src/api/app/components/notification_component.rb M src/api/app/components/notification_notifiable_link_component.rb M src/api/app/models/decision.rb M src/api/app/models/event/cleared_decision.rb M src/api/app/models/event/favored_decision.rb Log Message: ----------- Improve the notification for clear or favor events Commit: cb1351737026188ccfb075aa8f82334f36713111 https://github.com/openSUSE/open-build-service/commit/cb1351737026188ccfb07… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/app/models/decision.rb Log Message: ----------- Set the correct reportable_type value on payload Commit: 60354db125419530121e36b36049a9e74865010e https://github.com/openSUSE/open-build-service/commit/60354db125419530121e3… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb M src/api/app/components/notification_excerpt_component.rb Log Message: ----------- Set description and excerpt correctly The description contained two paragraphs. However, the first paragraph corresponds to description and the second to excerpt. This commit splits them. Commit: 5d5051308943738e2d50126b407233719f332487 https://github.com/openSUSE/open-build-service/commit/5d5051308943738e2d501… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb Log Message: ----------- Remove word User from the descriptions Commit: d45db2a761289a39304eee7fad2eaab918965308 https://github.com/openSUSE/open-build-service/commit/d45db2a761289a39304ee… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb Log Message: ----------- Rephrase and simplify the description Commit: 64217c80f2e443b7735de0544955313e2a481ec5 https://github.com/openSUSE/open-build-service/commit/64217c80f2e443b7735de… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/app/components/notification_notifiable_link_component.rb Log Message: ----------- Titleize the link text For consistency with other types of notifications. Commit: 7b08b5fa4a09aafeb53de2b003a133fd39c97f8c https://github.com/openSUSE/open-build-service/commit/7b08b5fa4a09aafeb53de… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/app/components/notification_notifiable_link_component.rb Log Message: ----------- Omit the word Created on report notification description Commit: f79292577f3ad8e16e37fb5a44eb7f74d2791247 https://github.com/openSUSE/open-build-service/commit/f79292577f3ad8e16e37f… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/spec/components/notification_action_description_component_spec.rb M src/api/spec/components/notification_notifiable_link_component_spec.rb Log Message: ----------- Adapt specs accordingly Commit: ec6c2c2ea5ba114a89e19e75b0f6fddb0f4ddc20 https://github.com/openSUSE/open-build-service/commit/ec6c2c2ea5ba114a89e19… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: A src/api/spec/factories/decisions.rb M src/api/spec/factories/notification.rb Log Message: ----------- Create factories related to decisions Commit: 27ab45404f6f1fe6e3289ba96d51ad82a3d265c6 https://github.com/openSUSE/open-build-service/commit/27ab45404f6f1fe6e3289… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/spec/components/notification_action_description_component_spec.rb Log Message: ----------- Test description of decisions notifications Commit: 7ca9a3c6a5267e1e4226ec2f3414740b87a6ee28 https://github.com/openSUSE/open-build-service/commit/7ca9a3c6a5267e1e4226e… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/spec/components/notification_notifiable_link_component_spec.rb Log Message: ----------- Test the links of the decisions notifications Commit: dbbf111efbc1e04c146ffc7bc2b72672665a5651 https://github.com/openSUSE/open-build-service/commit/dbbf111efbc1e04c146ff… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb M src/api/app/components/notification_component.rb M src/api/app/components/notification_excerpt_component.rb M src/api/app/components/notification_notifiable_link_component.rb M src/api/app/models/decision.rb M src/api/app/models/event/cleared_decision.rb M src/api/app/models/event/favored_decision.rb M src/api/lib/tasks/dev/reports.rake M src/api/spec/components/notification_action_description_component_spec.rb M src/api/spec/components/notification_notifiable_link_component_spec.rb A src/api/spec/factories/decisions.rb M src/api/spec/factories/notification.rb Log Message: ----------- Merge pull request #14976 from danidoni/implement-better-notifications-for-report-decisions Implement better notifications for report decisions Compare: https://github.com/openSUSE/open-build-service/compare/a71fdfcfa098...dbbf1…

1 0

[openSUSE/open-build-service] dc502e: Update dalli to version 3.2.6
by Bernhard M. Wiedemann 28 Sep '23

28 Sep '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: dc502e10b88305c9b8d5a2a02cee43895f4085a3 https://github.com/openSUSE/open-build-service/commit/dc502e10b88305c9b8d5a… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/dalli-3.2.5.gem A src/api/vendor/cache/dalli-3.2.6.gem Log Message: ----------- Update dalli to version 3.2.6 Commit: a71fdfcfa0981d92018f8e9cf87cb3e696fbda46 https://github.com/openSUSE/open-build-service/commit/a71fdfcfa0981d92018f8… Author: Bernhard M. Wiedemann <bwiedemann(a)suse.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/dalli-3.2.5.gem A src/api/vendor/cache/dalli-3.2.6.gem Log Message: ----------- Merge pull request #14977 from openSUSE/depfu/update/srcapi/dalli-3.2.6 [src/api] Update dalli 3.2.5 → 3.2.6 (patch) * Rescue IO::TimeoutError raised by Ruby since 3.2.0 on blocking reads/writes * Fix rubydoc link Compare: https://github.com/openSUSE/open-build-service/compare/c2e145bdd08a...a71fd…

1 0

[openSUSE/open-build-service]
by Bernhard M. Wiedemann 28 Sep '23

28 Sep '23

Branch: refs/heads/depfu/update/srcapi/dalli-3.2.6 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 1e099d: Revert "[src/api] Update selenium-webdriver 4.5.0 ...
by Henne Vogelsang 28 Sep '23

28 Sep '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1e099d9dc0b99084a1f3283783b15696882660d2 https://github.com/openSUSE/open-build-service/commit/1e099d9dc0b99084a1f32… Author: Bernhard M. Wiedemann <githubbmwprimary(a)lsmod.de> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/Gemfile.lock A src/api/vendor/cache/childprocess-4.1.0.gem R src/api/vendor/cache/selenium-webdriver-4.13.1.gem A src/api/vendor/cache/selenium-webdriver-4.5.0.gem Log Message: ----------- Revert "[src/api] Update selenium-webdriver 4.5.0 → 4.13.1 (minor)" Commit: c2e145bdd08a0e87a987e2c9c29eaa9dc18b776a https://github.com/openSUSE/open-build-service/commit/c2e145bdd08a0e87a987e… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M src/api/Gemfile.lock A src/api/vendor/cache/childprocess-4.1.0.gem R src/api/vendor/cache/selenium-webdriver-4.13.1.gem A src/api/vendor/cache/selenium-webdriver-4.5.0.gem Log Message: ----------- Merge pull request #14980 from openSUSE/revert-14973-depfu/update/srcapi/selenium-webdriver-4.13.1 Revert "[src/api] Update selenium-webdriver 4.5.0 → 4.13.1 (minor)" Compare: https://github.com/openSUSE/open-build-service/compare/9ca0110162b9...c2e14…

1 0