Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: e58c4bf87a45407c55898de34e74221741a30f8a
https://github.com/openSUSE/open-build-service/commit/e58c4bf87a45407c55898…
Author: Christian Bruckmayer <cbruckmayer(a)suse.com>
Date: 2016-12-30 (Fri, 30 Dec 2016)
Changed paths:
M src/api/app/models/history.rb
M src/api/app/models/review.rb
Log Message:
-----------
[api][webui] Move History.find_by_element into association
Because it is an association between HistoryElement and Review. No need to ask History and handing the review object over.
Commit: 4641333c200a109d9a766871d85d2372300f8eaf
https://github.com/openSUSE/open-build-service/commit/4641333c200a109d9a766…
Author: Christian Bruckmayer <cbruckmayer(a)suse.com>
Date: 2016-12-30 (Fri, 30 Dec 2016)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/bs_request.rb
R src/api/app/models/history.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/unit/history_test.rb
Log Message:
-----------
[api][webui] Remove History.find_by_request query function
The History class was just a helper class to query history elements of Request and Review objects.
This is now handled via Rails associations in the Request and Review models.
- Added Request#request_history_elements association to query HistoryElements of this Request
- Added Request#history_elements function to query HistoryElements of this Request and associated Reviews (was withreviews option)
- Added helper association Request#review_history_elements
- Removed History class as it is not necessary anymore
This was a refactoring to use rails build in functionality and remove unnecessary code. Functionality stayed the same.
Commit: 252b98e8e944f43e435518684b9534cd9df2d61b
https://github.com/openSUSE/open-build-service/commit/252b98e8e944f43e43551…
Author: Ana María Martínez Gómez <ammartinez(a)suse.de>
Date: 2016-12-30 (Fri, 30 Dec 2016)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/bs_request.rb
R src/api/app/models/history.rb
M src/api/app/models/review.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/unit/history_test.rb
Log Message:
-----------
Merge pull request #2504 from ChrisBr/remove_history_class
Remove History class and introduces associations
Compare: https://github.com/openSUSE/open-build-service/compare/4b36772b2a82...252b9…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: ded747b72c37fb1f4c4c457d22d23acbdd9aab93
https://github.com/openSUSE/open-build-service/commit/ded747b72c37fb1f4c4c4…
Author: David Kang <gerheman(a)gmail.com>
Date: 2016-12-26 (Mon, 26 Dec 2016)
Changed paths:
M src/api/app/controllers/webui/comments_controller.rb
M src/api/app/models/comment.rb
A src/api/app/policies/comment_policy.rb
M src/api/app/views/webui/comment/_links.html.erb
Log Message:
-----------
[webui] Move Comment#check_delete_permissions to pundit policy
Commit: cf3f33dd83b97a3e7a9f605f526ae6110215cffb
https://github.com/openSUSE/open-build-service/commit/cf3f33dd83b97a3e7a9f6…
Author: David Kang <gerheman(a)gmail.com>
Date: 2016-12-26 (Mon, 26 Dec 2016)
Changed paths:
M src/api/app/controllers/application_controller.rb
M src/api/app/controllers/comments_controller.rb
Log Message:
-----------
[api] Add pundit rescue exception for comment
Commit: fc9298e6c7095feef5ec408d316e45c7ea339ef2
https://github.com/openSUSE/open-build-service/commit/fc9298e6c7095feef5ec4…
Author: David Kang <gerheman(a)gmail.com>
Date: 2016-12-26 (Mon, 26 Dec 2016)
Changed paths:
A src/api/spec/policies/comment_policy_spec.rb
M src/api/spec/rails_helper.rb
Log Message:
-----------
[ci] Comment pundit policy test
Commit: 34496c45a93ad421cb5bbf5466465163aa72bb4a
https://github.com/openSUSE/open-build-service/commit/34496c45a93ad421cb5bb…
Author: Christian Bruckmayer <cbruckmayer(a)suse.com>
Date: 2016-12-27 (Tue, 27 Dec 2016)
Changed paths:
M src/api/app/controllers/application_controller.rb
M src/api/app/controllers/comments_controller.rb
M src/api/app/controllers/webui/comments_controller.rb
M src/api/app/models/comment.rb
A src/api/app/policies/comment_policy.rb
M src/api/app/views/webui/comment/_links.html.erb
A src/api/spec/policies/comment_policy_spec.rb
M src/api/spec/rails_helper.rb
Log Message:
-----------
Merge pull request #2498 from DavidKang/move_comment_authorization_to_pundit
Move delete comment authorization to pundit
Compare: https://github.com/openSUSE/open-build-service/compare/3b3ad3ef60c8...34496…
Branch: refs/heads/2.7
Home: https://github.com/openSUSE/open-build-service
Commit: 5f869732d60b2769f3e0c5e367f1b9572bf6e9fd
https://github.com/openSUSE/open-build-service/commit/5f869732d60b2769f3e0c…
Author: Adrian Schröter <adrian(a)suse.de>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
M src/api/app/models/bs_request_action_maintenance_incident.rb
M src/api/test/functional/maintenance_test.rb
M src/api/test/unit/code_quality_test.rb
Log Message:
-----------
[api] fix maintenance incident merge
code ignored the specified revision of the request on accept.
Seems to be the case since quite some time (when code got moved to model)
Quite some cleanup since that also leaded to unnecessary usage of
method variables
also fixed some request number handling
(The code became simpler now, but I had to increase the "code quality" number :/)
Commit: 0e90a465a6e61891ce0084e57a89ed94d8a50f24
https://github.com/openSUSE/open-build-service/commit/0e90a465a6e61891ce008…
Author: Adrian Schröter <adrian(a)suse.de>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
M src/api/app/controllers/request_controller.rb
M src/api/test/functional/request_controller_test.rb
Log Message:
-----------
[api] fix crash on wrong command
Commit: f3ef45b6d339dd336a498923eda334ce4892e367
https://github.com/openSUSE/open-build-service/commit/f3ef45b6d339dd336a498…
Author: Adrian Schröter <adrian(a)suse.de>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
M src/api/app/models/bs_request_permission_check.rb
M src/api/app/models/package.rb
Log Message:
-----------
[api] fix permission check maintenance_incident actions
They checked wrong target package name, it became visible since
per package locking.
Commit: 9381ae8ea5a38ea2a00913567b1169fa7b887601
https://github.com/openSUSE/open-build-service/commit/9381ae8ea5a38ea2a0091…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
M src/api/app/models/package.rb
Log Message:
-----------
[api][webui] Refactor Package::extended_name
Commit: 7d2f8cb9d72c472a2516ec1f4788b10381de2b84
https://github.com/openSUSE/open-build-service/commit/7d2f8cb9d72c472a2516e…
Author: Adrian Schröter <adrian(a)suse.de>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
M src/api/app/models/package.rb
M src/api/test/functional/channel_maintenance_test.rb
Log Message:
-----------
[api] fix another case in maintenance_incident target check
find the right target package also when source also used extended names
Commit: 65316f92f64d3be5cb0a0d38ff47e20341ac4aef
https://github.com/openSUSE/open-build-service/commit/65316f92f64d3be5cb0a0…
Author: Adrian Schröter <adrian(a)suse.de>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
M src/api/app/controllers/source_controller.rb
M src/api/app/controllers/webui/project_controller.rb
M src/api/app/models/project.rb
M src/api/test/fixtures/path_elements.yml
M src/api/test/fixtures/repositories.yml
M src/api/test/fixtures/repository_architectures.yml
M src/api/test/functional/maintenance_test.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/functional/source_controller_test.rb
M src/api/test/unit/code_quality_test.rb
Log Message:
-----------
[api][webui] fix breakage on project destroy
Avoid the double write of meta data. It leads to a broken project
after undelete and it is causing double load in the backend.
Testcase for correct undelete behaviour added.
method in project model which was only used in one place got dropped,
since it wasn't usable this way anyway.
Commit: c0f05b1ed16128c6b491b96afbd5c5842c537105
https://github.com/openSUSE/open-build-service/commit/c0f05b1ed16128c6b491b…
Author: Adrian Schröter <adrian(a)suse.de>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
M src/api/test/functional/webui/download_on_demand_controller_test.rb
Log Message:
-----------
[ci] drop all flaky testcases of DoD webui interface
marked to be part of new rspec suite
Commit: 074ef352a8199440842a3c83e8d4a26a0e92880c
https://github.com/openSUSE/open-build-service/commit/074ef352a8199440842a3…
Author: Christian Bruckmayer <cbruckmayer(a)suse.com>
Date: 2016-12-21 (Wed, 21 Dec 2016)
Changed paths:
A ReleaseNotes-2.7.3
Log Message:
-----------
[ci] Add ReleaseNotes for 2.7.3
Commit: 230f2ded4134d317e3912c8560ef34a9ed322d12
https://github.com/openSUSE/open-build-service/commit/230f2ded4134d317e3912…
Author: Christian Bruckmayer <cbruckmayer(a)suse.com>
Date: 2016-12-23 (Fri, 23 Dec 2016)
Changed paths:
M src/api/test/functional/channel_maintenance_test.rb
Log Message:
-----------
[ci] Remove failing tests from channel maintenance test
as this is not relevant for 2.7 release
Commit: e7c17b0854d84cbb513c111cc27f7c1a5977154c
https://github.com/openSUSE/open-build-service/commit/e7c17b0854d84cbb513c1…
Author: Christian Bruckmayer <cbruckmayer(a)suse.com>
Date: 2016-12-23 (Fri, 23 Dec 2016)
Changed paths:
M src/api/test/functional/request_controller_test.rb
Log Message:
-----------
[ci] Add disable flags for rubocop
these are already fixed / added in master
Commit: 505b29c18871ce7466bf9398459b64dccf35563b
https://github.com/openSUSE/open-build-service/commit/505b29c18871ce7466bf9…
Author: Henne Vogelsang <hvogel(a)opensuse.org>
Date: 2016-12-23 (Fri, 23 Dec 2016)
Changed paths:
A ReleaseNotes-2.7.3
M src/api/app/controllers/request_controller.rb
M src/api/app/controllers/source_controller.rb
M src/api/app/controllers/webui/project_controller.rb
M src/api/app/models/bs_request_action_maintenance_incident.rb
M src/api/app/models/bs_request_permission_check.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/test/fixtures/path_elements.yml
M src/api/test/fixtures/repositories.yml
M src/api/test/fixtures/repository_architectures.yml
M src/api/test/functional/channel_maintenance_test.rb
M src/api/test/functional/maintenance_test.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/functional/source_controller_test.rb
M src/api/test/functional/webui/download_on_demand_controller_test.rb
M src/api/test/unit/code_quality_test.rb
Log Message:
-----------
Merge pull request #2492 from ChrisBr/2.7
Preparing for Release for 2.7.3
Compare: https://github.com/openSUSE/open-build-service/compare/370135078b8d...505b2…