November 2014 - Open Build Service Commits

[obs-commits] [openSUSE/osc2] 89ed43: - cli.checkout: added support to revert a project,...
by Marcus Huewe 29 Nov '14

29 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/osc2 Commit: 89ed43e4735fa6affb2bf0da868a54b0db438a8c https://github.com/openSUSE/osc2/commit/89ed43e4735fa6affb2bf0da868a54b0db4… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-29 (Sat, 29 Nov 2014) Changed paths: A osc2/cli/checkout/checkout.py M osc2/cli/checkout/ui.py M osc2/cli/update/update.py Log Message: ----------- - cli.checkout: added support to revert a project, package, or file Now, the term checkout has the following semantics: - checking out a project or package from the api - revert all local modifications of a project or package or file Moreover, the checkout ui supports two different syntaxes: - api://project/package? to newly checkout a project or package - wc_path to revert multiple projects, packages, or files Commit: d5891ef6c4e3841081a1fd7174bfb5cc9f3cc147 https://github.com/openSUSE/osc2/commit/d5891ef6c4e3841081a1fd7174bfb5cc9f3… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-29 (Sat, 29 Nov 2014) Changed paths: M osc2/cli/checkout/ui.py Log Message: ----------- - cli.checkout.ui: updated examples in the __doc__ str Compare: https://github.com/openSUSE/osc2/compare/3acf01d54058...d5891ef6c4e3

1 0

[obs-commits] [openSUSE/osc2] 962ec8: - cli.cli: added at_most decorator
by Marcus Huewe 29 Nov '14

29 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/osc2 Commit: 962ec8276a1ab0ea2ae19e10fc7bb0605719128f https://github.com/openSUSE/osc2/commit/962ec8276a1ab0ea2ae19e10fc7bb060571… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-29 (Sat, 29 Nov 2014) Changed paths: M osc2/cli/cli.py Log Message: ----------- - cli.cli: added at_most decorator Decorator, which checks that certain args are specified at most n times. If an arg from args occurs more than n times in the info object, a ValueError is raised. Commit: 3acf01d540581f4655c64f4c6b925c3afcfcfe8d https://github.com/openSUSE/osc2/commit/3acf01d540581f4655c64f4c6b925c3afcf… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-29 (Sat, 29 Nov 2014) Changed paths: M osc2/cli/cli.py Log Message: ----------- - cli._init: warn if multiple (distinct) apiurls are used This is currently not supported, but it will be in the future. Compare: https://github.com/openSUSE/osc2/compare/5f291be12c08...3acf01d54058

1 0

[obs-commits] [openSUSE/osc2] 41087b: - cli.status.status: also missing files (state '!'...
by Marcus Huewe 28 Nov '14

28 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/osc2 Commit: 41087b76c493bfdab7621e448d383ee7b44f8aa7 https://github.com/openSUSE/osc2/commit/41087b76c493bfdab7621e448d383ee7b44… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M osc2/cli/status/status.py Log Message: ----------- - cli.status.status: also missing files (state '!') Commit: 6d9a206a31fd6f5eb19ae4268496e7e84069caa0 https://github.com/openSUSE/osc2/commit/6d9a206a31fd6f5eb19ae4268496e7e8406… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M test/test_oscargs.py Log Message: ----------- - test.test_oscargs: wcpath testcase for a nonexistent package Even if the package does not exist, the WCPath instance should provide the path and name of the nonexistent package. The package_obj method should return None in this case. Commit: 5f291be12c08e07908a7a3a8cd88a6317c32177a https://github.com/openSUSE/osc2/commit/5f291be12c08e07908a7a3a8cd88a6317c3… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M osc2/oscargs.py Log Message: ----------- - oscargs.WCPath: handle a nonexistent package correctly Compare: https://github.com/openSUSE/osc2/compare/0b3901e7ff48...5f291be12c08

1 0

[obs-commits] [openSUSE/osc2] 0b3901: - oscargs: do par_dir assignment some lines later
by Marcus Huewe 28 Nov '14

28 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/osc2 Commit: 0b3901e7ff48299c53ad3a2606f978b572ab7ca9 https://github.com/openSUSE/osc2/commit/0b3901e7ff48299c53ad3a2606f978b572a… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M osc2/oscargs.py Log Message: ----------- - oscargs: do par_dir assignment some lines later The previous version was not wrong, but when reading the code it is not obvious why it is not wrong;) So, doing the assignment a bit later improves the "internal structure" a bit. No testcase, because nothing was wrong.

1 0

[obs-commits] [openSUSE/open-build-service] ec3c46: [backend] add import workaround to channel generat...
by Michael Schroeder 28 Nov '14

28 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ec3c46e610007d43e54ce5426f8098f2c9ec7e8f https://github.com/openSUSE/open-build-service/commit/ec3c46e610007d43e54ce… Author: Michael Schroeder <mls(a)suse.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M src/backend/bs_sched Log Message: ----------- [backend] add import workaround to channel generation Let it pick up imported binaries if the desired architecture is not in the repo's architecture list.

1 0

[obs-commits] [openSUSE/open-build-service] de48bc: [api] add an atomar command to assign a review of ...
by Adrian Schröter 28 Nov '14

28 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: de48bc068d96cd095c6e489db4fd7a856acb073a https://github.com/openSUSE/open-build-service/commit/de48bc068d96cd095c6e4… Author: Adrian Schröter <adrian(a)suse.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/history_element/review.rb M src/api/test/fixtures/groups_users.yml M src/api/test/functional/request_controller_test.rb M src/api/test/test_helper.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- [api] add an atomar command to assign a review of a group to a concrete person (fate#318207)

1 0

[obs-commits] [openSUSE/osc2] ed1a6d: - oscargs: refactored OscArgs._parse_entries
by Marcus Huewe 28 Nov '14

28 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/osc2 Commit: ed1a6d9a14d1d71e81ba3eeaa10c8a1a23fb1903 https://github.com/openSUSE/osc2/commit/ed1a6d9a14d1d71e81ba3eeaa10c8a1a23f… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M osc2/oscargs.py Log Message: ----------- - oscargs: refactored OscArgs._parse_entries Moved the entry parsing code to a new dedicated _parse_entry method. Commit: 26e9f4ac2271b369c7e1c5919162f5656e55bb80 https://github.com/openSUSE/osc2/commit/26e9f4ac2271b369c7e1c5919162f5656e5… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M test/test_oscargs.py Log Message: ----------- - test.test_oscargs: added testcases for alternative entries Commit: 07deb2ffa283ada6b5d49606fde254bdd761cb35 https://github.com/openSUSE/osc2/commit/07deb2ffa283ada6b5d49606fde254bdd76… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2014-11-28 (Fri, 28 Nov 2014) Changed paths: M osc2/oscargs.py Log Message: ----------- - oscargs: added support for alternative entries An alternative entry is used to provide different syntaxes for an argument. Use case: "overload" the checkout command's syntax Compare: https://github.com/openSUSE/osc2/compare/50dcf616821e...07deb2ffa283

1 0

[obs-commits] [openSUSE/open-build-service] 031b7e: [api] Fail authentication if we are not able to bi...
by Jan Blunck 27 Nov '14

27 Nov '14

Branch: refs/heads/2.5 Home: https://github.com/openSUSE/open-build-service Commit: 031b7e90100a38d55c4d6de1618832cc50165c05 https://github.com/openSUSE/open-build-service/commit/031b7e90100a38d55c4d6… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Fail authentication if we are not able to bind with user credentials We need to fail the authentication here because otherwise we create the user in OBS without the proper permissions. Signed-off-by: Jan Blunck <jblunck(a)infradead.org>

1 0

[obs-commits] [openSUSE/open-build-service] dfa9ce: [api] Fail authentication if we are not able to bi...
by Jan Blunck 27 Nov '14

27 Nov '14

Branch: refs/heads/2.6 Home: https://github.com/openSUSE/open-build-service Commit: dfa9ce9367878372ad6f1a39fdee0ca72814c395 https://github.com/openSUSE/open-build-service/commit/dfa9ce9367878372ad6f1… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Fail authentication if we are not able to bind with user credentials We need to fail the authentication here because otherwise we create the user in OBS without the proper permissions. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: f079df9e85c625a2f644b248d1bfe6a1d08e3fc6 https://github.com/openSUSE/open-build-service/commit/f079df9e85c625a2f644b… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Fix UserLdapStrategy.initialize_ldap_con() error handling The code needs to check if the bind was successful before calling unbind(): LDAP::InvalidDataError: The LDAP handler has already unbound. from /srv/www/obs/api/app/models/user_ldap_strategy.rb:574:in `err' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:574:in `rescue in initialize_ldap_con' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:551:in `initialize_ldap_con' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:382:in `block in find_with_ldap' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:380:in `times' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:380:in `find_with_ldap' Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: 118683d20a509da66c99e185920e631140ccd9d0 https://github.com/openSUSE/open-build-service/commit/118683d20a509da66c99e… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb A src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- [api] Extract authenticate_with_local() method from UserLdapStrategy.find_with_ldap() This refactoring extracts the local authentication into a separate function. They main purpose though was to move the extraction of user information *AFTER* the authentication is successful. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: b837f15ec754715f2c001eb36a4993d00868ad17 https://github.com/openSUSE/open-build-service/commit/b837f15ec754715f2c001… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Indention fix in UserLdapStrategy.find_with_ldap() This is a whitespace only change. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: e595bb67f64b17a0208ef5e5cd544eb8e7a9b131 https://github.com/openSUSE/open-build-service/commit/e595bb67f64b17a0208ef… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb M src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- [api] Support Distinguished Name to User Principal Name conversion for LDAP user email This is described in http://technet.microsoft.com/en-us/library/cc977992.aspx and can be used in cases the full email address of the person object is not available. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Compare: https://github.com/openSUSE/open-build-service/compare/aa6d4e02c56c...e595b…

1 0

[obs-commits] [openSUSE/open-build-service] 096e5d: [api] Fail authentication if we are not able to bi...
by Jan Blunck 27 Nov '14

27 Nov '14

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 096e5d6423e3a84413a4b524337cca1121381524 https://github.com/openSUSE/open-build-service/commit/096e5d6423e3a84413a4b… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Fail authentication if we are not able to bind with user credentials We need to fail the authentication here because otherwise we create the user in OBS without the proper permissions. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: c7f79ed2174cb84c22b0af68585576055398b727 https://github.com/openSUSE/open-build-service/commit/c7f79ed2174cb84c22b0a… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Fix UserLdapStrategy.initialize_ldap_con() error handling The code needs to check if the bind was successful before calling unbind(): LDAP::InvalidDataError: The LDAP handler has already unbound. from /srv/www/obs/api/app/models/user_ldap_strategy.rb:574:in `err' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:574:in `rescue in initialize_ldap_con' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:551:in `initialize_ldap_con' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:382:in `block in find_with_ldap' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:380:in `times' from /srv/www/obs/api/app/models/user_ldap_strategy.rb:380:in `find_with_ldap' Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: 27a5b35623572c8e2e4b10815ba86d2d66fe318c https://github.com/openSUSE/open-build-service/commit/27a5b35623572c8e2e4b1… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb A src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- [api] Extract authenticate_with_local() method from UserLdapStrategy.find_with_ldap() This refactoring extracts the local authentication into a separate function. They main purpose though was to move the extraction of user information *AFTER* the authentication is successful. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: 9387c9b57ac9f2e43ecf28e062bf6c57e4087a36 https://github.com/openSUSE/open-build-service/commit/9387c9b57ac9f2e43ecf2… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Indention fix in UserLdapStrategy.find_with_ldap() This is a whitespace only change. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Commit: 938e94fd136f4f34113af6d86e1563788badb707 https://github.com/openSUSE/open-build-service/commit/938e94fd136f4f34113af… Author: Jan Blunck <jblunck(a)infradead.org> Date: 2014-11-27 (Thu, 27 Nov 2014) Changed paths: M src/api/app/models/user_ldap_strategy.rb M src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- [api] Support Distinguished Name to User Principal Name conversion for LDAP user email This is described in http://technet.microsoft.com/en-us/library/cc977992.aspx and can be used in cases the full email address of the person object is not available. Signed-off-by: Jan Blunck <jblunck(a)infradead.org> Compare: https://github.com/openSUSE/open-build-service/compare/378cb8bfe0b6...938e9…

1 0