January 2019 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] d8d489: Don't close dropdowns in monitor filtering
by Stephan Kulow 31 Jan '19

31 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d8d48927467705661bd6576942e84e5d49604708 https://github.com/openSUSE/open-build-service/commit/d8d48927467705661bd65… Author: Ana María Martínez Gómez <anamaria(a)martinezgomez.name> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/assets/javascripts/webui2/project_monitor.js M src/api/app/views/webui2/webui/project/_monitor_control.html.haml Log Message: ----------- Don't close dropdowns in monitor filtering It used to close when selecting one checkbox, which made it really difficult to enable/disable several options. Commit: 23572544f4fca4a8acf18fc945e106f50b242665 https://github.com/openSUSE/open-build-service/commit/23572544f4fca4a8acf18… Author: Ana María Martínez Gómez <anamaria(a)martinezgomez.name> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/assets/javascripts/webui2/project_monitor.js M src/api/app/views/webui2/webui/project/_monitor_control.html.haml Log Message: ----------- Add select all for monitor filters We had an deselect all option for the filters in the monitor page, but not an unselect one. Commit: 15eac063aa54359e9cfb4ff9079392deae2124a8 https://github.com/openSUSE/open-build-service/commit/15eac063aa54359e9cfb4… Author: Ana María Martínez Gómez <anamaria(a)martinezgomez.name> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/api/app/assets/javascripts/webui2/project_monitor.js M src/api/app/views/webui2/webui/project/_monitor_control.html.haml Log Message: ----------- Fix checkboxes div in monitor filtering It was wider than the dropdown. Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Commit: f71568cd90f500e7b6d4f6c727b5db4cdbcf690a https://github.com/openSUSE/open-build-service/commit/f71568cd90f500e7b6d4f… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/api/app/assets/javascripts/webui2/project_monitor.js M src/api/app/views/webui2/webui/project/_monitor_control.html.haml Log Message: ----------- Merge pull request #6878 from Ana06/monitor-filter Improve monitor filtering Compare: https://github.com/openSUSE/open-build-service/compare/3f4f66bd6907...f7156…

1 0

[obs-commits] [openSUSE/open-build-service] e46508: [backend] publisher: do not call bs_regpush twice
by Michael Schroeder 31 Jan '19

31 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e46508c6e54a5822822f0a26a53bf2ee64125f08 https://github.com/openSUSE/open-build-service/commit/e46508c6e54a5822822f0… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/backend/BSPublisher/Container.pm Log Message: ----------- [backend] publisher: do not call bs_regpush twice Oops. This should make container publishing a bit faster... Commit: 3f4f66bd69075c469e9699e932172e81d039ad51 https://github.com/openSUSE/open-build-service/commit/3f4f66bd69075c469e969… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/backend/BSPublisher/Container.pm Log Message: ----------- Merge pull request #6886 from mlschroe/master [backend] publisher: do not call bs_regpush twice Compare: https://github.com/openSUSE/open-build-service/compare/a3f7610d0389...3f4f6…

1 0

[obs-commits] [openSUSE/open-build-service] c2ec9c: Revert "Don't repeat the same javascript behind ev...
by Björn Geuken 31 Jan '19

31 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c2ec9cc2898df3ad329e93caa3241c9895eb96ad https://github.com/openSUSE/open-build-service/commit/c2ec9cc2898df3ad329e9… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui2/webui/comment/_content.html.haml Log Message: ----------- Revert "Don't repeat the same javascript behind every comment" This reverts commit e8a1d5fa00c66f44cc969f2fc435dd4d5829653d. There is no need, or sense, to memoize execution of js methods in ruby. Also this obfuscates the code by making it more complex than it has to be. Commit: 77868bee699aaf3f4f43a7a0000996501dad772f https://github.com/openSUSE/open-build-service/commit/77868bee699aaf3f4f43a… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/comment/_content.html.haml M src/api/app/views/webui2/webui/comment/_show.html.haml Log Message: ----------- Move js event handler for comments to another partial The 'comment/_content' partial is rendered multiple times. Therefore the handler would be registered again and again. By moving it to the comment show view and wrapping it into a document ready statement we ensure that it's called only once, and for any comment img element in the DOM. Follow up of c2ec9cc2898df3ad329e93caa3241c9895eb96ad. Commit: 9623ec9653a4fdf388a3d5d66523003a949b6c88 https://github.com/openSUSE/open-build-service/commit/9623ec9653a4fdf388a3d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/comment/_show.html.haml Log Message: ----------- Fix n + 1 issue in comments partial Commit: a3f7610d03897e866ac101641476a183be5810cf https://github.com/openSUSE/open-build-service/commit/a3f7610d03897e866ac10… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui2/webui/comment/_content.html.haml M src/api/app/views/webui2/webui/comment/_show.html.haml Log Message: ----------- Merge pull request #6870 from bgeuken/update_default_icon_for_comments Update default icon for comments Compare: https://github.com/openSUSE/open-build-service/compare/1d2b21a90590...a3f76…

1 0

[obs-commits] [openSUSE/open-build-service] f29056: Fix monitor page pagination in Firefox
by Björn Geuken 31 Jan '19

31 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f2905673fca01df8f2ad177e2d1d05e1b5d0d685 https://github.com/openSUSE/open-build-service/commit/f2905673fca01df8f2ad1… Author: Ana María Martínez Gómez <anamaria(a)martinezgomez.name> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/project/monitor.html.haml Log Message: ----------- Fix monitor page pagination in Firefox We need to initialize the DataTable after the page is ready. Fixes https://github.com/openSUSE/open-build-service/issues/6561 Commit: 1d2b21a905900656ae192c1c0acf9fa07bb0e393 https://github.com/openSUSE/open-build-service/commit/1d2b21a905900656ae192… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/project/monitor.html.haml Log Message: ----------- Merge pull request #6880 from Ana06/monitor-firefox Fix monitor page pagination in Firefox Compare: https://github.com/openSUSE/open-build-service/compare/702bc764273c...1d2b2…

1 0

[obs-commits] [openSUSE/open-build-service] c2c8e7: [backend] signer: do not write a .bininfo file if ...
by Adrian Schröter 31 Jan '19

31 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c2c8e72dcf6e3f716307626cf81bef3a279a11b8 https://github.com/openSUSE/open-build-service/commit/c2c8e72dcf6e3f7163076… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/backend/bs_signer Log Message: ----------- [backend] signer: do not write a .bininfo file if it didn't exist yet The code reuses entries from the old bininfo files for non-rpm packages, so the entries will be missing if the .bininfo did not exist before. But the job handling code in the scheduler relies on the bininfo containing all entries. Commit: 702bc764273c1ebcfcd17c5e2d1782d64b8656fd https://github.com/openSUSE/open-build-service/commit/702bc764273c1ebcfcd17… Author: Adrian Schröter <adrian(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/backend/bs_signer Log Message: ----------- Merge pull request #6882 from mlschroe/master [backend] signer: do not write a .bininfo file if it didn't exist yet Compare: https://github.com/openSUSE/open-build-service/compare/17eff12d9bc2...702bc…

1 0

[obs-commits] [openSUSE/open-build-service] 17e8f6: [backend] allow a :flavor suffix in the channel pa...
by Adrian Schröter 31 Jan '19

31 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 17e8f6c5949b052a6e9a1604fb7989aac4a98ef9 https://github.com/openSUSE/open-build-service/commit/17e8f6c5949b052a6e9a1… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/backend/BSSched/BuildJob/Channel.pm Log Message: ----------- [backend] allow a :flavor suffix in the channel package definition Commit: 17eff12d9bc22111f2afbfa205223f70903d84e8 https://github.com/openSUSE/open-build-service/commit/17eff12d9bc22111f2afb… Author: Adrian Schröter <adrian(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/backend/BSSched/BuildJob/Channel.pm Log Message: ----------- Merge pull request #6876 from mlschroe/master [backend] allow a :flavor suffix in the channel package definition Compare: https://github.com/openSUSE/open-build-service/compare/7291c5f51571...17eff…

1 0

[obs-commits] [openSUSE/open-build-service] 658f8f: Use an SQL query to check whether a package has a ...
by Björn Geuken 31 Jan '19

31 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 658f8f273bb211041dcfb881f3239ea4584865f5 https://github.com/openSUSE/open-build-service/commit/658f8f273bb211041dcfb… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/project.rb A src/api/spec/cassettes/Webui_ProjectController/GET_show/with_patchinfo/1_13_4_1.yml M src/api/spec/controllers/webui/project_controller_spec.rb Log Message: ----------- Use an SQL query to check whether a package has a patchinfo or not This is much faster than iterating through an array and checking a hashed backend result for each package. Commit: 7291c5f51571e5b2b88a1473d0d81d1e18bff9e5 https://github.com/openSUSE/open-build-service/commit/7291c5f51571e5b2b88a1… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/project.rb A src/api/spec/cassettes/Webui_ProjectController/GET_show/with_patchinfo/1_13_4_1.yml M src/api/spec/controllers/webui/project_controller_spec.rb Log Message: ----------- Merge pull request #6829 from bgeuken/has_patchinfo_refactoring Use an SQL query to check whether a package has a patchinfo or not Compare: https://github.com/openSUSE/open-build-service/compare/b63fb67c523e...7291c…

1 0

[obs-commits] [openSUSE/open-build-service] cfbe47: Change my email
by Ana María Martínez Gómez 30 Jan '19

30 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: cfbe47c90a155b3fcf41cc0963180563db6ac926 https://github.com/openSUSE/open-build-service/commit/cfbe47c90a155b3fcf41c… Author: Ana María Martínez Gómez <anamaria(a)martinezgomez.name> Date: 2019-01-29 (Tue, 29 Jan 2019) Changed paths: M .gitmessage Log Message: ----------- Change my email In the commit template. Commit: b63fb67c523ea84b7ef41572ff92d2417d5245ed https://github.com/openSUSE/open-build-service/commit/b63fb67c523ea84b7ef41… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M .gitmessage Log Message: ----------- Merge pull request #6865 from Ana06/email Change my email Compare: https://github.com/openSUSE/open-build-service/compare/4f33b42c9242...b63fb…

1 0

[obs-commits] [openSUSE/open-build-service]
by dmarcoux 30 Jan '19

30 Jan '19

Branch: refs/heads/depfu/update/srcapi/rubocop-rspec-1.32.0 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] 461756: Update rubocop-rspec to version 1.32.0
by Dany Marcoux 30 Jan '19

30 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4617562c81977407198a1e4a367691f06a76afb1 https://github.com/openSUSE/open-build-service/commit/4617562c81977407198a1… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2019-01-28 (Mon, 28 Jan 2019) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-rspec to version 1.32.0 Commit: 4f33b42c924296ee8e9d33c155e773a0f3b7c7f6 https://github.com/openSUSE/open-build-service/commit/4f33b42c924296ee8e9d3… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6860 from openSUSE/depfu/update/srcapi/rubocop-rspec-1.32.0 [src/api] Update rubocop-rspec: 1.31.0 → 1.32.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/b1d764114f8e...4f33b…

1 0