Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c2ec9cc2898df3ad329e93caa3241c9895eb96ad https://github.com/openSUSE/open-build-service/commit/c2ec9cc2898df3ad329e93... Author: Björn Geuken <bgeuken@suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui2/webui/comment/_content.html.haml Log Message: ----------- Revert "Don't repeat the same javascript behind every comment" This reverts commit e8a1d5fa00c66f44cc969f2fc435dd4d5829653d. There is no need, or sense, to memoize execution of js methods in ruby. Also this obfuscates the code by making it more complex than it has to be. Commit: 77868bee699aaf3f4f43a7a0000996501dad772f https://github.com/openSUSE/open-build-service/commit/77868bee699aaf3f4f43a7... Author: Björn Geuken <bgeuken@suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/comment/_content.html.haml M src/api/app/views/webui2/webui/comment/_show.html.haml Log Message: ----------- Move js event handler for comments to another partial The 'comment/_content' partial is rendered multiple times. Therefore the handler would be registered again and again. By moving it to the comment show view and wrapping it into a document ready statement we ensure that it's called only once, and for any comment img element in the DOM. Follow up of c2ec9cc2898df3ad329e93caa3241c9895eb96ad. Commit: 9623ec9653a4fdf388a3d5d66523003a949b6c88 https://github.com/openSUSE/open-build-service/commit/9623ec9653a4fdf388a3d5... Author: Björn Geuken <bgeuken@suse.de> Date: 2019-01-30 (Wed, 30 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/comment/_show.html.haml Log Message: ----------- Fix n + 1 issue in comments partial Commit: a3f7610d03897e866ac101641476a183be5810cf https://github.com/openSUSE/open-build-service/commit/a3f7610d03897e866ac101... Author: Björn Geuken <bgeuken@suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui2/webui/comment/_content.html.haml M src/api/app/views/webui2/webui/comment/_show.html.haml Log Message: ----------- Merge pull request #6870 from bgeuken/update_default_icon_for_comments Update default icon for comments Compare: https://github.com/openSUSE/open-build-service/compare/1d2b21a90590...a3f761...