December 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] e5bc7f: Update styling of monitor filter
by Björn Geuken 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e5bc7fcc9c26f4c72bf9bb3b28e4d0c243082f73 https://github.com/openSUSE/open-build-service/commit/e5bc7fcc9c26f4c72bf9b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/_monitor_control.html.haml Log Message: ----------- Update styling of monitor filter * Give it more emphasive by removing the 'outline' style. * Make it more explicit that this is an action by updating the button label. Commit: 6f3575c3500fa533ee6093d4b257de7c93408883 https://github.com/openSUSE/open-build-service/commit/6f3575c3500fa533ee609… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/_monitor_control.html.haml Log Message: ----------- Merge pull request #6647 from bgeuken/update_styling_of_monitor_filter Update styling of monitor filter Compare: https://github.com/openSUSE/open-build-service/compare/da422eb40960...6f357… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 6d38e3: Prefetch all elements required to render requests
by Stephan Kulow 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6d38e3417f6f7cac7b040cb55fa49ecd682ef5e8 https://github.com/openSUSE/open-build-service/commit/6d38e3417f6f7cac7b040… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/controllers/search_controller.rb Log Message: ----------- Prefetch all elements required to render requests /search/request is one of the slowest routes we have and most time is not spent in searching, but in rendering the results. Help the model by prefetching all required elements. One often request route is all pending requests to openSUSE:Factory Before: Completed 200 OK in 14263ms (Views: 0.1ms | ActiveRecord: 2358.7ms | Backend: 0.0ms) After: Completed 200 OK in 4725ms (Views: 0.1ms | ActiveRecord: 252.8ms | Backend: 0.0ms) Co-authored-by: Ana María Martínez Gómez <ammartinez(a)suse.de> Commit: da422eb40960531ccbb60a1554b0fe086c40c266 https://github.com/openSUSE/open-build-service/commit/da422eb40960531ccbb60… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/controllers/search_controller.rb Log Message: ----------- Merge pull request #6641 from coolo/prefetch_search_request Prefetch all elements required to render requests Compare: https://github.com/openSUSE/open-build-service/compare/d779e1bbcd4f...da422… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 9653de: Cache User#is_admin? & User#is_staff?
by Stephan Kulow 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9653de6ac5db904e243f1e06e73100a214a3e634 https://github.com/openSUSE/open-build-service/commit/9653de6ac5db904e243f1… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Cache User#is_admin? & User#is_staff? is_admin? is called in many places, often 3 and more times per action. Co-authored-by: Ana María Martínez Gómez <ammartinez(a)suse.de> Commit: d779e1bbcd4f0a49ad333f67b50ed3657f379860 https://github.com/openSUSE/open-build-service/commit/d779e1bbcd4f0a49ad333… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Merge pull request #6642 from coolo/cache_is_admin Cache User#is_admin? & User#is_staff? Compare: https://github.com/openSUSE/open-build-service/compare/98757d52d11e...d779e… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 4bbceb: Do not use expensive hash keys for cheap queries
by Björn Geuken 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4bbceb5ce00aa37d5798ef071b4128301132f631 https://github.com/openSUSE/open-build-service/commit/4bbceb5ce00aa37d5798e… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/models/role.rb Log Message: ----------- Do not use expensive hash keys for cheap queries Role.hashed uses Rails.all.cache_key - which is rather expensive SELECT COUNT(*) AS `size`, MAX(`roles`.`updated_at`) AS timestamp FROM `roles` to avoid querying 8 role titles. The problem is that all the other code expects Role.hashed to be cheaper than querying the database directly - which is no longer true with this approach. E.g. irb(main):001:0> Role.local_roles (0.2ms) SELECT COUNT(*) AS `size`, MAX(`roles`.`updated_at`) AS timestamp FROM `roles` (0.3ms) SELECT COUNT(*) AS `size`, MAX(`roles`.`updated_at`) AS timestamp FROM `roles` (0.2ms) SELECT COUNT(*) AS `size`, MAX(`roles`.`updated_at`) AS timestamp FROM `roles` (0.2ms) SELECT COUNT(*) AS `size`, MAX(`roles`.`updated_at`) AS timestamp FROM `roles` (0.2ms) SELECT COUNT(*) AS `size`, MAX(`roles`.`updated_at`) AS timestamp FROM `roles` I noticed these repeated queries when working on involved_packages and wondered since then what is going on. Commit: 98757d52d11edb13225057c915ec33ddc0048c5d https://github.com/openSUSE/open-build-service/commit/98757d52d11edb1322505… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/models/role.rb Log Message: ----------- Merge pull request #6633 from coolo/fix_role_hashed Do not use expensive hash keys for cheap queries Compare: https://github.com/openSUSE/open-build-service/compare/955a91fabda8...98757… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] bfbbe3: [backend] slow request log: log worker requests in...
by Michael Schroeder 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: bfbbe3a102608b205a3a495b0d7410d58b73be9e https://github.com/openSUSE/open-build-service/commit/bfbbe3a102608b205a3a4… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/backend/BSServer.pm M src/backend/BSStdServer.pm Log Message: ----------- [backend] slow request log: log worker requests into a different file Commit: 955a91fabda820fad7ecd501be002256342e67b4 https://github.com/openSUSE/open-build-service/commit/955a91fabda820fad7ecd… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/backend/BSServer.pm M src/backend/BSStdServer.pm Log Message: ----------- Merge pull request #6643 from mlschroe/master [backend] slow request log: log worker requests into a different file Compare: https://github.com/openSUSE/open-build-service/compare/ee4292af17d7...955a9… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/obs-build] 40c5af: [dist] do a simple syntax check in check section
by GitHub 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 40c5af792d6771ac1db9720b21157a3291f37d67 https://github.com/openSUSE/obs-build/commit/40c5af792d6771ac1db9720b21157a… Author: Ruediger Oertel <ro(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M dist/build.spec Log Message: ----------- [dist] do a simple syntax check in check section Commit: 588375d893d5c66708e4f7f281c02e869e133d98 https://github.com/openSUSE/obs-build/commit/588375d893d5c66708e4f7f281c02e… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M dist/build.spec Log Message: ----------- Merge pull request #482 from bugfinder/check_during_build [dist] do a simple syntax check in check section Compare: https://github.com/openSUSE/obs-build/compare/738f1948330c...588375d893d5 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 37474d: Update subheader for repository states
by David Kang 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 37474d0bd3a3ad51013f7c3ad50df6af80795464 https://github.com/openSUSE/open-build-service/commit/37474d0bd3a3ad51013f7… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-14 (Fri, 14 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/package/binaries.html.haml Log Message: ----------- Update subheader for repository states Reduce the icon size so that it matches with our default icon size. Commit: ffcb8d7109608166ac89515aa9e874b5b67268ca https://github.com/openSUSE/open-build-service/commit/ffcb8d7109608166ac895… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-14 (Fri, 14 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/package/binaries.html.haml Log Message: ----------- Remove explicit mentioning of repository and architecture It's evident that #repository_name is a repository given that we are on the repository page. And since the architecture names don't change per project, we don't need to repeatedly add an 'Architecture: ' prefix to each binary list. Commit: ee4292af17d7c3fad1472267fafd47b9ae229eac https://github.com/openSUSE/open-build-service/commit/ee4292af17d7c3fad1472… Author: David Kang <dkang(a)suse.com> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/package/binaries.html.haml Log Message: ----------- Merge pull request #6544 from bgeuken/update_icon_on_repository_state_page Update subheader for repository states Compare: https://github.com/openSUSE/open-build-service/compare/9559d3d88b90...ee429… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 17 Dec '18

17 Dec '18

Branch: refs/heads/depfu/update/srcapi/concurrent-ruby-ext-1.1.4 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 17 Dec '18

17 Dec '18

Branch: refs/heads/depfu/update/srcapi/concurrent-ruby-1.1.4 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 83f87f: Update concurrent-ruby to version 1.1.4
by Stephan Kulow 17 Dec '18

17 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 83f87fee80df75b28de19d234554551686d217ae https://github.com/openSUSE/open-build-service/commit/83f87fee80df75b28de19… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-16 (Sun, 16 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update concurrent-ruby to version 1.1.4 Commit: 9559d3d88b905e47de2fead0bd8fcd5daf98dab9 https://github.com/openSUSE/open-build-service/commit/9559d3d88b905e47de2fe… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-17 (Mon, 17 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6628 from openSUSE/depfu/update/srcapi/concurrent-ruby-1.1.4 [src/api] Update concurrent-ruby: 1.1.3 → 1.1.4 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/b01a7c2e5a01...9559d… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0