December 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 5f77a0: Avoid N+1 queries in update policy
by Stephan Kulow 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5f77a024cba5d20f65b4c280d0cdb943c49cb762 https://github.com/openSUSE/open-build-service/commit/5f77a024cba5d20f65b4c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Avoid N+1 queries in update policy has_remote_repositories? is called from project update? policy, which is called in a lot of places. And it's horribly slow as it loops through an array with N+1 queries looking like this in logs: DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 357782 LIMIT 1 DownloadRepository Exists (0.2ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 157220 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 214402 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 289102 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 264047 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 320882 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 408379 LIMIT 1 Using one subselect gives you one access into the repositories index. p=Project.find_by_name('openSUSE:Tools') irb(main):022:0> Benchmark.measure { 100.times { p.has_remote_repositories_old? } } => real=2.6102131991647184 irb(main):023:0> Benchmark.measure { 100.times { p.has_remote_repositories? } } => real=0.0647597061470151 Commit: f47ecabbb3ee7fd51eb9e4a6536ab6c799d330a3 https://github.com/openSUSE/open-build-service/commit/f47ecabbb3ee7fd51eb9e… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Merge pull request #6682 from coolo/avoid_sql3 Avoid N+1 queries in update policy Compare: https://github.com/openSUSE/open-build-service/compare/708540bb012a...f47ec… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 20 Dec '18

20 Dec '18

Branch: refs/heads/depfu/update/srcapi/font-awesome-sass-5.6.1 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 29844d: Update font-awesome-sass to version 5.6.1
by Stephan Kulow 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 29844d66eddeddb5e8350d8eed0ac13c232ce88b https://github.com/openSUSE/open-build-service/commit/29844d66eddeddb5e8350… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update font-awesome-sass to version 5.6.1 Commit: 708540bb012a6f4251917229681079d5925a6424 https://github.com/openSUSE/open-build-service/commit/708540bb012a6f4251917… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6681 from openSUSE/depfu/update/srcapi/font-awesome-sass-5.6.1 [src/api] Update font-awesome-sass: 5.5.0.1 → 5.6.1 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/c5d34def3ec8...70854… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 3daaab: Make it possible to preload repository architectur...
by Henne Vogelsang 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3daaab49245359d6a357d424f62c1f2a5ea25726 https://github.com/openSUSE/open-build-service/commit/3daaab49245359d6a357d… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/repository.rb Log Message: ----------- Make it possible to preload repository architectures Remove the duplicated order statement, which breaks preloading. This order isn't used normally (as it's a :through relationship and repository_architectures have an order already), but it breaks in preload situation where rails will load all architectures in a 2nd statement. Fixes #6662 Commit: c5d34def3ec876735ddc78f10dc985b4e9bea2e0 https://github.com/openSUSE/open-build-service/commit/c5d34def3ec876735ddc7… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/repository.rb Log Message: ----------- Merge pull request #6666 from coolo/fix_6662 Make it possible to preload architectures Compare: https://github.com/openSUSE/open-build-service/compare/491b8f25316e...c5d34… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 20 Dec '18

20 Dec '18

Branch: refs/heads/depfu/update/srcapi/erubi-1.8.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 20ef93: Update erubi to version 1.8.0
by Stephan Kulow 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 20ef939f6a75cc9ba3b8c286f5a920956f44ca0c https://github.com/openSUSE/open-build-service/commit/20ef939f6a75cc9ba3b8c… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update erubi to version 1.8.0 Commit: 491b8f25316ecc2394e01d8a3a589ab8b57e182d https://github.com/openSUSE/open-build-service/commit/491b8f25316ecc2394e01… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6676 from openSUSE/depfu/update/srcapi/erubi-1.8.0 [src/api] Update erubi: 1.7.1 → 1.8.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/dbc61f858760...491b8… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] aa11f1: Rename and clean set_flavors up
by Alexander Graul 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: aa11f1be97f1744d815e620dd8b826374e897556 https://github.com/openSUSE/software-o-o/commit/aa11f1be97f1744d815e620dd8b… Author: Alexander Graul <agraul(a)suse.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M app/controllers/download_controller.rb Log Message: ----------- Rename and clean set_flavors up We use the American spelling ("flavor") everywhere else in the file, this method should not be an outlier. The method is shorter now and uses a guard clause instead of an if-else block and a more concise and efficient sort. Commit: 44063691ea4e4087677f282b452c17e06c567375 https://github.com/openSUSE/software-o-o/commit/44063691ea4e4087677f282b452… Author: Alexander Graul <agraul(a)suse.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M app/controllers/download_controller.rb Log Message: ----------- Remove unused method set_parameters was not used anywhere. Commit: c3f684dbe2687eb2226997e1144560579a7f86dc https://github.com/openSUSE/software-o-o/commit/c3f684dbe2687eb2226997e1144… Author: Alexander Graul <agraul(a)suse.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M app/controllers/download_controller.rb Log Message: ----------- Merge pull request #446 from alexandergraul/download-controller-cleanup Small cleanup of download controller Compare: https://github.com/openSUSE/software-o-o/compare/a3b136446c32...c3f684dbe268 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 6fb2a2: Avoid N+1 queries in comments controller
by Stephan Kulow 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6fb2a24bab901ea9b9517efd916dd87e1bae0390 https://github.com/openSUSE/open-build-service/commit/6fb2a24bab901ea9b9517… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/comments_controller.rb Log Message: ----------- Avoid N+1 queries in comments controller According to metrics.opensuse.org the comments/index.xml.builder view has the most impact - rendered 106K in 24 hours (all these bots communicating through comments don't help) Commit: ad2bc11601127009b12247aacb32e7efbc9728d2 https://github.com/openSUSE/open-build-service/commit/ad2bc11601127009b1224… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: R src/api/app/views/comments/_comments.xml.builder M src/api/app/views/comments/index.xml.builder Log Message: ----------- Merge 2 three-line views into one The partial is only used in one view and repeats the same call in a loop, so better pull it out Commit: dbc61f858760e456bbb00691e598ed1a8752adc0 https://github.com/openSUSE/open-build-service/commit/dbc61f858760e456bbb00… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/comments_controller.rb R src/api/app/views/comments/_comments.xml.builder M src/api/app/views/comments/index.xml.builder Log Message: ----------- Merge pull request #6668 from coolo/preload_users Avoid N+1 queries in comments controller Compare: https://github.com/openSUSE/open-build-service/compare/12c4f9a52101...dbc61… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 6a429e: Set correct date range and period during initial p...
by Henne Vogelsang 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6a429eaf72cd6b1700dd16e7d4123f10243df071 https://github.com/openSUSE/open-build-service/commit/6a429eaf72cd6b1700dd1… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/pulse_controller.rb M src/api/app/views/webui2/webui/projects/pulse/show.html.haml Log Message: ----------- Set correct date range and period during initial page load Commit: 632c1d5b18133d9b0691e95483ea75a183c0095b https://github.com/openSUSE/open-build-service/commit/632c1d5b18133d9b0691e… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/show.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.js.erb Log Message: ----------- Reuse spinner on pulse page instead of always overwriting it The spinner is now always in the same position. It was previously centered during the initial page load, then on the left whenever changing the selected period in the dropdown. This was caused by the HTML and CSS classes which differed. Commit: 4989c0fd447f2b3172482cd15075c6a1f56d717c https://github.com/openSUSE/open-build-service/commit/4989c0fd447f2b3172482… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests.html.haml Log Message: ----------- Set the request description as a tooltip It isn't truncated anymore Commit: 173652f787961bb94fa3162099324a5381f63932 https://github.com/openSUSE/open-build-service/commit/173652f787961bb94fa31… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_changes.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_comments.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_commits.html.haml Log Message: ----------- Emphasize information under date range in pulse page Commit: 7bb83d85cc05e8422f4fcc366595433072e38f8a https://github.com/openSUSE/open-build-service/commit/7bb83d85cc05e8422f4fc… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list.html.haml Log Message: ----------- Use accordions for lists on the pulse page Also display lists only if data is present Commit: 90ea0ce91a170c42bbff3079189bb1b3fe72c22b https://github.com/openSUSE/open-build-service/commit/90ea0ce91a170c42bbff3… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list.html.haml A src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests_box.html.haml Log Message: ----------- Use a partial for the Requests box in the pulse page Commit: 12c4f9a5210170f6bb6eec802eb29a387d6864da https://github.com/openSUSE/open-build-service/commit/12c4f9a5210170f6bb6ee… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/pulse_controller.rb M src/api/app/views/webui2/webui/projects/pulse/_pulse_list.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_changes.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_comments.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_commits.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests.html.haml A src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests_box.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.js.erb Log Message: ----------- Merge pull request #6669 from dmarcoux/improve-pulse-bootstrap Improvements for the pulse page Compare: https://github.com/openSUSE/open-build-service/compare/be6894228072...12c4f… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 122098: ProjectUpdater#call returns self
by Victor Pereira 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 122098dacacf32e2c7bee83c157ab0e8168ae9ff https://github.com/openSUSE/open-build-service/commit/122098dacacf32e2c7bee… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/meta_controller.rb M src/api/app/services/meta_controller_service/project_updater.rb M src/api/spec/controllers/webui/projects/meta_controller_spec.rb A src/api/spec/services/meta_controller_service/project_updater_spec.rb Log Message: ----------- ProjectUpdater#call returns self calling call should return the ProjectUpdater instance as normally done with Service objects, giving us the ability to mock it with a simple Proc object Simplify call to ProjectUpdater#call on MetAcontroller#update Stub calls to service objects on MetaControllerSpec to avoid VCR Add spec for ProjectUpdater service object Commit: 4a574ed0f93070997c18c56bb230885f2a315fc5 https://github.com/openSUSE/open-build-service/commit/4a574ed0f93070997c18c… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_2.yml Log Message: ----------- Remove unused cassettes Commit: be6894228072f74e5b2d1c645d5b87a0330aea58 https://github.com/openSUSE/open-build-service/commit/be6894228072f74e5b2d1… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/meta_controller.rb M src/api/app/services/meta_controller_service/project_updater.rb R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_2.yml M src/api/spec/controllers/webui/projects/meta_controller_spec.rb A src/api/spec/services/meta_controller_service/project_updater_spec.rb Log Message: ----------- Merge pull request #6620 from vpereira/meta_controller_spec Refactor Meta controller related specs Compare: https://github.com/openSUSE/open-build-service/compare/5bd21f977117...be689… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0