April 2020 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] dcb298: Update amq-protocol to version 2.3.1
by depfu[bot] 09 Apr '20

09 Apr '20

Branch: refs/heads/depfu/update/srcapi/amq-protocol-2.3.1 Home: https://github.com/openSUSE/open-build-service Commit: dcb2982d6b5f3c6cd10526510f17011ae83d4282 https://github.com/openSUSE/open-build-service/commit/dcb2982d6b5f3c6cd1052… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2020-04-09 (Thu, 09 Apr 2020) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update amq-protocol to version 2.3.1

1 0

[obs-commits] [openSUSE/open-build-service] 2cd50e: [dist] move memcached restart to postun of obs-api...
by Henne Vogelsang 08 Apr '20

08 Apr '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2cd50e6d9b06a192f9e543440166d0f15bfdcc82 https://github.com/openSUSE/open-build-service/commit/2cd50e6d9b06a192f9e54… Author: Rüdiger Oertel <ro(a)suse.de> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] move memcached restart to postun of obs-api package where it belongs according to package conventions Commit: 8c41cb63920eca170f04c3d0045a688c62a30de3 https://github.com/openSUSE/open-build-service/commit/8c41cb63920eca170f04c… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M dist/obs-server.spec Log Message: ----------- Merge pull request #9354 from bugfinder/master [dist] move memcached restart to postun of obs-api package Compare: https://github.com/openSUSE/open-build-service/compare/1a79cbe37eb5...8c41c…

1 0

[obs-commits] [openSUSE/open-build-service] 873623: Link to Tasks in the Places menu
by Dany Marcoux 08 Apr '20

08 Apr '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8736238d6f04a85b542f4db75de5107e55546a67 https://github.com/openSUSE/open-build-service/commit/8736238d6f04a85b542f4… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M src/api/app/views/layouts/webui/responsive_ux/_bottom_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_user_navigation.html.haml M src/api/app/views/webui/users/notifications/index.html.haml Log Message: ----------- Link to Tasks in the Places menu This implies removing the `All Requests` workaround we had in the `Notifications` page. The link to the `Notifications` page in the top-level navigation is now correctly named. Commit: 1a79cbe37eb5dd241040a229831cbfe4d40d1a60 https://github.com/openSUSE/open-build-service/commit/1a79cbe37eb5dd241040a… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M src/api/app/views/layouts/webui/responsive_ux/_bottom_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_user_navigation.html.haml M src/api/app/views/webui/users/notifications/index.html.haml Log Message: ----------- Merge pull request #9356 from dmarcoux/link-to-my-tasks Link to Tasks in the Places menu Compare: https://github.com/openSUSE/open-build-service/compare/cb8562372605...1a79c…

1 0

[obs-commits] [openSUSE/obs-build] 5a586b: extend --ccache to generate _ccache.tar.gz and imp...
by Sumit Jamgade 08 Apr '20

08 Apr '20

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 5a586bed0b2799bfb4cf9d0b84fd40441cba6cad https://github.com/openSUSE/obs-build/commit/5a586bed0b2799bfb4cf9d0b84fd40… Author: Sumit Jamgade <sjamgade(a)suse.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M build M build-vm Log Message: ----------- extend --ccache to generate _ccache.tar.gz and implement --pkg-ccache with `--ccache` every build will generate a `OTHER/_ccache.tar.gz` archive which can be used for subsequent builds. However for local builds explicit path to archive with `--pkg-ccahe` is necessary. A user provided archive can be used as ccache contents with `--pkg-ccache=/path/to/archive.tar.gz` `--pkg-ccache` will override the default ccache. (`--pkg-ccahe` implies `--ccache` but with provided archive) Commit: ca8cafd46d63c6b68ed5a0a98cdde30abc0d6ed2 https://github.com/openSUSE/obs-build/commit/ca8cafd46d63c6b68ed5a0a98cdde3… Author: Sumit Jamgade <sjamgade(a)users.noreply.github.com> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M build M build-vm Log Message: ----------- Merge pull request #559 from sjamgade/ccache extend --ccache to generate _ccache.tar.gz and implement --pkg-ccache Compare: https://github.com/openSUSE/obs-build/compare/9195922eaa67...ca8cafd46d63

1 0

[obs-commits] [openSUSE/open-build-service] cb9469: [backend]pass --ccache param if usecache:packid is...
by Sumit Jamgade 08 Apr '20

08 Apr '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: cb94696c92ea8a1c54d3aa164535022291b056f4 https://github.com/openSUSE/open-build-service/commit/cb94696c92ea8a1c54d3a… Author: Sumit Jamgade <sjamgade(a)suse.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M src/backend/bs_worker Log Message: ----------- [backend]pass --ccache param if usecache:packid is present as buildflag this buildflag is to be manually added in project config as BuildFlags: useccache:package-name along with this ccache has be included as BuildRequires in the spec file for ccache to be installable. If buildflag is added but ccache is not present it will result in error Commit: cb8562372605db88e3f985c00bb1aafa6f87dc14 https://github.com/openSUSE/open-build-service/commit/cb8562372605db88e3f98… Author: Sumit Jamgade <sjamgade(a)users.noreply.github.com> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M src/backend/bs_worker Log Message: ----------- Merge pull request #9346 from sjamgade/ccache [backend]pass --ccache param if usecache:packid is present as buildflag Compare: https://github.com/openSUSE/open-build-service/compare/003535b0c1e4...cb856…

1 0

[obs-commits] [openSUSE/open-build-service] e85203: Add scope for notifications without notifiable
by Henne Vogelsang 08 Apr '20

08 Apr '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e8520381ea9d3451b1d25a6a01549c6b57860cff https://github.com/openSUSE/open-build-service/commit/e8520381ea9d3451b1d25… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-03-26 (Thu, 26 Mar 2020) Changed paths: M src/api/app/models/notification.rb Log Message: ----------- Add scope for notifications without notifiable Commit: fc70acab118fcbbe2e82388a51c8fd2543e74f66 https://github.com/openSUSE/open-build-service/commit/fc70acab118fcbbe2e823… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-03-26 (Thu, 26 Mar 2020) Changed paths: M src/api/spec/factories/notification.rb Log Message: ----------- Fix typo on event name RequestCreate Commit: fa4c0889636c4cbbdc0e7708b2b18a31a8662e85 https://github.com/openSUSE/open-build-service/commit/fa4c0889636c4cbbdc0e7… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-04-02 (Thu, 02 Apr 2020) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/comment.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/review.rb Log Message: ----------- Refactor code related to events creation Before, when a change in an object triggered an event creation, the method 'create_notification' was called. It calculated the set of parameters needed to create the event (according to the type) and then created the event. Now, the same functionality is splitted in two methods: 'event_parameters' (public) and 'create_event' (private). This way the set of parameters is accesible from other parts of the code. Co-authored-by: David Kang <dkang(a)suse.com> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: a8ae0b12cc1f734f82bef16987fd5da38866542d https://github.com/openSUSE/open-build-service/commit/a8ae0b12cc1f734f82bef… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-04-02 (Thu, 02 Apr 2020) Changed paths: M src/api/app/models/event/base.rb M src/api/app/models/event/comment_event.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/event_subscription.rb Log Message: ----------- Get the parameters for notifications from each model When creating a notification we use a set of parameters. Some of them are common (event type, payload, etc.) and some others depend on the type of event. Before, we calculated all the possible sets of parameters in a concrete point of the code by checking the event type. Now, we added a method called 'parameters_for_notification' to each kind of event so we just ask them for its set of parameters. Co-authored-by: David Kang <dkang(a)suse.com> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 4e434ed3f9c8e5d7a71c94bbaef55a473b83be1f https://github.com/openSUSE/open-build-service/commit/4e434ed3f9c8e5d7a71c9… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-04-06 (Mon, 06 Apr 2020) Changed paths: M src/api/app/jobs/send_event_emails_job.rb A src/api/app/services/notification_creator.rb A src/api/spec/services/notification_creator_spec.rb Log Message: ----------- Define NotificationCreator service The notification creation code used to be inside the SendEventEmailsJob. The parameters needed to create the notifications were also calculated there (according to the type of event). Now, the creation is isolated in the NotificationCreator service, which keeps the code tidy and makes it accesible from other parts of the code. The calculation of the parameters has been distributed to the corresponding models. They all have now a method called 'parameters_for_notification' to do so. Co-authored-by: David Kang <dkang(a)suse.com> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 3cd61ddc8104c9771557c7bac69947c4c0d80200 https://github.com/openSUSE/open-build-service/commit/3cd61ddc8104c9771557c… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M src/api/app/models/comment.rb M src/api/app/models/event/base.rb M src/api/app/models/event/comment_event.rb M src/api/app/models/review.rb Log Message: ----------- Track date for all the notifiable events A few event types used to track, in its payload, the date and time when the event was triggered. The 'when' key was used for this. From now on, all the notifiable event types track this value. Now, when a notification is created, its timestaps fields (create_at and updated_at) are set to the 'when' value. This way, we ensure they have realistic date and time according to the moment when the event happened and not when the notification was created (what usually happens some time later). Commit: 003535b0c1e4c43f88f1b1c41fcf001711cbf061 https://github.com/openSUSE/open-build-service/commit/003535b0c1e4c43f88f1b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/bs_request.rb M src/api/app/models/comment.rb M src/api/app/models/event/base.rb M src/api/app/models/event/comment_event.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/event_subscription.rb M src/api/app/models/notification.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/review.rb A src/api/app/services/notification_creator.rb M src/api/spec/factories/notification.rb A src/api/spec/services/notification_creator_spec.rb Log Message: ----------- Merge pull request #9307 from saraycp/data_migration_notifications Refactor notification's creation code Compare: https://github.com/openSUSE/open-build-service/compare/d43bca2b38a9...00353…

1 0

[obs-commits] [openSUSE/open-build-service] 9878b8: Bump rails gem version to 6.0
by Henne Vogelsang 08 Apr '20

08 Apr '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9878b8b7e32f73b089fd2293cb199db999bf0a18 https://github.com/openSUSE/open-build-service/commit/9878b8b7e32f73b089fd2… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock Log Message: ----------- Bump rails gem version to 6.0 Commit: 4362e505719f307a803f317af1a898ed023e908b https://github.com/openSUSE/open-build-service/commit/4362e505719f307a803f3… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/config/application.rb Log Message: ----------- Enable rails 6 defaults and keep classic code loading mechanism Keep the classic code loading mechanism for now, since the usuage of zeitwerk need a lot of restructuring regarding the naming of classes etc. This should be tackled as soon as the upgrade to Rails 6 was successfully. Commit: 7ea1213b93d157ceb93bd601389aa772fb9f6163 https://github.com/openSUSE/open-build-service/commit/7ea1213b93d157ceb93bd… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/app/models/role.rb M src/api/config/application.rb M src/api/config/initializers/new_framework_defaults.rb Log Message: ----------- Fix validation and association deprecations for rails 6.0 upgrade A few things let to a broken development setup, since a couple of the seeds couldn't sucessfully insert new entries to the database * the uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. * since Rails 5 a belongs_to association requires to have the associated record to be present. This should be refactored in the future,but for now we can keep the old behaviour by setting 'belongs_to_required_by_default' to false in the application.rb. Commit: c9f0c6cf55b0aafa0f090aea2c8ecc4d838d5cc9 https://github.com/openSUSE/open-build-service/commit/c9f0c6cf55b0aafa0f090… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/spec/controllers/webui/apidocs_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb Log Message: ----------- Switch to media_type instead of content_type in rspec tests In Rails 6, the return value of "ActionDispatch::Response#content_type" contains the charset as well. Commit: c9e20af4600a4a16252d9f07cfe9a768f3208b1c https://github.com/openSUSE/open-build-service/commit/c9e20af4600a4a16252d9… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/review_spec.rb Log Message: ----------- Adjust rspec tests for the usage of recyclable cache key Commit: 0f198cba0a801a86976ad6ede7e2553f812e33c2 https://github.com/openSUSE/open-build-service/commit/0f198cba0a801a86976ad… Author: Stephan Kulow <coolo(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Expect dates as `as_json` expects them Increases compatibility with rails6 Commit: 58bf15d23c9504e7cb124bed07f2a23617c2c9a7 https://github.com/openSUSE/open-build-service/commit/58bf15d23c9504e7cb124… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/config/initializers/new_framework_defaults.rb Log Message: ----------- Use to_time behaviour introduced in ruby 2.4 Since ruby 2.4 the to_time method preserve receiver’s timezone offset instead of it's own system timezone offset. This was a breaking change in rails 5.0 and got manually disabled at the upgrade of OBS. Turns out the only place where to_time is used, is the issue_tracker model. Since the datetime entry for the issue_tracker is set by the OBS frontend, its fine to enable the default behaviour, since the timezone offset doesn't differ. Commit: 923fd017f56c017e2fb50635b1df7be45b847d24 https://github.com/openSUSE/open-build-service/commit/923fd017f56c017e2fb50… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: R src/api/config/initializers/new_framework_defaults.rb Log Message: ----------- Enable per-form CSRF tokens and origin-checking CSRF mitigation Both features got introduced with Rails 5.0 and bring some improvements in terms of security. Both features dont break the setup, so we can enable them. Commit: d268b281fcbb30fcd0cbee82a0514264e9950261 https://github.com/openSUSE/open-build-service/commit/d268b281fcbb30fcd0cbe… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Ignore rubocop offenses in existing codebase after rails 6 upgrade Rubocop complains about two offenses in the configuration_controller after the upgrade to Rails 6.0 Commit: e79ee0171e57527a1183e396d6e05945a191f4af https://github.com/openSUSE/open-build-service/commit/e79ee0171e57527a1183e… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock Log Message: ----------- Dont use puma server default version from rails 5 anymore There is no reason to use the default puma version from rails 5 after the migration to rails 6.0. Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: f04cf373a01e26cdec37f4e4ac698fb30531810e https://github.com/openSUSE/open-build-service/commit/f04cf373a01e26cdec37f… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: M src/api/test/fixtures/path_elements.yml M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Adapt the minitests to the Rails 6 upgrade * Fix know issues with the ActiveJob queue_adapter with Rails 6 for tests cases, in the minitests. * Adapt outdated syntax in fixtures Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Co-authored-by: Stephan Kulow <coolo(a)suse.de> Commit: 34e129f58182bf26c7b972c31466ae87103e5422 https://github.com/openSUSE/open-build-service/commit/34e129f58182bf26c7b97… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2020-04-03 (Fri, 03 Apr 2020) Changed paths: A src/api/db/migrate/20200402141344_change_datetime_precision_ar_internal_metadata.rb M src/api/db/structure.sql Log Message: ----------- Fix precision of field 'created_at' in internal table The default precision of created_at and updated_at fields have changed in Rails 6. This change is needed to upgrade to Rails 6. Co-authored-by: Lukas Krause <lkrause(a)suse.de> Commit: d43bca2b38a98ff5a953fde0edd19c67803cb715 https://github.com/openSUSE/open-build-service/commit/d43bca2b38a98ff5a953f… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/models/role.rb M src/api/config/application.rb R src/api/config/initializers/new_framework_defaults.rb A src/api/db/migrate/20200402141344_change_datetime_precision_ar_internal_metadata.rb M src/api/db/structure.sql M src/api/spec/controllers/webui/apidocs_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/review_spec.rb M src/api/test/fixtures/path_elements.yml M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Merge pull request #9210 from krauselukas/rails_6_upgrade Upgrade OBS to Rails 6.0 Compare: https://github.com/openSUSE/open-build-service/compare/b8ce4c32060d...d43bc…

1 0

[obs-commits] [openSUSE/open-build-service] fa0ea3: Update autoprefixer-rails to version 9.7.6
by Eduardo J. 08 Apr '20

08 Apr '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: fa0ea3bf9ef2424b5877ac1074dffe0320ad14eb https://github.com/openSUSE/open-build-service/commit/fa0ea3bf9ef2424b5877a… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update autoprefixer-rails to version 9.7.6 Commit: b8ce4c32060db3c8fb1d3632dbc25b88f98ddb0a https://github.com/openSUSE/open-build-service/commit/b8ce4c32060db3c8fb1d3… Author: Eduardo J <enavarro(a)suse.com> Date: 2020-04-08 (Wed, 08 Apr 2020) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #9348 from openSUSE/depfu/update/srcapi/autoprefixer-rails-9.7.6 [src/api] Update autoprefixer-rails: 9.7.5 → 9.7.6 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/b6182f64fb05...b8ce4…

1 0

[obs-commits] [openSUSE/open-build-service]
by Eduardo J. 08 Apr '20

08 Apr '20

Branch: refs/heads/depfu/update/srcapi/autoprefixer-rails-9.7.6 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] fa0ea3: Update autoprefixer-rails to version 9.7.6
by depfu[bot] 07 Apr '20

07 Apr '20

Branch: refs/heads/depfu/update/srcapi/autoprefixer-rails-9.7.6 Home: https://github.com/openSUSE/open-build-service Commit: fa0ea3bf9ef2424b5877ac1074dffe0320ad14eb https://github.com/openSUSE/open-build-service/commit/fa0ea3bf9ef2424b5877a… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update autoprefixer-rails to version 9.7.6

1 0