Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 9878b8b7e32f73b089fd2293cb199db999bf0a18
https://github.com/openSUSE/open-build-service/commit/9878b8b7e32f73b089fd22...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/Gemfile
M src/api/Gemfile.lock
Log Message:
-----------
Bump rails gem version to 6.0
Commit: 4362e505719f307a803f317af1a898ed023e908b
https://github.com/openSUSE/open-build-service/commit/4362e505719f307a803f31...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/config/application.rb
Log Message:
-----------
Enable rails 6 defaults and keep classic code loading mechanism
Keep the classic code loading mechanism for now, since
the usuage of zeitwerk need a lot of restructuring
regarding the naming of classes etc.
This should be tackled as soon as the upgrade to Rails 6 was
successfully.
Commit: 7ea1213b93d157ceb93bd601389aa772fb9f6163
https://github.com/openSUSE/open-build-service/commit/7ea1213b93d157ceb93bd6...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/app/models/role.rb
M src/api/config/application.rb
M src/api/config/initializers/new_framework_defaults.rb
Log Message:
-----------
Fix validation and association deprecations for rails 6.0 upgrade
A few things let to a broken development setup, since a
couple of the seeds couldn't sucessfully insert new entries to
the database
* the uniqueness validator will no longer enforce case sensitive comparison
in Rails 6.1.
* since Rails 5 a belongs_to association requires to have the associated
record to be present. This should be refactored in the future,but for
now we can keep the old behaviour by setting 'belongs_to_required_by_default'
to false in the application.rb.
Commit: c9f0c6cf55b0aafa0f090aea2c8ecc4d838d5cc9
https://github.com/openSUSE/open-build-service/commit/c9f0c6cf55b0aafa0f090a...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/spec/controllers/webui/apidocs_controller_spec.rb
M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb
Log Message:
-----------
Switch to media_type instead of content_type in rspec tests
In Rails 6, the return value of "ActionDispatch::Response#content_type"
contains the charset as well.
Commit: c9e20af4600a4a16252d9f07cfe9a768f3208b1c
https://github.com/openSUSE/open-build-service/commit/c9e20af4600a4a16252d9f...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/spec/models/bs_request_spec.rb
M src/api/spec/models/review_spec.rb
Log Message:
-----------
Adjust rspec tests for the usage of recyclable cache key
Commit: 0f198cba0a801a86976ad6ede7e2553f812e33c2
https://github.com/openSUSE/open-build-service/commit/0f198cba0a801a86976ad6...
Author: Stephan Kulow
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
Expect dates as `as_json` expects them
Increases compatibility with rails6
Commit: 58bf15d23c9504e7cb124bed07f2a23617c2c9a7
https://github.com/openSUSE/open-build-service/commit/58bf15d23c9504e7cb124b...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/config/initializers/new_framework_defaults.rb
Log Message:
-----------
Use to_time behaviour introduced in ruby 2.4
Since ruby 2.4 the to_time method preserve receiver’s
timezone offset instead of it's own system timezone
offset. This was a breaking change in rails 5.0 and got
manually disabled at the upgrade of OBS.
Turns out the only place where to_time is used, is the
issue_tracker model. Since the datetime entry for the
issue_tracker is set by the OBS frontend, its fine to
enable the default behaviour, since the timezone offset
doesn't differ.
Commit: 923fd017f56c017e2fb50635b1df7be45b847d24
https://github.com/openSUSE/open-build-service/commit/923fd017f56c017e2fb506...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
R src/api/config/initializers/new_framework_defaults.rb
Log Message:
-----------
Enable per-form CSRF tokens and origin-checking CSRF mitigation
Both features got introduced with Rails 5.0 and bring some
improvements in terms of security. Both features dont break
the setup, so we can enable them.
Commit: d268b281fcbb30fcd0cbee82a0514264e9950261
https://github.com/openSUSE/open-build-service/commit/d268b281fcbb30fcd0cbee...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/.rubocop_todo.yml
Log Message:
-----------
Ignore rubocop offenses in existing codebase after rails 6 upgrade
Rubocop complains about two offenses in the configuration_controller
after the upgrade to Rails 6.0
Commit: e79ee0171e57527a1183e396d6e05945a191f4af
https://github.com/openSUSE/open-build-service/commit/e79ee0171e57527a1183e3...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/Gemfile
M src/api/Gemfile.lock
Log Message:
-----------
Dont use puma server default version from rails 5 anymore
There is no reason to use the default puma version from
rails 5 after the migration to rails 6.0.
Co-authored-by: Eduardo Navarro
Commit: f04cf373a01e26cdec37f4e4ac698fb30531810e
https://github.com/openSUSE/open-build-service/commit/f04cf373a01e26cdec37f4...
Author: Lukas Krause
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
M src/api/test/fixtures/path_elements.yml
M src/api/test/functional/channel_maintenance_test.rb
M src/api/test/functional/product_test.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/functional/source_services_test.rb
Log Message:
-----------
Adapt the minitests to the Rails 6 upgrade
* Fix know issues with the ActiveJob queue_adapter with Rails 6
for tests cases, in the minitests.
* Adapt outdated syntax in fixtures
Co-authored-by: Eduardo Navarro
Co-authored-by: Stephan Kulow
Commit: 34e129f58182bf26c7b972c31466ae87103e5422
https://github.com/openSUSE/open-build-service/commit/34e129f58182bf26c7b972...
Author: Eduardo Navarro
Date: 2020-04-03 (Fri, 03 Apr 2020)
Changed paths:
A src/api/db/migrate/20200402141344_change_datetime_precision_ar_internal_metadata.rb
M src/api/db/structure.sql
Log Message:
-----------
Fix precision of field 'created_at' in internal table
The default precision of created_at and updated_at fields have changed
in Rails 6. This change is needed to upgrade to Rails 6.
Co-authored-by: Lukas Krause
Commit: d43bca2b38a98ff5a953fde0edd19c67803cb715
https://github.com/openSUSE/open-build-service/commit/d43bca2b38a98ff5a953fd...
Author: Henne Vogelsang
Date: 2020-04-08 (Wed, 08 Apr 2020)
Changed paths:
M src/api/.rubocop_todo.yml
M src/api/Gemfile
M src/api/Gemfile.lock
M src/api/app/models/role.rb
M src/api/config/application.rb
R src/api/config/initializers/new_framework_defaults.rb
A src/api/db/migrate/20200402141344_change_datetime_precision_ar_internal_metadata.rb
M src/api/db/structure.sql
M src/api/spec/controllers/webui/apidocs_controller_spec.rb
M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb
M src/api/spec/models/bs_request_spec.rb
M src/api/spec/models/review_spec.rb
M src/api/test/fixtures/path_elements.yml
M src/api/test/functional/channel_maintenance_test.rb
M src/api/test/functional/product_test.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/functional/source_services_test.rb
Log Message:
-----------
Merge pull request #9210 from krauselukas/rails_6_upgrade
Upgrade OBS to Rails 6.0
Compare: https://github.com/openSUSE/open-build-service/compare/b8ce4c32060d...d43bca...