September 2018 - Open Build Service Commits

[obs-commits] [openSUSE/software-o-o] 9b8819: Update capybara to version 3.8.0
by Duncan Mac-Vicar P 20 Sep '18

20 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: 9b8819d36da5b173c1d070175bdb3d99d6688343 https://github.com/openSUSE/software-o-o/commit/9b8819d36da5b173c1d070175bd… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M Gemfile.lock Log Message: ----------- Update capybara to version 3.8.0 Commit: 71c89679dd3a5e6c423ce6a280246e1430835657 https://github.com/openSUSE/software-o-o/commit/71c89679dd3a5e6c423ce6a2802… Author: Duncan Mac-Vicar P <dmacvicar(a)gmail.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M Gemfile.lock Log Message: ----------- Merge pull request #380 from openSUSE/depfu/update/capybara-3.8.0 Update capybara: 3.7.2 → 3.8.0 (minor) Compare: https://github.com/openSUSE/software-o-o/compare/94c4e6218860...71c89679dd3a **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] 349b14: Fix using local chameleon gem version
by Duncan Mac-Vicar P 20 Sep '18

20 Sep '18

Branch: refs/heads/chameleon_assets Home: https://github.com/openSUSE/software-o-o Commit: 349b1479843bdb455cd86d074ca9e2df68f7d360 https://github.com/openSUSE/software-o-o/commit/349b1479843bdb455cd86d074ca… Author: Duncan Mac-Vicar P <dmacvicar(a)suse.de> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M Gemfile.lock Log Message: ----------- Fix using local chameleon gem version **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] 4b90dc: Update chamaleon
by Duncan Mac-Vicar P 20 Sep '18

20 Sep '18

Branch: refs/heads/chameleon_assets Home: https://github.com/openSUSE/software-o-o Commit: 4b90dc14d3ddb4145520ed91bdcea7a09d19e142 https://github.com/openSUSE/software-o-o/commit/4b90dc14d3ddb4145520ed91bdc… Author: Duncan Mac-Vicar P <dmacvicar(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M public/chameleon Log Message: ----------- Update chamaleon Commit: 33cf3b818e98ffd3b92ab7100a996683caedb212 https://github.com/openSUSE/software-o-o/commit/33cf3b818e98ffd3b92ab7100a9… Author: Duncan Mac-Vicar P <dmacvicar(a)suse.de> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: R .gitmodules M Gemfile M Gemfile.lock M app/assets/stylesheets/application.scss M app/views/layouts/_navbar.html.erb M app/views/layouts/application.html.erb M app/views/layouts/download.html.erb M app/views/layouts/iframe.html.erb M config/initializers/assets.rb R public/chameleon Log Message: ----------- Initial port of chameleon theme as a gem Compare: https://github.com/openSUSE/software-o-o/compare/4b90dc14d3dd^...33cf3b818e… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 3e2269: Implement status checks for requests
by Henne Vogelsang 20 Sep '18

20 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3e226956eb594acaa8cf875bd61dbafa8498c0da https://github.com/openSUSE/open-build-service/commit/3e226956eb594acaa8cf8… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb A src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/controllers/status/reports_controller.rb M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/helpers/status/required_checks_helper.rb M src/api/app/helpers/webui/obs_factory/application_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/models/status/check.rb A src/api/app/models/status/report.rb R src/api/app/models/status/repository_publish.rb M src/api/app/policies/project_policy.rb R src/api/app/policies/status/check_policy.rb A src/api/app/policies/status/report_policy.rb R src/api/app/views/status/checks/index.xml.builder A src/api/app/views/status/reports/_check.xml.builder A src/api/app/views/status/reports/show.xml.builder M src/api/app/views/webui/obs_factory/staging_projects/_checks.html.haml M src/api/config/routes.rb A src/api/db/migrate/20180906115417_add_required_checks_to_projects.rb A src/api/db/migrate/20180906142702_create_status_reports.rb A src/api/db/migrate/20180906142802_update_status_checks_table.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb A src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/factories/checks.rb M src/api/spec/factories/groups.rb A src/api/spec/factories/status_reports.rb R src/api/spec/factories/status_repository_publish.rb R src/api/spec/fixtures/files/check.xml R src/api/spec/fixtures/files/invalid_check.xml M src/api/spec/models/status/check_spec.rb A src/api/spec/models/status/report_spec.rb R src/api/spec/models/status/repository_publish_spec.rb A src/api/spec/policies/status/report_policy_spec.rb Log Message: ----------- Implement status checks for requests in order to do this it was also necessary to refactor the whole status checks module * Dropped Status::RepositoryPublish model and introduced generic Status::Report model instead * Dropped all routes except Checks#update and Reports#index as discussed with the stakeholders that these are the only requested routes for now. Checks#update will create or update the check. Report#index will list all checks of this report. * Moved common functionality to a concern * Changed routes like requested by stakeholders * Made controllers polymorphic to support requests and repositories for now, more to probably come * Updated controller specs Co-authored-by: Björn Geuken <bgeuken(a)suse.de> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: efe7476b5ddda16367d62b80dc69aee8fac59f57 https://github.com/openSUSE/open-build-service/commit/efe7476b5ddda16367d62… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/required_checks_controller.rb Log Message: ----------- Extract set_project before action to make error messages more verbose and follow single responsibilty. Commit: f59bcd46e3d285515a9dd247fc094205e1bed470 https://github.com/openSUSE/open-build-service/commit/f59bcd46e3d285515a9dd… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Fix linting errors Commit: 012a8d87e31752c07509d3743789bc0fbf71ca76 https://github.com/openSUSE/open-build-service/commit/012a8d87e31752c07509d… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/policies/project_policy.rb M src/api/app/policies/status/report_policy.rb Log Message: ----------- Be more explicit in the policies No need to defer the decisions to index? Commit: c5c089472a92baa4816a3edb5e6e7dc0f531c0e2 https://github.com/openSUSE/open-build-service/commit/c5c089472a92baa4816a3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/spec/factories/project.rb Log Message: ----------- Unlock :project_with_repository factory The factory was inside the factory above which would make this project locked. Looks like this was accidental... Commit: 06ec3621f203a7284e0bfe98ca1d8fe243d2d3c2 https://github.com/openSUSE/open-build-service/commit/06ec3621f203a7284e0bf… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Simplify set_status_report Reduce cognitive complexity. Commit: a1fa3ca705e73b114a791eba511b70aa14358786 https://github.com/openSUSE/open-build-service/commit/a1fa3ca705e73b114a791… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb A src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/controllers/status/reports_controller.rb M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/helpers/status/required_checks_helper.rb M src/api/app/helpers/webui/obs_factory/application_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/models/status/check.rb A src/api/app/models/status/report.rb R src/api/app/models/status/repository_publish.rb M src/api/app/policies/project_policy.rb R src/api/app/policies/status/check_policy.rb A src/api/app/policies/status/report_policy.rb R src/api/app/views/status/checks/index.xml.builder A src/api/app/views/status/reports/_check.xml.builder A src/api/app/views/status/reports/show.xml.builder M src/api/app/views/webui/obs_factory/staging_projects/_checks.html.haml M src/api/config/routes.rb A src/api/db/migrate/20180906115417_add_required_checks_to_projects.rb A src/api/db/migrate/20180906142702_create_status_reports.rb A src/api/db/migrate/20180906142802_update_status_checks_table.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb A src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/factories/checks.rb M src/api/spec/factories/groups.rb M src/api/spec/factories/project.rb A src/api/spec/factories/status_reports.rb R src/api/spec/factories/status_repository_publish.rb R src/api/spec/fixtures/files/check.xml R src/api/spec/fixtures/files/invalid_check.xml M src/api/spec/models/status/check_spec.rb A src/api/spec/models/status/report_spec.rb R src/api/spec/models/status/repository_publish_spec.rb A src/api/spec/policies/status/report_policy_spec.rb Log Message: ----------- Merge pull request #5862 from ChrisBr/refactor_check_controller Refactor check controller Compare: https://github.com/openSUSE/open-build-service/compare/4df2f1154e90...a1fa3… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 4df2f1: [backend] bs_admin: add --recheck-dod command to f...
by Michael Schroeder 20 Sep '18

20 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4df2f1154e9087386fa6563c524906c4ba44947f https://github.com/openSUSE/open-build-service/commit/4df2f1154e9087386fa65… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/backend/bs_admin M src/backend/bs_dodup Log Message: ----------- [backend] bs_admin: add --recheck-dod command to force recheck a DoD It supports a project or url prefix as argument **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ec418d: Fix can't convert nil into Integer
by Moisés Déniz Alemán 20 Sep '18

20 Sep '18

Branch: refs/heads/bootstrap-master Home: https://github.com/openSUSE/open-build-service Commit: ec418d0cec4c9133ba2c7001594ee4894c3c15e3 https://github.com/openSUSE/open-build-service/commit/ec418d0cec4c9133ba2c7… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M src/api/app/controllers/webui/project_controller.rb Log Message: ----------- Fix can't convert nil into Integer to check for '0' instead of converting the value. Fix #5774. Commit: be61024e516e66c03bd0d87b898a4e5060340c13 https://github.com/openSUSE/open-build-service/commit/be61024e516e66c03bd0d… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update uglifier to version 4.1.19 Commit: 9d4e4696a4f2e5f6e67544eb7fde87af4010ca9c https://github.com/openSUSE/open-build-service/commit/9d4e4696a4f2e5f6e6754… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock Log Message: ----------- Update data_migrate to version 5.1.0 Commit: 57d9b708dfe4650fdda0f9e56df0e45c7f4cef0e https://github.com/openSUSE/open-build-service/commit/57d9b708dfe4650fdda0f… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/models/architecture.rb M src/api/spec/models/architecture_spec.rb Log Message: ----------- Move map_to_workers to the Architecture#worker Remove method from controller and move it to the model. add test case for that Commit: 21460764b204d88a0ae5606b82a64b56b7ede11a https://github.com/openSUSE/open-build-service/commit/21460764b204d88a0ae56… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/app/controllers/request_controller.rb Log Message: ----------- Fix issue while adding XML for requests diff We had an issue that was adding the <?xml version="1.0"??> after the first node (<request...>), now is fixed and is the first node of the XML Co-authored-by: Christian Bruckmayer <cbruckmayer(a)suse.com> Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: David Kang <dkang(a)suse.com> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: 2d051360f007574d5d11eef0472fd7be2bb7f158 https://github.com/openSUSE/open-build-service/commit/2d051360f007574d5d11e… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/app/controllers/request_controller.rb Log Message: ----------- Merge pull request #5844 from mdeniz/bugfix/fix_5843 Fix issue while adding XML for requests diff Commit: d3c2840ca078cd8c914b349f70a2f57a31dec1b6 https://github.com/openSUSE/open-build-service/commit/d3c2840ca078cd8c914b3… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/models/architecture.rb M src/api/spec/models/architecture_spec.rb Log Message: ----------- Merge pull request #5832 from vpereira/architecture_worker Move map_to_workers to the Architecture#worker Commit: 52449e5ca527921143bb1b97ddcc68111ef88845 https://github.com/openSUSE/open-build-service/commit/52449e5ca527921143bb1… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5839 from openSUSE/depfu/update/srcapi/uglifier-4.1.19 [src/api] Update uglifier: 4.1.18 → 4.1.19 (patch) Commit: b8373e7425b8d7c80b327df343ea8034d334fa57 https://github.com/openSUSE/open-build-service/commit/b8373e7425b8d7c80b327… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/app/controllers/announcements_controller.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/status_messages_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/models/branch_package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/service.rb M src/api/lib/opensuse/validator.rb M src/api/spec/controllers/public_controller_spec.rb M src/api/spec/controllers/webui/sitemaps_controller_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/test_helper.rb Log Message: ----------- Be strict with Nokogiri::XML Nokogiri's xml default options include 'recover', which is a problem because invalid XML is a no-go, both on the input and the output layer as we use it as mean of communication. If there is an error in it, it means something went wrong Commit: ba3c6e99ea403dfe33093d11a7688d7f1e85e250 https://github.com/openSUSE/open-build-service/commit/ba3c6e99ea403dfe33093… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/app/controllers/announcements_controller.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/status_messages_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/models/branch_package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/service.rb M src/api/lib/opensuse/validator.rb M src/api/spec/controllers/public_controller_spec.rb M src/api/spec/controllers/webui/sitemaps_controller_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/test_helper.rb Log Message: ----------- Merge pull request #5847 from coolo/be_strict_in_minitest Be strict with XML documents Commit: 52f4f55c79315ca5ef9c16463735aa987246bbb4 https://github.com/openSUSE/open-build-service/commit/52f4f55c79315ca5ef9c1… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/app/controllers/webui/project_controller.rb Log Message: ----------- Merge pull request #5802 from ChrisBr/bug/cant-convert-nil Fix can't convert nil in monitor Commit: a14465934719c78d3b5ff3b01657bfedd1e5aae6 https://github.com/openSUSE/open-build-service/commit/a14465934719c78d3b5ff… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-12 (Wed, 12 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update capybara to version 3.7.2 Commit: d59babe5db6b4fe670f0867438b3c49bcdf84ac1 https://github.com/openSUSE/open-build-service/commit/d59babe5db6b4fe670f08… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2018-09-13 (Thu, 13 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5850 from openSUSE/depfu/update/srcapi/capybara-3.7.2 [src/api] Update capybara: 3.7.1 → 3.7.2 (patch) Commit: b02bc9b455ce95298ac3a37bf94e1a796a519ac2 https://github.com/openSUSE/open-build-service/commit/b02bc9b455ce95298ac3a… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2018-09-13 (Thu, 13 Sep 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5840 from openSUSE/depfu/update/srcapi/data_migrate-5.1.0 [src/api] Upgrade data_migrate: 5.0.2 → 5.1.0 (minor) Commit: 63c6b25f487b2a9c1284492dcaea53148f177357 https://github.com/openSUSE/open-build-service/commit/63c6b25f487b2a9c12844… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-13 (Thu, 13 Sep 2018) Changed paths: M src/api/app/controllers/webui/monitor_controller.rb Log Message: ----------- Remove method discard_cache? This method never really worked and the idea behind was to allow the client to invalidate the server cache remotely Commit: ef27aaaf9c55ec5b30eb7c4be7724807bb82bc5b https://github.com/openSUSE/open-build-service/commit/ef27aaaf9c55ec5b30eb7… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-13 (Thu, 13 Sep 2018) Changed paths: M src/api/app/controllers/webui/monitor_controller.rb Log Message: ----------- Merge pull request #5849 from vpereira/http_cache_control Remove the method discard_cache? as it never worked as intended. Commit: f0463713fc15edaf09bec8d13f1d6582e3396c96 https://github.com/openSUSE/open-build-service/commit/f0463713fc15edaf09bec… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-14 (Fri, 14 Sep 2018) Changed paths: A src/api/app/views/webui2/webui/package/_show_derived_packages.html.haml A src/api/app/views/webui2/webui/package/_show_devel_package.html.haml A src/api/app/views/webui2/webui/package/_show_developed_packages.html.haml A src/api/app/views/webui2/webui/package/_show_failures.html.haml A src/api/app/views/webui2/webui/package/_show_inherited_from_project.html.haml A src/api/app/views/webui2/webui/package/_show_linkinfo.html.haml A src/api/app/views/webui2/webui/package/_show_patchinfo.html.haml M src/api/app/views/webui2/webui/package/_side_links.html.haml Log Message: ----------- Refactor package partial links (_side_links) (#5854) Split partial package/_side_links.html.haml into smaller partials Commit: 27086b32ff99ef47acf0430f9349665417801980 https://github.com/openSUSE/open-build-service/commit/27086b32ff99ef47acf04… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-14 (Fri, 14 Sep 2018) Changed paths: M src/api/app/views/webui/package/show.html.erb M src/api/app/views/webui2/webui/package/_show_failures.html.haml Log Message: ----------- Use pluralize instead of custom code Commit: 4ac0559361240eefafbbd0d9b9cdb707900836bb https://github.com/openSUSE/open-build-service/commit/4ac0559361240eefafbbd… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-14 (Fri, 14 Sep 2018) Changed paths: M src/api/app/views/webui/package/show.html.erb M src/api/app/views/webui2/webui/package/_show_failures.html.haml Log Message: ----------- Merge pull request #5863 from vpereira/pluralize_show_failure Use pluralize instead of custom code Commit: 973d8c20ae4b23ddda8c0cf620653952cb557f5e https://github.com/openSUSE/open-build-service/commit/973d8c20ae4b23ddda8c0… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-15 (Sat, 15 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update marcel to version 0.3.3 Commit: b4d2a7a45827c21a90c9617b7077464f7247d8aa https://github.com/openSUSE/open-build-service/commit/b4d2a7a45827c21a90c96… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2018-09-17 (Mon, 17 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5864 from openSUSE/depfu/update/srcapi/marcel-0.3.3 [src/api] Update marcel: 0.3.2 → 0.3.3 (minor) Commit: 71a2a434b7158fa882e736b473c81632394c2f71 https://github.com/openSUSE/open-build-service/commit/71a2a434b7158fa882e73… Author: Lukas Krause <lkrause(a)suse.de> Date: 2018-09-17 (Mon, 17 Sep 2018) Changed paths: M src/api/app/helpers/webui/user_helper.rb Log Message: ----------- Do not return image tag if no_icon var is set The no_icon variable had no effect Fixes #4926 Commit: f1014e4d8fc0a3b22898d550262511bdf9d8bc92 https://github.com/openSUSE/open-build-service/commit/f1014e4d8fc0a3b22898d… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M src/api/app/helpers/webui/user_helper.rb Log Message: ----------- Merge pull request #5861 from krauselukas/no_icon Do not return image tag if no_icon var is set Commit: eafbb5ba6756e7b9a1a8b3c7210d404576666a63 https://github.com/openSUSE/open-build-service/commit/eafbb5ba6756e7b9a1a8b… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: R src/api/app/views/webui2/webui/package/_show_derived_packages.html.haml R src/api/app/views/webui2/webui/package/_show_devel_package.html.haml R src/api/app/views/webui2/webui/package/_show_developed_packages.html.haml R src/api/app/views/webui2/webui/package/_show_failures.html.haml R src/api/app/views/webui2/webui/package/_show_inherited_from_project.html.haml R src/api/app/views/webui2/webui/package/_show_linkinfo.html.haml R src/api/app/views/webui2/webui/package/_show_patchinfo.html.haml M src/api/app/views/webui2/webui/package/_side_links.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_derived_packages.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_devel_package.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_developed_packages.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_failures.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_inherited_from_project.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_linkinfo.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_patchinfo.html.haml Log Message: ----------- Move partials to its own directory Commit: 0968458cc84829340a40677da5722fd634f47235 https://github.com/openSUSE/open-build-service/commit/0968458cc84829340a406… Author: Lukas Krause <lkrause(a)suse.de> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui2/webui/comment/_new.html.haml Log Message: ----------- Ask for login or signup in comment section Users might wonder why commenting isn't available Fixes #4775 Commit: a7f7e49cb710c3cfa33c851fa8229de9a358a981 https://github.com/openSUSE/open-build-service/commit/a7f7e49cb710c3cfa33c8… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/package/_bottom_actions.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_branch_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_bugzilla_owner.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_cloud_upload.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_delete_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_edit_description.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_deletion.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_devel_project_change.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_role_addition.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_submit_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_trigger_services.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_view_kiwi.html.haml Log Message: ----------- Refactor bottom_actions Package view: Add partials: - bottom_actions/bugzilla_owner - bottom_actions/branch_package - bottom_actions/submit_package - bottom_actions/edit_description - bottom_actions/delete_package - bottom_actions/cloud_upload - bottom_actions/trigger_services - bottom_actions/view_kiwi - bottom_actions/request_deletion - bottom_action/request_devel_project_change - bottom_action/request_role_adiction Commit: 9277beb054f0a00c0033f8512f3aad858aad69bf https://github.com/openSUSE/open-build-service/commit/9277beb054f0a00c0033f… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: R src/api/app/views/webui2/webui/package/_show_derived_packages.html.haml R src/api/app/views/webui2/webui/package/_show_devel_package.html.haml R src/api/app/views/webui2/webui/package/_show_developed_packages.html.haml R src/api/app/views/webui2/webui/package/_show_failures.html.haml R src/api/app/views/webui2/webui/package/_show_inherited_from_project.html.haml R src/api/app/views/webui2/webui/package/_show_linkinfo.html.haml R src/api/app/views/webui2/webui/package/_show_patchinfo.html.haml M src/api/app/views/webui2/webui/package/_side_links.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_derived_packages.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_devel_package.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_developed_packages.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_failures.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_inherited_from_project.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_linkinfo.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_patchinfo.html.haml Log Message: ----------- Merge pull request #5869 from vpereira/refactor_show_sidelinks Move partials to its own directory. Commit: 7e4e30b9d3336577fa886273ef0b7c6989000324 https://github.com/openSUSE/open-build-service/commit/7e4e30b9d3336577fa886… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui2/webui/comment/_new.html.haml Log Message: ----------- Merge pull request #5868 from krauselukas/hint_comment Ask for login or signup in comment section Commit: 76f9212e57b30cca10a3e7fcb0272b5e35ed3c96 https://github.com/openSUSE/open-build-service/commit/76f9212e57b30cca10a3e… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M src/api/app/models/comment.rb Log Message: ----------- Prevent invalid xml output of null characters Prevent the xml renderer from throwing a 500 internal server error: ActionView::Template::Error (string contains null byte) Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: 8b19a369e4a2845d36b74f17cc6562c006fde9b6 https://github.com/openSUSE/open-build-service/commit/8b19a369e4a2845d36b74… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M src/api/app/models/comment.rb Log Message: ----------- Validate input of comments, without null character This prevents the creation of a comment with the null character, that would make the comment invalid for xml output. Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: 13382897788b73a5f65d5d19d39d5f6dec519a6a https://github.com/openSUSE/open-build-service/commit/13382897788b73a5f65d5… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M src/api/app/models/comment.rb Log Message: ----------- Merge pull request #5870 from eduardoj/fix_comment_output_in_osc Fix xml output for comments Commit: 3ed2f974d43ae147558ac5e3ce0d1f0c61a77e9c https://github.com/openSUSE/open-build-service/commit/3ed2f974d43ae147558ac… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/package/_bottom_actions.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_branch_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_bugzilla_owner.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_cloud_upload.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_delete_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_edit_description.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_deletion.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_devel_project_change.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_role_addition.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_submit_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_trigger_services.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_view_kiwi.html.haml Log Message: ----------- Merge pull request #5867 from vpereira/refactor_bottom_actions Refactor bottom_actions Package view: Break it in small partials Commit: 720f0941a0f99238c7e22c622f43a48b892587f6 https://github.com/openSUSE/open-build-service/commit/720f0941a0f99238c7e22… Author: David Kang <dkang(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/views/webui/comment/_links.html.haml M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_reply.html.haml Log Message: ----------- Add no_switch parameter in old webui for comments If you are a beta user, the comments section are rendering the views from `webui2` in sections that are not migrated like `project#show`. The `no_switch` was added in `webui` comment views because they will be deleted as soon as we migrate everything to Bootstrap, Co-authored-by: Moisés Déniz Alemán <mdeniz(a)suse.com> Commit: 56874af3d62d35ea0aadf99ead6ee1abe32e5e2c https://github.com/openSUSE/open-build-service/commit/56874af3d62d35ea0aadf… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Adapt testcase for pundit Commit: 6b45997e0d81cde4ce6ada67b4c3667aaef55758 https://github.com/openSUSE/open-build-service/commit/6b45997e0d81cde4ce6ad… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/views/webui/comment/_links.html.haml M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_reply.html.haml Log Message: ----------- Merge pull request #5875 from DavidKang/fix/comments Fix comments in old webui Commit: e6d6218ae3e93f09aaca7b7de7185806abde839d https://github.com/openSUSE/open-build-service/commit/e6d6218ae3e93f09aaca7… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: A src/api/spec/policies/package_policy_spec.rb Log Message: ----------- Add policy spec for Package policy Commit: 13973f68552cb215611f9c999e129073b06d768e https://github.com/openSUSE/open-build-service/commit/13973f68552cb215611f9… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/policies/package_policy.rb Log Message: ----------- Add to policy the `save_meta_update` method Commit: c725ef395c33e0cf8c29aea72ba89e43dd432e2b https://github.com/openSUSE/open-build-service/commit/c725ef395c33e0cf8c29a… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Refactor PackageController. Use pundit and enable `verify_authorized` To be able to add explict pundit verification via `verify_authorized` it was necessary to refactor the method `save_meta` which led to move some logic to `before_action` methods like `validate_xml` Commit: 3e9fac7d1ebd49902e0be142860c4173d3e81935 https://github.com/openSUSE/open-build-service/commit/3e9fac7d1ebd49902e0be… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Disable rubocop Lint/NonLocalExitFromIterator for Package#dependency Commit: ead693e2bb2db5ae0d50a0c5a5e2a95d90aeb385 https://github.com/openSUSE/open-build-service/commit/ead693e2bb2db5ae0d50a… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/lib/tasks/dev.rake Log Message: ----------- Fix testdata rake task and add the YAML magic comment to the Staging project instead of the parent. Otherwise the staging dashboard will crash because of a YAML load error while parsing the empty description of the Staging project. Commit: 62e6d89549963898b32138aec65b39e88f6f10d1 https://github.com/openSUSE/open-build-service/commit/62e6d89549963898b3213… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/policies/package_policy.rb M src/api/spec/controllers/webui/package_controller_spec.rb A src/api/spec/policies/package_policy_spec.rb Log Message: ----------- Merge pull request #5871 from vpereira/verify_authorized_on_packages Enable verify_authorized in Package controller actions Commit: 168777821551c2e0431e7082948542d63bb12427 https://github.com/openSUSE/open-build-service/commit/168777821551c2e0431e7… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/lib/tasks/dev.rake Log Message: ----------- Merge pull request #5877 from ChrisBr/fix_testdata Fix testdata rake task Commit: 157a9c70793d68e87c68fc1953bd54881fc380e9 https://github.com/openSUSE/open-build-service/commit/157a9c70793d68e87c68f… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M dist/t/osc/fixtures/obs-testpackage-2.8._service M dist/t/osc/fixtures/obs-testpackage._service Log Message: ----------- [dist] fix compression in osc test cases Changed to be consistent with https://github.com/M0ses/obs-testpackage/commit/f43d00d49ffefe2cd3296070e37… Commit: 3c28941a6e117e4b0c4d41cef5576770c05a0aef https://github.com/openSUSE/open-build-service/commit/3c28941a6e117e4b0c4d4… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M dist/t/osc/fixtures/obs-testpackage-2.8._service M dist/t/osc/fixtures/obs-testpackage._service M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/controllers/announcements_controller.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/status_messages_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/user_helper.rb M src/api/app/models/architecture.rb M src/api/app/models/branch_package.rb M src/api/app/models/comment.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/service.rb M src/api/app/policies/package_policy.rb M src/api/app/views/webui/comment/_links.html.haml M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_reply.html.haml M src/api/app/views/webui/package/show.html.erb M src/api/app/views/webui2/webui/comment/_new.html.haml M src/api/app/views/webui2/webui/package/_bottom_actions.html.haml M src/api/app/views/webui2/webui/package/_side_links.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_branch_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_bugzilla_owner.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_cloud_upload.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_delete_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_edit_description.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_deletion.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_devel_project_change.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_request_role_addition.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_submit_package.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_trigger_services.html.haml A src/api/app/views/webui2/webui/package/bottom_actions/_view_kiwi.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_derived_packages.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_devel_package.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_developed_packages.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_failures.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_inherited_from_project.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_linkinfo.html.haml A src/api/app/views/webui2/webui/package/side_links/_show_patchinfo.html.haml M src/api/lib/opensuse/validator.rb M src/api/lib/tasks/dev.rake M src/api/spec/controllers/public_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/sitemaps_controller_spec.rb M src/api/spec/models/architecture_spec.rb M src/api/spec/models/bs_request_spec.rb A src/api/spec/policies/package_policy_spec.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/test_helper.rb Log Message: ----------- Merge pull request #5884 from openSUSE/master Update bootstrap master Compare: https://github.com/openSUSE/open-build-service/compare/5038fa71ae23...3c289… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 157a9c: [dist] fix compression in osc test cases
by Frank Schreiner 20 Sep '18

20 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 157a9c70793d68e87c68fc1953bd54881fc380e9 https://github.com/openSUSE/open-build-service/commit/157a9c70793d68e87c68f… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M dist/t/osc/fixtures/obs-testpackage-2.8._service M dist/t/osc/fixtures/obs-testpackage._service Log Message: ----------- [dist] fix compression in osc test cases Changed to be consistent with https://github.com/M0ses/obs-testpackage/commit/f43d00d49ffefe2cd3296070e37… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ead693: Fix testdata rake task
by Christian Bruckmayer 19 Sep '18

19 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ead693e2bb2db5ae0d50a0c5a5e2a95d90aeb385 https://github.com/openSUSE/open-build-service/commit/ead693e2bb2db5ae0d50a… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/lib/tasks/dev.rake Log Message: ----------- Fix testdata rake task and add the YAML magic comment to the Staging project instead of the parent. Otherwise the staging dashboard will crash because of a YAML load error while parsing the empty description of the Staging project. Commit: 168777821551c2e0431e7082948542d63bb12427 https://github.com/openSUSE/open-build-service/commit/168777821551c2e0431e7… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/lib/tasks/dev.rake Log Message: ----------- Merge pull request #5877 from ChrisBr/fix_testdata Fix testdata rake task Compare: https://github.com/openSUSE/open-build-service/compare/62e6d8954996...16877… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 56874a: Adapt testcase for pundit
by Victor Pereira 19 Sep '18

19 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 56874af3d62d35ea0aadf99ead6ee1abe32e5e2c https://github.com/openSUSE/open-build-service/commit/56874af3d62d35ea0aadf… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Adapt testcase for pundit Commit: e6d6218ae3e93f09aaca7b7de7185806abde839d https://github.com/openSUSE/open-build-service/commit/e6d6218ae3e93f09aaca7… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: A src/api/spec/policies/package_policy_spec.rb Log Message: ----------- Add policy spec for Package policy Commit: 13973f68552cb215611f9c999e129073b06d768e https://github.com/openSUSE/open-build-service/commit/13973f68552cb215611f9… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/policies/package_policy.rb Log Message: ----------- Add to policy the `save_meta_update` method Commit: c725ef395c33e0cf8c29aea72ba89e43dd432e2b https://github.com/openSUSE/open-build-service/commit/c725ef395c33e0cf8c29a… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Refactor PackageController. Use pundit and enable `verify_authorized` To be able to add explict pundit verification via `verify_authorized` it was necessary to refactor the method `save_meta` which led to move some logic to `before_action` methods like `validate_xml` Commit: 3e9fac7d1ebd49902e0be142860c4173d3e81935 https://github.com/openSUSE/open-build-service/commit/3e9fac7d1ebd49902e0be… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Disable rubocop Lint/NonLocalExitFromIterator for Package#dependency Commit: 62e6d89549963898b32138aec65b39e88f6f10d1 https://github.com/openSUSE/open-build-service/commit/62e6d89549963898b3213… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/policies/package_policy.rb M src/api/spec/controllers/webui/package_controller_spec.rb A src/api/spec/policies/package_policy_spec.rb Log Message: ----------- Merge pull request #5871 from vpereira/verify_authorized_on_packages Enable verify_authorized in Package controller actions Compare: https://github.com/openSUSE/open-build-service/compare/6b45997e0d81...62e6d… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 720f09: Add no_switch parameter in old webui for comments
by Christian Bruckmayer 19 Sep '18

19 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 720f0941a0f99238c7e22c622f43a48b892587f6 https://github.com/openSUSE/open-build-service/commit/720f0941a0f99238c7e22… Author: David Kang <dkang(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/views/webui/comment/_links.html.haml M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_reply.html.haml Log Message: ----------- Add no_switch parameter in old webui for comments If you are a beta user, the comments section are rendering the views from `webui2` in sections that are not migrated like `project#show`. The `no_switch` was added in `webui` comment views because they will be deleted as soon as we migrate everything to Bootstrap, Co-authored-by: Moisés Déniz Alemán <mdeniz(a)suse.com> Commit: 6b45997e0d81cde4ce6ada67b4c3667aaef55758 https://github.com/openSUSE/open-build-service/commit/6b45997e0d81cde4ce6ad… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/views/webui/comment/_links.html.haml M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_reply.html.haml Log Message: ----------- Merge pull request #5875 from DavidKang/fix/comments Fix comments in old webui Compare: https://github.com/openSUSE/open-build-service/compare/3ed2f974d43a...6b459… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0