Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3e226956eb594acaa8cf875bd61dbafa8498c0da https://github.com/openSUSE/open-build-service/commit/3e226956eb594acaa8cf87... Author: Christian Bruckmayer Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb A src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/controllers/status/reports_controller.rb M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/helpers/status/required_checks_helper.rb M src/api/app/helpers/webui/obs_factory/application_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/models/status/check.rb A src/api/app/models/status/report.rb R src/api/app/models/status/repository_publish.rb M src/api/app/policies/project_policy.rb R src/api/app/policies/status/check_policy.rb A src/api/app/policies/status/report_policy.rb R src/api/app/views/status/checks/index.xml.builder A src/api/app/views/status/reports/_check.xml.builder A src/api/app/views/status/reports/show.xml.builder M src/api/app/views/webui/obs_factory/staging_projects/_checks.html.haml M src/api/config/routes.rb A src/api/db/migrate/20180906115417_add_required_checks_to_projects.rb A src/api/db/migrate/20180906142702_create_status_reports.rb A src/api/db/migrate/20180906142802_update_status_checks_table.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb A src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/factories/checks.rb M src/api/spec/factories/groups.rb A src/api/spec/factories/status_reports.rb R src/api/spec/factories/status_repository_publish.rb R src/api/spec/fixtures/files/check.xml R src/api/spec/fixtures/files/invalid_check.xml M src/api/spec/models/status/check_spec.rb A src/api/spec/models/status/report_spec.rb R src/api/spec/models/status/repository_publish_spec.rb A src/api/spec/policies/status/report_policy_spec.rb Log Message: ----------- Implement status checks for requests in order to do this it was also necessary to refactor the whole status checks module * Dropped Status::RepositoryPublish model and introduced generic Status::Report model instead * Dropped all routes except Checks#update and Reports#index as discussed with the stakeholders that these are the only requested routes for now. Checks#update will create or update the check. Report#index will list all checks of this report. * Moved common functionality to a concern * Changed routes like requested by stakeholders * Made controllers polymorphic to support requests and repositories for now, more to probably come * Updated controller specs Co-authored-by: Björn Geuken Co-authored-by: Eduardo Navarro Commit: efe7476b5ddda16367d62b80dc69aee8fac59f57 https://github.com/openSUSE/open-build-service/commit/efe7476b5ddda16367d62b... Author: Christian Bruckmayer Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/required_checks_controller.rb Log Message: ----------- Extract set_project before action to make error messages more verbose and follow single responsibilty. Commit: f59bcd46e3d285515a9dd247fc094205e1bed470 https://github.com/openSUSE/open-build-service/commit/f59bcd46e3d285515a9dd2... Author: Henne Vogelsang Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Fix linting errors Commit: 012a8d87e31752c07509d3743789bc0fbf71ca76 https://github.com/openSUSE/open-build-service/commit/012a8d87e31752c07509d3... Author: Henne Vogelsang Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/policies/project_policy.rb M src/api/app/policies/status/report_policy.rb Log Message: ----------- Be more explicit in the policies No need to defer the decisions to index? Commit: c5c089472a92baa4816a3edb5e6e7dc0f531c0e2 https://github.com/openSUSE/open-build-service/commit/c5c089472a92baa4816a3e... Author: Henne Vogelsang Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/spec/factories/project.rb Log Message: ----------- Unlock :project_with_repository factory The factory was inside the factory above which would make this project locked. Looks like this was accidental... Commit: 06ec3621f203a7284e0bfe98ca1d8fe243d2d3c2 https://github.com/openSUSE/open-build-service/commit/06ec3621f203a7284e0bfe... Author: Henne Vogelsang Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Simplify set_status_report Reduce cognitive complexity. Commit: a1fa3ca705e73b114a791eba511b70aa14358786 https://github.com/openSUSE/open-build-service/commit/a1fa3ca705e73b114a791e... Author: Henne Vogelsang Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb A src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/controllers/status/reports_controller.rb M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/helpers/status/required_checks_helper.rb M src/api/app/helpers/webui/obs_factory/application_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/models/status/check.rb A src/api/app/models/status/report.rb R src/api/app/models/status/repository_publish.rb M src/api/app/policies/project_policy.rb R src/api/app/policies/status/check_policy.rb A src/api/app/policies/status/report_policy.rb R src/api/app/views/status/checks/index.xml.builder A src/api/app/views/status/reports/_check.xml.builder A src/api/app/views/status/reports/show.xml.builder M src/api/app/views/webui/obs_factory/staging_projects/_checks.html.haml M src/api/config/routes.rb A src/api/db/migrate/20180906115417_add_required_checks_to_projects.rb A src/api/db/migrate/20180906142702_create_status_reports.rb A src/api/db/migrate/20180906142802_update_status_checks_table.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb A src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/factories/checks.rb M src/api/spec/factories/groups.rb M src/api/spec/factories/project.rb A src/api/spec/factories/status_reports.rb R src/api/spec/factories/status_repository_publish.rb R src/api/spec/fixtures/files/check.xml R src/api/spec/fixtures/files/invalid_check.xml M src/api/spec/models/status/check_spec.rb A src/api/spec/models/status/report_spec.rb R src/api/spec/models/status/repository_publish_spec.rb A src/api/spec/policies/status/report_policy_spec.rb Log Message: ----------- Merge pull request #5862 from ChrisBr/refactor_check_controller Refactor check controller Compare: https://github.com/openSUSE/open-build-service/compare/4df2f1154e90...a1fa3c... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.