July 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 58a4aa: Update autoprefixer-rails to version 9.0.0
by Christian Bruckmayer 17 Jul '18

17 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 58a4aa3e44055a1d1f57e8636dd8a2b8e8c39957 https://github.com/openSUSE/open-build-service/commit/58a4aa3e44055a1d1f57e… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update autoprefixer-rails to version 9.0.0 Commit: c7c6609c9bac8192b1863fc5247aa0e453266f58 https://github.com/openSUSE/open-build-service/commit/c7c6609c9bac8192b1863… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5380 from openSUSE/depfu/update/srcapi/autoprefixer-rails-9.0.0 Update autoprefixer-rails: 8.6.5 → 9.0.0 (major) Compare: https://github.com/openSUSE/open-build-service/compare/18959e33e937...c7c66… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 18959e: Service sub-process does not inherit the http_prox...
by doccaz 17 Jul '18

17 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 18959e33e9371d976d9f36044ccdf1cf12d95b29 https://github.com/openSUSE/open-build-service/commit/18959e33e9371d976d9f3… Author: doccaz <erico.mendonca(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/backend/bs_service Log Message: ----------- Service sub-process does not inherit the http_proxy/https_proxy variables, redeclaring from BSConfig.pm information. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 7d4a4e: [api] Implement service webhooks
by Christian Bruckmayer 17 Jul '18

17 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7d4a4eef5e647704b39833ba09deaf01f7badf5a https://github.com/openSUSE/open-build-service/commit/7d4a4eef5e647704b3983… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: A src/api/app/controllers/services/webhooks_controller.rb M src/api/app/models/token/service.rb M src/api/app/views/person/token/create.xml.builder M src/api/config/routes.rb A src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_3_1_1_1.yml A src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_2_1_1_1.yml A src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_1_1_1_1.yml A src/api/spec/controllers/services/webhooks_controller_spec.rb M src/api/spec/factories/tokens.rb A src/api/spec/models/token/service_spec.rb Log Message: ----------- [api] Implement service webhooks GitHub announced the deprecation of GitHub services in favor of webhooks (on January 31, 2019 GitHub will stop delivering services events). WebHooks are designed different than services, therefore it was necessary to implement a dedicated controller. Unlike the OBS GitHub service, webhooks do not deliver the token anymore in the HTTP Header. Because of that it is not possible to compare the tokens anymore as part of the authentication process. We used this opportunity to implement generic webhooks which support for now GitHub, Pagure and a generic webhook. To trigger a webhook, it is now necessary to generate a signature over the payload body with the secret token. To authorize, OBS verifies this signature. OBS supports for now three different HTTP header to submit this signature: * HTTP_X_OBS_SIGNATURE (generic OBS header) * HTTP_X_HUB_SIGNATURE (GitHub) * HTTP_X-Pagure-Signature-256 (Pagure) It is now also necessary to send the token id with the webhook request. This PR introduces the new route: 'trigger/service/github?id=42' See these URLs for more details: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ https://developer.github.com/webhooks/securing/ https://docs.pagure.org/pagure/usage/using_webhooks.html Commit: 80cb3011e5ff28794248777f147f39266b4acb15 https://github.com/openSUSE/open-build-service/commit/80cb3011e5ff287942487… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: A src/api/app/controllers/services/webhooks_controller.rb M src/api/app/models/token/service.rb M src/api/app/views/person/token/create.xml.builder M src/api/config/routes.rb A src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_3_1_1_1.yml A src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_HUB_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_2_1_1_1.yml A src/api/spec/cassettes/Services_WebhooksController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_1_1_1_1_1.yml A src/api/spec/controllers/services/webhooks_controller_spec.rb M src/api/spec/factories/tokens.rb A src/api/spec/models/token/service_spec.rb Log Message: ----------- Merge pull request #5326 from ChrisBr/feature/github-webhooks [api] Implement webhooks Compare: https://github.com/openSUSE/open-build-service/compare/561587eedc35...80cb3… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] e4d673: [minitest] make test_config_file_exists_and_have_t...
by Henne Vogelsang 17 Jul '18

17 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e4d673344dd44a623f66c60a74df14c605d609ad https://github.com/openSUSE/open-build-service/commit/e4d673344dd44a623f66c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/test/unit/project_test.rb Log Message: ----------- [minitest] make test_config_file_exists_and_have_the_right_content more robust --- expected +++ actual @@ -1,5 +1,4 @@ "Type: spec Substitute: kiwi package Substitute: kiwi-packagemanager:instsource package -Ignore: package:bash -" +Ignore: package:bash" Commit: 9648f5ea4176c6e729c52139e06edf31e834bc5b https://github.com/openSUSE/open-build-service/commit/9648f5ea4176c6e729c52… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/spec/models/branch_package_spec.rb Log Message: ----------- [ci] Login before creating attributes Commit: 90d2d5f3f9109686d63d9f2507ff55678b72803d https://github.com/openSUSE/open-build-service/commit/90d2d5f3f9109686d63d9… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/spec/models/project_spec.rb Log Message: ----------- [frontend] project_spec: Login before attribute creation Commit: bc1c3d9e8e86d392972719b605804c56473b04c8 https://github.com/openSUSE/open-build-service/commit/bc1c3d9e8e86d39297271… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/spec/models/project_spec.rb Log Message: ----------- [ci] project_spec: Make undelete tests more robust Make sure the project to be deleted and undeleted is gone before the test - as we reuse it and the backend response differs if the project is there initially Commit: 757b8fa3eaced1b3a8d9b10aadc5eb779414909d https://github.com/openSUSE/open-build-service/commit/757b8fa3eaced1b3a8d9b… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/spec/models/attrib_value_spec.rb Log Message: ----------- [ci] attrib_value_spec: Login a user to write attributes to backend Commit: 561587eedc354c298b2bb6b544cf0b57f8456f26 https://github.com/openSUSE/open-build-service/commit/561587eedc354c298b2bb… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/models/attrib_value_spec.rb M src/api/spec/models/branch_package_spec.rb M src/api/spec/models/project_spec.rb M src/api/test/unit/project_test.rb Log Message: ----------- Merge pull request #5378 from coolo/cherry_pick Cherry pick some fixes Compare: https://github.com/openSUSE/open-build-service/compare/6b49f6054c77...56158… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] cad5cb: [minitest] Move channel test from minitest 2 to 1
by Stephan Kulow 16 Jul '18

16 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: cad5cbfc7c75d577cbc5b39eb4558e22a568f6c5 https://github.com/openSUSE/open-build-service/commit/cad5cbfc7c75d577cbc5b… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/lib/tasks/test_webui.rake Log Message: ----------- [minitest] Move channel test from minitest 2 to 1 Commit: 274151dc55aa9f771c8fa03481a038ef6881c324 https://github.com/openSUSE/open-build-service/commit/274151dc55aa9f771c8fa… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M .circleci/config.yml M src/api/lib/tasks/test_webui.rake Log Message: ----------- [frontend] Move one more slow test - we need to do this carefully Commit: 32bdefb3854e4971b536d1dd6d00bd8ebb2662b1 https://github.com/openSUSE/open-build-service/commit/32bdefb3854e4971b536d… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/lib/tasks/test_webui.rake Log Message: ----------- [ci] Add 3 more minitests for trial Commit: fd00238c22c5c43ca3167d9ac5bbe5156e3fb341 https://github.com/openSUSE/open-build-service/commit/fd00238c22c5c43ca3167… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/lib/tasks/test_webui.rake Log Message: ----------- [ci] Move 7 more tests from minitest 2 to 1 + 'test/functional/read_permission_test.rb', + 'test/functional/statistics_controller_test.rb', + 'test/functional/comments_controller_test.rb', + 'test/functional/group_request_test.rb', + 'test/functional/group_test.rb', + 'test/functional/person_controller_test.rb', + 'test/functional/message_controller_test.rb', Commit: 2e363b0e3165e045c4c7089640f025242c22b432 https://github.com/openSUSE/open-build-service/commit/2e363b0e3165e045c4c70… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/lib/tasks/test_webui.rake Log Message: ----------- [ci] Add 2 more minitests to the safe group + 'test/functional/request_controller_test.rb', + 'test/functional/search_controller_test.rb' Commit: 6b49f6054c77ff32de310ec476efd2b91cadac69 https://github.com/openSUSE/open-build-service/commit/6b49f6054c77ff32de310… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M .circleci/config.yml M src/api/lib/tasks/test_webui.rake Log Message: ----------- Merge pull request #5367 from coolo/more_minitest_parallel Move a little more tests between the minitest groups on circleci Compare: https://github.com/openSUSE/open-build-service/compare/65d80dd7b7b7...6b49f… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 7a9bb6: [ci] Do not report indivual coverage reports but m...
by Henne Vogelsang 16 Jul '18

16 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7a9bb6f1109a9fbf90ba867363ecdba8d9ff6bb5 https://github.com/openSUSE/open-build-service/commit/7a9bb6f1109a9fbf90ba8… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-15 (Sun, 15 Jul 2018) Changed paths: M .circleci/config.yml M codecov.yml M src/api/Gemfile M src/api/Gemfile.lock M src/api/lib/tasks/coverage.rake M src/api/spec/support/coverage.rb M src/api/test/test_helper.rb Log Message: ----------- [ci] Do not report indivual coverage reports but merge manually This allows several benefits: - we always have HTML reports within circleci artefacts - we avoid bugs in merges on coverage services - the coverage services don't have to wait - if we upload, we're done - the coverage can be grouped as wildly as we need it, it can be done within the merge task Codecov still does not report status back reliable, but coveralls seems to have no problem with it. It doesn't hurt to report into both though - if we let coveralls not comment but only report status we can have codecov comments as optional. It will be 100% the same coverage we calculated ourselves on circleci Reused the existing lib/tasks/coverage.rake that wasn't in used since 2012 (when travis+coveralls became a valid option) Commit: 990bf617c233d6d88026c5b1f6a71fd69be966a1 https://github.com/openSUSE/open-build-service/commit/990bf617c233d6d88026c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-15 (Sun, 15 Jul 2018) Changed paths: M src/api/lib/tasks/coverage.rake Log Message: ----------- [ci] Group the files in coverage results Commit: 34c5a6d993e12ab31b62ba619784a3cad3860e34 https://github.com/openSUSE/open-build-service/commit/34c5a6d993e12ab31b62b… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-15 (Sun, 15 Jul 2018) Changed paths: M src/api/lib/tasks/coverage.rake Log Message: ----------- [ci] Render rspec and minitest on their own Both have < 70% coverage on their own Commit: 65d80dd7b7b78cea9a1c8aa803905dddf1fe28ff https://github.com/openSUSE/open-build-service/commit/65d80dd7b7b78cea9a1c8… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M .circleci/config.yml M codecov.yml M src/api/Gemfile M src/api/Gemfile.lock M src/api/lib/tasks/coverage.rake M src/api/spec/support/coverage.rb M src/api/test/test_helper.rb Log Message: ----------- Merge pull request #5377 from coolo/coverage_experiment [ci] Do not report indivual coverage reports but merge manually Compare: https://github.com/openSUSE/open-build-service/compare/59d4c46bf425...65d80… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 70c09d: [ci] Add tests for subproject related methods
by Christian Bruckmayer 16 Jul '18

16 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 70c09daca45d1fe88a384ff7c85fa819313276ce https://github.com/openSUSE/open-build-service/commit/70c09daca45d1fe88a384… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-13 (Fri, 13 Jul 2018) Changed paths: A src/api/spec/models/project/subprojects_spec.rb Log Message: ----------- [ci] Add tests for subproject related methods Commit: fde6dab9eff8dd96d0819964833df4dbdf096e76 https://github.com/openSUSE/open-build-service/commit/fde6dab9eff8dd96d0819… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-13 (Fri, 13 Jul 2018) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [frontend] Refactor Project#parent method Commit: 59d4c46bf425b1d4e0418bc421bc56cc8b3a2db2 https://github.com/openSUSE/open-build-service/commit/59d4c46bf425b1d4e0418… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/app/models/project.rb A src/api/spec/models/project/subprojects_spec.rb Log Message: ----------- Merge pull request #5366 from bgeuken/tests_for_subproject_relations Tests for subproject relations Compare: https://github.com/openSUSE/open-build-service/compare/ebf1b4f1a488...59d4c… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 16 Jul '18

16 Jul '18

Branch: refs/heads/depfu/update/srcapi/uglifier-4.1.15 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8fbc58: Update uglifier to version 4.1.15
by Christian Bruckmayer 16 Jul '18

16 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8fbc58b0f80bd6a1ec52c513938e33f181602b51 https://github.com/openSUSE/open-build-service/commit/8fbc58b0f80bd6a1ec52c… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-07-13 (Fri, 13 Jul 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update uglifier to version 4.1.15 Commit: ebf1b4f1a48891cf3a0733130b277391e5b97618 https://github.com/openSUSE/open-build-service/commit/ebf1b4f1a48891cf3a073… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-07-16 (Mon, 16 Jul 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5375 from openSUSE/depfu/update/srcapi/uglifier-4.1.15 Update uglifier: 4.1.14 → 4.1.15 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/a4247fe989f5...ebf1b… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 16 Jul '18

16 Jul '18

Branch: refs/heads/depfu/update/srcapi/puma-3.12.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0