July 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] cfaaeb: [ci] Fix attribute writing in attribute_controller...
by Henne Vogelsang 18 Jul '18

18 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: cfaaeb7848d2dac33f15024a0bc9cf56fe3fc338 https://github.com/openSUSE/open-build-service/commit/cfaaeb7848d2dac33f150… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/controllers/webui/attribute_controller_spec.rb Log Message: ----------- [ci] Fix attribute writing in attribute_controller_spec Commit: d901aaecf1c5ee49d11bd0be4b4ce3f33ab2ba76 https://github.com/openSUSE/open-build-service/commit/d901aaecf1c5ee49d11bd… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/support/database_cleaner.rb Log Message: ----------- [ci] Reset user after every test Otherwise the order matters Commit: 76adf6b3019ee227bbd9e5c79d9948f48ab1ee74 https://github.com/openSUSE/open-build-service/commit/76adf6b3019ee227bbd9e… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/controllers/webui/project_controller_spec.rb Log Message: ----------- [ci] Have project_controller_spec login before writing attributes Commit: fa5483894840766f459a6248be09c9393c17f2db https://github.com/openSUSE/open-build-service/commit/fa5483894840766f459a6… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/controllers/webui/image_templates_controller_spec.rb Log Message: ----------- [ci] Fix image_templates_controller_spec to login a user Commit: 8d9ce7ee551f45b6757cc39996b4cb4d740d7646 https://github.com/openSUSE/open-build-service/commit/8d9ce7ee551f45b6757cc… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/features/webui/image_templates_spec.rb Log Message: ----------- [ci] Fix image_templates_spec to create attrib as user Commit: 5372e666f80bdee6d5f64ef11e4ff9080b1e1339 https://github.com/openSUSE/open-build-service/commit/5372e666f80bdee6d5f64… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M src/api/spec/controllers/webui/attribute_controller_spec.rb M src/api/spec/controllers/webui/image_templates_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/features/webui/image_templates_spec.rb M src/api/spec/support/database_cleaner.rb Log Message: ----------- Merge pull request #5387 from coolo/more_cherry_picks More fixes for attribute writing in rspec Compare: https://github.com/openSUSE/open-build-service/compare/ce6ffe281f90...5372e… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 07bc98: [dist] Fix definition of search indexes
by Christian Bruckmayer 18 Jul '18

18 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 07bc98781352314a8bbd11b8323e5855a7069ab2 https://github.com/openSUSE/open-build-service/commit/07bc98781352314a8bbd1… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M src/api/app/indices/package_index.rb M src/api/app/indices/project_index.rb Log Message: ----------- [dist] Fix definition of search indexes The definition of the search indexes worked partially before, only for the 'name' fields. As it is said in the documentation the definition of each index follows this pattern: indexes field_name Applying this patch makes fields 'title' and 'description' be indexed because now the definition of each index is followed, as described in the documentation. Commit: ce6ffe281f908a745df8947c1e123ca4b772c02b https://github.com/openSUSE/open-build-service/commit/ce6ffe281f908a745df89… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M src/api/app/indices/package_index.rb M src/api/app/indices/project_index.rb Log Message: ----------- Merge pull request #5385 from eduardoj/search Fix definition of search indexes Compare: https://github.com/openSUSE/open-build-service/compare/3c1e92ea8739...ce6ff… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 3c1e92: [backend] fix lockopen no longer working with old-...
by Adrian Schröter 18 Jul '18

18 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3c1e92ea87395de348f486ff41fda1b5a78f538a https://github.com/openSUSE/open-build-service/commit/3c1e92ea87395de348f48… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M src/backend/BSUtil.pm Log Message: ----------- [backend] fix lockopen no longer working with old-style glob passing (from mls) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8c604d: [ci] Extend model tests for staging_project
by Henne Vogelsang 18 Jul '18

18 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8c604d0200437a0f62b141ba3ad0f2bb4d6e0eff https://github.com/openSUSE/open-build-service/commit/8c604d0200437a0f62b14… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/models/obs_factory/staging_project_spec.rb A src/api/spec/support/shared_contexts/a_staging_project_with_description.rb A src/api/spec/support/shared_contexts/a_summary_response.rb Log Message: ----------- [ci] Extend model tests for staging_project Co-authored-by: David Kang <dkang(a)suse.com> Commit: 095c9cdab7427ec62d5bc4fa4ca2eed394c9d314 https://github.com/openSUSE/open-build-service/commit/095c9cdab7427ec62d5bc… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- [ci] Update Rubocop TODO file for rails Commit: fcdf9c1d251afe6fb3521b99aa6ceee72d916a89 https://github.com/openSUSE/open-build-service/commit/fcdf9c1d251afe6fb3521… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/spec/models/obs_factory/staging_project_spec.rb A src/api/spec/support/shared_contexts/a_staging_project_with_description.rb A src/api/spec/support/shared_contexts/a_summary_response.rb Log Message: ----------- Merge pull request #5322 from DavidKang/obs_factory_test_2 Extend model tests for staging_project Compare: https://github.com/openSUSE/open-build-service/compare/1aaa954c3b1c...fcdf9… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 7aeada: [rspec] Make it fatal to add to a cassette
by Henne Vogelsang 18 Jul '18

18 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7aeadaf7e2a7db8ec07d37f9f1b1d74ac96b5030 https://github.com/openSUSE/open-build-service/commit/7aeadaf7e2a7db8ec07d3… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M src/api/spec/support/vcr.rb Log Message: ----------- [rspec] Make it fatal to add to a cassette If a test case requires new routes, the cassette has to be recreated from scratch. Only this way you can guarantee that the test case still works without cassette Commit: 1aaa954c3b1c2e1e5dd20bc3e6c2d8e1cd81bac8 https://github.com/openSUSE/open-build-service/commit/1aaa954c3b1c2e1e5dd20… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M src/api/spec/support/vcr.rb Log Message: ----------- Merge pull request #5392 from coolo/make_adding_stories_fatal [rspec] Make it fatal to add to a cassette Compare: https://github.com/openSUSE/open-build-service/compare/1e0178923178...1aaa9… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 268296: [frontend] Drop phantomjs and run against selenium...
by Henne Vogelsang 18 Jul '18

18 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 26829644d30f5861d3c33e644759ebc53c297725 https://github.com/openSUSE/open-build-service/commit/26829644d30f5861d3c33… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M Rakefile M docker-compose.ci.yml M docker-compose.yml M docker-files/base/docker-bootstrap.sh M src/api/Gemfile M src/api/Gemfile.lock M src/api/spec/support/capybara.rb M src/api/spec/support/vcr.rb Log Message: ----------- [frontend] Drop phantomjs and run against selenium container Commit: 65acc848aad591c3ea8c0ecc58b8897bd7f609e8 https://github.com/openSUSE/open-build-service/commit/65acc848aad591c3ea8c0… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M .travis.yml Log Message: ----------- [ci] Update docker-compose on travis The installed version is from ubuntu 14 and does not support --use-aliases Commit: ee7c5ce3aaa93eec7b0bb145a714279874d94c4c https://github.com/openSUSE/open-build-service/commit/ee7c5ce3aaa93eec7b0bb… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- [ci] Fix projects_spec to work on chrome - accept alert on delete - wait for the page to reload before checking models Commit: 847c78098a05f8a3a547642f6712849fd68d67ed https://github.com/openSUSE/open-build-service/commit/847c78098a05f8a3a5476… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/features/webui/packages_spec.rb Log Message: ----------- [ci] Fix packages_spec not to check invisible elements Commit: 012d08862ee6197f64ac8a80ed92bac36ea50a71 https://github.com/openSUSE/open-build-service/commit/012d08862ee6197f64ac8… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/cassettes/Sign_up/User.yml M src/api/spec/features/webui/sign_up_spec.rb Log Message: ----------- [ci] Fix sign_up_spec to require javascript Commit: 275537e9fccd72d0eb87ad14a7e05e1dd367eb3f https://github.com/openSUSE/open-build-service/commit/275537e9fccd72d0eb87a… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: A src/api/spec/cassettes/Projects/locked_projects/fail_to_unlock.yml A src/api/spec/cassettes/Projects/locked_projects/unlock.yml R src/api/spec/cassettes/Projects/locked_projects/unlock_project.yml M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- [ci] Fix naming conflict between 2 scenarios Commit: 3aed7db54c5647a0033bc825037bc037c524e5b4 https://github.com/openSUSE/open-build-service/commit/3aed7db54c5647a0033bc… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: A docker-compose.selenium.yml M docker-compose.yml Log Message: ----------- [ci] Move the selenium container into an override file This way the selenium container is only required to run feature tests Commit: dcfbc0e176d779fb1c8fee1d2f3aa44778efef28 https://github.com/openSUSE/open-build-service/commit/dcfbc0e176d779fb1c8fe… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/features/webui/image_templates_spec.rb Log Message: ----------- [ci] image_templates_spec: Make click more reliable Clicking into the group may result in actually clicking on the package link, which would leave the page. We want to make sure it's selecting the radio box instead. The description is the only part that is clickable within the group, so click it Commit: 5cf8493733a0400e02650678fea30991e1881d7b https://github.com/openSUSE/open-build-service/commit/5cf8493733a0400e02650… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/app/assets/javascripts/webui/application/image_templates.js M src/api/app/views/webui/image_templates/index.html.haml Log Message: ----------- [frontend] Use ready_function in image_templates Commit: 08253a38ed69bcd26b09d2ee43062c6db84eb6b1 https://github.com/openSUSE/open-build-service/commit/08253a38ed69bcd26b09d… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/support/vcr.rb Log Message: ----------- [rspec] Ignore all localhost requests for vcr This ignores requests to 127.0.0.1 and 0.0.0.0 - both are selenium Commit: 384397e376abea94c339b203d9cd2db2909260f7 https://github.com/openSUSE/open-build-service/commit/384397e376abea94c339b… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] Fix feature tests in spec file %ifnarch is always true in noarch packages like obs-server. So the check for it is pointless - remove it BuildRequire: chromedriver if we want to run the frontend test suite Commit: 1e01789231784abbdd706b938c0eb9d4da78bba5 https://github.com/openSUSE/open-build-service/commit/1e01789231784abbdd706… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-18 (Wed, 18 Jul 2018) Changed paths: M .travis.yml M Rakefile M dist/obs-server.spec M docker-compose.ci.yml A docker-compose.selenium.yml M docker-files/base/docker-bootstrap.sh M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/assets/javascripts/webui/application/image_templates.js M src/api/app/views/webui/image_templates/index.html.haml A src/api/spec/cassettes/Projects/locked_projects/fail_to_unlock.yml A src/api/spec/cassettes/Projects/locked_projects/unlock.yml R src/api/spec/cassettes/Projects/locked_projects/unlock_project.yml M src/api/spec/cassettes/Sign_up/User.yml M src/api/spec/features/webui/image_templates_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/features/webui/projects_spec.rb M src/api/spec/features/webui/sign_up_spec.rb M src/api/spec/support/capybara.rb M src/api/spec/support/vcr.rb Log Message: ----------- Merge pull request #5195 from coolo/chromedriver_experiment Drop phantomjs and run against selenium container with chrome Compare: https://github.com/openSUSE/open-build-service/compare/118b990cb5a2...1e017… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 9aeffd: Reference Gravatar avatars from a HTTPS scheme URI
by Stephan Kulow 17 Jul '18

17 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9aeffd8bc75c324eaa60bb3e74eec641d97bae50 https://github.com/openSUSE/open-build-service/commit/9aeffd8bc75c324eaa60b… Author: Andreas Stieger <astieger(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/app/helpers/webui/user_helper.rb M src/api/spec/helpers/webui/user_helper_spec.rb Log Message: ----------- Reference Gravatar avatars from a HTTPS scheme URI Avoids mixed content warnings. Fixes #5388 Commit: 118b990cb5a25178f64147dde9baef4b81fccecc https://github.com/openSUSE/open-build-service/commit/118b990cb5a25178f6414… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/app/helpers/webui/user_helper.rb M src/api/spec/helpers/webui/user_helper_spec.rb Log Message: ----------- Merge pull request #5389 from andreasstieger/https-gravatars Reference Gravatar avatars from a HTTPS scheme URI Compare: https://github.com/openSUSE/open-build-service/compare/3185dc645988...118b9… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 1e2dfb: [ci] Skip broken addKiwiImport service test
by Stephan Kulow 17 Jul '18

17 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1e2dfb1f81150ddda2480c90566b20d7e060ccc5 https://github.com/openSUSE/open-build-service/commit/1e2dfb1f81150ddda2480… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/models/service_spec.rb Log Message: ----------- [ci] Skip broken addKiwiImport service test as this service expects a tar archive. We need to transfer this test to a more integration like test e.g. in Package#save_file. Commit: 3185dc64598828096476abb75c44842538d357ec https://github.com/openSUSE/open-build-service/commit/3185dc64598828096476a… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/models/service_spec.rb Log Message: ----------- Merge pull request #5382 from ChrisBr/skip_kiwi_import_test [ci] Skip broken addKiwiImport service test Compare: https://github.com/openSUSE/open-build-service/compare/cbe8ef16ceae...3185d… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 9afb6f: [ci] Fix ec2 upload test by properly stubing
by Stephan Kulow 17 Jul '18

17 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9afb6f14c188aeb3d07f6ea5ab2cc3ca04216479 https://github.com/openSUSE/open-build-service/commit/9afb6f14c188aeb3d07f6… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/controllers/webui/cloud/ec2/upload_jobs_controller_spec.rb Log Message: ----------- [ci] Fix ec2 upload test by properly stubing Relying on a cassette of a broken backend just won't work Commit: 09a5156a10804b23ad35c2c412a40f4dc2fbccb5 https://github.com/openSUSE/open-build-service/commit/09a5156a10804b23ad35c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/models/cloud/backend/upload_job_spec.rb Log Message: ----------- [ci] Stub cloud misconfiguration Having a cassette for broken backend configuration is not reproducible Commit: 4f40aec960a6f97312b34cfb9de6eb1fcc2836ac https://github.com/openSUSE/open-build-service/commit/4f40aec960a6f97312b34… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/controllers/webui/cloud/azure/upload_jobs_controller_spec.rb Log Message: ----------- [ci] Stub one more misconfigure cloud backend Commit: 2187757d945f72f8e75e4ca64901ec4641e64515 https://github.com/openSUSE/open-build-service/commit/2187757d945f72f8e75e4… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/models/cloud/upload_job_spec.rb Log Message: ----------- [ci] Do not require misconfigured backend on upload_job_spec Commit: cbe8ef16ceae34b4402670ca3c10c406cd5d7257 https://github.com/openSUSE/open-build-service/commit/cbe8ef16ceae34b440267… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-17 (Tue, 17 Jul 2018) Changed paths: M src/api/spec/controllers/webui/cloud/azure/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/cloud/ec2/upload_jobs_controller_spec.rb M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/cloud/upload_job_spec.rb Log Message: ----------- Merge pull request #5381 from coolo/fix_cloud Fix 4 specs that require a misconfigured backend Compare: https://github.com/openSUSE/open-build-service/compare/c7c6609c9bac...cbe8e… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 17 Jul '18

17 Jul '18

Branch: refs/heads/depfu/update/srcapi/autoprefixer-rails-9.0.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0