December 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] a34ffc: [backend] BSHTTP: use tr/// insted of s///
by Michael Schroeder 21 Dec '18

21 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a34ffc05fb27bceaa20fea79d65b7ede4fe51887 https://github.com/openSUSE/open-build-service/commit/a34ffc05fb27bceaa20fe… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/backend/BSHTTP.pm Log Message: ----------- [backend] BSHTTP: use tr/// insted of s/// Commit: f633acdf7d7cf864faecda34b2d4f8cb6b0cce1f https://github.com/openSUSE/open-build-service/commit/f633acdf7d7cf864faecd… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/backend/BSRPC.pm Log Message: ----------- [backend] BSRPC: simplify HEAD request handling Commit: 319c6a2a30c924ebabf4f3159514a22ed263f45b https://github.com/openSUSE/open-build-service/commit/319c6a2a30c924ebabf4f… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/backend/BSRegistryServer.pm Log Message: ----------- [backend] BSRegistryServer: add 'use' statements for the modules we use Commit: 516b222c733fb0e5d52cacd1417073dc6f3eed1e https://github.com/openSUSE/open-build-service/commit/516b222c733fb0e5d52ca… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/backend/BSHTTP.pm M src/backend/BSRPC.pm M src/backend/BSRegistryServer.pm Log Message: ----------- Merge pull request #6687 from mlschroe/master Small backend cleanups Compare: https://github.com/openSUSE/open-build-service/compare/5fc5f167b12a...516b2… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 21 Dec '18

21 Dec '18

Branch: refs/heads/depfu/update/srcapi/mimemagic-0.3.3 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 93d207: Update mimemagic to version 0.3.3
by Stephan Kulow 21 Dec '18

21 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 93d207b2c35ba86ec1c32e0480a308efbdfee48c https://github.com/openSUSE/open-build-service/commit/93d207b2c35ba86ec1c32… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update mimemagic to version 0.3.3 Commit: 5fc5f167b12ad5bb97737fc9aa7e4c90934aa685 https://github.com/openSUSE/open-build-service/commit/5fc5f167b12ad5bb97737… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6684 from openSUSE/depfu/update/srcapi/mimemagic-0.3.3 [src/api] Update mimemagic: 0.3.2 → 0.3.3 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/b7b04f7fabb3...5fc5f… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 9e6467: Display table information when the pagination is a...
by Ana María Martínez Gómez 21 Dec '18

21 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9e6467fcd4c10d9a72a762fc917954fff7d5e789 https://github.com/openSUSE/open-build-service/commit/9e6467fcd4c10d9a72a76… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/show.html.haml M src/api/app/views/webui2/webui/user/_involvement.html.haml Log Message: ----------- Display table information when the pagination is also displayed To be consistent in all tables. We have some pages where tables don't have any control (pagination, search), we don't display the information in such cases. When only the search is present, we don't either. In these cases, the tables contain only a few rows (examples: users/groups, attributes). Commit: b7b04f7fabb326a1192fe095217b60eed6024c68 https://github.com/openSUSE/open-build-service/commit/b7b04f7fabb326a1192fe… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/show.html.haml M src/api/app/views/webui2/webui/user/_involvement.html.haml Log Message: ----------- Merge pull request #6678 from dmarcoux/display-table-information Display table information when the pagination is also displayed Compare: https://github.com/openSUSE/open-build-service/compare/fff27d0917e9...b7b04… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] b8f880: Include user when querying request history
by Ana María Martínez Gómez 21 Dec '18

21 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b8f8803c6c0d56266c1ad5621359dc047cd4e251 https://github.com/openSUSE/open-build-service/commit/b8f8803c6c0d56266c1ad… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/attribute/new.html.haml Log Message: ----------- Include user when querying request history Commit: 73a0403f76a1623d22b3def83cbf63385b5cd4d7 https://github.com/openSUSE/open-build-service/commit/73a0403f76a1623d22b3d… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/views/models/_project.xml.builder Log Message: ----------- Avoid N+1 queries in rendering project meta Commit: cdd89063e8b1bd71c8be0485cae6f8941718f986 https://github.com/openSUSE/open-build-service/commit/cdd89063e8b1bd71c8be0… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/api/app/views/models/_project.xml.builder Log Message: ----------- project _meta: Order the repositories in the DB not in rails Commit: fff27d0917e9af4d7e92e178042a4e2e46adae7b https://github.com/openSUSE/open-build-service/commit/fff27d0917e9af4d7e92e… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-12-21 (Fri, 21 Dec 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/models/_project.xml.builder M src/api/app/views/webui/attribute/new.html.haml Log Message: ----------- Merge pull request #6683 from coolo/avoid_sql4 Avoid some more N+1 queries Compare: https://github.com/openSUSE/open-build-service/compare/f47ecabbb3ee...fff27… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 5f77a0: Avoid N+1 queries in update policy
by Stephan Kulow 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5f77a024cba5d20f65b4c280d0cdb943c49cb762 https://github.com/openSUSE/open-build-service/commit/5f77a024cba5d20f65b4c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Avoid N+1 queries in update policy has_remote_repositories? is called from project update? policy, which is called in a lot of places. And it's horribly slow as it loops through an array with N+1 queries looking like this in logs: DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 357782 LIMIT 1 DownloadRepository Exists (0.2ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 157220 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 214402 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 289102 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 264047 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 320882 LIMIT 1 DownloadRepository Exists (0.1ms) SELECT 1 AS one FROM `download_repositories` WHERE `download_repositories`.`repository_id` = 408379 LIMIT 1 Using one subselect gives you one access into the repositories index. p=Project.find_by_name('openSUSE:Tools') irb(main):022:0> Benchmark.measure { 100.times { p.has_remote_repositories_old? } } => real=2.6102131991647184 irb(main):023:0> Benchmark.measure { 100.times { p.has_remote_repositories? } } => real=0.0647597061470151 Commit: f47ecabbb3ee7fd51eb9e4a6536ab6c799d330a3 https://github.com/openSUSE/open-build-service/commit/f47ecabbb3ee7fd51eb9e… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Merge pull request #6682 from coolo/avoid_sql3 Avoid N+1 queries in update policy Compare: https://github.com/openSUSE/open-build-service/compare/708540bb012a...f47ec… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 20 Dec '18

20 Dec '18

Branch: refs/heads/depfu/update/srcapi/font-awesome-sass-5.6.1 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 29844d: Update font-awesome-sass to version 5.6.1
by Stephan Kulow 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 29844d66eddeddb5e8350d8eed0ac13c232ce88b https://github.com/openSUSE/open-build-service/commit/29844d66eddeddb5e8350… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update font-awesome-sass to version 5.6.1 Commit: 708540bb012a6f4251917229681079d5925a6424 https://github.com/openSUSE/open-build-service/commit/708540bb012a6f4251917… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6681 from openSUSE/depfu/update/srcapi/font-awesome-sass-5.6.1 [src/api] Update font-awesome-sass: 5.5.0.1 → 5.6.1 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/c5d34def3ec8...70854… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 3daaab: Make it possible to preload repository architectur...
by Henne Vogelsang 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3daaab49245359d6a357d424f62c1f2a5ea25726 https://github.com/openSUSE/open-build-service/commit/3daaab49245359d6a357d… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/repository.rb Log Message: ----------- Make it possible to preload repository architectures Remove the duplicated order statement, which breaks preloading. This order isn't used normally (as it's a :through relationship and repository_architectures have an order already), but it breaks in preload situation where rails will load all architectures in a 2nd statement. Fixes #6662 Commit: c5d34def3ec876735ddc78f10dc985b4e9bea2e0 https://github.com/openSUSE/open-build-service/commit/c5d34def3ec876735ddc7… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/app/models/repository.rb Log Message: ----------- Merge pull request #6666 from coolo/fix_6662 Make it possible to preload architectures Compare: https://github.com/openSUSE/open-build-service/compare/491b8f25316e...c5d34… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 20 Dec '18

20 Dec '18

Branch: refs/heads/depfu/update/srcapi/erubi-1.8.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 20ef93: Update erubi to version 1.8.0
by Stephan Kulow 20 Dec '18

20 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 20ef939f6a75cc9ba3b8c286f5a920956f44ca0c https://github.com/openSUSE/open-build-service/commit/20ef939f6a75cc9ba3b8c… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update erubi to version 1.8.0 Commit: 491b8f25316ecc2394e01d8a3a589ab8b57e182d https://github.com/openSUSE/open-build-service/commit/491b8f25316ecc2394e01… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-20 (Thu, 20 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6676 from openSUSE/depfu/update/srcapi/erubi-1.8.0 [src/api] Update erubi: 1.7.1 → 1.8.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/dbc61f858760...491b8… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] aa11f1: Rename and clean set_flavors up
by Alexander Graul 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: aa11f1be97f1744d815e620dd8b826374e897556 https://github.com/openSUSE/software-o-o/commit/aa11f1be97f1744d815e620dd8b… Author: Alexander Graul <agraul(a)suse.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M app/controllers/download_controller.rb Log Message: ----------- Rename and clean set_flavors up We use the American spelling ("flavor") everywhere else in the file, this method should not be an outlier. The method is shorter now and uses a guard clause instead of an if-else block and a more concise and efficient sort. Commit: 44063691ea4e4087677f282b452c17e06c567375 https://github.com/openSUSE/software-o-o/commit/44063691ea4e4087677f282b452… Author: Alexander Graul <agraul(a)suse.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M app/controllers/download_controller.rb Log Message: ----------- Remove unused method set_parameters was not used anywhere. Commit: c3f684dbe2687eb2226997e1144560579a7f86dc https://github.com/openSUSE/software-o-o/commit/c3f684dbe2687eb2226997e1144… Author: Alexander Graul <agraul(a)suse.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M app/controllers/download_controller.rb Log Message: ----------- Merge pull request #446 from alexandergraul/download-controller-cleanup Small cleanup of download controller Compare: https://github.com/openSUSE/software-o-o/compare/a3b136446c32...c3f684dbe268 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 6fb2a2: Avoid N+1 queries in comments controller
by Stephan Kulow 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6fb2a24bab901ea9b9517efd916dd87e1bae0390 https://github.com/openSUSE/open-build-service/commit/6fb2a24bab901ea9b9517… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/comments_controller.rb Log Message: ----------- Avoid N+1 queries in comments controller According to metrics.opensuse.org the comments/index.xml.builder view has the most impact - rendered 106K in 24 hours (all these bots communicating through comments don't help) Commit: ad2bc11601127009b12247aacb32e7efbc9728d2 https://github.com/openSUSE/open-build-service/commit/ad2bc11601127009b1224… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: R src/api/app/views/comments/_comments.xml.builder M src/api/app/views/comments/index.xml.builder Log Message: ----------- Merge 2 three-line views into one The partial is only used in one view and repeats the same call in a loop, so better pull it out Commit: dbc61f858760e456bbb00691e598ed1a8752adc0 https://github.com/openSUSE/open-build-service/commit/dbc61f858760e456bbb00… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/comments_controller.rb R src/api/app/views/comments/_comments.xml.builder M src/api/app/views/comments/index.xml.builder Log Message: ----------- Merge pull request #6668 from coolo/preload_users Avoid N+1 queries in comments controller Compare: https://github.com/openSUSE/open-build-service/compare/12c4f9a52101...dbc61… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 6a429e: Set correct date range and period during initial p...
by Henne Vogelsang 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6a429eaf72cd6b1700dd16e7d4123f10243df071 https://github.com/openSUSE/open-build-service/commit/6a429eaf72cd6b1700dd1… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/pulse_controller.rb M src/api/app/views/webui2/webui/projects/pulse/show.html.haml Log Message: ----------- Set correct date range and period during initial page load Commit: 632c1d5b18133d9b0691e95483ea75a183c0095b https://github.com/openSUSE/open-build-service/commit/632c1d5b18133d9b0691e… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/show.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.js.erb Log Message: ----------- Reuse spinner on pulse page instead of always overwriting it The spinner is now always in the same position. It was previously centered during the initial page load, then on the left whenever changing the selected period in the dropdown. This was caused by the HTML and CSS classes which differed. Commit: 4989c0fd447f2b3172482cd15075c6a1f56d717c https://github.com/openSUSE/open-build-service/commit/4989c0fd447f2b3172482… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests.html.haml Log Message: ----------- Set the request description as a tooltip It isn't truncated anymore Commit: 173652f787961bb94fa3162099324a5381f63932 https://github.com/openSUSE/open-build-service/commit/173652f787961bb94fa31… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_changes.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_comments.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_commits.html.haml Log Message: ----------- Emphasize information under date range in pulse page Commit: 7bb83d85cc05e8422f4fcc366595433072e38f8a https://github.com/openSUSE/open-build-service/commit/7bb83d85cc05e8422f4fc… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list.html.haml Log Message: ----------- Use accordions for lists on the pulse page Also display lists only if data is present Commit: 90ea0ce91a170c42bbff3079189bb1b3fe72c22b https://github.com/openSUSE/open-build-service/commit/90ea0ce91a170c42bbff3… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/projects/pulse/_pulse_list.html.haml A src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests_box.html.haml Log Message: ----------- Use a partial for the Requests box in the pulse page Commit: 12c4f9a5210170f6bb6eec802eb29a387d6864da https://github.com/openSUSE/open-build-service/commit/12c4f9a5210170f6bb6ee… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/pulse_controller.rb M src/api/app/views/webui2/webui/projects/pulse/_pulse_list.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_changes.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_comments.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_commits.html.haml M src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests.html.haml A src/api/app/views/webui2/webui/projects/pulse/_pulse_list_requests_box.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.html.haml M src/api/app/views/webui2/webui/projects/pulse/show.js.erb Log Message: ----------- Merge pull request #6669 from dmarcoux/improve-pulse-bootstrap Improvements for the pulse page Compare: https://github.com/openSUSE/open-build-service/compare/be6894228072...12c4f… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 122098: ProjectUpdater#call returns self
by Victor Pereira 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 122098dacacf32e2c7bee83c157ab0e8168ae9ff https://github.com/openSUSE/open-build-service/commit/122098dacacf32e2c7bee… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/meta_controller.rb M src/api/app/services/meta_controller_service/project_updater.rb M src/api/spec/controllers/webui/projects/meta_controller_spec.rb A src/api/spec/services/meta_controller_service/project_updater_spec.rb Log Message: ----------- ProjectUpdater#call returns self calling call should return the ProjectUpdater instance as normally done with Service objects, giving us the ability to mock it with a simple Proc object Simplify call to ProjectUpdater#call on MetAcontroller#update Stub calls to service objects on MetaControllerSpec to avoid VCR Add spec for ProjectUpdater service object Commit: 4a574ed0f93070997c18c56bb230885f2a315fc5 https://github.com/openSUSE/open-build-service/commit/4a574ed0f93070997c18c… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_2.yml Log Message: ----------- Remove unused cassettes Commit: be6894228072f74e5b2d1c645d5b87a0330aea58 https://github.com/openSUSE/open-build-service/commit/be6894228072f74e5b2d1… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/webui/projects/meta_controller.rb M src/api/app/services/meta_controller_service/project_updater.rb R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_non_existing_repository_path/1_2_2_4_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_a_valid_meta/1_2_2_3_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/with_an_invalid_devel_project/1_2_2_2_2.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_1.yml R src/api/spec/cassettes/Webui_Projects_MetaController/POST_update/with_a_valid_project/without_a_valid_meta/1_2_2_1_2.yml M src/api/spec/controllers/webui/projects/meta_controller_spec.rb A src/api/spec/services/meta_controller_service/project_updater_spec.rb Log Message: ----------- Merge pull request #6620 from vpereira/meta_controller_spec Refactor Meta controller related specs Compare: https://github.com/openSUSE/open-build-service/compare/5bd21f977117...be689… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 0cf396: Migrate project new page to bootstrap
by Björn Geuken 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0cf396ad302c52fdccc6ebebdc691e36a51821ac https://github.com/openSUSE/open-build-service/commit/0cf396ad302c52fdccc6e… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/_form.html.haml A src/api/app/views/webui2/webui/project/_new_project_modal.html.haml M src/api/app/views/webui2/webui/project/list.html.haml Log Message: ----------- Migrate project new page to bootstrap Following the re-design, the creation of a project will be in a modal as it is in subprojects. Co-authored-by: David Kang <dkang(a)suse.com> Commit: ef9e8122e949ad7d0f3ae48eab5b9d47ce598e5d https://github.com/openSUSE/open-build-service/commit/ef9e8122e949ad7d0f3ae… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: R src/api/app/views/webui2/webui/project/_add_new_subproject_modal.html.haml M src/api/app/views/webui2/webui/project/_new_project_modal.html.haml M src/api/app/views/webui2/webui/project/subprojects.html.haml Log Message: ----------- Unify creation modal for both projects and subprojects They are almost the same, it is not worth having two different views. Co-authored-by: David Kang <dkang(a)suse.com> Commit: 5bd21f977117d90aae34d5a72e8e8040a37dc55b https://github.com/openSUSE/open-build-service/commit/5bd21f977117d90aae34d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: R src/api/app/views/webui2/webui/project/_add_new_subproject_modal.html.haml M src/api/app/views/webui2/webui/project/_form.html.haml A src/api/app/views/webui2/webui/project/_new_project_modal.html.haml M src/api/app/views/webui2/webui/project/list.html.haml M src/api/app/views/webui2/webui/project/subprojects.html.haml Log Message: ----------- Merge pull request #6658 from saraycp/bootstrap_project_create Migrate project creation page to bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/30e51fd24dac...5bd21… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] a9ac08: If there is no influxdb config, we don't want the ...
by Stephan Kulow 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a9ac08cec02481f89958ea74f6007076082118bf https://github.com/openSUSE/open-build-service/commit/a9ac08cec02481f89958e… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/config/initializers/influxdb_rails.rb Log Message: ----------- If there is no influxdb config, we don't want the default For whatever reason influxdb-rails keeps flooding localhost:8086 if nothing is configured - for every developer, only test environment is ignored by default Commit: 30e51fd24dac83e81919175ba2b2efd6f9a4048b https://github.com/openSUSE/open-build-service/commit/30e51fd24dac83e819191… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/config/initializers/influxdb_rails.rb Log Message: ----------- Merge pull request #6670 from coolo/disable_influxdb If there is no influxdb config, we don't want the default Compare: https://github.com/openSUSE/open-build-service/compare/3a68c38ccea5...30e51… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ec60a7: Add limit to project autocomplete
by Björn Geuken 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ec60a799e755f71fee34833ff87761a62066b96d https://github.com/openSUSE/open-build-service/commit/ec60a799e755f71fee348… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Add limit to project autocomplete This got lost while updating #6591. Commit: 3a68c38ccea587ca94f62d63c1574548ce25291a https://github.com/openSUSE/open-build-service/commit/3a68c38ccea587ca94f62… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Merge pull request #6667 from bgeuken/fix_autocomplete_ Add limit to project autocomplete Compare: https://github.com/openSUSE/open-build-service/compare/6497d9510d8c...3a68c… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] a7fb91: Cache user_can_modify_project in repository page
by Stephan Kulow 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a7fb91615ef30c2a78bd1036c2a6110fd1ca0d81 https://github.com/openSUSE/open-build-service/commit/a7fb91615ef30c2a78bd1… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/repositories/_repository_card_content.html.haml M src/api/app/views/webui2/webui/repositories/_repository_entry.html.haml M src/api/app/views/webui2/webui/repositories/index.html.haml Log Message: ----------- Cache user_can_modify_project in repository page This function was called *twice* per repository and is not exactly cheap: CACHE Flag Exists (0.0ms) SELECT 1 AS one FROM `flags` WHERE `flags`.`project_id` = 2 AND `flags`.`flag` = 'lock' AND `flags`.`status` = 'enable' LIMIT 1 has_global_permission? change_project CACHE (0.0ms) SELECT `roles_static_permissions`.`role_id` FROM `roles_static_permissions` INNER JOIN `static_permissions` ON `static_permissions`.`id` = `roles_static_permissions`.`s tatic_permission_id` WHERE `static_permissions`.`title` = 'change_project' running local permission check: user coolo, project home:Admin, permission 'change_project' CACHE Project Load (0.0ms) SELECT `projects`.* FROM `projects` WHERE (projects.id not in (0)) AND `projects`.`name` = 'home' ORDER BY `projects`.`name` DESC LIMIT 1 CACHE Relationship Exists (0.0ms) SELECT 1 AS one FROM `relationships` WHERE `relationships`.`project_id` = 2 AND `relationships`.`user_id` = 3 AND (role_id in (1,2)) LIMIT 1 CACHE Relationship Exists (0.0ms) SELECT 1 AS one FROM `relationships` INNER JOIN `groups` ON `groups`.`id` = `relationships`.`group_id` INNER JOIN `groups_users` ON `groups_users`.` group_id` = `groups`.`id` WHERE `relationships`.`project_id` = 2 AND `groups_users`.`user_id` = 3 AND (role_id in (1,2)) LIMIT 1 Commit: 6497d9510d8cce341665c309afd8e0c5f2d60941 https://github.com/openSUSE/open-build-service/commit/6497d9510d8cce341665c… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/repositories/_repository_card_content.html.haml M src/api/app/views/webui2/webui/repositories/_repository_entry.html.haml M src/api/app/views/webui2/webui/repositories/index.html.haml Log Message: ----------- Merge pull request #6664 from coolo/avoid_sql Cache user_can_modify_project in repository page Compare: https://github.com/openSUSE/open-build-service/compare/dd0d5460e941...6497d… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 00b494: Enable consider_all_requests_local in test suite
by Ana María Martínez Gómez 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 00b494e5066a1e57f728ff5bc839f977ba078baa https://github.com/openSUSE/open-build-service/commit/00b494e5066a1e57f728f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/config/environments/test.rb Log Message: ----------- Enable consider_all_requests_local in test suite This allows us to see detailed debugging information, including a backtrace, when a feature test fails. See https://guides.rubyonrails.org/configuring.html for more information. Commit: dd0d5460e941326e5ad79281d9c4e76c85348955 https://github.com/openSUSE/open-build-service/commit/dd0d5460e941326e5ad79… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/config/environments/test.rb Log Message: ----------- Merge pull request #6660 from bgeuken/show_backtrace_in_feature_tests Enable consider_all_requests_local in test suite Compare: https://github.com/openSUSE/open-build-service/compare/cf8b4ef70094...dd0d5… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] c1e6ca: Align appearance of build status icons
by Björn Geuken 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c1e6ca1413fc8cacecdcc79d330c0dd4fbe774a1 https://github.com/openSUSE/open-build-service/commit/c1e6ca1413fc8cacecdcc… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui2/webui/package/_buildstatus.html.haml M src/api/app/views/webui2/webui/package/binaries.html.haml M src/api/app/views/webui2/webui/project/_buildstatus.html.haml M src/api/app/views/webui2/webui/project/monitor.html.haml Log Message: ----------- Align appearance of build status icons * Add tooltip to build status icons on monitor and binary page * Wrap common code in a helper method Commit: e35661a59d19c16198bd34c45bdf99b3c2184363 https://github.com/openSUSE/open-build-service/commit/e35661a59d19c16198bd3… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/build-results.scss M src/api/app/helpers/webui/webui_helper.rb Log Message: ----------- Refactor repository state: outdated * Move coloring of repository state icon to CSS * Refactor handling of 'outdated_' flag Commit: 418bfd9a831c5f8435c0b6c532225d7fdde3cb19 https://github.com/openSUSE/open-build-service/commit/418bfd9a831c5f8435c0b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/helpers/webui/webui_helper.rb Log Message: ----------- Wrap REPO_STATUS constants in a method and add a default Commit: cf8b4ef700948d6b46ffcc0447162d687d11fef6 https://github.com/openSUSE/open-build-service/commit/cf8b4ef700948d6b46ffc… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/build-results.scss M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/webui2/webui/package/_buildstatus.html.haml M src/api/app/views/webui2/webui/package/binaries.html.haml M src/api/app/views/webui2/webui/project/_buildstatus.html.haml M src/api/app/views/webui2/webui/project/monitor.html.haml Log Message: ----------- Merge pull request #6654 from bgeuken/sync_build_results Sync repository state icons Compare: https://github.com/openSUSE/open-build-service/compare/da503da7a274...cf8b4… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 99dedf: Don't put classname specifics in a mixing
by Björn Geuken 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 99dedf007adeea14468eea7f4517a7834323d664 https://github.com/openSUSE/open-build-service/commit/99dedf007adeea14468ee… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/mixins/can_render_model.rb A src/api/app/views/models/_remote_project.xml.builder Log Message: ----------- Don't put classname specifics in a mixing Commit: da503da7a274750afb2dbcfbb4f589bb6c685d8e https://github.com/openSUSE/open-build-service/commit/da503da7a274750afb2db… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/mixins/can_render_model.rb A src/api/app/views/models/_remote_project.xml.builder Log Message: ----------- Merge pull request #6665 from coolo/fix_fixme Don't put classname specifics in a mixing Compare: https://github.com/openSUSE/open-build-service/compare/9f962c1b467a...da503… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 19 Dec '18

19 Dec '18

Branch: refs/heads/depfu/update/srcapi/nokogiri-1.9.1 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8e6dff: Update nokogiri to version 1.9.1
by Stephan Kulow 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8e6dff809dc7fb200eb5dd0fd68e0fed8598be5e https://github.com/openSUSE/open-build-service/commit/8e6dff809dc7fb200eb5d… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update nokogiri to version 1.9.1 Commit: 9f962c1b467aac4f20bedf45ea0252afd19bbc12 https://github.com/openSUSE/open-build-service/commit/9f962c1b467aac4f20bed… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6661 from openSUSE/depfu/update/srcapi/nokogiri-1.9.1 [src/api] Update nokogiri: 1.8.5 → 1.9.1 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/be530382cefb...9f962… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] f91efc: Migrate project index page to bootstrap
by Stephan Kulow 19 Dec '18

19 Dec '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f91efc95a19798a04a6d0a573fdc7f01438430f7 https://github.com/openSUSE/open-build-service/commit/f91efc95a19798a04a6d0… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M src/api/app/assets/javascripts/webui2/application.js A src/api/app/assets/javascripts/webui2/project.js M src/api/app/controllers/webui/project_controller.rb M src/api/app/views/layouts/webui2/webui.html.haml A src/api/app/views/webui2/webui/project/list.html.haml Log Message: ----------- Migrate project index page to bootstrap The content of the public projects' table is added by javascript. We keep it like it was with small changes only: the table itself is written by the view not by JS, we add "Search" placeholder and remove some unnecessary params. Co-authored-by: David Kang <dkang(a)suse.com> Commit: be530382cefba2973596e83f0dc1f7ac7500ca43 https://github.com/openSUSE/open-build-service/commit/be530382cefba2973596e… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/assets/javascripts/webui2/application.js A src/api/app/assets/javascripts/webui2/project.js M src/api/app/controllers/webui/project_controller.rb M src/api/app/views/layouts/webui2/webui.html.haml A src/api/app/views/webui2/webui/project/list.html.haml Log Message: ----------- Merge pull request #6648 from saraycp/bootstrap_project_index Migrate project index page to bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/7cd0fb88aeeb...be530… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0