March 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 533487: [ci] Add validation_helper_spec.rb
by Björn Geuken 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 533487d20d948b8a07574a6be294f5d280669175 https://github.com/openSUSE/open-build-service/commit/533487d20d948b8a07574… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: A src/api/spec/helpers/validation_helper_spec.rb Log Message: ----------- [ci] Add validation_helper_spec.rb This implements the missing tests for the rspec test suite. Related to card: https://trello.com/c/CJtlSMoy/268-app-helpers-validation-helper-rb Commit: 68fe392b919052f5ee8e5aa631850212bb28a084 https://github.com/openSUSE/open-build-service/commit/68fe392b919052f5ee8e5… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: A src/api/spec/helpers/validation_helper_spec.rb Log Message: ----------- Merge pull request #2885 from mschnitzer/validation_helper_rspec [ci] Add validation_helper_spec.rb Compare: https://github.com/openSUSE/open-build-service/compare/1bdf6c290fbd...68fe3…

1 0

[obs-commits] [openSUSE/open-build-service] 936a88: [api] Remove unnecessary `references`
by Ana María Martínez Gómez 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 936a88b596dec2db264a27c340aa1179d733feed https://github.com/openSUSE/open-build-service/commit/936a88b596dec2db264a2… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [api] Remove unnecessary `references` `references` method only makes sense when used together with `includes` and we are using `join` for `bs_request_actions`. So `references(:bs_request_actions)` can be removed. http://apidock.com/rails/ActiveRecord/QueryMethods/references Commit: 1bdf6c290fbdfa01014c02d240cff9595450d5fc https://github.com/openSUSE/open-build-service/commit/1bdf6c290fbdfa01014c0… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- Merge pull request #2876 from Ana06/references [api] Remove unnecessary `references` Compare: https://github.com/openSUSE/open-build-service/compare/3c164b4b0d46...1bdf6…

1 0

[obs-commits] [openSUSE/open-build-service] 7b0fab: [ci] Move Rubocop config files to base directory
by David Kang 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7b0faba21129add379142b533619ca967d5122c7 https://github.com/openSUSE/open-build-service/commit/7b0faba21129add379142… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: A .rubocop.yml A .rubocop_todo.yml R src/api/.rubocop.yml R src/api/.rubocop_todo.yml Log Message: ----------- [ci] Move Rubocop config files to base directory Move `.rubocop.yml` and `.rubocop_todo.yml` files to base directory to be able to apply Rubocop also to the Ruby files outside of the Rails project. Pair programmed with @Ana06. Commit: b62c5b34c9b207297090b3e2470899f5b0f773ba https://github.com/openSUSE/open-build-service/commit/b62c5b34c9b207297090b… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M .rubocop.yml M .rubocop_todo.yml Log Message: ----------- [ci] Add cop exceptions for dist directory Add exceptions for `dist` directory to .rubocop_todo.yml for every cop, so it will be easy to enable them afterwards. Pair programmed with @Ana06. Commit: 47c97952110d0caa8b105ccaab04166f15cede04 https://github.com/openSUSE/open-build-service/commit/47c97952110d0caa8b105… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M .travis.yml M Makefile M dist/ci/travis_script.sh Log Message: ----------- [ci] Add rubocop target to main Makefile Add `rubocop` target to main Makefile. Now you can call Rubocop from the base directory with this command: `make rubocop`. Modify `travis_script.sh` to call this target. Modify `.travis.yml` to install rubocop gem system wide. Now it is possible to execute it from base directory. Pair programmed with @Ana06. Commit: 3c164b4b0d4670be937c2fcf1e59e4073558f0b5 https://github.com/openSUSE/open-build-service/commit/3c164b4b0d4670be937c2… Author: David Kang <dkang(a)suse.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: A .rubocop.yml A .rubocop_todo.yml M .travis.yml M Makefile M dist/ci/travis_script.sh R src/api/.rubocop.yml R src/api/.rubocop_todo.yml Log Message: ----------- Merge pull request #2884 from eduardoj/move_rubocop_conf_up [ci] Move Rubocop config files to base directory Compare: https://github.com/openSUSE/open-build-service/compare/4f83a7d47f8b...3c164…

1 0

[obs-commits] [openSUSE/open-build-service] 18b6f6: [ci] Reload page before testing it
by Björn Geuken 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 18b6f61afef8a7cb7b2ce5959d4943edc139366c https://github.com/openSUSE/open-build-service/commit/18b6f61afef8a7cb7b2ce… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/api/test/functional/webui/package_branch_test.rb Log Message: ----------- [ci] Reload page before testing it Between creating a branch and testing package submission we do a backend request which creates a new package revision. The revision is part of the package show page and might be needed by the test (it actually is needed with pr#2829). Commit: 4f83a7d47f8bdcba088704500681295dd7c1ba4d https://github.com/openSUSE/open-build-service/commit/4f83a7d47f8bdcba08870… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/api/test/functional/webui/package_branch_test.rb Log Message: ----------- Merge pull request #2878 from bgeuken/fix_package_branch_test [ci] Reload page before testing it Compare: https://github.com/openSUSE/open-build-service/compare/917147239150...4f83a…

1 0

[obs-commits] [openSUSE/open-build-service]
by hennevogel 22 Mar '17

22 Mar '17

Branch: refs/heads/revert-2811-fix_ordering_of_rubocops Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service]
by hennevogel 22 Mar '17

22 Mar '17

Branch: refs/heads/pundit Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/software-o-o] 7d84b5: in is an invalid locale
by Ludwig Nussel 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: 7d84b5373726eccd80127cc8ea0973065d639ceb https://github.com/openSUSE/software-o-o/commit/7d84b5373726eccd80127cc8ea0… Author: Ludwig Nussel <ludwig.nussel(a)suse.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: R locale/in/in.po Log Message: ----------- in is an invalid locale

1 0

[obs-commits] [openSUSE/open-build-service] 550ae3: [ci] Add even more tests to attrib controller test...
by Björn Geuken 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 550ae37d76444f361e5d0651dcfccc071f1ed9a5 https://github.com/openSUSE/open-build-service/commit/550ae37d76444f361e5d0… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/api/spec/controllers/webui/attributes_spec.rb Log Message: ----------- [ci] Add even more tests to attrib controller tests 'new' and 'edit' actions are now tested. Commit: 917147239150f08ab655d2301e2da42a3f611f62 https://github.com/openSUSE/open-build-service/commit/917147239150f08ab655d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/api/spec/controllers/webui/attributes_spec.rb Log Message: ----------- Merge pull request #2870 from eduardoj/attribute_controller_more_tests_2 [ci] Add even more tests to attrib controller tests Compare: https://github.com/openSUSE/open-build-service/compare/4857bd66a0bf...91714…

1 0

[obs-commits] [openSUSE/osc] 678c79: added --blame switch to osc meta command
by Marcus Huewe 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 678c79224c270aeb28dbcd6fdfd3fc83f7aeeed4 https://github.com/openSUSE/osc/commit/678c79224c270aeb28dbcd6fdfd3fc83f7ae… Author: Marco Strigl <mstrigl(a)suse.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M osc/commandline.py M osc/core.py Log Message: ----------- added --blame switch to osc meta command Commit: bbd5a922262f9b745551e215fee7b1f77ed5639d https://github.com/openSUSE/osc/commit/bbd5a922262f9b745551e215fee7b1f77ed5… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M osc/commandline.py M osc/core.py Log Message: ----------- Merge branch 'osc_meta_blame' of https://github.com/lethliel/osc Add --blame option to the "meta" command (it only works for the "prj", "pkg", and "prjconf" kinds). Note: the functions show_project_meta and show_package_meta can return xml and non-xml (depending on the value of the "blame" parameter). Compare: https://github.com/openSUSE/osc/compare/30b5af2d86e4...bbd5a922262f

1 0

[obs-commits] [openSUSE/open-build-service] fc72c4: [webui] Create package branch partial
by Henne Vogelsang 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: fc72c4c089f121c0faac93680fcaca3011f07408 https://github.com/openSUSE/open-build-service/commit/fc72c4c089f121c0faac9… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: A src/api/app/views/shared/_package_branch_form.html.erb Log Message: ----------- [webui] Create package branch partial Commit: 05d49dccc140fd557fe5e6605e35bf33e3f61356 https://github.com/openSUSE/open-build-service/commit/05d49dccc140fd557fe5e… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/api/app/assets/stylesheets/webui/application/dialog.scss Log Message: ----------- [webui] Modify the dialog.scss file for correctly displaying input boxes If this would not be added the input box would have a length of 90%. This would display the input field wrongly, like this: https://cloud.githubusercontent.com/assets/8287131/23656314/82c34040-0339-1… This happens because the dialog does no longer gets loaded in the #dialog_wrapper div. The old didn't get used during this implementation, because dialogs, that gets loaded via Ajax, gets removed from the DOM afterwards. If we would still use this, the dialog would get removed from the DOM afterwards (that we don't want) Commit: b4c1e14b9af3e4d15f6bd85a44a028282c3eb6e5 https://github.com/openSUSE/open-build-service/commit/b4c1e14b9af3e4d15f6bd… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/api/app/views/webui/package/_branch_dialog.html.erb M src/api/app/views/webui/project/new_package_branch.html.erb Log Message: ----------- [webui] Make use of the new branching dialog partial Commit: 591574d22562b81e8784c1c993207b3ac70791f7 https://github.com/openSUSE/open-build-service/commit/591574d22562b81e8784c… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- [ci] Fix test cases for new branching dialog The title of the input text got renamed, so we need to match for the new one. Commit: d28647b41c33ea7da88015e120fe40cfae99ffb8 https://github.com/openSUSE/open-build-service/commit/d28647b41c33ea7da8801… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/api/app/assets/javascripts/webui/application.js.erb M src/api/app/views/webui/package/_branch_dialog.html.erb Log Message: ----------- [webui] Implement show/hide mechanism for branch package dialog Commit: 4857bd66a0bff95bda5dd6928ab8fc76c678de3e https://github.com/openSUSE/open-build-service/commit/4857bd66a0bff95bda5dd… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/api/app/assets/javascripts/webui/application.js.erb M src/api/app/assets/stylesheets/webui/application/dialog.scss A src/api/app/views/shared/_package_branch_form.html.erb M src/api/app/views/webui/package/_branch_dialog.html.erb M src/api/app/views/webui/project/new_package_branch.html.erb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Merge pull request #2720 from mschnitzer/improve_branching [webui] Allow user to specify package name while branching Compare: https://github.com/openSUSE/open-build-service/compare/15c1d8581161...4857b…

1 0