March 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] e6b36e: [api] Remove duplicate routes
by Björn Geuken 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e6b36e901c01e3c738aa79830ab6963ef91a2919 https://github.com/openSUSE/open-build-service/commit/e6b36e901c01e3c738aa7… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/config/routes.rb Log Message: ----------- [api] Remove duplicate routes Commit: 012a3f7ac77fae96def9046198107a040eeca5f3 https://github.com/openSUSE/open-build-service/commit/012a3f7ac77fae96def90… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/config/routes.rb Log Message: ----------- Merge pull request #2912 from marcus-h/duplicate_routes [api] Remove duplicate routes Compare: https://github.com/openSUSE/open-build-service/compare/4e493b1f61e0...012a3…

1 0

[obs-commits] [openSUSE/open-build-service] 106c8a: [api] Refactor Project#check_access?
by Henne Vogelsang 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 106c8a4864ab084d8c859b375291cfa0346e5966 https://github.com/openSUSE/open-build-service/commit/106c8a4864ab084d8c859… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [api] Refactor Project#check_access? Remove condition that always evaluate to true since grouprels is always an array. Commit: 135ed0be47062a598ebe84b8758db1e053fccd34 https://github.com/openSUSE/open-build-service/commit/135ed0be47062a598ebe8… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- [api] Remove default parameter value from check_access? It didn't make sense to set the default to self, since check_access? is a class method. Commit: 8889f8aa1bb365f6259daae0557412a7c0808f4d https://github.com/openSUSE/open-build-service/commit/8889f8aa1bb365f6259da… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [api] Fix using nonexistent variable: group -> grouprel Commit: 804f0dc88912da7c591edc428b2b40cc12adbb04 https://github.com/openSUSE/open-build-service/commit/804f0dc88912da7c591ed… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [api] Refactor querying groups in Project#check_access? * Drop temporary variable and array conversion * Include groups directly when querying group relationships. When passing a group id to is_in_group?, the method is fetching the group from DB. We can avoid this by passing the object directly. Commit: ec646ab9e015e493e822d5b8b27b37982467632f https://github.com/openSUSE/open-build-service/commit/ec646ab9e015e493e822d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [api] Drop conditional check when iterating through group relations Since we iterate through group relations, we already know that each item has a group associated. No need to check this again. Commit: 321a949efbeb0378aec7da4e479bb77c08678cd2 https://github.com/openSUSE/open-build-service/commit/321a949efbeb0378aec7d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [api] Refactor check if User.current belongs to group Commit: 7d998fb5faf8c5291d5ba37e0d1925f8e33c016b https://github.com/openSUSE/open-build-service/commit/7d998fb5faf8c5291d5ba… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [api] Refactor UserLdapStrategy#user_in_group_ldap? Commit: efa3b95d2f7318c98e188cb70fe7e00bd0895160 https://github.com/openSUSE/open-build-service/commit/efa3b95d2f7318c98e188… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- [api] Update variable naming of check_access? methods Commit: 4e493b1f61e09a6adc4b7d3a2fe1cb840e8aaaff https://github.com/openSUSE/open-build-service/commit/4e493b1f61e09a6adc4b7… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Merge pull request #2911 from bgeuken/cleanup_check_access Cleanup check access Compare: https://github.com/openSUSE/open-build-service/compare/644281ffc756...4e493…

1 0

[obs-commits] [openSUSE/open-build-service] e6d02b: [api] consistency check: write_through -> commit_o...
by Henne Vogelsang 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e6d02b7f5111133d232d89a23fb37dc23f5579c3 https://github.com/openSUSE/open-build-service/commit/e6d02b7f5111133d232d8… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M src/api/app/jobs/consistency_check.rb Log Message: ----------- [api] consistency check: write_through -> commit_opts Commit: 644281ffc7565e92c0639ae87b2a1f3234c308d7 https://github.com/openSUSE/open-build-service/commit/644281ffc7565e92c0639… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/jobs/consistency_check.rb Log Message: ----------- Merge pull request #2901 from adrianschroeter/nice [api] consistency check: write_through -> commit_opts Compare: https://github.com/openSUSE/open-build-service/compare/363a2859d288...64428…

1 0

[obs-commits] [openSUSE/obs-build] 1a6c3d: KVM: don't run into endless loop when qemu is alre...
by GitHub 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 1a6c3d981cd324f3a7f0eafb2a77ca708c47f83a https://github.com/openSUSE/obs-build/commit/1a6c3d981cd324f3a7f0eafb2a77ca… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M build-vm-kvm Log Message: ----------- KVM: don't run into endless loop when qemu is already dead

1 0

[obs-commits] [openSUSE/open-build-service] fcae8f: [dist] drop dependency to ruby for obs-utils
by Adrian Schröter 28 Mar '17

28 Mar '17

Branch: refs/heads/2.8 Home: https://github.com/openSUSE/open-build-service Commit: fcae8f674a4130209646d1e5582cf2441b8dc597 https://github.com/openSUSE/open-build-service/commit/fcae8f674a4130209646d… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] drop dependency to ruby for obs-utils it is a bash script. obs_project_update should get dropped entirely actually, but lets wait for project remote copy

1 0

[obs-commits] [openSUSE/open-build-service] 363a28: [dist] drop dependency to ruby for obs-utils
by Adrian Schröter 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 363a2859d28829d2e157da1068729841733840b9 https://github.com/openSUSE/open-build-service/commit/363a2859d28829d2e157d… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] drop dependency to ruby for obs-utils it is a bash script. obs_project_update should get dropped entirely actually, but lets wait for project remote copy

1 0

[obs-commits] [openSUSE/open-build-service] 5f2756: [ci] Enable Rubocop for Vagrantfile
by Björn Geuken 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5f275680e75184d435a4d5f4009491a14197b6e0 https://github.com/openSUSE/open-build-service/commit/5f275680e75184d435a4d… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M .rubocop.yml M Vagrantfile Log Message: ----------- [ci] Enable Rubocop for Vagrantfile Commit: 45cbbfaf36275900335e9b0d76573de3c200cdd3 https://github.com/openSUSE/open-build-service/commit/45cbbfaf36275900335e9… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M .rubocop.yml M docs/dev/controller_template_example.rb M docs/dev/model_template_example.rb Log Message: ----------- [ci] Enable Rubocop for 'docs/dev/*' files Enable Rubocop for `docs/dev/*` files and fix Rubocop complains. `docs/api/restility/*` files are left as exclude. These files must be fixed by Rubocop upstream. Pair programmed with @dkang. Commit: 85bb5a327913b45342197613c9ef9c278b58ee29 https://github.com/openSUSE/open-build-service/commit/85bb5a327913b45342197… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M docs/dev/model_template_example.rb Log Message: ----------- [ci] ++ doesn't exist in Ruby Commit: 3bfa5166c28a4c338bf477636d5897021f8832c3 https://github.com/openSUSE/open-build-service/commit/3bfa5166c28a4c338bf47… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M .rubocop.yml M .rubocop_todo.yml M src/api/app/models/attrib.rb M src/api/app/models/role.rb M src/api/test/test_helper.rb Log Message: ----------- [ci] Enable Style/Alias Rubocop Enable Style/Alias with 'prefer_alias_method'. Commit: 0cdadb16d23c63a182bbb6ba05895a07705e6910 https://github.com/openSUSE/open-build-service/commit/0cdadb16d23c63a182bbb… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M .rubocop.yml M .rubocop_todo.yml M Vagrantfile M docs/dev/controller_template_example.rb M docs/dev/model_template_example.rb M src/api/app/models/attrib.rb M src/api/app/models/role.rb M src/api/test/test_helper.rb Log Message: ----------- Merge pull request #2891 from eduardoj/rubocop_docs_and_vagrantfile Enable Rubocop for Vagrantfile and docs/ Compare: https://github.com/openSUSE/open-build-service/compare/21c1bf0266da...0cdad…

1 0

[obs-commits] [openSUSE/open-build-service] 2a9c18: [ci] Cover missed lines from main controller in sp...
by Björn Geuken 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2a9c18d79ce0e17c9dbba88faf74c28a37854f04 https://github.com/openSUSE/open-build-service/commit/2a9c18d79ce0e17c9dbba… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/spec/controllers/webui/main_controller_spec.rb Log Message: ----------- [ci] Cover missed lines from main controller in spec Commit: 300002d2afec23b79ffafc21ff7892bdf89ed678 https://github.com/openSUSE/open-build-service/commit/300002d2afec23b79ffaf… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/spec/controllers/webui/main_controller_spec.rb Log Message: ----------- [ci] Test uncovered line in main controller#add_news spec Commit: 90faeb822a1c54e31a100bae1cef021b508d067c https://github.com/openSUSE/open-build-service/commit/90faeb822a1c54e31a100… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/spec/controllers/webui/main_controller_spec.rb Log Message: ----------- [ci] Test main_controller#add_news_dialog in Rspec Commit: bb129164a458f8df56dde79201b5f919643c39d1 https://github.com/openSUSE/open-build-service/commit/bb129164a458f8df56dde… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/spec/controllers/webui/main_controller_spec.rb Log Message: ----------- [ci] Test main_controller#delete_message_dialog in Rspec Commit: 21c1bf0266da88abd793d44d4c9a8d02b76630ed https://github.com/openSUSE/open-build-service/commit/21c1bf0266da88abd793d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/spec/controllers/webui/main_controller_spec.rb Log Message: ----------- Merge pull request #2909 from mdeniz/main_controller_specs Main controller specs covering missed lines in RSpec Compare: https://github.com/openSUSE/open-build-service/compare/fdd0d21760dc...21c1b…

1 0

[obs-commits] [openSUSE/open-build-service] e4cafc: [ci][webui] Refactor and add specs for even_mailer...
by Eduardo J 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e4cafccbf3739cd1175504aa911f1a4e8f05b4d3 https://github.com/openSUSE/open-build-service/commit/e4cafccbf3739cd117550… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/helpers/event_mailer_helper.rb A src/api/spec/helpers/event_mailer_helper_spec.rb Log Message: ----------- [ci][webui] Refactor and add specs for even_mailer_helper Commit: fdd0d21760dc99b0c831494a3ae8c30ff60e23b1 https://github.com/openSUSE/open-build-service/commit/fdd0d21760dc99b0c8314… Author: Eduardo J <eduardoj(a)users.noreply.github.com> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/helpers/event_mailer_helper.rb A src/api/spec/helpers/event_mailer_helper_spec.rb Log Message: ----------- Merge pull request #2910 from mdeniz/event_mailer_helper_spec Refactor and add specs for event_mailer_helper Compare: https://github.com/openSUSE/open-build-service/compare/f840d5f8ea7f...fdd0d…

1 0

[obs-commits] [openSUSE/open-build-service] 0b57ed: [webui] Break set_file_details recursion
by Henne Vogelsang 28 Mar '17

28 Mar '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0b57edde6e8e945d606e9d55f6ecb2d9ba408068 https://github.com/openSUSE/open-build-service/commit/0b57edde6e8e945d606e9… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-03-20 (Mon, 20 Mar 2017) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [webui] Break set_file_details recursion if service is in progress after one retry. Before it was possible that it ends in an infinite recursion. Now set_file_details gets only called again when @expand = 1, otherwise it will continue. Commit: cae78792c6378ace2c8aa89571429f53f3d551e9 https://github.com/openSUSE/open-build-service/commit/cae78792c6378ace2c8aa… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-03-20 (Mon, 20 Mar 2017) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [webui] Show service in progress in flash and propose reloading the page (#2598). Commit: f840d5f8ea7fe853f0e2e6c623439004aba1f370 https://github.com/openSUSE/open-build-service/commit/f840d5f8ea7fe853f0e2e… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-03-28 (Tue, 28 Mar 2017) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Merge pull request #2867 from ChrisBr/service_running Catch service running exception Compare: https://github.com/openSUSE/open-build-service/compare/055ff042d0ae...f840d…

1 0