September 2015 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 8e7c8c: Fix save_meta action for project
by Henne Vogelsang 03 Sep '15

03 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8e7c8c99b3801f5380972a685608a0594d3f0226 https://github.com/openSUSE/open-build-service/commit/8e7c8c99b3801f5380972… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/project_controller.rb Log Message: ----------- Fix save_meta action for project Adds save_meta to the set_project before filter, otherwise the pundit authentication fails and the meta can't be saved. Commit: c25ae246003e26753517f048d9b9641ef0a01266 https://github.com/openSUSE/open-build-service/commit/c25ae246003e26753517f… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/project_controller.rb Log Message: ----------- Merge pull request #1095 from ChrisBr/fix_save_meta Fix save_meta action for project Compare: https://github.com/openSUSE/open-build-service/compare/5b7eb11de81a...c25ae…

1 0

[obs-commits] [openSUSE/open-build-service] b1405a: [webui] Get rid of require_project before_filter c...
by Björn Geuken 03 Sep '15

03 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b1405a9749c091e05933f9bde83cc7712d433a27 https://github.com/openSUSE/open-build-service/commit/b1405a9749c091e05933f… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/path_element.rb M src/api/app/views/webui/project/_edit_repository.html.erb M src/api/config/routes.rb A src/api/db/migrate/20150902130939_remove_index_from_path_element_position.rb M src/api/db/structure.sql M src/api/test/functional/webui/project_controller_test.rb Log Message: ----------- [webui] Get rid of require_project before_filter completely No more WebuiProject in the project controller! Hurray Commit: 047717c000dd76632e600a7bb95126772b94c01d https://github.com/openSUSE/open-build-service/commit/047717c000dd76632e600… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [webui] Switch require_project before_filter in Webui::PackageController from except to only Commit: 130aa788cb368c03ef637ee78175bab3d7fa187c https://github.com/openSUSE/open-build-service/commit/130aa788cb368c03ef637… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [webui] Switch require_package before_filter in Webui::PackageController from except to only Commit: 9188f2d7e0334a6a8e461d8c87424359ca3afecd https://github.com/openSUSE/open-build-service/commit/9188f2d7e0334a6a8e461… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [webui] Get rid of require_project in Webui::PackageController No more WebuiProject! Hurray Commit: 68f24e656467db3af59ba0ffb28f0ac6d0e16a28 https://github.com/openSUSE/open-build-service/commit/68f24e656467db3af59ba… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/search_controller.rb M src/api/test/functional/webui/search_controller_test.rb Log Message: ----------- [webui] Save disturl handling in the search_controller Commit: eaa7d8887082d0f673e99f4b3f6dc503ed6509fc https://github.com/openSUSE/open-build-service/commit/eaa7d8887082d0f673e99… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/views/webui/package/_buildstatus.html.erb M src/api/app/views/webui/package/_no_repositories.html.erb M src/api/app/views/webui/package/edit.html.erb M src/api/test/functional/webui/package_controller_test.rb Log Message: ----------- [webui] Also load @package for save_comment, use Project's everywhere Commit: bf8c174583b2f55324f7510981d1f2e32d9020fb https://github.com/openSUSE/open-build-service/commit/bf8c174583b2f55324f75… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/driver_update_controller.rb Log Message: ----------- [webui] Remove WebuiProject from DriverUpdateController Commit: 29f1adbb5f3d80b916735b0ddeb60539d5f190df https://github.com/openSUSE/open-build-service/commit/29f1adbb5f3d80b916735… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb Log Message: ----------- [webui] Remove WebuiProject from PatchinfoController Commit: de648f7251799f2680ee5793564fbcd114a5067f https://github.com/openSUSE/open-build-service/commit/de648f7251799f2680ee5… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Remove WebuiProject from RequestController Commit: 1ae33657d667b48c9462b41ac9da0cc85afc41ca https://github.com/openSUSE/open-build-service/commit/1ae33657d667b48c9462b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb R src/api/app/mixins/webui/requires_project.rb R src/api/app/models/webui_project.rb Log Message: ----------- [webui] Get rid of WebuiProject completely. What a trip... Commit: 5b7eb11de81a787aa0bd6460e53ee54839c26a49 https://github.com/openSUSE/open-build-service/commit/5b7eb11de81a787aa0bd6… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/controllers/webui/driver_update_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/search_controller.rb R src/api/app/mixins/webui/requires_project.rb M src/api/app/models/path_element.rb R src/api/app/models/webui_project.rb M src/api/app/views/webui/package/_buildstatus.html.erb M src/api/app/views/webui/package/_no_repositories.html.erb M src/api/app/views/webui/package/edit.html.erb M src/api/app/views/webui/project/_edit_repository.html.erb M src/api/config/routes.rb A src/api/db/migrate/20150902130939_remove_index_from_path_element_position.rb M src/api/db/structure.sql M src/api/test/functional/webui/package_controller_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/search_controller_test.rb Log Message: ----------- Merge pull request #1091 from hennevogel/refactoring_kill_webuiproject Killall WebuiProject! Compare: https://github.com/openSUSE/open-build-service/compare/0af6b5fe72ea...5b7eb…

1 0

[obs-commits] [openSUSE/obs-build] 85766d: - switch to liblua5_3 for openSUSE 13.3
by GitHub 03 Sep '15

03 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 85766d52174f2994556395ddd077c9753989183d https://github.com/openSUSE/obs-build/commit/85766d52174f2994556395ddd077c9… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M configs/sl13.3.conf Log Message: ----------- - switch to liblua5_3 for openSUSE 13.3

1 0

[obs-commits] [openSUSE/open-build-service] 8b4d42: [webui][api] Get rid of WebuiProject in webui/proj...
by Henne Vogelsang 03 Sep '15

03 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8b4d426e63a02440ca76359f6a163ae17cdd6ca3 https://github.com/openSUSE/open-build-service/commit/8b4d426e63a02440ca763… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-02 (Wed, 02 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/models/architecture.rb M src/api/app/models/history_element.rb R src/api/app/models/history_element/all.rb R src/api/app/models/history_element/base.rb R src/api/app/models/history_element/request.rb R src/api/app/models/history_element/review.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/policies/project_policy.rb M src/api/app/views/shared/_involved_users.html.erb M src/api/app/views/shared/_repositories_flag_table.html.erb M src/api/app/views/webui/project/_add_maintained_project_dialog.html.erb M src/api/app/views/webui/project/_buildstatus.html.erb M src/api/app/views/webui/project/_delete_dialog.html.erb M src/api/app/views/webui/project/_edit_comment_form.html.erb M src/api/app/views/webui/project/_edit_repository.html.erb M src/api/app/views/webui/project/_form.html.erb M src/api/app/views/webui/project/_packages_table.html.erb M src/api/app/views/webui/project/_release_request_dialog.html.erb M src/api/app/views/webui/project/_remove_target_request_dialog.html.erb M src/api/app/views/webui/project/_tabs.html.erb M src/api/app/views/webui/project/add_repository.html.erb M src/api/app/views/webui/project/add_repository_from_default_list.html.erb M src/api/app/views/webui/project/edit.html.erb M src/api/app/views/webui/project/edit_comment_form.js.erb M src/api/app/views/webui/project/maintained_projects.html.erb M src/api/app/views/webui/project/meta.html.erb M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/package_buildresult.html.erb M src/api/app/views/webui/project/prjconf.html.erb M src/api/app/views/webui/project/repositories.html.erb M src/api/app/views/webui/project/requests.html.erb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/project/status.html.erb M src/api/app/views/webui/project/subprojects.html.haml M src/api/config/routes.rb M src/api/test/fixtures/history_elements.yml M src/api/test/functional/request_controller_test.rb M src/api/test/functional/webui/add_repo_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/project_edit_test.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- [webui][api] Get rid of WebuiProject in webui/project_controller.rb * Make some of the rubocop metric rules not fail * revoke requests when projects get deleted * Introduce set_project before_filter and use it * Limit :require_project before filter (and hence WebuiProject) to move_path_* The path_elements list of repositories needs a little more thought. acts_as_list would be an option but that means removing the uniqe key in the db for partent_id and position * Move all the support methods down in the file * Move some of the methods into the project model * authorize all calls that change the project * Rename CRUD the methods * Use strong parameters * Concat all the stupid history_element files into one for lazy loading * Also fix the history_elements fixtures, rake db:fixtures:load works again now... Commit: 0af6b5fe72eac0782bf6b84dacea0d04d4f1c2ec https://github.com/openSUSE/open-build-service/commit/0af6b5fe72eac0782bf6b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/models/architecture.rb M src/api/app/models/history_element.rb R src/api/app/models/history_element/all.rb R src/api/app/models/history_element/base.rb R src/api/app/models/history_element/request.rb R src/api/app/models/history_element/review.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/policies/project_policy.rb M src/api/app/views/shared/_involved_users.html.erb M src/api/app/views/shared/_repositories_flag_table.html.erb M src/api/app/views/webui/project/_add_maintained_project_dialog.html.erb M src/api/app/views/webui/project/_buildstatus.html.erb M src/api/app/views/webui/project/_delete_dialog.html.erb M src/api/app/views/webui/project/_edit_comment_form.html.erb M src/api/app/views/webui/project/_edit_repository.html.erb M src/api/app/views/webui/project/_form.html.erb M src/api/app/views/webui/project/_packages_table.html.erb M src/api/app/views/webui/project/_release_request_dialog.html.erb M src/api/app/views/webui/project/_remove_target_request_dialog.html.erb M src/api/app/views/webui/project/_tabs.html.erb M src/api/app/views/webui/project/add_repository.html.erb M src/api/app/views/webui/project/add_repository_from_default_list.html.erb M src/api/app/views/webui/project/edit.html.erb M src/api/app/views/webui/project/edit_comment_form.js.erb M src/api/app/views/webui/project/maintained_projects.html.erb M src/api/app/views/webui/project/meta.html.erb M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/package_buildresult.html.erb M src/api/app/views/webui/project/prjconf.html.erb M src/api/app/views/webui/project/repositories.html.erb M src/api/app/views/webui/project/requests.html.erb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/project/status.html.erb M src/api/app/views/webui/project/subprojects.html.haml M src/api/config/routes.rb M src/api/test/fixtures/history_elements.yml M src/api/test/functional/request_controller_test.rb M src/api/test/functional/webui/add_repo_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/project_edit_test.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- Merge pull request #1085 from hennevogel/refactoring_project_controller [webui][api] Get rid of WebuiProject in webui/project_controller.rb Compare: https://github.com/openSUSE/open-build-service/compare/855d64807dc3...0af6b…

1 0

[obs-commits] [openSUSE/open-build-service] 855d64: [api] find broken channel setup on creation of rel...
by Adrian Schröter 03 Sep '15

03 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 855d64807dc3fb4e783a9d0bb4c3b2c26d2c20fc https://github.com/openSUSE/open-build-service/commit/855d64807dc3fb4e783a9… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/channel_target.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- [api] find broken channel setup on creation of release request

1 0

[obs-commits] [openSUSE/open-build-service] d27f67: [webui] Update OBS redirect after login
by Henne Vogelsang 02 Sep '15

02 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d27f674b3e5da6898928a203c9a691527044b40b https://github.com/openSUSE/open-build-service/commit/d27f674b3e5da6898928a… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/views/layouts/webui/_personal_navigation.html.erb M src/api/app/views/webui/user/login.html.erb M src/api/test/functional/webui/patchinfo_create_test.rb M src/api/test/functional/webui/signup_test.rb M src/api/test/functional/webui/user_controller_test.rb M src/api/test/test_helper.rb Log Message: ----------- [webui] Update OBS redirect after login After login OBS users get redirected to the page they initially visited. So far this was done via hidden fields in the views and parameters that were processed in the controller. An attacker could use those parameters to redirect to an untrusted side. This commit stores the last visited page in the session store to avoid that kind of attack. Commit: d2aacc4470116d55974f4be28a1a41c8a874a4d9 https://github.com/openSUSE/open-build-service/commit/d2aacc4470116d55974f4… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-02 (Wed, 02 Sep 2015) Changed paths: M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/views/layouts/webui/_personal_navigation.html.erb M src/api/app/views/webui/user/login.html.erb M src/api/test/functional/webui/patchinfo_create_test.rb M src/api/test/functional/webui/signup_test.rb M src/api/test/functional/webui/user_controller_test.rb M src/api/test/test_helper.rb Log Message: ----------- Merge pull request #1078 from bgeuken/hakiri_redirect_issue [webui] Update OBS redirect after login Compare: https://github.com/openSUSE/open-build-service/compare/e2ed2c45c575...d2aac…

1 0

[obs-commits] [openSUSE/obs-build] a3ce06: add openSUSE 13.3 config
by GitHub 02 Sep '15

02 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: a3ce06d2c0207fb2128f8e19f80adae3d8e6b8ea https://github.com/openSUSE/obs-build/commit/a3ce06d2c0207fb2128f8e19f80ada… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-09-02 (Wed, 02 Sep 2015) Changed paths: A configs/sl13.3.conf Log Message: ----------- add openSUSE 13.3 config

1 0

[obs-commits] [openSUSE/open-build-service] e2ed2c: [backend] strip support_ prefix to cope with broke...
by Michael Schroeder 02 Sep '15

02 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e2ed2c45c575636bb7b036fd52e7e59007e4a824 https://github.com/openSUSE/open-build-service/commit/e2ed2c45c575636bb7b03… Author: Michael Schroeder <mls(a)suse.de> Date: 2015-09-02 (Wed, 02 Sep 2015) Changed paths: M src/backend/bs_publish Log Message: ----------- [backend] strip support_ prefix to cope with broken code11 imports

1 0

[obs-commits] [openSUSE/open-build-service] 185a38: [backend] always send supportstatus in packtrack e...
by Michael Schroeder 02 Sep '15

02 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 185a3808084706ed715ed9897f64fe9e921a16d8 https://github.com/openSUSE/open-build-service/commit/185a3808084706ed715ed… Author: Michael Schroeder <mls(a)suse.de> Date: 2015-09-02 (Wed, 02 Sep 2015) Changed paths: M src/backend/bs_publish Log Message: ----------- [backend] always send supportstatus in packtrack even if there is no patchinforef

1 0

[obs-commits] [openSUSE/open-build-service] ec4a04: [api] More rubocop offenses in BsRequest*
by Henne Vogelsang 02 Sep '15

02 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ec4a04c3931df311408b38854773b381f02f7a1c https://github.com/openSUSE/open-build-service/commit/ec4a04c3931df311408b3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-02 (Wed, 02 Sep 2015) Changed paths: M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_maintenance_release.rb Log Message: ----------- [api] More rubocop offenses in BsRequest*

1 0