September 2015 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] a825d7: [webui] Fix hakiri report: File Access
by Björn Geuken 01 Sep '15

01 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a825d7a0e8b6a826ad8667605ba02091f94d8e74 https://github.com/openSUSE/open-build-service/commit/a825d7a0e8b6a826ad866… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-08-28 (Fri, 28 Aug 2015) Changed paths: M src/api/app/controllers/webui/apidocs_controller.rb Log Message: ----------- [webui] Fix hakiri report: File Access Ensure that users can't fetch files from other directories (by adding '../' to the filepath). Commit: a43b39885bade797b1abea1c97fbe016a86e1d87 https://github.com/openSUSE/open-build-service/commit/a43b39885bade797b1abe… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-08-28 (Fri, 28 Aug 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [webui] Fix hakiri reports: File access Commit: b19737c44c0e111f12aff104b39da7615e858f9b https://github.com/openSUSE/open-build-service/commit/b19737c44c0e111f12aff… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Merge pull request #1070 from bgeuken/hakiri_file_access Hakiri file access Compare: https://github.com/openSUSE/open-build-service/compare/7b10b1c15c08...b1973…

1 0

[obs-commits] [openSUSE/open-build-service] 5444ed: [ci] Fix Style/AlignHash rubocop offences
by Henne Vogelsang 01 Sep '15

01 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5444edab4f85ab78c05044fd34d0e280b5719f9f https://github.com/openSUSE/open-build-service/commit/5444edab4f85ab78c0504… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- [ci] Fix Style/AlignHash rubocop offences Commit: bcec9349ed34dcfb66e5776ff1b002f891b1302a https://github.com/openSUSE/open-build-service/commit/bcec9349ed34dcfb66e57… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/relationship.rb Log Message: ----------- [ci] Fix RailsCop rubocop offences Commit: 9d85ce744f13fd4d52824e29e1fe2b04a469c1a3 https://github.com/openSUSE/open-build-service/commit/9d85ce744f13fd4d52824… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/test/test_helper.rb Log Message: ----------- [ci] Fix LineLength rubocop offences Commit: fa5b610fa4f72f777766d32cc3f20f0b29a4415e https://github.com/openSUSE/open-build-service/commit/fa5b610fa4f72f777766d… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/test/functional/maintenance_test.rb M src/api/test/unit/binary_release.rb Log Message: ----------- [ci] Fix AlignParameters rubocop offences Commit: fdd4bcbcfc846146927f5044dbe1455d655b8956 https://github.com/openSUSE/open-build-service/commit/fdd4bcbcfc846146927f5… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/helpers/branch_package.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/full_text_search.rb Log Message: ----------- [ci] Fix EmptyElse rubocop offences Commit: 7b10b1c15c08a859ae29390014a8ea806e2e481a https://github.com/openSUSE/open-build-service/commit/7b10b1c15c08a859ae293… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/helpers/branch_package.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/full_text_search.rb M src/api/app/models/relationship.rb M src/api/test/functional/maintenance_test.rb M src/api/test/test_helper.rb M src/api/test/unit/binary_release.rb Log Message: ----------- Merge pull request #1073 from ChrisBr/rubocop Rubocop Compare: https://github.com/openSUSE/open-build-service/compare/b059dadcee1f...7b10b…

1 0

[obs-commits] [openSUSE/open-build-service]
by ChrisBr 01 Sep '15

01 Sep '15

Branch: refs/heads/rubocop Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] fc370e: [webui] Fix indentation
by chrisbr 01 Sep '15

01 Sep '15

Branch: refs/heads/rubocop Home: https://github.com/openSUSE/open-build-service Commit: fc370e4d7db417c66dea232478ea1238d9870933 https://github.com/openSUSE/open-build-service/commit/fc370e4d7db417c66dea2… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Fix indentation Commit: 42e9fb1ff14bb8f5090392bdfb82ad82e4533de3 https://github.com/openSUSE/open-build-service/commit/42e9fb1ff14bb8f509039… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Fix indentation Commit: 685dabd51785a70c6d64c948f01542cf7af3ea9b https://github.com/openSUSE/open-build-service/commit/685dabd51785a70c6d64c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Refactor open_requests_for method This method is only used by ProjectCreateAutoCleanupRequests. It's not used for any object of Package class. Thus we can remove the code that handles packages. Commit: 5606c368fd9d54fc07f5ff1a9a25dae5205a5151 https://github.com/openSUSE/open-build-service/commit/5606c368fd9d54fc07f5f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Replace helper methods and simplify query Since the query is only used once we can run it directly where it's needed. Additional changes: - Removed ordering by ids. We only use the count there anyway. - Count open requests as part of the SQL query. Faster;-) - Combine both queries Commit: ca016c5b554f9cc9a90b2ae21a50afd20d667d83 https://github.com/openSUSE/open-build-service/commit/ca016c5b554f9cc9a90b2… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Remove superfluous reference The scope is running in the BsRequest class therefore doesn't need to reference bs_requests. Commit: 20923d9c4b3c6faabcf4bc6fbc5f1f174e0b1980 https://github.com/openSUSE/open-build-service/commit/20923d9c4b3c6faabcf4b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [webui] Update scope of bs request model Commit: 5720a5fc911d542729f508dbc8988436912ce09a https://github.com/openSUSE/open-build-service/commit/5720a5fc911d542729f50… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M docs/dev/controller_template_example.rb M docs/dev/model_template_example.rb M src/api/app/models/architecture.rb M src/api/lib/templates/active_record/model/model.rb M src/api/lib/templates/rails/scaffold_controller/controller.rb Log Message: ----------- [webui] Use the templates in the model. Few changes to the templates itself Commit: 2e8e8a4196b09abd69159ce26287fc29d526a19c https://github.com/openSUSE/open-build-service/commit/2e8e8a4196b09abd69159… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib.rb M src/api/lib/templates/active_record/model/model.rb Log Message: ----------- [webui] Refactored Attrib model. Added "alias" section to model template Commit: a0042c7355c7df39f5019186589e259f509b6e2a https://github.com/openSUSE/open-build-service/commit/a0042c7355c7df39f5019… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/architecture.rb M src/api/app/models/attrib.rb A src/api/app/validators/attrib_allowed_values_validator.rb A src/api/app/validators/attrib_issue_validator.rb A src/api/app/validators/attrib_value_length_validator.rb Log Message: ----------- [webui] Moving validators of Attrib to a file for themselves. Commit: e37de5267a0e69cffcc284546c212ae10004c650 https://github.com/openSUSE/open-build-service/commit/e37de5267a0e69cffcc28… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib_value.rb Log Message: ----------- [webui] Refactored AttribValue model Commit: e6509c11bbb4f7b18bb17f785cf9983aa0127d1c https://github.com/openSUSE/open-build-service/commit/e6509c11bbb4f7b18bb17… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib_namespace.rb Log Message: ----------- [webui] Refactored AttribNamespace Commit: b7d9cbf29a680874d54e30f0f071fa037484fb6c https://github.com/openSUSE/open-build-service/commit/b7d9cbf29a680874d54e3… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib_type.rb Log Message: ----------- [webui] Refactored AttribType model Commit: 00e75e649e051da809a0257c585282d909a620a7 https://github.com/openSUSE/open-build-service/commit/00e75e649e051da809a02… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/backend_info.rb M src/api/app/models/backend_package.rb Log Message: ----------- [webui] Refactor backend models Commit: 6fcc7eebea0d7ccb8a0ea691773f37d06ed241d0 https://github.com/openSUSE/open-build-service/commit/6fcc7eebea0d7ccb8a0ea… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/binary_release.rb M src/api/test/unit/binary_release.rb Log Message: ----------- [webui] Refactor Binary Releases model and fix tests for it Commit: f6af1113ae783d70e6728511f713e689ff28c3f1 https://github.com/openSUSE/open-build-service/commit/f6af1113ae783d70e6728… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib.rb M src/api/app/models/attrib_issue.rb M src/api/test/functional/attributes_test.rb Log Message: ----------- [webui] Minor changes in Attrib and fix test for it Commit: 8dc492cba12147004405eee85a99e4e289955989 https://github.com/openSUSE/open-build-service/commit/8dc492cba12147004405e… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/attrib.rb Log Message: ----------- [webui] Use will_save instead of save local variable Commit: 248d64f8266b801e134df174c1fa8f085fba05b0 https://github.com/openSUSE/open-build-service/commit/248d64f8266b801e134df… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- [ci] Fix Style/AlignHash rubocop offences Commit: 2b323d4079ea316e280d8869ee8dcdcc261d56e5 https://github.com/openSUSE/open-build-service/commit/2b323d4079ea316e280d8… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/relationship.rb Log Message: ----------- [ci] Fix RailsCop rubocop offences Commit: ba26e90f22535327208c2e5af8a192da48c32ecd https://github.com/openSUSE/open-build-service/commit/ba26e90f22535327208c2… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/test/test_helper.rb Log Message: ----------- [ci] Fix LineLength rubocop offences Commit: 032be2f7a8c9154f81046a0a7c81258fdac926ea https://github.com/openSUSE/open-build-service/commit/032be2f7a8c9154f81046… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/test/functional/maintenance_test.rb M src/api/test/unit/binary_release.rb Log Message: ----------- [ci] Fix AlignParameters rubocop offences Commit: 2d4c2c27b396d1a53cac9c410cacb12f5b58f1cd https://github.com/openSUSE/open-build-service/commit/2d4c2c27b396d1a53cac9… Author: chrisbr <cbruckmayer(a)suse.com> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/helpers/branch_package.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/full_text_search.rb Log Message: ----------- [ci] Fix EmptyElse rubocop offences Compare: https://github.com/openSUSE/open-build-service/compare/fc370e4d7db4^...2d4c…

1 0

[obs-commits] [openSUSE/open-build-service] 1ed10d: [webui] Update readme: OBS 2.5 -> OBS 2.6
by Henne Vogelsang 01 Sep '15

01 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1ed10d3efc184dcb9d6b823501576e19ed7b42ed https://github.com/openSUSE/open-build-service/commit/1ed10d3efc184dcb9d6b8… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-08-31 (Mon, 31 Aug 2015) Changed paths: M README.md Log Message: ----------- [webui] Update readme: OBS 2.5 -> OBS 2.6 Commit: b059dadcee1fbad4946bf40be36092751cb6dbb7 https://github.com/openSUSE/open-build-service/commit/b059dadcee1fbad4946bf… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M README.md Log Message: ----------- Merge pull request #1072 from bgeuken/update_readme [webui] Update readme: OBS 2.5 -> OBS 2.6 Compare: https://github.com/openSUSE/open-build-service/compare/68d65780a467...b059d…

1 0

[obs-commits] [openSUSE/open-build-service] 603996: [webui] Convert if-else condition into case
by Henne Vogelsang 01 Sep '15

01 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6039967f93a2cc689e09edb313146e868bc1df81 https://github.com/openSUSE/open-build-service/commit/6039967f93a2cc689e09e… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- [webui] Convert if-else condition into case Commit: 68d65780a4673702350e114c2afbf99bfbab3f92 https://github.com/openSUSE/open-build-service/commit/68d65780a4673702350e1… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Merge pull request #1077 from bgeuken/cleanup_webui_controller [webui] Convert if-else condition into case Compare: https://github.com/openSUSE/open-build-service/compare/071c27653c5d...68d65…

1 0

[obs-commits] [openSUSE/open-build-service] 0e4b6f: [webui] Remove unused natcmp file
by Henne Vogelsang 01 Sep '15

01 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0e4b6fc36b5e37430c8415dc3eed8e2fba8007df https://github.com/openSUSE/open-build-service/commit/0e4b6fc36b5e37430c841… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: R src/api/lib/natcmp.rb Log Message: ----------- [webui] Remove unused natcmp file Commit: 071c27653c5d611f0902c96700dce0f3c56fbec7 https://github.com/openSUSE/open-build-service/commit/071c27653c5d611f0902c… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: R src/api/lib/natcmp.rb Log Message: ----------- Merge pull request #1079 from bgeuken/natcmp [webui] Remove unused natcmp file Compare: https://github.com/openSUSE/open-build-service/compare/8356f6374581...071c2…

1 0

[obs-commits] [openSUSE/open-build-service] aaad76: [ci] Set RuboCop::RakeTask fail level to 'conventi...
by Björn Geuken 01 Sep '15

01 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: aaad768396c36948c18e48dab6752b03073640cd https://github.com/openSUSE/open-build-service/commit/aaad768396c36948c18e4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/Rakefile Log Message: ----------- [ci] Set RuboCop::RakeTask fail level to 'convention' This causes rubocop to fail on any broken convention, which is what we need for integrating rubocop into our travis testsuite. https://github.com/bbatsov/rubocop#severity Commit: 8356f637458189085502960c95a7a124988b1fec https://github.com/openSUSE/open-build-service/commit/8356f6374581890855029… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/Rakefile Log Message: ----------- Merge pull request #1076 from bgeuken/fix_rubocop [ci] Set RuboCop::RakeTask fail level to 'convention' Compare: https://github.com/openSUSE/open-build-service/compare/a3bc6e7c080c...8356f…

1 0

[obs-commits] [openSUSE/open-build-service] a3bc6e: [api][backend] adapt CPE id according to standard ...
by Adrian Schröter 01 Sep '15

01 Sep '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a3bc6e7c080c010c1d2268ba35ad4aee2bc13650 https://github.com/openSUSE/open-build-service/commit/a3bc6e7c080c010c1d226… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-09-01 (Tue, 01 Sep 2015) Changed paths: M src/api/app/models/product.rb M src/api/test/functional/product_test.rb M src/backend/bs_productconvert Log Message: ----------- [api][backend] adapt CPE id according to standard (FATE#319360)

1 0