[Bug 980329] New: gettext tools do not support Ruby
http://bugzilla.suse.com/show_bug.cgi?id=980329 Bug ID: 980329 Summary: gettext tools do not support Ruby Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 Assignee: yast2-maintainers@suse.de Reporter: ke@suse.com QA Contact: jsrain@suse.com Blocks: 979781 Found By: --- Blocker: --- +++ This bug was initially created as a clone of Bug #979781 +++ The German translation of module yast2-journal contains an error: msgid "Between %{since} and %{until}" msgstr "Zwischen %{seit} und %{bis}" "since" and "until" should not be translated. See this code: ... =================================================================== We see this kind of bugs again and again. In the past, YCC was properly supported in gettext. We need this for Ruby as well. Please, take the time to report appropriate info to the gettext maintainers (or better, provide a patch). In the meantime, which tools can I use as a workaround? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c1 Josef Reidinger <jreidinger@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jreidinger@suse.com, | |lslezak@suse.com Flags| |needinfo?(lslezak@suse.com) --- Comment #1 from Josef Reidinger <jreidinger@suse.com> --- Lada - you work the most with translation, do you have idea? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c2 Martin Vidner <mvidner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mvidner@suse.com --- Comment #2 from Martin Vidner <mvidner@suse.com> --- msgfmt should be able to check this, at least in theory: http://linux.die.net/man/1/msgfmt --check-format check language dependent format strings It should check that the format strings are not changed(=broken by translation), just permuted. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c3 --- Comment #3 from Josef Reidinger <jreidinger@suse.com> --- (In reply to Martin Vidner from comment #2)
msgfmt should be able to check this, at least in theory:
http://linux.die.net/man/1/msgfmt --check-format check language dependent format strings
It should check that the format strings are not changed(=broken by translation), just permuted.
maybe this bug is about missing ruby support in msgfmt? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c4 --- Comment #4 from Martin Vidner <mvidner@suse.com> --- Yes, it seems format-ruby should be implemented in http://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-tools/src There is no upstream bug for that it seems: http://savannah.gnu.org/bugs/?group=gettext -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c5 Ladislav Slezák <lslezak@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lslezak@suse.com) | --- Comment #5 from Ladislav Slezák <lslezak@suse.com> --- With Ruby it's a bit more complicated, the GNU Gettext does not support Ruby at all. The translatable texts are collected by Ruby rgettext (https://github.com/ruby-gettext/gettext) and at runtime YaST uses fast_gettext gem (https://github.com/grosser/fast_gettext) for actual translation. That means beside adapting the GNU gettext to support the ruby-format, we would need to fix Ruby gettext to write this flag when creating the POT file... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c6 --- Comment #6 from Martin Vidner <mvidner@suse.com> --- See also https://bugzilla.suse.com/show_bug.cgi?id=954505 "yast ruby msg extractor (xgettext) does not support format marker" -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c7 --- Comment #7 from Karl Eichwalder <ke@suse.com> --- (In reply to Martin Vidner from comment #6)
See also https://bugzilla.suse.com/show_bug.cgi?id=954505 "yast ruby msg extractor (xgettext) does not support format marker"
Thanks for the reminder! I'd vote to report it upstream. I'd have reported it upstream, if I'd be familiar with Rudy. In the past, the gettext maintainers (Bruno) wanted to know the specifics about the format specifiers and then implemented it (ycp). I guess Ruby is rather complex, but why not trying? It's rather important to us ((open)SUSE). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 Ladislav Slezák <lslezak@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Assignee|yast2-maintainers@suse.de |yast-internal@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 Ladislav Slezák <lslezak@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|979781 | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1026156 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c9 Luiz Fernando Ranghetti <elchevive68@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elchevive68@gmail.com --- Comment #9 from Luiz Fernando Ranghetti <elchevive68@gmail.com> --- *** Bug 1026156 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1023608 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c10 Ladislav Slezák <lslezak@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #10 from Ladislav Slezák <lslezak@suse.com> --- I'm closing the bug as the original problem has been fixed (see comment #8). Implementing the Ruby support in GNU gettext is out of our scope for the YaST team. Moreover I guess the GNU and Ruby upstreams are probably not interested as there already is a separate pure Ruby gettext implementation. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- Severity|Normal |Enhancement -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c12 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |IN_PROGRESS --- Comment #12 from Stefan Hundhammer <shundhammer@suse.com> --- See also bug #954505. Please read the extensive documentation at the pull request for the proposed fix to get an idea how this works: https://github.com/yast/yast-devtools/pull/152 In a nutshell, we manually add different types of format markers for the different kinds of format that we use; so "msgfmt -c" or "msgmerge -c" should catch any errors in the translations. The script is normally part of our translation process when generating .pot files, but it can also be invoked standalone. Feel free to test and experiment. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|yast-internal@suse.de |shundhammer@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c13 --- Comment #13 from Luiz Fernando Ranghetti <elchevive68@gmail.com> --- Hi, Seams that gettext is gaining Ruby support: http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=d079c75c1a1e04b1677a... http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=c4da9b03f016dbf1f956... and http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=6c39c38b094db79b59ee... maybe is worth a look -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c14 --- Comment #14 from Stefan Hundhammer <shundhammer@suse.com> --- Native support for Ruby in the gettext tools would be most welcome. Once that arrives, it will supersede our post-processing solution: This new script does not override an existing format. If a message already has a format marker, that one has priority, and we do not attempt to add another one (which might conflict with the existing one). Thanks for the update! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c15 --- Comment #15 from Stefan Hundhammer <shundhammer@suse.com> --- Oh yes, and of course we also have our YaST-specific format to consider which goes back to YCP and its "sformat()" builtin: _("Can't open file %1 for %2", filename, operation) i.e. another version of positional parameters. And in all the existing YaST code we have a lot of those. So this script will still remain useful for the forseeable future. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c16 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #16 from Stefan Hundhammer <shundhammer@suse.com> --- The fix will become available with yast2-devtools-4.2.6. But it can already be used independently if downloaded from here: https://github.com/yast/yast-devtools/blob/master/build-tools/scripts/po_add... It doesn't need any YaST development environment, only Ruby (which all SUSE users should have installed anyway for YaST) and the "gettext" Ruby gem for that Ruby version (see ruby --version) sudo zypper in ruby2.6-rubygem-gettext For more details, see https://github.com/yast/yast-devtools/pull/152 All YaST .pot files that we generate from now on should already contain format flags generated by this script, so they will trickle down to the translators with the normal translation workflow. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=980329 https://bugzilla.suse.com/show_bug.cgi?id=980329#c17 --- Comment #17 from Karl Eichwalder <ke@suse.com> --- Ok, this is really good news! I'm still uncertain whether we still must update or adjust the tools on the weblate server? Maybe, I'd better check twice. I'll ask Standa. Thanks for all your help. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=980329 Lukas Ocilka <locilka@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(shundhammer@suse. | |com) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=980329 https://bugzilla.suse.com/show_bug.cgi?id=980329#c19 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(shundhammer@suse. | |com) | --- Comment #19 from Stefan Hundhammer <shundhammer@suse.com> --- (In reply to Karl Eichwalder from comment #17)
Ok, this is really good news! I'm still uncertain whether we still must update or adjust the tools on the weblate server?
From our side, we are only making use of existing things; those formats have been in gettext for a long time (including ycp-format since the early 2000s). So if they use standard gettext tools from less than 10-15 years ago, it should work out of the box. But it can't hurt to give it a try.
Maybe, I'd better check twice. I'll ask Standa.
Thanks for all your help.
You are welcome! -- You are receiving this mail because: You are on the CC list for the bug.
participants (2)
-
bugzilla_noreply＠novell.com -
bugzilla_noreply＠suse.com