February 2008 - Zypp Development - openSUSE Mailing Lists

[zypp-devel] Re: [zypp-commit] r8702 - in /trunk/sat-solver/tools: repo2solv.sh repo_susetags.c repo_susetags.h susetags2solv.c
by Klaus Kaempf 15 Feb '08

15 Feb '08

* matz(a)svn.opensuse.org <matz(a)svn.opensuse.org> [Feb 15. 2008 10:58]: > Author: matz > Date: Fri Feb 15 10:58:43 2008 > New Revision: 8702 > > URL: http://svn.opensuse.org/viewcvs/zypp?rev=8702&view=rev > Log: > susetags2solv always constructs attributes now, by default into the main > SOLV file. Agreed, always constructing attributes makes sense. However, with this change it seems as if attributes aren't stored in a separate .attr file. Is this right ? Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

2 4

[zypp-devel] weired problems during commit
by Stephan Kulow 15 Feb '08

15 Feb '08

Hi, I dared to update to zypp:svn and then tried to zypper in and then I get a weired problem, it downloads media.1/media first and then again /inst-source/ and wonders that it can't write a dir as a file. Any idea? Greetings, Stephan Herunterladen von Paket yast2-users-2.16.8-9.x86_64, 0 B (0 B installiert) Lade herunter: media * Downloading [100%] Lade herunter: inst-source * Downloading [100%] Problem beim Laden von Daten von: Cannot write file /var/adm/mount/AP_0x00000005 and this how zypper log looks like: MediaHandler.cc(createAttachPoint):393 Trying to create attach point in /var/adm/mount PathInfo.cc(_Log_Result):295 mkdir /var/adm/mount/AP_0x00000005 00755 MediaHandler.cc(createAttachPoint):370 Created default attach point /var/adm/mount/AP_0x00000005 Sysconfig.cc(read):31 Load '/etc/sysconfig/proxy' Sysconfig.cc(read):71 done reading '/etc/sysconfig/proxy' MediaCurl.cc(attachTo):547 Proxy: -none- MediaHandler.cc(attach):653 Attached: http://download.opensuse.org/distribution/SL-OSS-factory/inst-source/ attached; localRoot "/var/adm/mount/AP_0x00000005" MediaCurl.cc(doGetFileCopy):1024 /media.1/media MediaCurl.cc(doGetFileCopy):1058 URL: http://download.opensuse.org/distribution/SL-OSS-factory/inst-source/media.… MediaCurl.cc(doGetFileCopy):1119 dest: /var/adm/mount/AP_0x00000005/media.1/media MediaCurl.cc(doGetFileCopy):1120 temp: /var/adm/mount/AP_0x00000005/media.1/media.new.zypp.WJZjti MediaCurl.cc(doGetFileCopy):1303 HTTP response: 200 PathInfo.cc(_Log_Result):295 mkdir /var/adm/mount/AP_0x00000005/media.1 00755rename /var/adm/mount/AP_0x00000005/media.1/media.new.zypp.WJZjti -> /var/adm/mount/AP_0x00000005/media.1/media MediaCurl.cc(doGetFileCopy):1332 done: /var/adm/mount/AP_0x00000005/media.1/media{- 0644 0/0 size 42} MediaHandler.cc(provideFile):1010 provideFile(/media.1/media) MediaManager.cc(checkDesired):113 checkDesired(1): desired (report by N4zypp4repo17SUSEMediaVerifierE) MediaManager.cc(checkDesired):116 checkDesired(1): desired (cached) MediaCurl.cc(doGetFileCopy):1024 MediaCurl.cc(doGetFileCopy):1058 URL: http://download.opensuse.org/distribution/SL-OSS-factory/inst-source/ MediaCurl.cc(doGetFileCopy):1119 dest: /var/adm/mount/AP_0x00000005 MediaCurl.cc(doGetFileCopy):1120 temp: /var/adm/mount/AP_0x00000005.new.zypp.GyKRq1 MediaCurl.cc(doGetFileCopy):1303 HTTP response: 200 PathInfo.cc(_Log_Result):295 rename /var/adm/mount/AP_0x00000005.new.zypp.GyKRq1 -> /var/adm/mount/AP_0x00000005 PathInfo.cc(_Log_Result):297 FAILED: errno 21 MediaCurl.cc(doGetFileCopy):1321 Rename failed -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

4 3

[zypp-devel] Warning: I moved libzypp
by Stephan Kulow 15 Feb '08

15 Feb '08

Hi, /trunk/libzypp is now what was yesterday jump_sat branch, so don't update unless you want to :) The current plan is to port the UIs today and then submit to Factory. Greetings, Stephan -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

1 0

[zypp-devel] Re: [zypp-commit] r8671 - /branches/tmp/ma/jump_sat/libzypp/zypp/ResObject.cc
by Michael Matz 14 Feb '08

14 Feb '08

Hi, On Thu, 14 Feb 2008, mlandres(a)svn.opensuse.org wrote: > ByteCount ResObject::size() const > - { return 1024 * lookupNumAttribute( sat::SolvAttr::size ); } > + { return ByteCount( lookupNumAttribute( sat::SolvAttr::size ), ByteCount::K ); } Meh. Talk about overdesign :-) int n1 = 12, n2 = 3, n3; Number number1(n1), number2(n2), number3; number3 = math::Number::Natural::Operation::Commutative::Multiplicative::Multiply (number1, number2); n3 = number3.toInt(); Crazy. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

1 0

[zypp-devel] progress
by Stephan Kulow 13 Feb '08

13 Feb '08

Hi! As you can see in my zypper.log, it takes 44 seconds for rpmdb2solv to finish, but still my zypper stays silent on what is going on. Only after the process finished, it will say "Reading installed packages", but that step takes exactly no second, so it's pointless to have progress for that one ;( Please move the progress kickoff to before rpmdb2solv is started. Greetings, Stephan 2008-02-13 14:43:03 <0> desdemona(17411) [zypp] ExternalProgram.cc(start_program):172 Executing '/bin/sh' '-c' 'rpmdb2solv > "/var/cache/zypp/_rpm.solv"' 2008-02-13 14:43:03 <0> desdemona(17411) [zypp] ExternalProgram.cc(start_program):283 pid 17490 launched 2008-02-13 14:43:47 <0> desdemona(17411) [zypp] ExternalProgram.cc(checkStatus):336 pid 17490 successfully completed 2008-02-13 14:43:47 <0> desdemona(17411) [zypp::satpool] PoolImpl.cc(setDirty):125 _createRepo @System 2008-02-13 14:43:47 <0> desdemona(17411) [zypp::satpool] PoolImpl.cc(setDirty):125 _addSolv @System 2008-02-13 14:43:47 <1> desdemona(17411) [zypp] TargetImpl.cc(load):347 adding /var/cache/zypp/_rpm.solv to pool(@System)Target loaded: 1427 resolvables -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

3 2

[zypp-devel] New preferred way to iterate the pool by name and kind.
by Michael Andres 12 Feb '08

12 Feb '08

JFYI URL: http://svn.opensuse.org/svn/zypp/branches/tmp/ma/jump_sat/libzypp/zypp Revision: 8625 I tagged the byName iterator as deprecated, so the compiler tells you where it is used. Please review the code and check whether byIdent is an appropriate replacement. -- The 'old' zypp pool internally maintained a byName index, so it was a fast way to iterate the pool by name and filter by kind to visit e.g. all packages named foo: invokeOnEach( pool.byNameBegin( name ), pool.byNameEnd( name ), resfilter::ByKind( kind ), action() ); for_( it, pool.byNameBegin( name ), pool.byNameEnd( name ) ) { if ( (*it)->kind() == kind ) { ... } } This is no longer true. In contrary, byName now is a 'quite expensive' iteration. It's faster to rewrite these loops using byIdent (and no filter): invokeOnEach( pool.byIdentBegin( kind, name ), pool.byIdentEnd( kind, name ), action() ); for_( it, pool.byIdentBegin( kind, name ), pool.byNameEnd( kind, name ) ) { ... } How to construct the byIdent iterator: ResPool::byIdentBegin( poolItem ) // using this poolItems kind and name ResPool::byIdentBegin( kind, name ) // explicit kind and name ResPool::byIdentBegin<Package>( name ) // or templated kind -- If you prefer using iterator in a for' loop, but dislike to figure out the exact type of the iterator, you may find the 'for_' macro convenient: #include "zypp/base/Easy.h" for_( it, pool.byIdentBegin( kind, name ), pool.byIdentEnd( kind, name ) ) { PoolItem copy = *it; } instead of: for ( ResPool::byIdent_iterator it = pool.byIdentBegin( kind, name ), end = pool.byIdentEnd( kind, name ); it != end, ++it ) { PoolItem copy = *it; } -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma(a)novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

1 0

[zypp-devel] SAT: speedup zypper lu
by Michael Matz 11 Feb '08

11 Feb '08

Hi, the same problem as with dist upgrade also hits with zypper lu, it does a linear walk over all poolitems, for each calling the ByName iterator, which in turn also walks over the entire pool. Not So Clever, except if you want to test how the machine behaves with O(N^2) algorithms :) This of course could be fixed in libzypp by building a name->poolitem index itself and use it in the ByName iterator. But in the old libzypp a considerable amount of space and time was used for just building several dozen indices, and ideally we don't repeat this again. For one or two ByName filters (e.g. when done in reaction to a user action) such index is not necessary. In this case of course it is. The question is, if we want to support such use case in libzypp nicely, and if yes in which way. We could add an ByNameFast filter which builds an index, or just rely on the callers being fixed (like I do here). What the SAT library can provide without much overhead is an index for a ByKindName filter (doesn't exist yet), so _that_ one could be made fast without taking many resources. Interestingly that happens to be the usecase of zypper too. Anyway, for the time being for people testing zypper of the sat branch, this patch makes one usecase (which happens to be my primary performance testcase) fast. Ciao, Michael. Index: zypper-misc.cc =================================================================== --- zypper-misc.cc (revision 8599) +++ zypper-misc.cc (working copy) @@ -1,6 +1,7 @@ #include <fstream> #include <sstream> #include <ctype.h> +#include <tr1/unordered_map> #include <boost/format.hpp> #include <boost/logic/tribool.hpp> #include <boost/logic/tribool_io.hpp> @@ -33,6 +34,7 @@ //using namespace zypp::detail; using namespace std; +using namespace std::tr1; using namespace zypp; using namespace boost; @@ -1231,6 +1233,7 @@ findArchUpdateItem( const ResPool & pool // ---------------------------------------------------------------------------- typedef set<PoolItem> Candidates; +typedef unordered_multimap<string, PoolItem> Name2Item; static void find_updates( const ResObject::Kind &kind, Candidates &candidates ) @@ -1240,6 +1243,42 @@ find_updates( const ResObject::Kind &kin it = pool.byKindBegin (kind), e = pool.byKindEnd (kind); cerr_vv << "Finding update candidates" << endl; +#if 1 + Name2Item name2item; + for (; it != e; ++it) + name2item.insert(std::make_pair((*it)->name(), *it)); + + it = pool.byKindBegin (kind); + for (; it != e; ++it) + { + if (it->status().isUninstalled()) + continue; + PoolItem item = *it; + LookForArchUpdate info; + std::pair<Name2Item::iterator, Name2Item::iterator> it2 + = name2item.equal_range(item->name()); + invokeOnEach( make_transform_iterator(it2.first, _Select2nd<Name2Item::value_type>()), + make_transform_iterator(it2.second, _Select2nd<Name2Item::value_type>()), + // get uninstalled, equal kind and arch, better edition + functor::chain ( + functor::chain ( + functor::chain ( + resfilter::ByUninstalled (), + resfilter::ByKind( item->kind() ) ), + resfilter::byArch<CompareByEQ<Arch> >( item->arch() ) ), + resfilter::byEdition<CompareByGT<Edition> >( item->edition() )), + functor::functorRef<bool,PoolItem> (info) ); + + _XDEBUG("findArchUpdateItem(" << item << ") => " << info.best); + PoolItem candidate = info.best; + if (!candidate.resolvable()) + continue; + + cerr_vv << "item " << *it << endl; + cerr_vv << "cand " << candidate << endl; + candidates.insert (candidate); + } +#else for (; it != e; ++it) { if (it->status().isUninstalled()) @@ -1253,6 +1292,7 @@ find_updates( const ResObject::Kind &kin cerr_vv << "cand " << candidate << endl; candidates.insert (candidate); } +#endif } // ---------------------------------------------------------------------------- -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

3 4

[zypp-devel] yast2-qt
by Stephan Kulow 11 Feb '08

11 Feb '08

Hi! With the advice from Michael I ported yast2-qt (basically removing Selection support and commenting out Language support for now). It starts, but works weired and crashes when I play too much. Greetings, Stephan -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

3 3

[zypp-devel] adding Supplements for USB devices to packages
by Stanislav Brabec 11 Feb '08

11 Feb '08

Hallo. I am maintaining several packages with drivers for specialized USB hardware - Smart Card readers, UPSes. Is it a good idea to add Supplements to spec files to allow automatic picking of driver packages during the package selection? If yes, what exactly should I add there? -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 966, +49 911 740538747 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

2 1

[zypp-devel] Re: [zypp-commit] r8586 - /trunk/sat-solver/tools/repo_rpmmd.c
by Michael Matz 11 Feb '08

11 Feb '08

Hi, On Sun, 10 Feb 2008, dmacvicar(a)svn.opensuse.org wrote: > Author: dmacvicar > Date: Sun Feb 10 23:24:05 2008 > New Revision: 8586 > > URL: http://svn.opensuse.org/viewcvs/zypp?rev=8586&view=rev > Log: > - store location, dunno why it does not work yet Your lastsolvableid handling missed some cases where the solvable also is changed to the next one. In fact in the rpm-md case it's easier to calculate the solvable Id when we need it, from the (certainly correct) pd->solvable. Works now. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

2 2