[zypp-devel] Re: [zypp-commit] r8702 - in /trunk/sat-solver/tools: repo2solv.sh repo_susetags.c repo_susetags.h susetags2solv.c
* matz@svn.opensuse.org
Author: matz Date: Fri Feb 15 10:58:43 2008 New Revision: 8702
URL: http://svn.opensuse.org/viewcvs/zypp?rev=8702&view=rev Log: susetags2solv always constructs attributes now, by default into the main SOLV file.
Agreed, always constructing attributes makes sense. However, with this change it seems as if attributes aren't stored in a separate .attr file. Is this right ? Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Fri, 15 Feb 2008, Klaus Kaempf wrote:
* matz@svn.opensuse.org
[Feb 15. 2008 10:58]: Author: matz Date: Fri Feb 15 10:58:43 2008 New Revision: 8702
URL: http://svn.opensuse.org/viewcvs/zypp?rev=8702&view=rev Log: susetags2solv always constructs attributes now, by default into the main SOLV file.
Agreed, always constructing attributes makes sense.
However, with this change it seems as if attributes aren't stored in a separate .attr file. Is this right ?
Yes, because libzypp isn't yet prepared to do that. E.g. if it generates multiple solv files, the "test.attr" files will overwrite each other currently. Similarly it doesn't set a loadcallback and so on. This needs some work on the zypp side until we can really activate separate attr files. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
* Michael Matz
However, with this change it seems as if attributes aren't stored in a separate .attr file. Is this right ?
Yes, because libzypp isn't yet prepared to do that. E.g. if it generates multiple solv files, the "test.attr" files will overwrite each other currently.
That's why I introduced the 'attrname' parameter yesterday.
Similarly it doesn't set a loadcallback and so on.
Huh ? It's a single line setting the callback and a handful of lines implementing it.
This needs some work on the zypp side until we can really activate separate attr files.
Then I'd vote for reverting your change and fix libzypp. :-} Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Fri, 15 Feb 2008, Klaus Kaempf wrote:
Yes, because libzypp isn't yet prepared to do that. E.g. if it generates multiple solv files, the "test.attr" files will overwrite each other currently.
That's why I introduced the 'attrname' parameter yesterday.
I realize this. But you broke "zypper in", and I just quickly fixed it. I wasn't immediately prepared to change libzypp to do the right thing.
Similarly it doesn't set a loadcallback and so on.
Huh ? It's a single line setting the callback and a handful of lines implementing it.
Yes it's trivial (I know, as I implemented the first one :)), but still takes a little time.
This needs some work on the zypp side until we can really activate separate attr files.
Then I'd vote for reverting your change and fix libzypp. :-}
My change doesn't need reverting, separate attribute files can be generated just fine still (-n blabla). I just unbroke your change in behaviour of "-a" (it didn't write a separate SOLV file since some time). Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
My change doesn't need reverting, separate attribute files can be generated just fine still (-n blabla). I just unbroke your change in behaviour of "-a" (it didn't write a separate SOLV file since some time).
Ah, ok. Thanks. Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (2)
-
Klaus Kaempf
-
Michael Matz