September 2007 - YaST Commits - openSUSE Mailing Lists

[yast-commit] r40797 - in /trunk/ntp-client: VERSION package/yast2-ntp-client.changes
by kmachalkova＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: kmachalkova Date: Thu Sep 6 18:54:44 2007 New Revision: 40797 URL: http://svn.opensuse.org/viewcvs/yast?rev=40797&view=rev Log: version 2.15.9 Modified: trunk/ntp-client/VERSION trunk/ntp-client/package/yast2-ntp-client.changes Modified: trunk/ntp-client/VERSION URL: http://svn.opensuse.org/viewcvs/yast/trunk/ntp-client/VERSION?rev=40797&r1=… ============================================================================== --- trunk/ntp-client/VERSION (original) +++ trunk/ntp-client/VERSION Thu Sep 6 18:54:44 2007 @@ -1 +1 @@ -2.15.8 +2.15.9 Modified: trunk/ntp-client/package/yast2-ntp-client.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/ntp-client/package/yast2-ntp-cli… ============================================================================== --- trunk/ntp-client/package/yast2-ntp-client.changes (original) +++ trunk/ntp-client/package/yast2-ntp-client.changes Thu Sep 6 18:54:44 2007 @@ -1,4 +1,14 @@ ------------------------------------------------------------------- +Thu Sep 6 18:51:37 CEST 2007 - kmachalkova(a)suse.cz + +- Accept IP as a valid NTP server address (#308265) +- Use Packages::addAdditionalPackage() for marking xntp package for + installation so that it is not discarded later on (#307363) +- Correct fix for not re-reading NTP configuration when calling + ntp-client from outside (no exception for the 1st stage) +- 2.15.9 + +------------------------------------------------------------------- Mon Sep 3 17:01:12 CEST 2007 - kmachalkova(a)suse.cz - Fixed adding new NTP servers when calling ntp-client from outside -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40796 - /trunk/country/package/yast2-country.changes
by kmachalkova＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: kmachalkova Date: Thu Sep 6 18:48:37 2007 New Revision: 40796 URL: http://svn.opensuse.org/viewcvs/yast?rev=40796&view=rev Log: Changelog up Modified: trunk/country/package/yast2-country.changes Modified: trunk/country/package/yast2-country.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/country/package/yast2-country.ch… ============================================================================== --- trunk/country/package/yast2-country.changes (original) +++ trunk/country/package/yast2-country.changes Thu Sep 6 18:48:37 2007 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Thu Sep 6 18:29:27 CEST 2007 - kmachalkova(a)suse.cz + +- Accept also IP as a valid NTP server address (handle receiving + `invalid_hostname from ntp-client) (#308265) + +------------------------------------------------------------------- Fri Aug 31 17:26:12 CEST 2007 - kmachalkova(a)suse.cz - Timezone dialog adjusted to use new ntp installation clients -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40795 - /trunk/country/timezone/src/dialogs.ycp
by kmachalkova＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: kmachalkova Date: Thu Sep 6 18:22:57 2007 New Revision: 40795 URL: http://svn.opensuse.org/viewcvs/yast?rev=40795&view=rev Log: Accept also IP as a valid NTP server address (handle receiving `invalid_hostname from ntp-client) Modified: trunk/country/timezone/src/dialogs.ycp Modified: trunk/country/timezone/src/dialogs.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/country/timezone/src/dialogs.ycp… ============================================================================== --- trunk/country/timezone/src/dialogs.ycp (original) +++ trunk/country/timezone/src/dialogs.ycp Thu Sep 6 18:22:57 2007 @@ -138,6 +138,10 @@ UI::ChangeWidget (`id (`ntp_configure), `Enabled, ntp_used); } + void handle_invalid_hostname( string server ) { + Popup::Error( sformat("Invalid NTP server hostname %1", server) ); + } + term cont = `HBox ( `RadioButtonGroup (`id (`rb), `HCenter (`VBox ( `Left (`VBox ( @@ -181,7 +185,7 @@ ret = UI::UserInput(); y2debug ("UserInput ret:%1", ret ); if (ret == `ntp || ret == `manual) - { + { ntp_used = (ret == `ntp); if (ntp_used && !Stage::initial () && !ntp_installed) { @@ -202,7 +206,15 @@ } if (ret == `ntp_configure) { - if (WFM::CallFunction ("ntp-client_proposal", ["AskUser"]) != `next) + symbol rv = (symbol) WFM::CallFunction ("ntp-client_proposal", ["AskUser"]); + + if( rv == `invalid_hostname) + { + handle_invalid_hostname( (string) UI::QueryWidget(`id(`ntp_server), `Value) ); + ret = `retry; + continue; + } + if (rv != `next) continue; } if (ret == `accept && !ntp_used) @@ -262,7 +274,7 @@ if (rv == `invalid_hostname) { - Popup::Error( sformat("Invalid NTP server hostname %1", server) ); + handle_invalid_hostname( server ); ret = `retry; continue; } -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40794 - /trunk/ntp-client/src/dialogs.ycp
by kmachalkova＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: kmachalkova Date: Thu Sep 6 18:18:46 2007 New Revision: 40794 URL: http://svn.opensuse.org/viewcvs/yast?rev=40794&view=rev Log: Correct fix for not re-reading NTP configuration when calling the ntp-client from outside (no exception for the 1st stage) Modified: trunk/ntp-client/src/dialogs.ycp Modified: trunk/ntp-client/src/dialogs.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/ntp-client/src/dialogs.ycp?rev=4… ============================================================================== --- trunk/ntp-client/src/dialogs.ycp (original) +++ trunk/ntp-client/src/dialogs.ycp Thu Sep 6 18:18:46 2007 @@ -53,21 +53,14 @@ define symbol ReadDialog() ``{ Wizard::RestoreHelp(HELPS["read"]:""); - if(Stage::initial()) - { - NtpClient::ProcessNtpConf(); - return `next; - } - else - { - // checking for root permissions (#158483) - if (!Confirm::MustBeRoot()) - return `abort; - - NtpClient::AbortFunction = PollAbort; - boolean ret = NtpClient::Read(); - return ret ? `next : `abort; - } + // checking for root permissions (#158483) + if (!Stage::initial() && !Confirm::MustBeRoot()) + return `abort; + + NtpClient::AbortFunction = PollAbort; + boolean ret = NtpClient::Read(); + return ret ? `next : `abort; + } /** -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40793 - /trunk/ntp-client/src/ntp-client_proposal.ycp
by kmachalkova＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: kmachalkova Date: Thu Sep 6 18:16:40 2007 New Revision: 40793 URL: http://svn.opensuse.org/viewcvs/yast?rev=40793&view=rev Log: Use Packages::addAdditionalPackage() for marking xntp package for installation so that it is not discarded later on (#307363) Modified: trunk/ntp-client/src/ntp-client_proposal.ycp Modified: trunk/ntp-client/src/ntp-client_proposal.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/ntp-client/src/ntp-client_propos… ============================================================================== --- trunk/ntp-client/src/ntp-client_proposal.ycp (original) +++ trunk/ntp-client/src/ntp-client_proposal.ycp Thu Sep 6 18:16:40 2007 @@ -15,6 +15,7 @@ import "String"; import "Stage"; import "Package"; +import "Packages"; import "Pkg"; y2milestone("----------------------------------------"); @@ -155,7 +156,7 @@ } //Schedule package for installation - Pkg::PkgInstall("xntp"); + Packages::addAdditionalPackage("xntp"); integer r = (integer) SCR::Execute (.target.bash, sformat ("/usr/sbin/ntpdate '%1'", String::Quote(ntp_server))); y2milestone ("'ntpdate %1' returned %2", ntp_server, r); -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40792 - /trunk/ntp-client/src/ntp-client_proposal.ycp
by kmachalkova＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: kmachalkova Date: Thu Sep 6 18:13:28 2007 New Revision: 40792 URL: http://svn.opensuse.org/viewcvs/yast?rev=40792&view=rev Log: Accept IP as a valid NTP server address Modified: trunk/ntp-client/src/ntp-client_proposal.ycp Modified: trunk/ntp-client/src/ntp-client_proposal.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/ntp-client/src/ntp-client_propos… ============================================================================== --- trunk/ntp-client/src/ntp-client_proposal.ycp (original) +++ trunk/ntp-client/src/ntp-client_proposal.ycp Thu Sep 6 18:13:28 2007 @@ -8,7 +8,7 @@ { textdomain "ntp-client"; -import "Hostname"; +import "Address"; import "NetworkService"; import "NtpClient"; import "Service"; @@ -47,6 +47,7 @@ ntp_items = NtpClient::GetNtpServersByCountry( cc, true ); NtpClient::config_has_been_read = true; } + ntp_items = add(ntp_items, ""); UI::ChangeWidget(`id(`ntp_address), `Items, ntp_items); } @@ -68,6 +69,17 @@ NtpClient::storeSyncRecord(); } +boolean ValidateSingleServer( string ntp_server ) +{ + if (!Address::Check(ntp_server) ) + { + UI::SetFocus(`id(`ntp_address)); + return false; + } + + return true; +} + if (func == "CreateUI") { term cont = @@ -123,11 +135,8 @@ else if (func == "Write") { string ntp_server = (string) UI::QueryWidget(`id(`ntp_address), `Value); - if (!Hostname::CheckFQ(ntp_server)) - { - UI::SetFocus(`id(`ntp_address)); + if ( !ValidateSingleServer( ntp_server ) ) ret = `invalid_hostname; - } else { y2milestone("Running ntpdate to sync with %1", ntp_server); @@ -141,7 +150,7 @@ status = Service::Status (service_name); //Stop service temporarily (otherwise ntpdate won't work) //0 means service is running - if ( status == 0); + if ( status == 0) Service::Stop (service_name); } @@ -170,9 +179,15 @@ else if (func == "AskUser") { string ntp_server = (string) UI::QueryWidget(`id(`ntp_address), `Value); - AddSingleServer(ntp_server); - ret = (symbol) WFM::CallFunction("ntp-client"); - ProposeSomething(); + if ( !ValidateSingleServer( ntp_server ) ) + ret = `invalid_hostname; + else + { + string ntp_server = (string) UI::QueryWidget(`id(`ntp_address), `Value); + AddSingleServer(ntp_server); + ret = (symbol) WFM::CallFunction("ntp-client"); + ProposeSomething(); + } } y2milestone("Ntp client proposal finished"); -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40791 - /tags/stable-2_15_11/core/
by mvidner＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: mvidner Date: Thu Sep 6 17:44:16 2007 New Revision: 40791 URL: http://svn.opensuse.org/viewcvs/yast?rev=40791&view=rev Log: Created tag stable-2_15_11 for core Added: tags/stable-2_15_11/core/ - copied from r40790, trunk/core/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40790 - in /trunk/core: ./ package/yast2-core.changes wfm/src/Y2WFMComponent.cc
by mvidner＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: mvidner Date: Thu Sep 6 16:49:49 2007 New Revision: 40790 URL: http://svn.opensuse.org/viewcvs/yast?rev=40790&view=rev Log: Merged revisions 40275 via svnmerge from http://svn.opensuse.org/svn/yast/branches/SuSE-SLE-10-SP1-Branch/core ........ r40275 | mvidner | 2007-08-15 11:33:40 +0200 (St, 15 srp 2007) | 2 lines Do not log return value from clients (#248300). ........ Modified: trunk/core/ (props changed) trunk/core/package/yast2-core.changes trunk/core/wfm/src/Y2WFMComponent.cc Modified: trunk/core/package/yast2-core.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/package/yast2-core.changes?… ============================================================================== --- trunk/core/package/yast2-core.changes (original) +++ trunk/core/package/yast2-core.changes Thu Sep 6 16:49:49 2007 @@ -3,6 +3,7 @@ - Enabled iterating over all functions of a Y2Namespace, for a more natural call syntax in yast2-python-bindings (#308213). +- Do not log return value from clients (#248300). - 2.15.11 ------------------------------------------------------------------- Modified: trunk/core/wfm/src/Y2WFMComponent.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/wfm/src/Y2WFMComponent.cc?r… ============================================================================== --- trunk/core/wfm/src/Y2WFMComponent.cc (original) +++ trunk/core/wfm/src/Y2WFMComponent.cc Thu Sep 6 16:49:49 2007 @@ -651,7 +651,9 @@ YCPValue result = client_comp->doActualWork (args, NULL); ee.setFilename (filename); ee.setLinenumber (linenumber); - ycp2milestone (filename.c_str(), linenumber, + ycp2milestone (filename.c_str(), linenumber, "Called YaST client returned."); + // some clients return plaintext secrets #248300 + ycp2debug (filename.c_str(), linenumber, "Called YaST client returned: %s", result.isNull () ? "nil" : result->toString ().c_str ()); return result; -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40789 - in /trunk/core: VERSION libycp/src/SymbolTable.cc libycp/src/include/ycp/SymbolTable.h package/yast2-core.changes
by mvidner＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: mvidner Date: Thu Sep 6 16:43:46 2007 New Revision: 40789 URL: http://svn.opensuse.org/viewcvs/yast?rev=40789&view=rev Log: Enabled iterating over all functions of a Y2Namespace, for a more natural call syntax in yast2-python-bindings (#308213). Modified: trunk/core/VERSION trunk/core/libycp/src/SymbolTable.cc trunk/core/libycp/src/include/ycp/SymbolTable.h trunk/core/package/yast2-core.changes Modified: trunk/core/VERSION URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/VERSION?rev=40789&r1=40788&… ============================================================================== --- trunk/core/VERSION (original) +++ trunk/core/VERSION Thu Sep 6 16:43:46 2007 @@ -1 +1 @@ -2.15.10 +2.15.11 Modified: trunk/core/libycp/src/SymbolTable.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/libycp/src/SymbolTable.cc?r… ============================================================================== --- trunk/core/libycp/src/SymbolTable.cc (original) +++ trunk/core/libycp/src/SymbolTable.cc Thu Sep 6 16:43:46 2007 @@ -1019,4 +1019,27 @@ } } } + +// for #308213 +void +SymbolTable::forEach(SymbolTable::EntryConsumer consumer) const +{ + for (int i=0; i < m_prime; i++) + { + if (m_table[i] != 0) + { + SymbolEntryPtr s = m_table[i]->sentry (); + if (! consumer (*s)) + return; + + // walk the chain of colliding entries + for (TableEntry* t_next = m_table[i]->m_next; t_next; t_next = t_next->m_next) + { + SymbolEntryPtr s = t_next->sentry (); + if (! consumer (*s)) + return; + } + } + } +} // EOF Modified: trunk/core/libycp/src/include/ycp/SymbolTable.h URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/libycp/src/include/ycp/Symb… ============================================================================== --- trunk/core/libycp/src/include/ycp/SymbolTable.h (original) +++ trunk/core/libycp/src/include/ycp/SymbolTable.h Thu Sep 6 16:43:46 2007 @@ -149,6 +149,23 @@ // return size of hash table int size() const; + // consumer returns true to continue iterating + typedef bool (* EntryConsumer) (const SymbolEntry&); + /** + * call the consumer for each entry (or until it requests a break) + * + * Example: + * static bool MyClass::DoIt (const SymbolEntry & se) { + * cout << se.name() << endl; + * return true; + * } + * + * void MyClass::Foo () { + * my_y2namespace->table()->forEach (&DoIt); + * } + */ + void forEach (EntryConsumer consumer) const; + //--------------------------------------------------------------- // enter/find/remove Modified: trunk/core/package/yast2-core.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/package/yast2-core.changes?… ============================================================================== --- trunk/core/package/yast2-core.changes (original) +++ trunk/core/package/yast2-core.changes Thu Sep 6 16:43:46 2007 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Thu Sep 6 16:43:06 CEST 2007 - mvidner(a)suse.cz + +- Enabled iterating over all functions of a Y2Namespace, for + a more natural call syntax in yast2-python-bindings (#308213). +- 2.15.11 + +------------------------------------------------------------------- Wed Sep 5 13:18:55 CEST 2007 - mvidner(a)suse.cz - Fixed missing return value in YSymbolEntry::toXml -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r40788 - in /trunk/network: package/yast2-network.changes src/clients/save_network.ycp
by mzugec＠svn.opensuse.org 06 Sep '07

06 Sep '07

Author: mzugec Date: Thu Sep 6 16:24:35 2007 New Revision: 40788 URL: http://svn.opensuse.org/viewcvs/yast?rev=40788&view=rev Log: fixed missing space between source and destination when copy udev rules into installed system (#307162) Modified: trunk/network/package/yast2-network.changes trunk/network/src/clients/save_network.ycp Modified: trunk/network/package/yast2-network.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/network/package/yast2-network.ch… ============================================================================== --- trunk/network/package/yast2-network.changes (original) +++ trunk/network/package/yast2-network.changes Thu Sep 6 16:24:35 2007 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Thu Sep 6 16:22:18 CEST 2007 - mzugec(a)suse.cz + +- fixed missing space between source and destination when copy udev +rules into installed system (#307162) + +------------------------------------------------------------------- Thu Sep 6 14:24:50 CEST 2007 - mzugec(a)suse.cz - Finish button renamed to Accept for installation (#307789) Modified: trunk/network/src/clients/save_network.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/network/src/clients/save_network… ============================================================================== --- trunk/network/src/clients/save_network.ycp (original) +++ trunk/network/src/clients/save_network.ycp Thu Sep 6 16:24:35 2007 @@ -328,7 +328,7 @@ WFM::Execute(.local.bash, "udevtrigger --subsystem-match=net"); WFM::Execute (.local.bash, sformat ( - "mkdir -p '%2%1'; /bin/cp -p %1/70-persistent-net.rules'%2%1'", + "mkdir -p '%2%1'; /bin/cp -p %1/70-persistent-net.rules '%2%1'", "/etc/udev/rules.d", String::Quote (Installation::destdir))); -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0