May 2023 - Open Build Service Commits - openSUSE Mailing Lists

[openSUSE/open-build-service] 815f37: Beta version refactoring the `refresh` logic
by Henne Vogelsang 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 815f37adeecbefe71300efa1b010b281f7cd11a8 https://github.com/openSUSE/open-build-service/commit/815f37adeecbefe71300e… Author: ncounter <dleidi(a)suse.com> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- Beta version refactoring the `refresh` logic Async fetch and cache diff data whenever a request page is loaded Commit: cddbfa6af3ab32df804868f17fe48a3257bd85e7 https://github.com/openSUSE/open-build-service/commit/cddbfa6af3ab32df80486… Author: ncounter <dleidi(a)suse.com> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/api/app/components/sourcediff_component.html.haml M src/api/app/components/sourcediff_component.rb M src/api/app/components/sourcediff_tab_component.html.haml M src/api/app/components/sourcediff_tab_component.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/changes.html.haml M src/api/app/views/webui/request/request_action.js.erb M src/api/app/views/webui/request/request_action_changes.js.erb M src/api/spec/components/previews/sourcediff_tab_component_preview.rb M src/api/spec/components/sourcediff_tab_component_spec.rb Log Message: ----------- Rename refresh variable to its real meaning Commit: c3179acd308cb43eb738e3ced9e3ee9a83f71f74 https://github.com/openSUSE/open-build-service/commit/c3179acd308cb43eb738e… Author: ncounter <dleidi(a)suse.com> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/api/app/components/sourcediff_component.html.haml M src/api/app/components/sourcediff_component.rb M src/api/app/components/sourcediff_tab_component.html.haml M src/api/app/components/sourcediff_tab_component.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/changes.html.haml M src/api/app/views/webui/request/request_action.js.erb M src/api/app/views/webui/request/request_action_changes.js.erb M src/api/spec/components/previews/sourcediff_component_preview.rb M src/api/spec/components/previews/sourcediff_tab_component_preview.rb M src/api/spec/components/sourcediff_component_spec.rb M src/api/spec/components/sourcediff_tab_component_spec.rb Log Message: ----------- Get rid of redundant variable that can be computed on the fly Commit: ff473fbf49ee07c5d10a4d7d01466e28114b31dd https://github.com/openSUSE/open-build-service/commit/ff473fbf49ee07c5d10a4… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/api/app/components/sourcediff_component.html.haml M src/api/app/components/sourcediff_component.rb M src/api/app/components/sourcediff_tab_component.html.haml M src/api/app/components/sourcediff_tab_component.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/changes.html.haml M src/api/app/views/webui/request/request_action.js.erb M src/api/app/views/webui/request/request_action_changes.js.erb M src/api/spec/components/previews/sourcediff_component_preview.rb M src/api/spec/components/previews/sourcediff_tab_component_preview.rb M src/api/spec/components/sourcediff_component_spec.rb M src/api/spec/components/sourcediff_tab_component_spec.rb Log Message: ----------- Merge pull request #14312 from ncounter/refactor-request-refresh-logic Refactor request refresh logic Compare: https://github.com/openSUSE/open-build-service/compare/9aa13a1d0fed...ff473…

1 0

[openSUSE/open-build-service] 6aab09: Bug fix: make sure loadChanges ajax call receives ...
by Lukas Krause 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6aab0902e8aec28343d93ae4fd571cdaf367a9f4 https://github.com/openSUSE/open-build-service/commit/6aab0902e8aec28343d93… Author: ncounter <dleidi(a)suse.com> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/api/app/assets/javascripts/webui/request.js M src/api/app/components/sourcediff_component.html.haml Log Message: ----------- Bug fix: make sure loadChanges ajax call receives parameters to build url properly Commit: 9aa13a1d0fed2648b708b0725e617bd176714703 https://github.com/openSUSE/open-build-service/commit/9aa13a1d0fed2648b708b… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/api/app/assets/javascripts/webui/request.js M src/api/app/components/sourcediff_component.html.haml Log Message: ----------- Merge pull request #14319 from ncounter/fix-request-ajax-loadChanges Bug fix: make sure loadChanges receives parameters to build url properly Compare: https://github.com/openSUSE/open-build-service/compare/809d4f0930b8...9aa13…

1 0

[openSUSE/open-build-service] 92e225: [backend] BSASN1: make pack_obj_id a bit faster
by Michael Schroeder 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 92e225d8844aa9ff04eedff9de3b0401efc76b20 https://github.com/openSUSE/open-build-service/commit/92e225d8844aa9ff04eed… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/backend/BSASN1.pm M src/backend/BSX509.pm Log Message: ----------- [backend] BSASN1: make pack_obj_id a bit faster And add some common cert oids to BSX509. Commit: a45fa19b7425965080f76e0bbde94c8e12fabdd7 https://github.com/openSUSE/open-build-service/commit/a45fa19b7425965080f76… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/backend/bs_clouduploadserver M src/backend/bs_getbinariesproxy M src/backend/bs_repserver M src/backend/bs_service M src/backend/bs_srcserver Log Message: ----------- [backend] add a way to set extra values in the server configs Commit: 6c07c4af30df0cb422bd947e07fd58837967341d https://github.com/openSUSE/open-build-service/commit/6c07c4af30df0cb422bd9… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/backend/BSServer.pm M src/backend/BSServerEvents.pm Log Message: ----------- [backend] BSServer/BSServerEvent: also set peerip in the request Unlike the peer entry which always exists the peerip will only be set if the ip could be determined. Commit: cfb70f2cdd9d654dcf0936425248b71972330be6 https://github.com/openSUSE/open-build-service/commit/cfb70f2cdd9d654dcf093… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/backend/bs_repserver Log Message: ----------- [backend] use the peerip from the request instead of calling getpeerdata() Commit: 032d7a5860536d5f36fa0d865bbf591935da9750 https://github.com/openSUSE/open-build-service/commit/032d7a5860536d5f36fa0… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/backend/BSSSL.pm Log Message: ----------- [backend] BSSSL: make subjectdn do the right thing Commit: 809d4f0930b8048e730c0dc5ceef3e97e1eda7ec https://github.com/openSUSE/open-build-service/commit/809d4f0930b8048e730c0… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M src/backend/BSASN1.pm M src/backend/BSSSL.pm M src/backend/BSServer.pm M src/backend/BSServerEvents.pm M src/backend/BSX509.pm M src/backend/bs_clouduploadserver M src/backend/bs_getbinariesproxy M src/backend/bs_repserver M src/backend/bs_service M src/backend/bs_srcserver Log Message: ----------- Merge pull request #14317 from mlschroe/master [backend] allow to use a local https->http proxy Compare: https://github.com/openSUSE/open-build-service/compare/0799fd18dc7f...809d4…

1 0

[openSUSE/obs-service-source_validator] 76182b: helpers/spec_query: Handle %include
by Dirk Mueller 11 May '23

11 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-service-source_validator Commit: 76182b6b6d5de824f7473a7e6089ef72370aee9b https://github.com/openSUSE/obs-service-source_validator/commit/76182b6b6d5… Author: Fabian Vogt <fvogt(a)suse.de> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M helpers/spec_query Log Message: ----------- helpers/spec_query: Handle %include Copy the code from obs-build. Commit: 277f419d795840321ed8d28e8c87b036f6601e42 https://github.com/openSUSE/obs-service-source_validator/commit/277f419d795… Author: Dirk Mueller <dmueller(a)suse.com> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M helpers/spec_query Log Message: ----------- Merge pull request #123 from Vogtinator/include helpers/spec_query: Handle %include Compare: https://github.com/openSUSE/obs-service-source_validator/compare/a15bac0345…

1 0

[openSUSE/open-build-service] 797390: Mention dismissed pending reviews in conversation ...
by Henne Vogelsang 11 May '23

11 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 797390ecc9868a68a7d22b2b42b812c4171ac088 https://github.com/openSUSE/open-build-service/commit/797390ecc9868a68a7d22… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/app/components/bs_request_activity_timeline_component.html.haml M src/api/app/components/bs_request_activity_timeline_component.rb M src/api/app/components/bs_request_history_element_component.html.haml M src/api/app/components/bs_request_history_element_component.rb M src/api/app/views/webui/request/beta_show.html.haml Log Message: ----------- Mention dismissed pending reviews in conversation timeline for accepted request Make it more obvious when a user accepted a request, despite open/pending reviews by extending the text shown for the `HistoryElement::RequestAccepted` in the conversation timeline mentioning that the user dismissed pending reviews. Commit: fb929c3172af45e29aec7eafee4dff4a3946d871 https://github.com/openSUSE/open-build-service/commit/fb929c3172af45e29aec7… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/spec/components/bs_request_history_element_component_spec.rb Log Message: ----------- Adapt specs to cover changes mentioning dismissed reviews in the request converstations Commit: 0799fd18dc7f3a96905440df87e87088f63a9800 https://github.com/openSUSE/open-build-service/commit/0799fd18dc7f3a9690544… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/app/components/bs_request_activity_timeline_component.html.haml M src/api/app/components/bs_request_activity_timeline_component.rb M src/api/app/components/bs_request_history_element_component.html.haml M src/api/app/components/bs_request_history_element_component.rb M src/api/app/views/webui/request/beta_show.html.haml M src/api/spec/components/bs_request_history_element_component_spec.rb Log Message: ----------- Merge pull request #14305 from krauselukas/higlight_dismissed_reviews Mention dismissed reviews in request conversation timeline Compare: https://github.com/openSUSE/open-build-service/compare/5f69989922d5...0799f…

1 0

[openSUSE/open-build-service] 6ca5bd: Drop stale comment
by Dario Leidi 11 May '23

11 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6ca5bde173adb93977f45d66b4b1c9ca0c643446 https://github.com/openSUSE/open-build-service/commit/6ca5bde173adb93977f45… Author: ncounter <dleidi(a)suse.com> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/app/views/webui/request/_request_tabs.html.haml Log Message: ----------- Drop stale comment Commit: 5f69989922d5780b375c58c686a7efafc46e6652 https://github.com/openSUSE/open-build-service/commit/5f69989922d5780b375c5… Author: Dario Leidi <dleidi(a)suse.com> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/app/views/webui/request/_request_tabs.html.haml Log Message: ----------- Merge pull request #14315 from ncounter/drop-stale-comment Compare: https://github.com/openSUSE/open-build-service/compare/67b768f00b6a...5f699…

1 0

[openSUSE/open-build-service] e3f226: Clarify variable meaning
by Henne Vogelsang 11 May '23

11 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e3f226813ca927704ed508ed09cacefad94f5730 https://github.com/openSUSE/open-build-service/commit/e3f226813ca927704ed50… Author: ncounter <dleidi(a)suse.com> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_request_tabs.html.haml M src/api/app/views/webui/request/beta_show.html.haml M src/api/app/views/webui/request/build_results.html.haml M src/api/app/views/webui/request/changes.html.haml M src/api/app/views/webui/request/mentioned_issues.html.haml M src/api/app/views/webui/request/rpm_lint.html.haml Log Message: ----------- Clarify variable meaning Commit: 67b768f00b6ac315537c1492647a6a7fd23fba83 https://github.com/openSUSE/open-build-service/commit/67b768f00b6ac315537c1… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_request_tabs.html.haml M src/api/app/views/webui/request/beta_show.html.haml M src/api/app/views/webui/request/build_results.html.haml M src/api/app/views/webui/request/changes.html.haml M src/api/app/views/webui/request/mentioned_issues.html.haml M src/api/app/views/webui/request/rpm_lint.html.haml Log Message: ----------- Merge pull request #14313 from ncounter/rename-variable Clarify variable meaning Compare: https://github.com/openSUSE/open-build-service/compare/01379555b35d...67b76…

1 0

[openSUSE/open-build-service] 36cdb4: Remove superflous XML from ignored error messages
by Henne Vogelsang 11 May '23

11 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 36cdb47be3914cfe78774e5c14597c23f5420284 https://github.com/openSUSE/open-build-service/commit/36cdb47be3914cfe78774… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/config/initializers/airbrake.rb Log Message: ----------- Remove superflous XML from ignored error messages Fixes #14190 Commit: 01379555b35d63c24f2a05e037df87385e99b411 https://github.com/openSUSE/open-build-service/commit/01379555b35d63c24f2a0… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/config/initializers/airbrake.rb Log Message: ----------- Merge pull request #14310 from hennevogel/bugfix/14190 Remove superflous XML from ignored error messages Compare: https://github.com/openSUSE/open-build-service/compare/6f8492dc9a62...01379…

1 0

[openSUSE/open-build-service] f6d304: Split creation of a request with a delete action...
by Eduardo J. 11 May '23

11 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f6d304a360391680913c5ad47d4450e7bdbd80bd https://github.com/openSUSE/open-build-service/commit/f6d304a360391680913c5… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/lib/tasks/dev.rake M src/api/lib/tasks/dev/requests.rake Log Message: ----------- Split creation of a request with a delete action... ... in its own rake task It doesn't make sense to create a request with two maintenance_incident actions and also a delete action. Commit: 6f8492dc9a62c495f2c16ae8428ea5f88ee050ed https://github.com/openSUSE/open-build-service/commit/6f8492dc9a62c495f2c16… Author: Eduardo J <enavarro(a)suse.com> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/lib/tasks/dev.rake M src/api/lib/tasks/dev/requests.rake Log Message: ----------- Merge pull request #14306 from eduardoj/split_delete_request Split creation of a request with a delete action in its own rake task Compare: https://github.com/openSUSE/open-build-service/compare/2e4f9e1673bd...6f849…

1 0

[openSUSE/open-build-service] e992fd: Allow retrieving deleted maintainers
by Henne Vogelsang 11 May '23

11 May '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e992fd0ee500076018bc27f2f4eb841efab71f79 https://github.com/openSUSE/open-build-service/commit/e992fd0ee500076018bc2… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M src/api/app/mixins/has_relationships.rb Log Message: ----------- Allow retrieving deleted maintainers Until now, retrieving projects' maintainers that were deleted made the code crash. Deleted users are displayed everywhere in the application (groups' members, projects' users etc). They are visible but on a special state, "deleted". So there is no reason to stop displaying them in the list of maintainers. Commit: ba9df5cd61cc639c9d580716123994f7e99ffc1b https://github.com/openSUSE/open-build-service/commit/ba9df5cd61cc639c9d580… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: A src/api/spec/cassettes/Project/_maintainers/returns_all_the_users_but_user_2_only_once.yml A src/api/spec/cassettes/Project/_maintainers/when_one_of_the_users_is_deleted/still_returns_the_deleted_user.yml A src/api/spec/cassettes/Project/_maintainers/when_the_group_is_deleted/returns_the_deleted_user_but_not_the_deleted_group_s_user.yml M src/api/spec/models/project_spec.rb Log Message: ----------- Add specs for Project#maintainers Which is defined in the mixin HasRelationships. Commit: 2e4f9e1673bd1200748cad0382a80e31dbc2c3ff https://github.com/openSUSE/open-build-service/commit/2e4f9e1673bd1200748ca… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M src/api/app/mixins/has_relationships.rb A src/api/spec/cassettes/Project/_maintainers/returns_all_the_users_but_user_2_only_once.yml A src/api/spec/cassettes/Project/_maintainers/when_one_of_the_users_is_deleted/still_returns_the_deleted_user.yml A src/api/spec/cassettes/Project/_maintainers/when_the_group_is_deleted/returns_the_deleted_user_but_not_the_deleted_group_s_user.yml M src/api/spec/models/project_spec.rb Log Message: ----------- Merge pull request #14303 from saraycp/fix_14302 Allow retrieving deleted maintainers Compare: https://github.com/openSUSE/open-build-service/compare/11b63a2ba084...2e4f9…

1 0