December 2023 - Open Build Service Commits

[openSUSE/open-build-service] 988de1: Remove CONFIG['proxy_auth_mode'] from WebuiControl...
by Henne Vogelsang 08 Dec '23

08 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 988de18b79301cbecd6a82cdd21533a90b367735 https://github.com/openSUSE/open-build-service/commit/988de18b79301cbecd6a8… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/controllers/webui/webui_controller.rb M src/api/app/lib/routes_helper/role_matcher.rb M src/api/app/services/webui_controller_service/user_checker.rb M src/api/spec/services/webui_controller_service/user_checker_spec.rb Log Message: ----------- Remove CONFIG['proxy_auth_mode'] from WebuiControllerService::UserChecker Configuration.proxy_auth_mode_enabled? is the authorative place... Commit: 7434830127d65772de003baac0ebef1bb4062e66 https://github.com/openSUSE/open-build-service/commit/7434830127d65772de003… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/controllers/concerns/rescue_authorization_handler.rb M src/api/app/controllers/webui/session_controller.rb M src/api/app/models/configuration.rb M src/api/app/models/unregistered_user.rb M src/api/spec/components/sign_up_component_spec.rb M src/api/spec/controllers/webui/session_controller_spec.rb M src/api/spec/lib/authenticator_spec.rb Log Message: ----------- Remove more occurences of CONFIG['proxy_auth_mode'] Configuration.proxy_auth_mode_enabled? is the authorative place... Commit: 6b7a9a93032d786708feb154e99251ebd776163d https://github.com/openSUSE/open-build-service/commit/6b7a9a93032d786708feb… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/controllers/concerns/rescue_authorization_handler.rb M src/api/app/controllers/webui/session_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/lib/routes_helper/role_matcher.rb M src/api/app/models/configuration.rb M src/api/app/models/unregistered_user.rb M src/api/app/services/webui_controller_service/user_checker.rb M src/api/spec/components/sign_up_component_spec.rb M src/api/spec/controllers/webui/session_controller_spec.rb M src/api/spec/lib/authenticator_spec.rb M src/api/spec/services/webui_controller_service/user_checker_spec.rb Log Message: ----------- Merge pull request #15327 from hennevogel/refactoring/proxy_mode Remove more occurences of CONFIG['proxy_auth_mode'] Compare: https://github.com/openSUSE/open-build-service/compare/4884ffb2eb0d...6b7a9…

1 0

[openSUSE/software-o-o]
by depfu[bot] 08 Dec '23

08 Dec '23

Branch: refs/heads/depfu/update/rubocop-1.57.2 Home: https://github.com/openSUSE/software-o-o

1 0

[openSUSE/software-o-o] f84e66: Update rubocop to version 1.58.0
by depfu[bot] 08 Dec '23

08 Dec '23

Branch: refs/heads/depfu/update/rubocop-1.58.0 Home: https://github.com/openSUSE/software-o-o Commit: f84e6627da4b3fad19ec73c44009db21b96561e1 https://github.com/openSUSE/software-o-o/commit/f84e6627da4b3fad19ec73c4400… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M Gemfile.lock R vendor/cache/json-2.6.2.gem A vendor/cache/json-2.7.1.gem A vendor/cache/language_server-protocol-3.17.0.3.gem R vendor/cache/parallel-1.22.1.gem A vendor/cache/parallel-1.23.0.gem R vendor/cache/parser-3.1.2.1.gem A vendor/cache/parser-3.2.2.4.gem R vendor/cache/regexp_parser-2.8.1.gem A vendor/cache/regexp_parser-2.8.3.gem R vendor/cache/rubocop-1.36.0.gem A vendor/cache/rubocop-1.58.0.gem R vendor/cache/rubocop-ast-1.21.0.gem A vendor/cache/rubocop-ast-1.30.0.gem R vendor/cache/ruby-progressbar-1.11.0.gem A vendor/cache/ruby-progressbar-1.13.0.gem R vendor/cache/unicode-display_width-2.2.0.gem A vendor/cache/unicode-display_width-2.5.0.gem Log Message: ----------- Update rubocop to version 1.58.0

1 0

[openSUSE/open-build-service] f6e703: Add email notifications for decisions related events
by Lukas Krause 08 Dec '23

08 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f6e70370e6daa4d9dc6e67b1a41e2c8e48b4dabb https://github.com/openSUSE/open-build-service/commit/f6e70370e6daa4d9dc6e6… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/models/event/cleared_decision.rb M src/api/app/models/event/favored_decision.rb A src/api/app/views/event_mailer/cleared_decision.html.haml A src/api/app/views/event_mailer/cleared_decision.text.erb A src/api/app/views/event_mailer/favored_decision.html.haml A src/api/app/views/event_mailer/favored_decision.text.erb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Add email notifications for decisions related events Commit: 9b1e73ac9ecea1d7355723002641781ea6fe2026 https://github.com/openSUSE/open-build-service/commit/9b1e73ac9ecea1d735572… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/helpers/webui/reportables_helper.rb M src/api/app/views/event_mailer/create_report.html.haml Log Message: ----------- Make link_to_reportables helper reusable for decisions Commit: 89ccf9f19f0568bbacccf54492363eecea76184a https://github.com/openSUSE/open-build-service/commit/89ccf9f19f0568bbacccf… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/models/decision.rb M src/api/app/models/event/cleared_decision.rb M src/api/app/models/event/favored_decision.rb M src/api/app/views/event_mailer/cleared_decision.html.haml M src/api/app/views/event_mailer/cleared_decision.text.erb M src/api/app/views/event_mailer/favored_decision.html.haml M src/api/app/views/event_mailer/favored_decision.text.erb M src/api/spec/factories/decisions.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Add URL's to decision mail notifications Commit: 4884ffb2eb0db97181f8f7d80fc4118b3e09a84d https://github.com/openSUSE/open-build-service/commit/4884ffb2eb0db97181f8f… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/helpers/webui/reportables_helper.rb M src/api/app/models/decision.rb M src/api/app/models/event/cleared_decision.rb M src/api/app/models/event/favored_decision.rb A src/api/app/views/event_mailer/cleared_decision.html.haml A src/api/app/views/event_mailer/cleared_decision.text.erb M src/api/app/views/event_mailer/create_report.html.haml A src/api/app/views/event_mailer/favored_decision.html.haml A src/api/app/views/event_mailer/favored_decision.text.erb M src/api/spec/factories/decisions.rb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Merge pull request #15308 from saraycp/emails_for_decisions Email notifications for events related to decisions Compare: https://github.com/openSUSE/open-build-service/compare/91debd1dcbc8...4884f…

1 0

[openSUSE/open-build-service] 4627ee: Fix absolute URL's in link_to_reportables helper
by Eduardo J. 08 Dec '23

08 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4627ee1dc207b67cf33b6cd79e059e1c50faab66 https://github.com/openSUSE/open-build-service/commit/4627ee1dc207b67cf33b6… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/helpers/webui/reportables_helper.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Fix absolute URL's in link_to_reportables helper Use `*_url` helpers instead of `*_path` helpers. `*_path` helpers don't recognize the `host` parameter to make URL's absolute. Commit: 91debd1dcbc8ea8be3c964d5ab2acd7ba549933b https://github.com/openSUSE/open-build-service/commit/91debd1dcbc8ea8be3c96… Author: Eduardo J <enavarro(a)suse.com> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/helpers/webui/reportables_helper.rb M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Merge pull request #15328 from eduardoj/fix/link_to_reportables Fix absolute URL's in link_to_reportables helper Compare: https://github.com/openSUSE/open-build-service/compare/389ca50a7ae4...91deb…

1 0

[openSUSE/open-build-service] ec16c3: Create the appeals table
by Lukas Krause 08 Dec '23

08 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ec16c3bd230dbf2e73c294549b31b4a14860a93c https://github.com/openSUSE/open-build-service/commit/ec16c3bd230dbf2e73c29… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: A src/api/db/migrate/20231204093136_create_appeals.rb M src/api/db/schema.rb Log Message: ----------- Create the appeals table This will support the implementation of the Appeal model. Commit: 389ca50a7ae47e6cb3b361fbbe02055271eed14e https://github.com/openSUSE/open-build-service/commit/389ca50a7ae47e6cb3b36… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: A src/api/db/migrate/20231204093136_create_appeals.rb M src/api/db/schema.rb Log Message: ----------- Merge pull request #15314 from danidoni/create-appeals-table Create the appeals table Compare: https://github.com/openSUSE/open-build-service/compare/36917dc0ba4e...389ca…

1 0

[openSUSE/open-build-service] d84639: Add a model and a policy for canned_responses
by Lukas Krause 08 Dec '23

08 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d84639b6a56947ee7edb0fbe6410a1dda480258e https://github.com/openSUSE/open-build-service/commit/d84639b6a56947ee7edb0… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: A src/api/app/models/canned_response.rb M src/api/app/models/user.rb A src/api/app/policies/canned_response_policy.rb Log Message: ----------- Add a model and a policy for canned_responses Commit: 45c9379715ce26c71aae45568a38a3b023c8aaad https://github.com/openSUSE/open-build-service/commit/45c9379715ce26c71aae4… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: A src/api/app/controllers/webui/users/canned_responses_controller.rb M src/api/app/views/webui/user/_index_actions.html.haml A src/api/app/views/webui/user/index_actions/_manage_canned_responses.haml A src/api/app/views/webui/users/canned_responses/_breadcrumb_items.html.haml A src/api/app/views/webui/users/canned_responses/edit.html.haml A src/api/app/views/webui/users/canned_responses/index.html.haml M src/api/config/routes/webui_routes.rb Log Message: ----------- Add routes and controller actions for canned responses Commit: fbaa9377fa53b1ba5be6716a398a2478e6eb51ca https://github.com/openSUSE/open-build-service/commit/fbaa9377fa53b1ba5be67… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/assets/javascripts/webui/application.js A src/api/app/assets/javascripts/webui/canned_responses.js A src/api/app/components/canned_responses_dropdown_component.html.haml A src/api/app/components/canned_responses_dropdown_component.rb A src/api/spec/components/previews/canned_responses_dropdown_component_preview.rb Log Message: ----------- Add the canned responses component and javascript Commit: c1a3d9c87194d8e6767d7e95892a756e2441f38f https://github.com/openSUSE/open-build-service/commit/c1a3d9c87194d8e6767d7… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/components/reports_modal_component.html.haml M src/api/app/components/reports_modal_component.rb M src/api/app/views/webui/comment/_comment_field.html.haml Log Message: ----------- Implement canned responses component in decisions and comment boxes Commit: 052bb922c1780faf657a05e99685384cc2b88516 https://github.com/openSUSE/open-build-service/commit/052bb922c1780faf657a0… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: A src/api/spec/cassettes/Comments/can_be_created_using_canned_responses.yml A src/api/spec/factories/canned_responses.rb A src/api/spec/features/webui/canned_responses_spec.rb M src/api/spec/features/webui/comments_spec.rb Log Message: ----------- Add feature tests for canned responses Commit: 0b43d16ad8a9e32f3caa91a5644bc0ff518fce45 https://github.com/openSUSE/open-build-service/commit/0b43d16ad8a9e32f3caa9… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/policies/canned_response_policy.rb M src/api/app/views/webui/comment/_comment_field.html.haml M src/api/app/views/webui/user/_index_actions.html.haml Log Message: ----------- Put canned responses behind content moderation beta flag Commit: 0f920fc79c0ea84bfd2a789ebaaed2507ba4dda9 https://github.com/openSUSE/open-build-service/commit/0f920fc79c0ea84bfd2a7… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/views/webui/users/canned_responses/index.html.haml Log Message: ----------- Create extra section for list of canned responses Move them below the form for the creation of the canned responses, since the list can potentially grow and move the form out of the viewport. I added a heading and moved the index of the canned responses to and extra box, so they are better visible. Commit: 172683d5edf8ff65f6e35d46ba9e36fbe21af360 https://github.com/openSUSE/open-build-service/commit/172683d5edf8ff65f6e35… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/assets/javascripts/webui/canned_responses.js Log Message: ----------- Enable submit button after inserting canned response in comments form Commit: 36917dc0ba4e752749ef0fccff8ad34d49d1a1dc https://github.com/openSUSE/open-build-service/commit/36917dc0ba4e752749ef0… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/assets/javascripts/webui/application.js A src/api/app/assets/javascripts/webui/canned_responses.js A src/api/app/components/canned_responses_dropdown_component.html.haml A src/api/app/components/canned_responses_dropdown_component.rb M src/api/app/components/reports_modal_component.html.haml M src/api/app/components/reports_modal_component.rb A src/api/app/controllers/webui/users/canned_responses_controller.rb A src/api/app/models/canned_response.rb M src/api/app/models/user.rb A src/api/app/policies/canned_response_policy.rb M src/api/app/views/webui/comment/_comment_field.html.haml M src/api/app/views/webui/user/_index_actions.html.haml A src/api/app/views/webui/user/index_actions/_manage_canned_responses.haml A src/api/app/views/webui/users/canned_responses/_breadcrumb_items.html.haml A src/api/app/views/webui/users/canned_responses/edit.html.haml A src/api/app/views/webui/users/canned_responses/index.html.haml M src/api/config/routes/webui_routes.rb A src/api/spec/cassettes/Comments/can_be_created_using_canned_responses.yml A src/api/spec/components/previews/canned_responses_dropdown_component_preview.rb A src/api/spec/factories/canned_responses.rb A src/api/spec/features/webui/canned_responses_spec.rb M src/api/spec/features/webui/comments_spec.rb Log Message: ----------- Merge pull request #15296 from hellcp-work/canned-responses-ui Implement UI for canned responses feature Compare: https://github.com/openSUSE/open-build-service/compare/1709f89a254c...36917…

1 0

[openSUSE/open-build-service] 331e84: Separate class from instance methods more clearly
by Henne Vogelsang 07 Dec '23

07 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 331e842af6454c5550e25d27722488b68d6d2fe2 https://github.com/openSUSE/open-build-service/commit/331e842af6454c5550e25… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Separate class from instance methods more clearly Just moving methods around... Commit: a83023b14d5bec05af86bd16c7a54a62773ac68f https://github.com/openSUSE/open-build-service/commit/a83023b14d5bec05af86b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Fix a typo in a comment Commit: 1709f89a254c00fc77003bf1a45fe90687a4bd98 https://github.com/openSUSE/open-build-service/commit/1709f89a254c00fc77003… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- Merge pull request #15326 from hennevogel/bugfix/ldap-groups Separate class from instance methods more clearly Compare: https://github.com/openSUSE/open-build-service/compare/4c07115716c8...1709f…

1 0

[openSUSE/open-build-service]
by Dany Marcoux 07 Dec '23

07 Dec '23

Branch: refs/heads/depfu/update/srcapi/rubocop-1.58.0 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 84b0cd: Update rubocop to version 1.58.0
by Dany Marcoux 07 Dec '23

07 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 84b0cde09cb1e1ff982c850d549dc60a89daef90 https://github.com/openSUSE/open-build-service/commit/84b0cde09cb1e1ff982c8… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.57.2.gem A src/api/vendor/cache/rubocop-1.58.0.gem Log Message: ----------- Update rubocop to version 1.58.0 Commit: 29f64f3969add045b7bbe7f2fb03fc878e0d3860 https://github.com/openSUSE/open-build-service/commit/29f64f3969add045b7bbe… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/branch_package.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/workflow_run.rb Log Message: ----------- Address warnings for Style/RedundantParentheses cop Commit: 4c07115716c890047e3a76f5b73905a193644c2d https://github.com/openSUSE/open-build-service/commit/4c07115716c890047e3a7… Author: Dany Marcoux <git(a)dmarcoux.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M src/api/Gemfile.lock M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/branch_package.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/workflow_run.rb R src/api/vendor/cache/rubocop-1.57.2.gem A src/api/vendor/cache/rubocop-1.58.0.gem Log Message: ----------- Merge pull request #15307 from openSUSE/depfu/update/srcapi/rubocop-1.58.0 [src/api] Update rubocop 1.57.2 → 1.58.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/cbe3694836d3...4c071…

1 0