December 2023 - Open Build Service Commits

[openSUSE/open-build-service] d0912b: Remove gitlab/github related things from TriggerCo...
by Dani Donisa 12 Dec '23

12 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d0912b8d141f5bae3205e1188f468f5e64d73556 https://github.com/openSUSE/open-build-service/commit/d0912b8d141f5bae3205e… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M src/api/app/controllers/trigger_controller.rb Log Message: ----------- Remove gitlab/github related things from TriggerController We don't do anything with this in TriggerController and validate this differently in TriggerWorkflowController. Commit: c850e159dfa525c2612f7db73e79ec96d815ae32 https://github.com/openSUSE/open-build-service/commit/c850e159dfa525c2612f7… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-11-24 (Fri, 24 Nov 2023) Changed paths: M src/api/app/controllers/trigger_workflow_controller.rb Log Message: ----------- Decouple the two /trigger controllers We inherit from TriggerController in TriggerWorkflowController just for one before_action. We don't use anything else from TriggerController. This does not make much sense anymore. Commit: 566d2791fb09e04218fddb0fd9c4bc0e17031e2b https://github.com/openSUSE/open-build-service/commit/566d2791fb09e04218fdd… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/trigger_workflow_controller.rb Log Message: ----------- Merge pull request #15262 from hennevogel/refactoring/decouple-trigger-controllers Decouple the two /trigger controllers Compare: https://github.com/openSUSE/open-build-service/compare/e6f10da08c2e...566d2…

1 0

[openSUSE/open-build-service] c2b6c6: Update rubocop to version 1.59.0
by depfu[bot] 12 Dec '23

12 Dec '23

Branch: refs/heads/depfu/update/srcapi/rubocop-1.59.0 Home: https://github.com/openSUSE/open-build-service Commit: c2b6c6dbcdcb45497e8aca651840699652f56b75 https://github.com/openSUSE/open-build-service/commit/c2b6c6dbcdcb45497e8ac… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.58.0.gem A src/api/vendor/cache/rubocop-1.59.0.gem Log Message: ----------- Update rubocop to version 1.59.0

1 0

[openSUSE/open-build-service] a8a8c3: Implement notifications for appealed decisions
by Dani Donisa 12 Dec '23

12 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a8a8c32a8ac5c27f8e3cac64a5ebd8ca6ce059e6 https://github.com/openSUSE/open-build-service/commit/a8a8c32a8ac5c27f8e3ca… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb M src/api/app/components/notification_avatars_component.rb M src/api/app/components/notification_component.rb M src/api/app/components/notification_excerpt_component.rb M src/api/app/components/notification_notifiable_link_component.rb A src/api/app/queries/outdated_notifications_finder/appeal.rb M src/api/app/services/notification_service/notifier.rb M src/api/app/services/notification_service/web_channel.rb M src/api/app/services/notified_projects.rb Log Message: ----------- Implement notifications for appealed decisions Commit: 54fe6724019d204c2441127e5850c472e6c53df2 https://github.com/openSUSE/open-build-service/commit/54fe6724019d204c24411… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/app/components/notification_mark_button_component.html.haml Log Message: ----------- Show a button in notification to appeal a decision Commit: 347b6e6b229d0981ed0c8e975b8b028b8d1208f7 https://github.com/openSUSE/open-build-service/commit/347b6e6b229d0981ed0c8… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/app/components/notification_component.rb M src/api/app/components/notification_filter_component.html.haml M src/api/app/components/notification_filter_component.rb M src/api/app/components/notification_filter_link_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/queries/notifications_finder.rb M src/api/app/views/webui/users/notifications/_update.js.erb M src/api/app/views/webui/users/notifications/index.html.haml M src/api/spec/components/notification_filter_component_spec.rb Log Message: ----------- Add notification filter for appeals of decisions Commit: 72d9daa86a5f01017a584b0245d716bd995ea49d https://github.com/openSUSE/open-build-service/commit/72d9daa86a5f01017a584… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: A src/api/spec/cassettes/Appeals/appealing_a_decision/displays_the_message.yml A src/api/spec/features/beta/webui/appeals_spec.rb Log Message: ----------- Decision appealing feature specs Commit: e6f10da08c2e4ee03d1cc9b01b12a123e283ba66 https://github.com/openSUSE/open-build-service/commit/e6f10da08c2e4ee03d1cc… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb M src/api/app/components/notification_avatars_component.rb M src/api/app/components/notification_component.rb M src/api/app/components/notification_excerpt_component.rb M src/api/app/components/notification_filter_component.html.haml M src/api/app/components/notification_filter_component.rb M src/api/app/components/notification_filter_link_component.rb M src/api/app/components/notification_mark_button_component.html.haml M src/api/app/components/notification_notifiable_link_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/queries/notifications_finder.rb A src/api/app/queries/outdated_notifications_finder/appeal.rb M src/api/app/services/notification_service/notifier.rb M src/api/app/services/notification_service/web_channel.rb M src/api/app/services/notified_projects.rb M src/api/app/views/webui/users/notifications/_update.js.erb M src/api/app/views/webui/users/notifications/index.html.haml A src/api/spec/cassettes/Appeals/appealing_a_decision/displays_the_message.yml M src/api/spec/components/notification_filter_component_spec.rb A src/api/spec/features/beta/webui/appeals_spec.rb Log Message: ----------- Merge pull request #15319 from danidoni/implement-appealing-of-decisions Implement notifications for appealed decisions Compare: https://github.com/openSUSE/open-build-service/compare/9c03819e770e...e6f10…

1 0

[openSUSE/open-build-service] 5f438a: Fix the use of the Appeal policy
by Dany Marcoux 12 Dec '23

12 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5f438a153fc365f45988960cefde4540d6fe44b9 https://github.com/openSUSE/open-build-service/commit/5f438a153fc365f459889… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/app/controllers/webui/appeals_controller.rb Log Message: ----------- Fix the use of the Appeal policy While writing the feature specs the policy use for the AppealsController#new action was not allowing the creation of the appeals because it was missing the appellant. Commit: 9c03819e770e9eda4d1e2684947c9aa89a95699d https://github.com/openSUSE/open-build-service/commit/9c03819e770e9eda4d1e2… Author: Dany Marcoux <git(a)dmarcoux.com> Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M src/api/app/controllers/webui/appeals_controller.rb Log Message: ----------- Merge pull request #15351 from danidoni/fix-the-use-of-the-appeal-policy Fix the use of the appeal policy Compare: https://github.com/openSUSE/open-build-service/compare/af88c3babed4...9c038…

1 0

[openSUSE/open-build-service] 1c9efd: Drop Token:Rss
by Henne Vogelsang 11 Dec '23

11 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1c9efd0964c90de21c1536093b5ed88fad44e8b9 https://github.com/openSUSE/open-build-service/commit/1c9efd0964c90de21c153… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/models/token.rb R src/api/app/models/token/rss.rb R src/api/app/policies/token/rss_policy.rb M src/api/app/policies/token_policy.rb A src/api/db/data/20231208145155_drop_token_rss.rb M src/api/db/data_schema.rb M src/api/spec/controllers/webui/users/tokens_controller_spec.rb M src/api/spec/factories/tokens.rb R src/api/spec/policies/token/rss_policy_spec.rb M src/api/spec/policies/token_policy_spec.rb Log Message: ----------- Drop Token:Rss Commit: af88c3babed434b4274916c20dbd1c5a8ebd366c https://github.com/openSUSE/open-build-service/commit/af88c3babed434b427491… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/models/token.rb R src/api/app/models/token/rss.rb R src/api/app/policies/token/rss_policy.rb M src/api/app/policies/token_policy.rb A src/api/db/data/20231208145155_drop_token_rss.rb M src/api/db/data_schema.rb M src/api/spec/controllers/webui/users/tokens_controller_spec.rb M src/api/spec/factories/tokens.rb R src/api/spec/policies/token/rss_policy_spec.rb M src/api/spec/policies/token_policy_spec.rb Log Message: ----------- Merge pull request #15248 from hennevogel/refactoring/drop_rss_token Drop Token:Rss Compare: https://github.com/openSUSE/open-build-service/compare/0c6cd8b18b93...af88c…

1 0

[openSUSE/open-build-service] 19ba4e: Create pundit policies for appeals
by Lukas Krause 11 Dec '23

11 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 19ba4eaa570a968b4bb117575f42acf8dc9dc95e https://github.com/openSUSE/open-build-service/commit/19ba4eaa570a968b4bb11… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: A src/api/app/policies/appeal_policy.rb A src/api/spec/factories/appeal.rb A src/api/spec/policies/appeal_policy_spec.rb Log Message: ----------- Create pundit policies for appeals Commit: 901cfda0e1240955ed1652a2884fea92cb012379 https://github.com/openSUSE/open-build-service/commit/901cfda0e1240955ed165… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: A src/api/app/controllers/webui/appeals_controller.rb A src/api/app/views/webui/appeals/_breadcrumb_items.html.haml A src/api/app/views/webui/appeals/_list_decision.html.haml A src/api/app/views/webui/appeals/_list_reports.html.haml A src/api/app/views/webui/appeals/new.html.haml A src/api/app/views/webui/appeals/show.html.haml M src/api/config/routes/webui_routes.rb Log Message: ----------- Add webui controller, routes and views for appeals Commit: 0c6cd8b18b9311b63c1b7112373e8b89b3bf7706 https://github.com/openSUSE/open-build-service/commit/0c6cd8b18b9311b63c1b7… Author: Lukas Krause <lkrause(a)suse.de> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: A src/api/app/controllers/webui/appeals_controller.rb A src/api/app/policies/appeal_policy.rb A src/api/app/views/webui/appeals/_breadcrumb_items.html.haml A src/api/app/views/webui/appeals/_list_decision.html.haml A src/api/app/views/webui/appeals/_list_reports.html.haml A src/api/app/views/webui/appeals/new.html.haml A src/api/app/views/webui/appeals/show.html.haml M src/api/config/routes/webui_routes.rb A src/api/spec/factories/appeal.rb A src/api/spec/policies/appeal_policy_spec.rb Log Message: ----------- Merge pull request #15342 from krauselukas/appeals_controller_and_views Create appeals controller, routes and views Compare: https://github.com/openSUSE/open-build-service/compare/9aeb91243de3...0c6cd…

1 0

[openSUSE/open-build-service] cfcce7: [backend] Checker: free all caches when we finishe...
by Michael Schroeder 11 Dec '23

11 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: cfcce7a6d4e086107cd977c81b36445a7f37fc40 https://github.com/openSUSE/open-build-service/commit/cfcce7a6d4e086107cd97… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/backend/BSSched/Checker.pm M src/backend/bs_sched Log Message: ----------- [backend] Checker: free all caches when we finished checking a prp This is needed because the checker does not go out of scope when we do async rpcs, thus we need to release as much memory as possible. Commit: 40ecee864a8fc81b076d87382c04213590b09d17 https://github.com/openSUSE/open-build-service/commit/40ecee864a8fc81b076d8… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/backend/bs_getbinariesproxy Log Message: ----------- [backend] bs_getbinariesproxy: remove tmp files if a preinstall download failed Commit: 9aeb91243de3b92e056a6a989c04f8df59c61c3d https://github.com/openSUSE/open-build-service/commit/9aeb91243de3b92e056a6… Author: Michael Schroeder <mls(a)suse.de> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/backend/BSSched/Checker.pm M src/backend/bs_getbinariesproxy M src/backend/bs_sched Log Message: ----------- Merge pull request #15346 from mlschroe/master [backend] Checker: free all caches when we finished checking a prp Compare: https://github.com/openSUSE/open-build-service/compare/67c815ee3a7a...9aeb9…

1 0

[openSUSE/open-build-service] d27b45: Drop redundant test
by Eduardo J. 11 Dec '23

11 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d27b45b718be8cbf8d33ba0aed5dcd87321214f5 https://github.com/openSUSE/open-build-service/commit/d27b45b718be8cbf8d33b… Author: ncounter <dleidi(a)suse.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/api/spec/services/action_build_results_service/chart_data_extractor_spec.rb Log Message: ----------- Drop redundant test Commit: 67c815ee3a7aef303df7ff816c3125b70001e920 https://github.com/openSUSE/open-build-service/commit/67c815ee3a7aef303df7f… Author: Eduardo J <enavarro(a)suse.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/api/spec/services/action_build_results_service/chart_data_extractor_spec.rb Log Message: ----------- Merge pull request #15347 from ncounter/drop-redundant-test Drop redundant test Compare: https://github.com/openSUSE/open-build-service/compare/81d638c60e87...67c81…

1 0

[openSUSE/open-build-service] c3d066: Check if the request has any actions first
by Dario Leidi 11 Dec '23

11 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c3d06689ab991f9b1a7c4e6d15402bf1cd9e15c6 https://github.com/openSUSE/open-build-service/commit/c3d06689ab991f9b1a7c4… Author: ncounter <dleidi(a)suse.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/api/app/services/action_build_results_service/chart_data_extractor.rb M src/api/spec/services/action_build_results_service/chart_data_extractor_spec.rb Log Message: ----------- Check if the request has any actions first Commit: 81d638c60e87db8f93c24d720249c4c834cf5004 https://github.com/openSUSE/open-build-service/commit/81d638c60e87db8f93c24… Author: Dario Leidi <dleidi(a)suse.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/api/app/services/action_build_results_service/chart_data_extractor.rb M src/api/spec/services/action_build_results_service/chart_data_extractor_spec.rb Log Message: ----------- Merge pull request #15345 from ncounter/bugfix-chart-build-results-no-actions Check if the request has any actions first Compare: https://github.com/openSUSE/open-build-service/compare/304c27e64b00...81d63…

1 0

[openSUSE/open-build-service] 4d678d: Implement the appeal model
by Dany Marcoux 11 Dec '23

11 Dec '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4d678d53908a9bac746b40d68acfcad7597305b8 https://github.com/openSUSE/open-build-service/commit/4d678d53908a9bac746b4… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: A src/api/app/models/appeal.rb A src/api/db/migrate/20231211120635_add_missing_foreign_key_constraints_to_appeals.rb M src/api/db/schema.rb Log Message: ----------- Implement the appeal model Commit: 1fd68bf1352208a4fe70b69f1765a20c8163fc8e https://github.com/openSUSE/open-build-service/commit/1fd68bf1352208a4fe70b… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M src/api/app/models/appeal.rb A src/api/app/models/event/appeal_created.rb Log Message: ----------- Implement an event to signal an appeal was created Commit: 304c27e64b00936317ceb2319289592e9cb3887f https://github.com/openSUSE/open-build-service/commit/304c27e64b00936317ceb… Author: Dany Marcoux <git(a)dmarcoux.com> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: A src/api/app/models/appeal.rb A src/api/app/models/event/appeal_created.rb A src/api/db/migrate/20231211120635_add_missing_foreign_key_constraints_to_appeals.rb M src/api/db/schema.rb Log Message: ----------- Merge pull request #15341 from krauselukas/add_appeal_model_and_event Add appeal model and event Compare: https://github.com/openSUSE/open-build-service/compare/9a77cbd8009b...304c2…

1 0